adding works etc is still fairly slow.. so i havent really been doing much
2022-05-23 14334, 2022
CatQuest
i hope the next release mitigates more
2022-05-23 14352, 2022
Shubh
is entity editor still causing slow down?
2022-05-23 14301, 2022
CatQuest
I mean I'm pressing "add work" 3 times becasue i have 3 more works ot add and i have to like. go do something else in the meantime becasue the browser is taken up by the whole thing
2022-05-23 14338, 2022
CatQuest
and i mean, it's slow
2022-05-23 14353, 2022
CatQuest
infact let's force quit now and see if restarting helps
2022-05-23 14345, 2022
Shubh
not sure if that will help
2022-05-23 14323, 2022
CatQuest
a fresh browser restart will make things less slow?
2022-05-23 14358, 2022
Shubh
Hmm
2022-05-23 14306, 2022
CatQuest
atleast be able torule out someother factors. but yea after a full refresh those tabs really make it slwo to a crawl
2022-05-23 14343, 2022
CatQuest
.. i have no idea what "hørespill" is in bb terms :s
2022-05-23 14312, 2022
CatQuest
also one of these is a script for a tv series
2022-05-23 14329, 2022
CatQuest
.. we have so few types of works >_<
2022-05-23 14344, 2022
CatQuest
the being ble to edit these fro mthe admin pow just can't coem quikc enough
2022-05-23 14351, 2022
agatzk has quit
2022-05-23 14306, 2022
CatQuest
... so tyoing in a name is impossible. i managed two letters before the entire thing hanged and it didn't actually acceot any of them the letters so those tw ofirst letters are all here is. am i tying to fast?
2022-05-23 14319, 2022
CatQuest
in any case each keystroke is really bad
2022-05-23 14337, 2022
agatzk joined the channel
2022-05-23 14347, 2022
CatQuest
it really didn't use to be liek this
2022-05-23 14333, 2022
Shubh
CatQuest: do you think it would be bad idea to have ability to add other entities as well using unified form?
2022-05-23 14352, 2022
CatQuest
..
2022-05-23 14310, 2022
CatQuest
oh wait so you mena like in mb where if the artist or whatever doesnt excist yo ucna add one in a small ppup?
2022-05-23 14316, 2022
CatQuest
hells no! i've wanted that forever
2022-05-23 14325, 2022
monkey
The slowness is a problem CatQuest. I did some more digging last week using FF44 running somewhere. The very long list of languages is the issue
2022-05-23 14332, 2022
monkey
It's slowing everything down
2022-05-23 14337, 2022
CatQuest
hm
2022-05-23 14349, 2022
Shubh
monkeyL i just have a way to fix that
2022-05-23 14350, 2022
monkey
When I was testing, not enough to make it unusable, but I'll definitely buy that it does for you
2022-05-23 14354, 2022
Shubh
monkey: *
2022-05-23 14313, 2022
monkey
Shoot :) I've done some thinking of my own, maybe the two of us can come up with the right solution
2022-05-23 14313, 2022
CatQuest
yea I mean i's not *unusable* it's just.. not very usable :D
2022-05-23 14322, 2022
CatQuest
<3<3<3
2022-05-23 14324, 2022
monkey
Yeah, definitely needs to be fices
2022-05-23 14325, 2022
monkey
fixed
2022-05-23 14337, 2022
CatQuest
figs?
2022-05-23 14341, 2022
monkey
fish
2022-05-23 14350, 2022
Shubh
i was also facing same issue language dropdown component slowing the whole thing
2022-05-23 14354, 2022
CatQuest
🐟
2022-05-23 14334, 2022
monkey
My idea was: modify the loadLanguages middleware to only load 50 most frequently used languages. Do asyn search for the rest of the functionality
2022-05-23 14350, 2022
CatQuest
i liek this only loading most used first idea
2022-05-23 14357, 2022
monkey
We talked about this possibility previously, it seems sane to me
2022-05-23 14358, 2022
CatQuest
i was actually going to suggest this
2022-05-23 14321, 2022
Shubh
so i did some profiling and found dropdown rerender on each input typed which takes a lot of time
2022-05-23 14337, 2022
monkey
Yeah, that makes sense
2022-05-23 14351, 2022
CatQuest
even in like typing in a non-dropdown field like title or disambiguiation?
2022-05-23 14356, 2022
monkey
And each rerender means re-loading the giant list of languages in the dropdown :/
2022-05-23 14309, 2022
CatQuest
yesus no wonder it slows everything down
2022-05-23 14312, 2022
Shubh
monkey: so my solution was to use connect on language field itself, and it works now it don't rerender unnecessary
2022-05-23 14328, 2022
monkey
connect?
2022-05-23 14335, 2022
monkey
Meaning redux functionnality?
2022-05-23 14341, 2022
CatQuest
i think doing both of your ideas is a good idea. not interacting with the language drop dow nshouldn't need t orerender it
Interesting, I'd love to see that in action. Would you be able to open a PR for demo?
2022-05-23 14342, 2022
Shubh
yeah i will then
2022-05-23 14347, 2022
monkey
Thanks a lot
2022-05-23 14315, 2022
monkey
I think we might indeed implement both in the end, but if we can avoid doing more async calls to the backend then it's maybe better to avoid it
2022-05-23 14315, 2022
CatQuest
well honestly limiting to the 50 most common languages seem sane no matter what to me. it will make it easier to find things in thel ist too
2022-05-23 14340, 2022
monkey
Technically speaking, it brings more complications
2022-05-23 14301, 2022
CatQuest
mb has just a plain list. but for all intents and purposes it actually works better thna bb's option right now
2022-05-23 14308, 2022
monkey
Currently the languages are sorted by most used, so you already have the X most used at the topo of the list, so that wouldn't change much
2022-05-23 14320, 2022
CatQuest
alright
2022-05-23 14353, 2022
CatQuest
note: typingin the add relationsip thing doesnt really slow down anything
2022-05-23 14335, 2022
monkey
Yeah, that makes sense, I think we don't update the state until the modal is closed
2022-05-23 14352, 2022
CatQuest
but it's not slow when it does that either, so it doenst mess with the lang dropdown
2022-05-23 14323, 2022
Shubh
i suppose only namesection part causes slow downs?
2022-05-23 14326, 2022
monkey
It's possible. It could be because only the sections with languages are affected, or because the elements are not visible on the page at that moment, or…
2022-05-23 14356, 2022
Shubh
monkey: also apart from explorer achievement, is there any other achievement that causing issue?
2022-05-23 14310, 2022
monkey
Let me see if the forum posts shine a light on that
oh also, the gsoc one should be awarded to all gsocers too right
2022-05-23 14322, 2022
Shubh
can you please verify these? (possibly with progress thingy), i tried all Entity I & II achievements (that includes Worker Bee II as well) everything working flawlessly for me :/
2022-05-23 14337, 2022
monkey
Interesting.
2022-05-23 14340, 2022
CatQuest
and monkey and any other what'stheword, leaders
2022-05-23 14341, 2022
CatQuest
I know for a *fact* that "the one thing in 7 days" one is buggy too,
So if you can't replicate it, that probably means the issue is not always occurring
2022-05-23 14339, 2022
Shubh
Hmm then i need
2022-05-23 14356, 2022
Shubh
to create 100 works myself
2022-05-23 14309, 2022
ansh joined the channel
2022-05-23 14334, 2022
monkey
You could probably set up automated tests to try it out. Curious about why the issue would not always be reproducible
2022-05-23 14301, 2022
CatQuest
iirc it was something about from where the "add work" thing was initiated
2022-05-23 14328, 2022
CatQuest
for man author's(or edition?)'s link button, or fro mthe top dropdown "add work"
2022-05-23 14330, 2022
monkey
That was just a theory, and it doens't make much sense when you look at the code
2022-05-23 14303, 2022
CatQuest
yea but you said that about the add entity editior slowdown as well ;)
2022-05-23 14352, 2022
CatQuest
iirc. there was abit of "?=alert=somenumber" added to the url whence you got a new badge
2022-05-23 14303, 2022
monkey
Well, to be fair it wasn't anything related to the annotation field (iirc that was the theory). Symptoms and causes are sometimes far apart
2022-05-23 14346, 2022
CatQuest
once upon a time there *was* a notification about new badges , but that notification disapeared. long before th "alert=thing" thing fro murls did
2022-05-23 14300, 2022
CatQuest
i'm not entierly sure that the ?alert on urls disapeared at all
2022-05-23 14310, 2022
CatQuest
just throwing out ideas.
2022-05-23 14318, 2022
monkey
I'm not sure what that means. What's the ?Alert thing?
2022-05-23 14328, 2022
CatQuest
perhaps newer routine didn't have the "alert" thing coded in the url possibility.. idk
2022-05-23 14344, 2022
CatQuest
uh. when you supposedly got a new badge
2022-05-23 14327, 2022
CatQuest
there would be a ?&alert=23 (or whatever number of the badge you had got) added to the url which also included a notification about this and a link to see your badges
2022-05-23 14344, 2022
CatQuest
on that page
2022-05-23 14345, 2022
monkey
Ah interesting. I never saw this working
2022-05-23 14352, 2022
CatQuest
this is years ago
2022-05-23 14352, 2022
Shubh
same
2022-05-23 14327, 2022
CatQuest
but I remember that.. BenOckmore? was pleased aobut it and suggested gciers report bakc abotu this and saing to "chekc out what this new notification told tehme" etc
2022-05-23 14337, 2022
Shubh
monkey CatQuest: worker bee 2 achievement is unlocked for you?
I'm sure publisher is als obroken, because I must have created more than 100 EG by now (do they count ones created automatically now?)
2022-05-23 14335, 2022
CatQuest
is this badge even interesting anymore now that those are automatically created
2022-05-23 14343, 2022
Shubh
yes i suppose...
2022-05-23 14343, 2022
CatQuest
we shoudl have badges for series and things liek merges too
2022-05-23 14338, 2022
CatQuest
explorer is hella broken, i have viewed more than 10 differnt entities for sure
2022-05-23 14344, 2022
CatQuest
probably 100 differnt ones too
2022-05-23 14304, 2022
Shubh
it was broken for 5 years
2022-05-23 14316, 2022
CatQuest
they should be retrospeactically fixed too
2022-05-23 14353, 2022
CatQuest
I've already seen 10 entities by now ince it was fixed i'm sure
2022-05-23 14326, 2022
CatQuest
I made 3 last week and i am working on 6 now. i have opened
2022-05-23 14335, 2022
monkey
But it hasn't been fixed yet, has it?
2022-05-23 14344, 2022
CatQuest
just the last 14 days
2022-05-23 14351, 2022
CatQuest
i don't know?
2022-05-23 14356, 2022
Shubh
CatQuest: we are getting progress on achievement feature and also possibly fixing achievement issues :)
2022-05-23 14359, 2022
monkey
Not as far as i know
2022-05-23 14305, 2022
CatQuest
oh i see
2022-05-23 14311, 2022
CatQuest
[17:02] <Shubh> it was broken for 5 years <--
2022-05-23 14319, 2022
CatQuest
shoudl be "it's been broken for 5 years"
2022-05-23 14356, 2022
Shubh
CatQuest: Hmm
2022-05-23 14357, 2022
monkey
Wanted to say this publicly here: after some thought and considering Shubh's great quality work over the last 6 months, I feel there will be enough time to finish the project by the end of the GSoC period while staying sane :)
2022-05-23 14357, 2022
monkey
So…
2022-05-23 14357, 2022
monkey
!m Shubh
2022-05-23 14357, 2022
BrainzBot
You're doing good work, Shubh!
2022-05-23 14337, 2022
monkey
And I wanted to introduce you to aerozol, who I'm hoping we can rope in to help us finalize the design of the unified form project
2022-05-23 14343, 2022
Shubh
looking forward to working with you monkey, aerozol :)
2022-05-23 14331, 2022
monkey
🎉
2022-05-23 14340, 2022
P1RATEZ joined the channel
2022-05-23 14305, 2022
Shubh
monkey: i have created the PR for the said solution, not sure if it is the best way but it works(from ~600ms to ~20ms) :)
