#bookbrainz

Seem to work for me Shubh, but I'll reindex just in case

hmm, now it seems to be working fine

Well, i did reindex, so that might have been it :)

monkey: found the culprit https://github.com/metabrainz/bookbrainz-site/b... , will fix it in achievement-progress PR

oh hey.

so are we having a new release on beta this week?

adding works etc is still fairly slow.. so i havent really been doing much

i hope the next release mitigates more

I mean I'm pressing "add work" 3 times becasue i have 3 more works ot add and i have to like. go do something else in the meantime becasue the browser is taken up by the whole thing

and i mean, it's slow

infact let's force quit now and see if restarting helps

not sure if that will help

a fresh browser restart will make things less slow?

Hmm

atleast be able torule out someother factors. but yea after a full refresh those tabs really make it slwo to a crawl

.. i have no idea what "hørespill" is in bb terms :s

also one of these is a script for a tv series

.. we have so few types of works >_<

the being ble to edit these fro mthe admin pow just can't coem quikc enough

... so tyoing in a name is impossible. i managed two letters before the entire thing hanged and it didn't actually acceot any of them the letters so those tw ofirst letters are all here is. am i tying to fast?

in any case each keystroke is really bad

it really didn't use to be liek this

CatQuest: do you think it would be bad idea to have ability to add other entities as well using unified form?

..

oh wait so you mena like in mb where if the artist or whatever doesnt excist yo ucna add one in a small ppup?

hells no! i've wanted that forever

The slowness is a problem CatQuest. I did some more digging last week using FF44 running somewhere. The very long list of languages is the issue

It's slowing everything down

hm

monkeyL i just have a way to fix that

When I was testing, not enough to make it unusable, but I'll definitely buy that it does for you

monkey: *

Shoot :) I've done some thinking of my own, maybe the two of us can come up with the right solution

yea I mean i's not *unusable* it's just.. not very usable :D

<3<3<3

Yeah, definitely needs to be fices

fixed

figs?

fish

i was also facing same issue language dropdown component slowing the whole thing

🐟

My idea was: modify the loadLanguages middleware to only load 50 most frequently used languages. Do asyn search for the rest of the functionality

i liek this only loading most used first idea

We talked about this possibility previously, it seems sane to me

i was actually going to suggest this

so i did some profiling and found dropdown rerender on each input typed which takes a lot of time

Yeah, that makes sense

even in like typing in a non-dropdown field like title or disambiguiation?

And each rerender means re-loading the giant list of languages in the dropdown :/

yesus no wonder it slows everything down

monkey: so my solution was to use connect on language field itself, and it works now it don't rerender unnecessary

connect?

Meaning redux functionnality?

i think doing both of your ideas is a good idea. not interacting with the language drop dow nshouldn't need t orerender it

redux connect which do some memo behind the scene

i found this useful https://reactrocket.com/post/react-redux-optimi...

Interesting, I'd love to see that in action. Would you be able to open a PR for demo?

yeah i will then

Thanks a lot

I think we might indeed implement both in the end, but if we can avoid doing more async calls to the backend then it's maybe better to avoid it

well honestly limiting to the 50 most common languages seem sane no matter what to me. it will make it easier to find things in thel ist too

Technically speaking, it brings more complications

mb has just a plain list. but for all intents and purposes it actually works better thna bb's option right now

Currently the languages are sorted by most used, so you already have the X most used at the topo of the list, so that wouldn't change much

alright

note: typingin the add relationsip thing doesnt really slow down anything

Yeah, that makes sense, I think we don't update the state until the modal is closed

but it's not slow when it does that either, so it doenst mess with the lang dropdown

i suppose only namesection part causes slow downs?

It's possible. It could be because only the sections with languages are affected, or because the elements are not visible on the page at that moment, or…

monkey: also apart from explorer achievement, is there any other achievement that causing issue?

Let me see if the forum posts shine a light on that

According to indy (our best benchmark for it): https://community.metabrainz.org/t/elusive-work...

oh also, the gsoc one should be awarded to all gsocers too right

can you please verify these? (possibly with progress thingy), i tried all Entity I & II achievements (that includes Worker Bee II as well) everything working flawlessly for me :/

Interesting.

and monkey and any other what'stheword, leaders

I know for a *fact* that "the one thing in 7 days" one is buggy too,

Shubh: indy133 has definitely created more than 100 works and should have worker bee 2 and 3 already: https://bookbrainz.org/editor/1748/achievements

So if you can't replicate it, that probably means the issue is not always occurring

Hmm then i need

to create 100 works myself

You could probably set up automated tests to try it out. Curious about why the issue would not always be reproducible

iirc it was something about from where the "add work" thing was initiated

for man author's(or edition?)'s link button, or fro mthe top dropdown "add work"

That was just a theory, and it doens't make much sense when you look at the code

yea but you said that about the add entity editior slowdown as well ;)

iirc. there was abit of "?=alert=somenumber" added to the url whence you got a new badge

Well, to be fair it wasn't anything related to the annotation field (iirc that was the theory). Symptoms and causes are sometimes far apart

once upon a time there *was* a notification about new badges , but that notification disapeared. long before th "alert=thing" thing fro murls did

i'm not entierly sure that the ?alert on urls disapeared at all

just throwing out ideas.

I'm not sure what that means. What's the ?Alert thing?

perhaps newer routine didn't have the "alert" thing coded in the url possibility.. idk

uh. when you supposedly got a new badge

there would be a ?&alert=23 (or whatever number of the badge you had got) added to the url which also included a notification about this and a link to see your badges

on that page

Ah interesting. I never saw this working

this is years ago

same

but I remember that.. BenOckmore? was pleased aobut it and suggested gciers report bakc abotu this and saing to "chekc out what this new notification told tehme" etc

monkey CatQuest: worker bee 2 achievement is unlocked for you?

eehh i'd have to chek

For me yes: https://bookbrainz.org/editor/1245/achievements

yes

me too

I'm sure publisher is als obroken, because I must have created more than 100 EG by now (do they count ones created automatically now?)

is this badge even interesting anymore now that those are automatically created

yes i suppose...

we shoudl have badges for series and things liek merges too

explorer is hella broken, i have viewed more than 10 differnt entities for sure

probably 100 differnt ones too

it was broken for 5 years

they should be retrospeactically fixed too

I've already seen 10 entities by now ince it was fixed i'm sure

I made 3 last week and i am working on 6 now. i have opened

But it hasn't been fixed yet, has it?

just the last 14 days

i don't know?

CatQuest: we are getting progress on achievement feature and also possibly fixing achievement issues :)

Not as far as i know

oh i see

[17:02] <Shubh> it was broken for 5 years <--

shoudl be "it's been broken for 5 years"

CatQuest: Hmm

Wanted to say this publicly here: after some thought and considering Shubh's great quality work over the last 6 months, I feel there will be enough time to finish the project by the end of the GSoC period while staying sane :)

So…

!m Shubh

You're doing good work, Shubh!

And I wanted to introduce you to aerozol, who I'm hoping we can rope in to help us finalize the design of the unified form project

looking forward to working with you monkey, aerozol :)

🎉

monkey: i have created the PR for the said solution, not sure if it is the best way but it works(from ~600ms to ~20ms) :)