monkey aerozol : For unified form design, i think it would be good idea to get rid of both "Created Entites" & "Add" section and only allowing user to create/link other entites using inline forms like MB has for artist but not using any kind of modal.
2022-05-24 14427, 2022
Shubh
like for publisher field, if desired publisher doesn't exist user can create it, using search query as the publisher primary alias and language same as edition (or book), we can get rid of the modal but that might make form more limited in its usage...
2022-05-24 14421, 2022
agatzk has quit
2022-05-24 14429, 2022
agatzk joined the channel
2022-05-24 14413, 2022
MRiddickW has quit
2022-05-24 14406, 2022
CatQuest
.. i think a modal is a good idea,
2022-05-24 14416, 2022
CatQuest
but i hae some ideas for a multi work creator
2022-05-24 14441, 2022
CatQuest
something like the mb tracklist page in the release editor
2022-05-24 14454, 2022
CatQuest
so text fields and artist fields and trackurations ja?
2022-05-24 14434, 2022
CatQuest
but for bb we can have the "names" and "type" and can singualr or batch add relationships, the way the release-relationship editor does
2022-05-24 14436, 2022
CatQuest
(but I also think we need to enable atributes on relationships *first* or else there will be *so* many things that need re-editing after when we cna actually add dates)
2022-05-24 14436, 2022
Shubh
CatQuest: what do you think should we include in the modal, whole entity form or only required attributes?
2022-05-24 14413, 2022
CatQuest
as always, compare what mb does
2022-05-24 14438, 2022
CatQuest
(i also still dislike that language of title or name is mandatory)
2022-05-24 14448, 2022
Shubh
mb modal is kinda large, don't you think?
2022-05-24 14421, 2022
CatQuest
yes.
2022-05-24 14430, 2022
CatQuest
still wish it included alaises, lmao
2022-05-24 14416, 2022
Shubh
might be overwhelming for new users
2022-05-24 14449, 2022
CatQuest
there can be bits of it that are collapse/expand able
2022-05-24 14404, 2022
CatQuest
with a default of only the required ones expanded
2022-05-24 14435, 2022
CatQuest
gernally i i have ot open the link anyway to go add more data if i have it thne i'll jsut be going off and opening another ta t oadd it old-style anyway
2022-05-24 14447, 2022
CatQuest
it needs to be flexible enough for both newbies *and* power users
2022-05-24 14410, 2022
CatQuest
imagine indy adding works? they add SO MANY i reall, rallt want to make it easier for peopel like them adding all that magazine crap :O
2022-05-24 14422, 2022
CatQuest
(with crap hre i mean "lotsa stuff" not "bad data")
2022-05-24 14449, 2022
Shubh
Yeah but monkey suggested me to focus more on new user
2022-05-24 14400, 2022
CatQuest
monkey!!!
2022-05-24 14431, 2022
CatQuest
ok, I *agre* that for exampl, B is *very* steep learning curve for newbies
2022-05-24 14403, 2022
CatQuest
but we *shall not* make tools (very wanted long asked for tools) dumbed down and simplistic plastic jobs that are dumbed down
2022-05-24 14430, 2022
Shubh
i understand power user like indy have to put lot of efforts to add and link multiple entities
2022-05-24 14434, 2022
CatQuest
it only will make it so that new users will add incomplete data *even if* they have more of it and *even if* they actually want to add it
2022-05-24 14418, 2022
CatQuest
because by introducing a *different, "simpler" interface* you will make people use the "easy" one in defernece to the "harder to use" one
2022-05-24 14422, 2022
CatQuest
result: less data
2022-05-24 14415, 2022
CatQuest
we want to make it *easier* for (even new) peopel to add as much data as they have, by making it acessible to add and easy to add
2022-05-24 14442, 2022
Shubh
Hmm agree
2022-05-24 14446, 2022
CatQuest
having to make it so you have to open the tab another to add. idk wikidata links for example?
2022-05-24 14448, 2022
CatQuest
not a good idea
2022-05-24 14410, 2022
CatQuest
but by all means sections with collapse/expande bits is fine
2022-05-24 14420, 2022
CatQuest
even for power users
2022-05-24 14422, 2022
CatQuest
anyway the modal will be based on the *redesigned* entity creator anyway right?
2022-05-24 14444, 2022
CatQuest
so think about making the redesigned entity creator logical and easy ot understand!
2022-05-24 14411, 2022
Shubh
Hmm
2022-05-24 14452, 2022
Shubh
CatQuest: do you think it would good idea to have ability to add(manually) other entites from unified form?
2022-05-24 14457, 2022
CatQuest
i don't really understand what yo umean here
2022-05-24 14406, 2022
CatQuest
isn't that what we mean with "add from modial" ?
2022-05-24 14444, 2022
Shubh
but wouldn't it only work if we want to add entity for book(edition)?
2022-05-24 14413, 2022
CatQuest
ehh
2022-05-24 14400, 2022
Shubh
i mean like mb has for artist or release group
2022-05-24 14418, 2022
CatQuest
my main use of this tool would be to add publishers on edition, additional authors on work, more authors on edition, and series ot everything
2022-05-24 14403, 2022
CatQuest
eh the "add new" modeal is in every single type entity searchexept non-freely editable ones like instrument nad area
2022-05-24 14413, 2022
CatQuest
things like place, work, recording, artist, series
2022-05-24 14435, 2022
CatQuest
you can't "add a new release" with a modal.
2022-05-24 14440, 2022
CatQuest
I think? lol
2022-05-24 14417, 2022
Shubh
i mean mb has for eg. release form where we can add/create artist or release group on the go
2022-05-24 14449, 2022
CatQuest
...
2022-05-24 14452, 2022
CatQuest
yes that's what I mean
2022-05-24 14413, 2022
CatQuest
look have you tried "edit" no a recording? and searched for something to link in "relationships"?
2022-05-24 14422, 2022
CatQuest
ther is a dropdown there and yo ucn add straight away
2022-05-24 14400, 2022
CatQuest
it's, *easier* to add work via the relationship editor on release
2022-05-24 14409, 2022
CatQuest
but it is *possible* to add awork on the recording page
2022-05-24 14453, 2022
Shubh
something similar for unified form should work, right?
2022-05-24 14441, 2022
CatQuest
yes. i think so indeed
2022-05-24 14458, 2022
ansh
monkey: For implementing search for BB entities in CB, I was going to use the endpoint "https://bookbrainz.org/search/search?q=harry". Is there any way we can also fetch the total number of entities also which I need to implement pagination?
Shubh: I was looking for an endpoint to return the total number of search results.
2022-05-24 14422, 2022
monkey
Hi ansh, I believe we do not currently have an endpoint for that
2022-05-24 14429, 2022
monkey
But looking at the code, the search server should return that information, we just don't return it ourselves in the endpoint
2022-05-24 14435, 2022
ansh
Can we make an addition in the api?
2022-05-24 14441, 2022
monkey
So it should be pretty easy to also return the total count
2022-05-24 14431, 2022
ansh
Great
2022-05-24 14431, 2022
Shubh
monkey: is it okay if i start working on the routes now?, also would it a good idea to have single branch for whole project?
2022-05-24 14453, 2022
monkey
Shubh: I think that's a great place to start. And indeed let's create a branch for the project. For now we'll merge PRs into that branch, and we may choose to merge that branch in at regular intervals if need be
CatQuest: when you can, please try out the reactivity of the name section on https://test.bookbrainz.org/work/create compared to the slowness you describe in prod
2022-05-24 14420, 2022
monkey
I deployed Shubh's pull request BB#845
2022-05-24 14407, 2022
monkey
Shubh: I did a quick performance analysis, it does really improve the situation a lot. indeed the `addDocuments` method of js-search was taking 250-350ms on each re-render, meaning more or less on each keystroke. Super good find !
2022-05-24 14416, 2022
Shubh has quit
2022-05-24 14446, 2022
agatzk has quit
2022-05-24 14453, 2022
agatzk joined the channel
2022-05-24 14432, 2022
CatQuest
monkey: oh yea! that actually *is* much faster
2022-05-24 14405, 2022
CatQuest
its a great improvement really
2022-05-24 14412, 2022
monkey
!m Shubh
2022-05-24 14412, 2022
BrainzBot
You're doing good work, Shubh!
2022-05-24 14420, 2022
CatQuest
well done shubh
2022-05-24 14413, 2022
ShivamAwasthi joined the channel
2022-05-24 14418, 2022
ShivamAwasthi
Hi guys
2022-05-24 14431, 2022
monkey
Hi ShivamAwasthi !
2022-05-24 14432, 2022
ShivamAwasthi
Congrats Shubh and Ansh
2022-05-24 14439, 2022
ShivamAwasthi
Hey monkey
2022-05-24 14457, 2022
ShivamAwasthi
Can you please give a brief feedback of where I lacked in my proposal
2022-05-24 14430, 2022
monkey
I wanted to congratulate you too Shivam, your proposal was very good. Unfortunately I lack the time to mentor more than two projects, and had to make a difficult choice :(
2022-05-24 14436, 2022
ShivamAwasthi
If you think it can be improved, do you think I can perhaps do it anyways, outside of Gsoc
2022-05-24 14459, 2022
ShivamAwasthi
Without the time constraints
2022-05-24 14400, 2022
CatQuest
what was shivam roject
2022-05-24 14406, 2022
CatQuest
+p
2022-05-24 14414, 2022
ShivamAwasthi
So that it would be easy for you to review
2022-05-24 14429, 2022
monkey
The main motivator was that Shubh has been even more active than you were and for a bit longer too, hence getting more chances to get to know the codebase and community.
2022-05-24 14456, 2022
monkey
And the project can certainly be done outside of GSoC. It would be my pleasure to guide you through it if you are interested :)
2022-05-24 14425, 2022
monkey
CatQuest: The admin interface, which I was also very excited about
2022-05-24 14442, 2022
CatQuest
aaaaaaaaa
2022-05-24 14448, 2022
CatQuest
but that i need that pls
2022-05-24 14453, 2022
CatQuest
T___T
2022-05-24 14455, 2022
ShivamAwasthi
I have been learning here for the last two years, although I agree that Shubh has done a lot of great work in the time he has been with us, so I agree with you monkey
2022-05-24 14416, 2022
CatQuest
I mean not that shubh doesn't deserve a plce
2022-05-24 14449, 2022
ShivamAwasthi
I'll be happy to do it monkey, because I gave it a lot of thought and now I feel sad that I wont be able to do it
2022-05-24 14454, 2022
CatQuest
if you can do it, shivam, i would very much want that admin interface
2022-05-24 14409, 2022
CatQuest
i can not at all help with code but anythingelse, feedback, testing
2022-05-24 14426, 2022
monkey
Yeah, me too ShivamAwasthi :) It's sad to see good projects and not being able to accept them all !
