#bookbrainz

monkey aerozol : For unified form design, i think it would be good idea to get rid of both "Created Entites" & "Add" section and only allowing user to create/link other entites using inline forms like MB has for artist but not using any kind of modal.

like for publisher field, if desired publisher doesn't exist user can create it, using search query as the publisher primary alias and language same as edition (or book), we can get rid of the modal but that might make form more limited in its usage...

.. i think a modal is a good idea,

but i hae some ideas for a multi work creator

something like the mb tracklist page in the release editor

so text fields and artist fields and trackurations ja?

but for bb we can have the "names" and "type" and can singualr or batch add relationships, the way the release-relationship editor does

(but I also think we need to enable atributes on relationships *first* or else there will be *so* many things that need re-editing after when we cna actually add dates)

CatQuest: what do you think should we include in the modal, whole entity form or only required attributes?

as always, compare what mb does

(i also still dislike that language of title or name is mandatory)

mb modal is kinda large, don't you think?

yes.

still wish it included alaises, lmao

might be overwhelming for new users

there can be bits of it that are collapse/expand able

with a default of only the required ones expanded

gernally i i have ot open the link anyway to go add more data if i have it thne i'll jsut be going off and opening another ta t oadd it old-style anyway

it needs to be flexible enough for both newbies *and* power users

imagine indy adding works? they add SO MANY i reall, rallt want to make it easier for peopel like them adding all that magazine crap :O

(with crap hre i mean "lotsa stuff" not "bad data")

Yeah but monkey suggested me to focus more on new user

monkey!!!

ok, I *agre* that for exampl, B is *very* steep learning curve for newbies

but we *shall not* make tools (very wanted long asked for tools) dumbed down and simplistic plastic jobs that are dumbed down

i understand power user like indy have to put lot of efforts to add and link multiple entities

it only will make it so that new users will add incomplete data *even if* they have more of it and *even if* they actually want to add it

because by introducing a *different, "simpler" interface* you will make people use the "easy" one in defernece to the "harder to use" one

result: less data

we want to make it *easier* for (even new) peopel to add as much data as they have, by making it acessible to add and easy to add

Hmm agree

having to make it so you have to open the tab another to add. idk wikidata links for example?

not a good idea

but by all means sections with collapse/expande bits is fine

even for power users

anyway the modal will be based on the *redesigned* entity creator anyway right?

so think about making the redesigned entity creator logical and easy ot understand!

Hmm

CatQuest: do you think it would good idea to have ability to add(manually) other entites from unified form?

i don't really understand what yo umean here

isn't that what we mean with "add from modial" ?

but wouldn't it only work if we want to add entity for book(edition)?

ehh

i mean like mb has for artist or release group

my main use of this tool would be to add publishers on edition, additional authors on work, more authors on edition, and series ot everything

eh the "add new" modeal is in every single type entity searchexept non-freely editable ones like instrument nad area

things like place, work, recording, artist, series

you can't "add a new release" with a modal.

i mean mb has for eg. release form where we can add/create artist or release group on the go

...

yes that's what I mean

look have you tried "edit" no a recording? and searched for something to link in "relationships"?

ther is a dropdown there and yo ucn add straight away

it's, *easier* to add work via the relationship editor on release

but it is *possible* to add awork on the recording page

something similar for unified form should work, right?

yes. i think so indeed

monkey: For implementing search for BB entities in CB, I was going to use the endpoint "https://bookbrainz.org/search/search?q=harry". Is there any way we can also fetch the total number of entities also which I need to implement pagination?

ansh: you can do something like https://bookbrainz.org/search/search?q=harry&am...

Shubh: I was looking for an endpoint to return the total number of search results.

Hi ansh, I believe we do not currently have an endpoint for that

But looking at the code, the search server should return that information, we just don't return it ourselves in the endpoint

Can we make an addition in the api?

So it should be pretty easy to also return the total count

Great

monkey: is it okay if i start working on the routes now?, also would it a good idea to have single branch for whole project?

Shubh: I think that's a great place to start. And indeed let's create a branch for the project. For now we'll merge PRs into that branch, and we may choose to merge that branch in at regular intervals if need be

I'll create a branch

Here we go: https://github.com/metabrainz/bookbrainz-site/t...

CatQuest: when you can, please try out the reactivity of the name section on https://test.bookbrainz.org/work/create compared to the slowness you describe in prod

I deployed Shubh's pull request BB#845

Shubh: I did a quick performance analysis, it does really improve the situation a lot. indeed the `addDocuments` method of js-search was taking 250-350ms on each re-render, meaning more or less on each keystroke. Super good find !

monkey: oh yea! that actually *is* much faster

its a great improvement really

!m Shubh

You're doing good work, Shubh!

well done shubh

Hi guys

Hi ShivamAwasthi !

Congrats Shubh and Ansh

Hey monkey

Can you please give a brief feedback of where I lacked in my proposal

I wanted to congratulate you too Shivam, your proposal was very good. Unfortunately I lack the time to mentor more than two projects, and had to make a difficult choice :(

If you think it can be improved, do you think I can perhaps do it anyways, outside of Gsoc

Without the time constraints

what was shivam roject

+p

So that it would be easy for you to review

The main motivator was that Shubh has been even more active than you were and for a bit longer too, hence getting more chances to get to know the codebase and community.

And the project can certainly be done outside of GSoC. It would be my pleasure to guide you through it if you are interested :)

CatQuest: The admin interface, which I was also very excited about

aaaaaaaaa

but that i need that pls

T___T

I have been learning here for the last two years, although I agree that Shubh has done a lot of great work in the time he has been with us, so I agree with you monkey

I mean not that shubh doesn't deserve a plce

I'll be happy to do it monkey, because I gave it a lot of thought and now I feel sad that I wont be able to do it

if you can do it, shivam, i would very much want that admin interface

i can not at all help with code but anythingelse, feedback, testing

Yeah, me too ShivamAwasthi :) It's sad to see good projects and not being able to accept them all !