#bookbrainz

/

      • MRiddickW joined the channel
      • MRiddickW has quit
      • CatQuest
        yea there was some issue with it, i'll be making breakfast but once i have i'l be seated here and tt again+ explain what i saw last night
      • MRiddickW joined the channel
      • monkey
        Updated on test, merge fileds look good now thanks Shubh
      • MRiddickW has quit
      • CatQuest
        ok so, when I go t osome edition and write in the box: nothing happens. but if i click "edit" this new edit dialoge popsu up, it looks remarkably like mb's and i understand how t ouse it, I fill in soem stuff an it works fine, however when closing it nothing is on the page
      • monkey
        OK, I see it. Turns out if you type anything in the AC field (which shouldn't be allowed), the result from the modal doesn't appear as it should
      • CatQuest
        also I except a third author makin the first joinphrase "&"to a ","
      • also also, the way mb does it, i have manytimes aaaalmost pressed "delete" button isntead becase i expect the add button to be right after the box
      • but tis is an issue with bb as a whol and a differnt issue (same clunkyness in adding things to collections etc)
      • huh why is this field a text field then?
      • monkey
        A very good question.
      • CatQuest
        i expect it shoud lwork liek mb, so "fidn whatever author" and enter is go
      • but if it's a psudonym or several ou open the "edit" box
      • that's how i'd want to work (opening another box jsut to add one person every time is going ot be slow)
      • Shubh
        Something like disable text field should work ig
      • CatQuest
        especially sicne these are now gonig ot be added to *MANY* editions
      • nah, i'd say make it like relationships and publicist. let peopel paste an url or type and oy ucna select. but open the "edit" dialogue for more variations
      • see musicbrainz
      • monkey
        What we want is a search field, with the option to search for an existing author with no modifications. Then if we want the AC to be different (other author(s), pseudonyms,etc.) the user needs to click the edit button to open the modal.
      • CatQuest
        EXACTLY
      • monkey
        And the "search field" also needs to show the result AC, like it does on MB: https://usercontent.irccloud-cdn.com/file/VouyG...
      • Once the AC has been edited by the user, the "search field" cannot be used to search anything anymore, user can't type anything in it (input is disabled)
      • That's a bunch more logic, but doable
      • For reference, the MusicBrainz component is here.
      • Some of the logic we should be able to copy or adapt: https://github.com/metabrainz/musicbrainz-serve...
      • CatQuest
        this is exactly what I mean (I'll not that, on mb if you type in the field and select some artist, after it's been filled and is green) you can select (and copy) that text, or even start tying again (or even research with the same text already filled in ((useful for shifting when artist is named the same but i a differnt artist))
      • but *only* if its 1-1
      • so modified name or several people: its gray and uyoy need to open it
      • monkey
        Yeah, that logic is here, resulting in a boolean `singleArtistIsEditable`: https://github.com/metabrainz/musicbrainz-serve...
      • CatQuest
        yes!
      • if we cancombine this with "paste bbid auto-select" it'll be super easy to add author credits!
      • MRiddickW joined the channel
      • MRiddickW has quit
      • agatzk has quit