ansh: Sorry I forgot to respond this morning. Did you figure out the issue? If that was using a DB dump I would assume the role postgres should exist, not sure otherwise how you got that message
ok 1. thing: megaslow. each keystroke brings spinning beachball(hang) (EXCEPT language typing and selection :D)
2022-07-04 18519, 2022
CatQuest
including any button push (so adding another artist will also cause delay)
2022-07-04 18500, 2022
CatQuest
2: can't remove an empty author credit (so the edited credit which now is , with & after the last one) has to be manually edited
2022-07-04 18525, 2022
CatQuest
selecting an author will let me remove it, but artist credit doesn't go back to what I except (&)
2022-07-04 18525, 2022
CatQuest
(also sorry I should have tested AC before but i only cursory did so)
2022-07-04 18545, 2022
CatQuest
3: I really like that isbn is on the page, *AND* that the "add identifiers" are now a button at the end which inspires one to actually click it, instead of forgetting
2022-07-04 18513, 2022
CatQuest
however I think th "identifier editor" could easily be on the page? see how eg, urls are added on mb
2022-07-04 18523, 2022
CatQuest
but that's not a huge thing at all. actually not
2022-07-04 18513, 2022
CatQuest
I will note that this will break my workflow because i tend ot edit the annotation first and copy the isbn and barcode *from* there and paste into isbn. but this is still a big improvement (expect for the extremely slow keystroke thing)
2022-07-04 18511, 2022
CatQuest
oh here is an issue after adding a barcode it and closingig the identifier box it doesnt actually show on the page (under isbn, as i had expected)
2022-07-04 18547, 2022
CatQuest
I don't think the works adding box is agood. it's not exactly easy realise that i cna clci kin the box after i have added a work and see that i cna start typing again.
2022-07-04 18507, 2022
CatQuest
insteadi'd show this like the current relationships, or like identifers/aliases
2022-07-04 18510, 2022
CatQuest
one box for each
2022-07-04 18529, 2022
CatQuest
it's not clear in the popup that boxes can be clicked to be expanded
2022-07-04 18517, 2022
CatQuest
things like basic and details should always be expanded or we are going ot get a WHOLE lot of just blank works
2022-07-04 18549, 2022
CatQuest
works boxpopup has isses with the language dowpdown causing hanging after selecting a language
2022-07-04 18503, 2022
CatQuest
infact if the popupxo had less space to b "boxed" it would on the whole be lesstall in the first place
2022-07-04 18549, 2022
CatQuest
typing is excruciating. i must say
2022-07-04 18506, 2022
CatQuest
i mena i type a sentence and i cna go here and type this while i wait for the browser and whatnot to finish actually that sentence
2022-07-04 18523, 2022
CatQuest
it's not doen yet
2022-07-04 18551, 2022
CatQuest
I mean... it's taking mnutes. not seconds
2022-07-04 18511, 2022
CatQuest
also I would except "details" tab before works
2022-07-04 18545, 2022
CatQuest
and it should be always expanded not even collapsed. what's the point of even making it collapsible if we have tabs?
2022-07-04 18534, 2022
CatQuest
... expanded all the boxes in the work box earleir. gonig to try maknig another work and they are now collapsed again. not good, having ot re-open all these boxes *EVERY* time i want ot add a work is a huge pita
2022-07-04 18554, 2022
CatQuest
(nothing too ,that they should always be expanded, in my oppinion)
2022-07-04 18546, 2022
CatQuest
pasting a text in the works box doesn't search. so I have to type/remove a letter to get it to react
2022-07-04 18508, 2022
CatQuest
closing the add work box witotuh adding a work (the x button) isrelaly slow and hangs the browser
2022-07-04 18527, 2022
CatQuest
there is no option to create a new work if i enter a word that excists as a work (like "test" wich has a few works already)
2022-07-04 18553, 2022
CatQuest
disambiguiations aren't showed in the dropdowns. it should + probably author links as well
2022-07-04 18511, 2022
CatQuest
language doropdown on details continue to be slow
2022-07-04 18515, 2022
CatQuest
clicking away fro mth page will remove the dropdown but clicking towards the page again will repopup the dropdown (this is an issue becasue i was going for "format" and it's directly below and i ended up selectnganother language inadvertedly)
2022-07-04 18550, 2022
CatQuest
does format and status really need searchable drowdowns? status has like 2 options anyway
2022-07-04 18520, 2022
CatQuest
I'm sure not just having boring html dropdowns for these adds to code complxiy for no good reason
2022-07-04 18513, 2022
CatQuest
annotation on details tab doesnt lag as much as the works creating one
2022-07-04 18533, 2022
CatQuest
the design of th whole thing I like quite a lot. (other thna i woul want annotation next ot identifiers im usecase)
2022-07-04 18553, 2022
CatQuest
i would put the details right after basic and works after that
2022-07-04 18548, 2022
CatQuest
the last overview+note is useful but the data shown there should be the stuff yo untered, not just "what new things2 it looks like our reviews library (wich is notoriusly bad) which needs another overhaul by far
2022-07-04 18542, 2022
CatQuest
to sum up, this is really good! I liek that things are more left aligned in general!
2022-07-04 18557, 2022
CatQuest
the add works tab is what needs more. heh "work"
2022-07-04 18536, 2022
CatQuest
i susspct that the works popup is so significantly slower because it loads everything in the same page/thing
2022-07-04 18549, 2022
CatQuest
i wonder if having a thing wher yo ucna add works, theri name language and type in just a smal lthinger. and thne add the authors *on the works tab* like you would add links woudl be better
2022-07-04 18557, 2022
CatQuest
see how mb's relationship editor looks
2022-07-04 18517, 2022
CatQuest
you don't add relationships in the "add $entity" popup
2022-07-04 18531, 2022
CatQuest
it'd be fine wih not doing that
2022-07-04 18503, 2022
CatQuest
instead having one box eac for works (like identities) and then you could.. say have checkboxes and batch add "author" links to hme straight for mthe works tab
2022-07-04 18519, 2022
CatQuest
as well as individually adding thme as needed
2022-07-04 18530, 2022
CatQuest
see "add relatinoships" editor on release on mb
2022-07-04 18534, 2022
CatQuest
for what i'm thinknig of
2022-07-04 18538, 2022
ansh
monkey: Can we return edition group types, work types etc... on the search endpoint? We can display these on the CB search page
2022-07-04 18529, 2022
CatQuest
I'd definitely be for showing more data on search results!
2022-07-04 18539, 2022
Shubh
CatQuest: Thanks for the detailed feedback, really appreciated!
2022-07-04 18522, 2022
Shubh
About performance issues, i can understand since form state got so much complex handling different type of entities, will try my best to improve on that
2022-07-04 18519, 2022
monkey is back in front of keyboard
2022-07-04 18542, 2022
monkey
Shubh: I forgot to update the PR from master, so that could mayyyybe explain some of the slowness of some part of the state?
2022-07-04 18550, 2022
Shubh
also about having identifier editor inline, not sure about that. i think keeping tabs minimal is way to go, monkey your thoughts?
2022-07-04 18526, 2022
monkey
I have to read the whole feedback first but I'm in the middle of something, can comment tomorrow
2022-07-04 18537, 2022
Shubh
monkey: can't say, as CatQuest said it is due to keystrokes which might be triggering costly state updates thereby causing slowdown
2022-07-04 18552, 2022
monkey
ansh: the results currently do return the type, but only th id of the type and not it's label string
2022-07-04 18519, 2022
monkey
Shouldn't be hard to add
2022-07-04 18554, 2022
Shubh
CatQuest: how about showing identifiers count like we have for entity editor?
2022-07-04 18511, 2022
agatzk has quit
2022-07-04 18542, 2022
agatzk joined the channel
2022-07-04 18502, 2022
Shubh
CatQuest: are you sure pasting text on add works field not triggering a search?
2022-07-04 18524, 2022
Shubh
also disambiguation does show on options (which have disambiguation that is)
2022-07-04 18556, 2022
Shubh
7:28 PM <CatQuest> clicking away fro mth page will remove the dropdown but clicking towards the page again will repopup the dropdown.
2022-07-04 18556, 2022
Shubh
i'm not sure if i understand it correctly...
2022-07-04 18519, 2022
Shubh
CatQuest: what do you think should we include in summary section apart from name of new entity
2022-07-04 18501, 2022
Shubh
also from batch add "authors" to works, you mean having a checkbox to copy all edition's author (AC) to that work?
2022-07-04 18532, 2022
monkey
Mm, we can't do that, ACs don't apply to Works. But if there is only one author in the AC that could be doable
2022-07-04 18522, 2022
Shubh
not exactly AC, but linking those authors (from edition AC) using "author wrote work" to work
2022-07-04 18534, 2022
monkey
Right. And so if there are multiple authors in the AC you just add multiple relationships I guess?
2022-07-04 18500, 2022
Shubh
Yep
2022-07-04 18511, 2022
monkey
I think that would be convenient (but definitely needs an action from the user -for example as you say a checkbox)
2022-07-04 18558, 2022
Shubh
Hmm, maybe allowing user to remove some author if they want using relationship editor
