CatQuest: did you face the slow keystroke response on modal or on whole unified form?
2022-07-05 18644, 2022
CatQuest
whole unified form, but it was magnitudes worse in the popup(modal?)
2022-07-05 18659, 2022
Shubh
apart from modal(popup?) thing other components of uf should work fairly smooth, it would be helpful if you can provide me which specific field's performance is worse as compare to entity editor?
2022-07-05 18641, 2022
CatQuest
in the whole form they are all bad, in the mpopdal it was worst in.. typing the annotation
2022-07-05 18644, 2022
CatQuest
iirc
2022-07-05 18602, 2022
CatQuest
all typing in the popmodal was excruciating
2022-07-05 18645, 2022
CatQuest
in the whole form they are equally as bad i mean
2022-07-05 18604, 2022
CatQuest
except edit note it was the least bad
2022-07-05 18608, 2022
Shubh
so like annotation in uf is slower than annotation in entity editor?
2022-07-05 18615, 2022
monkey
I just update the new-creation-form branch from master, and pushed the uf-editor PR again on test.bb
2022-07-05 18637, 2022
monkey
CatQuest: Can you see if the typing aspect is any faster now?
2022-07-05 18644, 2022
Shubh
monkey: do you also think it would be a good idea to have separate row for each work in content tab(like identifier editor)?
2022-07-05 18617, 2022
monkey
Yes! I actually just a minute ago wrote that sentence in the comments I'm compiling :)
2022-07-05 18629, 2022
monkey
Here it is:
2022-07-05 18634, 2022
monkey
> I agree the works should be each on a separate row instead of a multi-select.
2022-07-05 18634, 2022
monkey
One added advantage: in the future we will most likely have a way to specify what page a certain work starts at, and it will be much easier if each is in a separate row.
2022-07-05 18634, 2022
monkey
It would also be helpful if we want to show a bit more information for each work in that tab like author (+ checkbox to copy author rel from AC).
2022-07-05 18659, 2022
Shubh
Yep, also one more thing slow performance on modal might be cause of uf and modal sharing the same root state i.e state update on modal also cause useless update (or render) on form as well.
2022-07-05 18640, 2022
monkey
I figured it would be something like that. How do we prevent that from happening?
2022-07-05 18602, 2022
Shubh
something like freezing form when modal is open?
2022-07-05 18635, 2022
monkey
The issue is that the redux actions that are dispatched affect more than one part of the state?
2022-07-05 18603, 2022
monkey
i.e. they will cause a state change in the modal state as expected, but other parts of the form are also reacting to the same actions?
2022-07-05 18614, 2022
Shubh
not state but more than one component dependent on that state
2022-07-05 18641, 2022
monkey
OK. So more a question of rendering on state change (i.e. a React problem, not a Redux problem), correct?
2022-07-05 18649, 2022
Shubh
hmm something like that
2022-07-05 18611, 2022
Shubh
didn't realize it would be noticeable though, i think it is mainly due to large language dropdown which get render 2-3 times on modal which make this worse
2022-07-05 18655, 2022
monkey
That was why I updated test.bb this morning, hoping it will make it more usable
2022-07-05 18607, 2022
Shubh
but this shouldn't be an issue after async language select, i hope
2022-07-05 18633, 2022
monkey
Speaking of, let me work on that one and see if we can get it merged, then I'll try to update new-creation-from branch and deploy the PR again.
2022-07-05 18652, 2022
CatQuest
monkey: yes i can. pls link me directly to the creation form again pls
We need another bit of time to figure it out, will ask you again when we think it's improved
2022-07-05 18659, 2022
CatQuest
sure!
2022-07-05 18616, 2022
CatQuest
I also have to say this yet again: over engenering "states" and "freezing" and the like is in my humble opinion not the way to go about it. instead doing a round to "de-complexify" code. especially ui/ux code to mak it "dumb" instead of "smart" and instead do "smart" things *after* a person clicks a button or selects or the like. is the right way. look how mb does it. searching and typing has never been an issue there.
2022-07-05 18616, 2022
CatQuest
art of this is elasticsearch I'm sure, we really should switch to solrs soon
2022-07-05 18639, 2022
CatQuest
like an annotation or a review note shoudl jsut be plain old hml text-fields
2022-07-05 18641, 2022
monkey
No, not at all related to the search itself
2022-07-05 18650, 2022
CatQuest
what are "states" exactly?
2022-07-05 18612, 2022
CatQuest
why do we need them?
2022-07-05 18615, 2022
CatQuest
what do they do?
2022-07-05 18625, 2022
monkey
The whole state thing is basically where we store the content of each field in a structured manner, that is then sent to the server as a form
2022-07-05 18637, 2022
CatQuest
...
2022-07-05 18650, 2022
CatQuest
and if we *don't* have that?
2022-07-05 18608, 2022
monkey
If we don't have that we need to rewrite the entire entity editor :)
2022-07-05 18614, 2022
CatQuest
well...
2022-07-05 18629, 2022
CatQuest
that's what this shoud e. (in my *humble humble* opinion)
2022-07-05 18631, 2022
monkey
what we call state = backbone in the old MB
2022-07-05 18635, 2022
CatQuest
hm
2022-07-05 18641, 2022
monkey
Same same
2022-07-05 18644, 2022
monkey
But different
2022-07-05 18652, 2022
CatQuest
it shoudl be same same
2022-07-05 18658, 2022
CatQuest
not different
2022-07-05 18659, 2022
CatQuest
well
2022-07-05 18625, 2022
CatQuest
what does mb do? it doesnt have these "states" i think?
2022-07-05 18635, 2022
monkey
Yes it does
2022-07-05 18643, 2022
CatQuest
what does it do differently thna bb?
2022-07-05 18645, 2022
monkey
Perhaps not exactly the same tool, but *some* tool
2022-07-05 18657, 2022
CatQuest
that tool seems ot be a hella lot less laggy. tbh
2022-07-05 18615, 2022
monkey
Well, most of the issue is some implementation we don't do correctly, and that's fixable
2022-07-05 18625, 2022
CatQuest
hm
2022-07-05 18659, 2022
CatQuest
it's literally always been a little slow though. like years and years ago. the initiall opening of an entity add/edit page has always taken extra tiem to load
2022-07-05 18631, 2022
monkey
Probably the very same implementation problem that's been there all along…
2022-07-05 18603, 2022
CatQuest
and it means i have to wait before editing like the title or whatever because until the page finishes loading it wont register any imput. and so if i type the title before tht and thne press "guess2 it wont work, evne if i do it after it finishes loading
2022-07-05 18608, 2022
CatQuest
exactly
2022-07-05 18607, 2022
CatQuest
btw. we should have a "guess case" type button on title too
2022-07-05 18613, 2022
CatQuest
all titles, names and so on
2022-07-05 18642, 2022
CatQuest
you can copy the logic direct from mb too. just have two states for now. english and sentence
2022-07-05 18657, 2022
CatQuest
later french/german/whatever can also be muxed in
2022-07-05 18616, 2022
monkey
Shubh: Overall I think the unified form is going very well. Still a few teething issues but nothing that seems unsurmountable.
OK. As I commented I don't think we should restrict the number of frequently used languages (there are only 21 in the DB) but I can rename and reuse the variable as a max number of items shown. Will make that change now
2022-07-05 18613, 2022
monkey
(if you don't mind)
2022-07-05 18651, 2022
Shubh
sound good to me :)
2022-07-05 18601, 2022
ansh
monkey: while working on the client side with live reload enabled, sometimes I observe that the css is not getting updated when refreshed. So I have to restart the server. Are there any changes that might help?
2022-07-05 18616, 2022
monkey
The css file name doesn't change, so it might be cached by the browser. I usually have my browser console open with the option selected to "Disable cache": https://usercontent.irccloud-cdn.com/file/4RdDkFg…
2022-07-05 18639, 2022
monkey
This is in the browser console settings
2022-07-05 18648, 2022
ansh
Is there any caching done by webpack?
2022-07-05 18610, 2022
monkey
At some level yes
2022-07-05 18635, 2022
ansh
Because hard reloading also does not help in those cases.
If we were to have a specific page to show all reviews for an entity ("show all" link sort of thing), conceivably tables might work, but then we're just duplicating critiquebrainz, we might as well directly link to the CB page
2022-07-05 18601, 2022
ansh
I have almost reached something similar to what I proposed and the cb website, I'll show it to you tomorrow.
2022-07-05 18614, 2022
monkey
Nice !
2022-07-05 18631, 2022
Shubh
monkey: is there any known way to append icon at accordion header in bootstrap v4?, i've added one in details tab accordion (https://test.bookbrainz.org/create) but its kinda clunky :(
To be clear, in addition to, not replacing styles for `show`
2022-07-05 18627, 2022
monkey
Hm, it reverses the delay (delay after closing, not after opening) which looks a lot better (reactive?) IMO, but maybe that's not what you're looking for
CatQuest: I put the new language-select-that-works-more-like-MB on beta.BB
2022-07-05 18637, 2022
monkey
Could you please have a look and let me know if it feels any faster?
2022-07-05 18650, 2022
Shubh
looking good, lets go with this then :)
2022-07-05 18618, 2022
CatQuest
[18:02] <monkey> If we were to have a specific page to show all reviews I epect ti to wrok like mb: on the edition-group page, reviews for the edition group will show (i'd do as the mb one, right now i actually don't know if it only will show the first one, the higest rated one or any review an RG has randonly)
2022-07-05 18636, 2022
CatQuest
monkey: yes i will test!
2022-07-05 18634, 2022
CatQuest
ok so this is what i'm noticing: typing is much, much faster. but things like selecting after search, language search or entity search (for autor credits etc) as wel las any btutton push, (guess case, add a new author credit, etc) is so. hella. slow
2022-07-05 18623, 2022
CatQuest
typing in isbn is really slow
2022-07-05 18626, 2022
CatQuest
name was fast
2022-07-05 18607, 2022
CatQuest
wow selecting "create new work" after searching and not finding anything takes up so much energy my music player crashed (not kidding)
2022-07-05 18612, 2022
CatQuest
the add work modal is as slow as ever. if anything worse
2022-07-05 18630, 2022
CatQuest
trying ot work in it is hanging my system pretty hard
2022-07-05 18652, 2022
monkey
Ah, test hasn't changed, I was asking to test beta :)
2022-07-05 18622, 2022
CatQuest
ಠ_ಠ
2022-07-05 18637, 2022
CatQuest
sorry
2022-07-05 18655, 2022
monkey
no worries
2022-07-05 18638, 2022
CatQuest
give me a link to the thing on beta then. i'm ultra lazy and should go and make dinner but i cna test things just before that for sure
2022-07-05 18600, 2022
CatQuest
you got mad about the ultralazy
2022-07-05 18622, 2022
CatQuest
anyway let me see
2022-07-05 18618, 2022
CatQuest
monkey: you should put things on test before beta you know... if things on beta contradict new fixes, then perhaps we need *another* test server. gsoc.bookbrainz.org? whatever
2022-07-05 18612, 2022
CatQuest
anyway the language selection now is... snappy! :o in comparason
2022-07-05 18618, 2022
CatQuest
well done
2022-07-05 18603, 2022
CatQuest
anyway i cna finally add quite a few books that's been waiting. so i thank you a lot for this
