-- BotBot disconnected, possible missing messages --
2022-07-25 20651, 2022
BrainzBot joined the channel
2022-07-25 20610, 2022
MRiddickW has quit
2022-07-25 20625, 2022
Shubh
Hey monkey!
2022-07-25 20653, 2022
monkey waves
2022-07-25 20639, 2022
Shubh
monkey: do you think those enzyme test should be more strict?, since most of components are reused from entity editor i thought adding including them in uf test would be redundant.
2022-07-25 20623, 2022
monkey
I haven't done any work since Thursday, haven't had time to look at the tests yet.
2022-07-25 20614, 2022
monkey
I should have a bit of time in the coming days since I need to do the GSoC paperwork, so I can have a quick look then and let you know
2022-07-25 20627, 2022
monkey
Generally I agree we can test individual components (name section, etc) which are more important.
2022-07-25 20630, 2022
monkey
Then we can see what other sort of test we would need if any for the whome uf and or for the whole entity editor per entity. I'm guessing not a lot needed
2022-07-25 20600, 2022
Shubh
then I will be adding test for entity-editor's components as well
2022-07-25 20608, 2022
monkey
I guess mostly making sure all the sections and props are there that we expect
2022-07-25 20635, 2022
Shubh
also i'm thinking of adding series, starting with work series in contents tab giving ability to user to select work to be include in that series. (series either created/selected).
2022-07-25 20608, 2022
monkey
I think that would be a very good addition. Not sure we need other entity series
2022-07-25 20627, 2022
Shubh
also for summary section, i'm thinking of adding a modal which open when user click on the entity name showing all entity details?
2022-07-25 20637, 2022
monkey
Shubh: good idea!
2022-07-25 20601, 2022
CatQuest
Shubh: hi, I will test, but not today (late) and not tomorrow (have an appointment with doctor, and on wednesday the weather is nice so I will be going to ocean and bath if I can)
2022-07-25 20601, 2022
CatQuest
depending on how things pan out tomorrow I can test later in the day or early in the morning if i wake up early.. *please* ping me about it tomorrow (if you do not it's likly that itwill not happen until thursday)
2022-07-25 20602, 2022
CatQuest
ok so change of plans. i tested it RIGHT NOW
2022-07-25 20603, 2022
CatQuest
and..
2022-07-25 20605, 2022
CatQuest
it's awesome!!!
2022-07-25 20613, 2022
CatQuest
it's snappier and easier to use than the current beta !
2022-07-25 20619, 2022
CatQuest
🎉🎊
2022-07-25 20628, 2022
CatQuest
one isue:i can't seem to actually submit it
2022-07-25 20644, 2022
CatQuest
it's litterally grayd out and i can't clic knext after "contens" tab
2022-07-25 20657, 2022
CatQuest
thre is no errors saying anything else
2022-07-25 20618, 2022
CatQuest
.. ok found out: it's because the "author credit" is not filled in. this shouldn't block adding. this is a magazine it doesnt *have* a spesific author credited
2022-07-25 20631, 2022
CatQuest
at the very least it shoudl give an error
2022-07-25 20656, 2022
CatQuest
....
2022-07-25 20659, 2022
CatQuest
i get error: Submission Error: Undefined binding(s) detected when compiling SELECT. Undefined column(s): [bookbrainz.entity.bbid] query: select "bookbrainz"."entity".* from "bookbrainz"."entity" where "bookbrainz"."entity"."bbid" = ? limit ?
2022-07-25 20652, 2022
CatQuest
nope tried everything. I've added 3 works, some rels to those works, ec...
2022-07-25 20658, 2022
CatQuest
cant add this
2022-07-25 20659, 2022
CatQuest
.. what does "copy authors from AC for this work" do? will it copy the ac in the editor into rels on works?
