hmm so the "type" dropdown in the "create a work" popup in the "add a book" routine has no way to unset it
2022-11-21 32529, 2022
CatQuest
this is bad because if i accidnetally set it and it turn out that the type it is actually doesnt excist we get bad data
2022-11-21 32544, 2022
CatQuest
(or have to refresh in order to do it again)
2022-11-21 32509, 2022
CatQuest
also autoscrolling the page. when I access a popup somewhat lower on the page. is annoying. i 'd like an option to turn that off
2022-11-21 32555, 2022
CatQuest
I had typed in the title and sortname and disambiguation and then selcted the language to fill it in and the page scrolled automatically. i'd rather it didn't
2022-11-21 32527, 2022
CatQuest
actually it does this on work/create too. it's rather distracting actually
2022-11-21 32514, 2022
CatQuest
it actually scrolls and moves the contence of the ag evne if the dropdown is even a lttle bit lower down than centered or high up
2022-11-21 32519, 2022
CatQuest
that's.. unintuitive
2022-11-21 32515, 2022
CatQuest
"back in the day (starts being an old geezer)
2022-11-21 32515, 2022
CatQuest
the dropdows would go either up or down and be adapted ot the page. the page wouldn't adapt to the damn dropdowns!" (shaes fist)
2022-11-21 32517, 2022
CatQuest
:D
2022-11-21 32544, 2022
CatQuest
seriously mandatory author credit is bad
2022-11-21 32511, 2022
CatQuest
please make this optional (highly recomended with a "fill this out if yo ucna please" type thing. but don't prevent addition)
2022-11-21 32520, 2022
CatQuest
it will only make it necessary to create bogus artists like "anon" and "various" etc
2022-11-21 32524, 2022
CatQuest
it's also great if yo ucan add something and *then* later dit it do add more data/relationships/author credits an the like
2022-11-21 32544, 2022
CatQuest
honestly the only mandatory thing should be name and sortname
2022-11-21 32551, 2022
CatQuest
even language shouldn't be mandatory
2022-11-21 32517, 2022
CatQuest
(naturally badly added things can and will be merged/reporpused) but that's fine too
I'm getting not null error on entity views (logs above) after the deleting the entity, wondering if it because data id is null for the entity but not sure how it related with revision parent. any ideas?
2022-11-21 32532, 2022
monkey
I'll try to have a look this week, I'm currently caught up in a nightmare of a react update for ListenBrainz…
2022-11-21 32515, 2022
Shubh
Also i realized there was a issue with deleted entity on CB modal which was causing the crash (https://test.bookbrainz.org/author/d8c0956b-0adf-…) so i will include the fix for this in the same PR (for deleted revision parent). I hope that sound sane.
since deleted entity will have alias_set_id null, when we try to update entity modal it will trigger the process_entity trigger which will try to create new entity_data with null alias_set thus causing error
