> Add .gitattributes file to fix cross-platform line-ending issues
2023-02-27 05821, 2023
pbryan
OK, the challenge will be testing. I'll see about getting a Windows VM setup so I can prove it works.
2023-02-27 05830, 2023
monkey
Can't help you there I'm afraid, no Windows machines around. If VM is too cumbersome, we could ask assistance from other people on the channel who are on Win
2023-02-27 05827, 2023
kellnerd
I have a Windows machine, but my Git for Windows autocrlf option is already set up correctly to avoid CRLF (although I always forget the correct value to achieve this), so I won't be a useful tester.
2023-02-27 05830, 2023
pbryan
I've got an ISO around here somewhere. Cue rummaging sounds. 😉
However I would expect a "Development" dropdown on the right hand side with the PR listed underneath. Will continue investigating.
2023-02-27 05851, 2023
BrainzBot
BB-667: Bug when modifying Series relationship in Edition
2023-02-27 05802, 2023
Deogee joined the channel
2023-02-27 05854, 2023
Siddhart1o1 joined the channel
2023-02-27 05809, 2023
Siddhart1o1 has quit
2023-02-27 05816, 2023
monkey
kellnerd: So it turns out everything was working fine with JIRA-Github integration, but 1. I was just not paying enough attention to the formatting of pull request titles and 2. The 'development' dropdown in JIRA is a separate thing to the "Github Bot" comments on the ticket.In your use-case, are the comments on the ticket good enough? https://usercontent.irccloud-cdn.com/file/NpZZ9Bh…
2023-02-27 05847, 2023
kellnerd
Yay! Comments are usually enough for me. Only if there are multiple PRs or direct commits to main the development dropdown is good to have.
2023-02-27 05832, 2023
monkey
OK, will see where we stand on that, as it's a question for the rest of the MeB projects as well
2023-02-27 05831, 2023
kellnerd
pbryan: I'm just looking into BB-712. Do you have a good real world example of an entity which has an alias with a comma?
Because a simple change of the alias separator would affect all entity types and what looks good for e.g. authors might not for editions.
2023-02-27 05844, 2023
kellnerd
For author aliases most separators (including comma and middle dot) are probably fine, but for editions/works the alias titles may contain any punctuation that would fit as alias separator (e.g. slashes, dashes, pipes...)
2023-02-27 05828, 2023
pbryan
I'll see if I can find a good example.
2023-02-27 05811, 2023
Deogee has quit
2023-02-27 05853, 2023
pbryan
kellerd, here are the first 5 examples I've found:
Thanks, so the comma is a problem for elaborate work titles, of course :)
2023-02-27 05846, 2023
pbryan
Yes, basically anything with a comma conflicts with the delimiter we're using to separate aliases.
2023-02-27 05806, 2023
pbryan
I'm sure there are authors with some kind of title or suffix with a comma as well.
2023-02-27 05816, 2023
kellnerd
I've attached a demo screenshot to the ticket, if monkey agrees and nobody else objects, I will submit a PR.
2023-02-27 05840, 2023
monkey
It makes a lot of sense with works, for sure. I wasn't originally convinced the author aliases would be an issue, but I can definitely see the value in this improvement
2023-02-27 05849, 2023
monkey looks at ticket
2023-02-27 05809, 2023
monkey
Middle dot works well. I was thinking of the Catalan "punt volant" (or "flying dot") which is a fatter version of the same, if we want something less subtle
2023-02-27 05836, 2023
kellnerd
We could also make the separator configurable per entity type if we consider some of them unproblematic and better-looking with a comma.
I'm not attached. It doesn't make much sense in terms of HTML hierarchy, so it's probably like that mainly for styling
2023-02-27 05841, 2023
monkey
Which means, if you're reviewing the styling anyway, it can just be scrapped
2023-02-27 05844, 2023
kellnerd
Ok, I will try to turn this into something like `<ul class="inline-aliases">` then.
2023-02-27 05807, 2023
monkey
Sounds good. Thank you !
2023-02-27 05806, 2023
pbryan
Nice!
2023-02-27 05847, 2023
pbryan now has WSL installed, so step 1 complete. 🙂
2023-02-27 05846, 2023
kellnerd
Almost there, I only have to copy the h4 styling from lobes4.
2023-02-27 05845, 2023
kellnerd
Should I use the Roboto font of h4 as previously (only used for headings) or should I keep the default Sintony font?
2023-02-27 05804, 2023
kellnerd
"Keep" as in not overwrite it
2023-02-27 05850, 2023
monkey
Hm.
2023-02-27 05830, 2023
monkey
I don't see much of a reason to use Roboto now that we're moving away from using header tags. I doubt it was on purpose.
2023-02-27 05810, 2023
monkey
But if you think it looks better to have the same font as the main alias just above, we could use Roboto
2023-02-27 05836, 2023
kellnerd
Ok, I'm experimenting a bit. I guess we definitely want to keep font-size and probably also font-weight (only 300 for headings, while it is 400 elsewhere).
2023-02-27 05830, 2023
sumit joined the channel
2023-02-27 05805, 2023
pbryan
Hmm, interesting. If I use git in WSL, everything is great.
2023-02-27 05839, 2023
pbryan
If I use git installed in Windows, I get `\r` line endings. So, reproduced at least.
2023-02-27 05801, 2023
pbryan
I'm surprised at how well integration WSL is. Not enough to make me want to switch to Windows, but...
2023-02-27 05808, 2023
kellnerd
Never have used SCSS before, but TIL that I can simply use `@extend h4;` instead of copying properties or finding the names of the appropriate SCSS variables.
2023-02-27 05819, 2023
monkey
Indeed
2023-02-27 05801, 2023
pbryan
monkey: Would it be safe to say we want all text files in GH to be Unix style (never have CRs)?
2023-02-27 05842, 2023
monkey
I… suppose? It's been so long I haven't Windowsed that I don't know what the implications could be
2023-02-27 05813, 2023
pbryan
If I have my facts straight, it means most good editors on Windows will be fine with it. Notepad will not work well.
I went through the codebase and it looks like the options(in this case Novel , short story , poem....) are gotten from the database and stored in the redux store
2023-02-27 05851, 2023
Deogee
I am trying to add "Essay" to the list of work type options
2023-02-27 05851, 2023
Deogee
Do i just need to add "Essay" to the database and that will you suffice ?
2023-02-27 05816, 2023
monkey
Hi Deogee ! Yes unfortunately this can only be aded to the database and I'm the only one with the keys :) Please pick another ticket !
2023-02-27 05829, 2023
monkey
I hadn't seen it was marked as a good first bug, my bad !
