monkey: I think we're ready for a PR for work guideline. Thoughts?
2023-03-06 06558, 2023
smach joined the channel
2023-03-06 06525, 2023
monkey
pbryan: Definitely !
2023-03-06 06523, 2023
smach has quit
2023-03-06 06540, 2023
monkey
ShivamAwasthi: should be live, but indeed I see only three at a time. Looking at the network tab in my browser I can see that the autocomplete endpoint is called with "size:3" which would explain it
The result is that this is not necessary at all, like I had guessed.
2023-03-06 06529, 2023
kellnerd
Properly encoding the entity name once is enough (has not been done at all before that PR), this way we can also drop the `decodeUrlQueryParams` middleware again.
2023-03-06 06551, 2023
kellnerd
I guess Shubh had run into the same issue with live reloading that component as me while trying to fix it: Changing src/client/components/pages/parts/call-to-action.js and saving has no effect in my browser at all in certain circumstances (not even after refreshing the browser tab) - maybe this happens after the server has already been restarted by
2023-03-06 06552, 2023
kellnerd
nodemon!?
2023-03-06 06547, 2023
kellnerd
`decodeUrlQueryParams` was only undoing the unnecessary second encoding pass, the first encoding is already handled by Express.
2023-03-06 06511, 2023
kellnerd
Now that I've got this working properly I will rebase my changes onto a new branch and create yet another PR for you to review, sorry :)
2023-03-06 06538, 2023
kellnerd
Probably because the dumps were always including the whole database, even before collections did exist D:
