Hello everyone !!! I hope you're all doing great. I'm currently working on resolving issue BB-768 and trying to make changes in bookbrainz-data-js repository. However, when attempting to commit my changes, I came across thousands of linting errors, none of which were caused by me. I would greatly appreciate it if someone could lend a hand in
2024-02-13 04444, 2024
Tarun_0x0
helping me navigate past this hurdle so that I can proceed with making a pull request. Thank you very much!
So, from a fresh repo on master branch, running `npm run lint` (the command we use for linting), I'm faced with 13 warnings, 0 errors.
2024-02-13 04459, 2024
monkey
All the warnings are about "todo" comments in the code
2024-02-13 04407, 2024
monkey
So far off from what you're seeing :)
2024-02-13 04426, 2024
monkey
I suspect your code editor might not be taking the ESLint rules we have in place?
2024-02-13 04401, 2024
Tarun_0x0
just when i am trying to commit my changes from my local branch it shows a git lint error , then in terminal whenever i run npm run lint it shows
2024-02-13 04401, 2024
Tarun_0x0
✖ 15321 problems (15308 errors, 13 warnings)
2024-02-13 04402, 2024
Tarun_0x0
15202 errors and 0 warnings potentially fixable with the `--fix` option.
2024-02-13 04418, 2024
monkey
i.e. the .eslintrc.js file in the root of the project is the configuration. Try to see why it's not respecting that. maybe expecting .eslintrc, without the .js at the end?
2024-02-13 04432, 2024
monkey
Huh
2024-02-13 04400, 2024
monkey
Well, um. Do you have a whole bunch of file changes if you run `git status`?
2024-02-13 04422, 2024
kellnerd is wondering how many of these 13 todo comments he added 😛
2024-02-13 04422, 2024
Tarun_0x0
no i only modified two file , those two are only in my git status
2024-02-13 04459, 2024
monkey
I have no idea what could be going on, to be honest.
2024-02-13 04456, 2024
Tarun_0x0
well almost all errors are about this
2024-02-13 04456, 2024
Tarun_0x0
1:51 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
Yep, looks about right. Please do read that GH docs page Tarun_0x0, it has all the answers you should need
2024-02-13 04405, 2024
monkey
kellnerd: January, during docsprint. I updated some dependencies, came with snazzy new theme
2024-02-13 04401, 2024
kellnerd
Ah, it will take me some time to get used to it, I kind of miss the previous colors :)
2024-02-13 04441, 2024
Tarun_0x0
truly appreciate your help monkey and let me give this a try =D
2024-02-13 04416, 2024
monkey
kellnerd: We can always revert, I'm neutral on the subject. Is it just the change you don't like?
2024-02-13 04414, 2024
kellnerd
Probably, I was used to the colors of the "Note" and "Important" boxes.
2024-02-13 04443, 2024
kellnerd
The only thing which is worse UX wise is that the navigation sidebar is no longer sticky, that left column is just wasting screen space and makes it harder to navigate.
2024-02-13 04410, 2024
monkey
I can get behind that. I had other issues with teh previous sidebar, but I did like the stickiness
2024-02-13 04446, 2024
Tarun_0x0 has quit
2024-02-13 04412, 2024
aabbi15 joined the channel
2024-02-13 04459, 2024
aabbi15 has quit
2024-02-13 04412, 2024
ApeKattQuest
wait bookbrainz changed colours?
2024-02-13 04435, 2024
monkey
No, the user developer guide readthedocs did
2024-02-13 04416, 2024
ApeKattQuest
uh ok? but isn't that user(per thingy) set?
2024-02-13 04427, 2024
ApeKattQuest
als othat wasn't gone throug for reasonstoo wasn't it :(
2024-02-13 04443, 2024
monkey
Sorry, I didn't understand any of that
2024-02-13 04420, 2024
ApeKattQuest
uh read the docs can have the colours set by whoever makede the whatever isntance o read the docs it is. so colours are customisable
