Yes, it's mainly just me reviewing PRs at the moment, so it usually takes some time for me to get to it
Usually within the week, but I do ask for your patience
Shubh
and also in first one lint checks failed so can i fix it in github without pulling it?
monkey
Possibly yes, although I usually find it's easier to make the modifications locally so I can check if the tests and linting passes
Shubh
i was kinda nervous as its my first contribution to open-source and though i messed that simple task
monkey
Don't you worry ! We all start somewhere :)
Shubh
although i passed most of the linter check but there was one related to inconsistent return
so what should i do to fix that like return something if entity only deleted once or just remove the lint check for that line?
monkey
So you can run the linter locally before committing changes: if you have NodeJS on your machine you can use the command `npm run lint` (after installing dependencies with `npm install`)
Alternatively you can run it in a docker container, le me find the command
`docker-compose run --rm bookbrainz-site npm run lint` I believe
Shubh
How should i fix that inconsistent return check ?
monkey
Which PR is that?
Shubh
first one that entity delete twice bug
monkey
Right. I think for all those route you can use `next(new ConflictError(…` instead of `return next(new ConflictError(…`
It's complaining because in one condition you `return` something, but in other conditions nothing is returned. But in this case we don't need to return explicitly, so we can just use next(…)
Shubh
lemme try without return then
umm..
if i dont return it then wont the other things run as well like displayEntity ..
monkey
Ah yes, correct.
CatQuest
oh man, here both Shubh and monkey are the same colour, it makes it difficukt to read conversation :D
Shubh
what will happen if i return that displayEntity thingy?
CatQuest
difficult*
Shubh
im purple
monkey
I guess you can put the rest of the processing inside an `else { }` block
I don't see a fix for 429 so probably still an issue
Shubh
but I don't see any related warning during build process
monkey
570 looks fixed to me
Ah, right, then if you don't see that warning anyomre consider it fixed
Shubh
are those instructions related to setting up docker fixed ?
monkey
If you mean the issues you encountered when you were setting up, not yet, something I'm working on now
Shubh
if you are busy then i can also fix those thingy , if you don't mind ..
monkey
These setup issues I'd like to do myself, there's something pretty crucial gone wrong.
But other than that feel free to take any ticket you are interested in
Shubh
Hmm on it !
Hello ..
monkey
Don't hesitate to write your questions without waiting for me to be here Shubh, I receive alerts and read the logs
Shubh
i just wanted to ask how page routing works in BB ?
monkey
I might need a more precise question, that one is a bit broad :p We use ExpressJS as a framework to handle routing, if that answers part of the question
i put in a user css to fix it so i'll try and disable this and see if i get it again
monkey
I wonder if it was just a superposition of the dropdown and the text box underneath
CatQuest
it no longer looks like that because the annotation box is further dows. but the lowest line in the drop down in the "type" dropdown *is* thinner and less visible than eg "language"