#bookbrainz

/

      • MRiddickW has quit
      • Shubh joined the channel
      • monkey
        CatQuest: The section *is* there, even if there are search results! :) Look at the bottom of the page.
      • > oh. also "series" should be added
      • Yep, I realized that was missing when I read the ticket again, will fix !
      • yvanzo_ joined the channel
      • KassOtsimine_ joined the channel
      • KassOtsimine has quit
      • KassOtsimine_ is now known as KassOtsimine
      • yvanzo has quit
      • yvanzo_ is now known as yvanzo
      • Shubh
        monkey: Hey!, finally userscript working with firefox ( https-> http ), also i added all the necessary options (identifiers included) to prefill edition entity.
      • when you get time please have a look and let me know if it fine with you.
      • monkey
        Ace !
      • riksucks has quit
      • amoggh[m] has quit
      • amoggh[m] joined the channel
      • amoggh[m] has quit
      • amoggh[m] joined the channel
      • amoggh[m] has quit
      • amoggh[m] joined the channel
      • amoggh[m] has quit
      • riksucks joined the channel
      • riksucks has quit
      • CatQuest
        monkey: ooh! it wasn't there yesterday! must have been a chace issue or something great to see it
      • and ace on the series thing!
      • monkey
        BenOckmore: Found one last thing to amend after the BS4 migration, and found a simple solution for the wrapping navbar menu items. That's really all I can see (apart from the nicer green color of the validation labels, let's keep that), I think that migration can be considered finished after this !
      • I'm deploying that to test.BB
      • BenOckmore
        Oh what's going on with the navbar items?
      • monkey
        A picture being worth 1000 words: https://github.com/metabrainz/bookbrainz-site/p...
      • It was also terrible pre-BS4, to be fair.
      • Just a different flavor of terrible :p
      • BenOckmore
        I wonder if we should change the navbar breakpoint so it collapses a little wider
      • monkey
        Pre-BS4 is worse, the whole navbar just wraps: https://usercontent.irccloud-cdn.com/file/ufoOL...
      • BenOckmore
        Oh yeah wow!
      • monkey
        I'd suggest trying it out on test once I've deployed, it works quite well as-is without the need to change the breakpoint
      • BenOckmore
        Weird about the date inputs, that's definitely an issue I fixed at some point, maybe I lost the CSS when I went through and tidied up the style.scss commits
      • monkey
        An easy one to miss, as it looks quite neat when it takes the whole width , looking like the fields above/below.
      • OK, deployed to test.bb
      • BenOckmore
        I was going to mention - I've started going through replacing CustomInput. It was a component added to make the transition from an older version of react-bootstrap easier - there used to be an Input component. In most cases, the replacement is just a Form.Group, Form.Label and Form.Control, which makes it easier to see what's going on
      • monkey
        Ah nice ! Yes it seemed like a lot of wrapper for not a lot of use
      • Although there is so much going on in there that it's hard to tell…
      • CatQuest
        honestly i prefer wrappnavbar over horizontal scrolling ffiw
      • is thre any way to create a "paste a date here and it will autofill the date bits" incorporated into the date format thing?
      • like that mb userscript
      • it could be simple and accept only YYYY-MM-DD or DD-MM-YYYY formats at first
      • i can priveide a lsit of formats
      • provide
      • YYYY/MM/DD DD/MM/YYYY DD $month YYYY
      • monkey
        Ticket please :)
      • CatQuest
        and that script was pretty brilliant for when it was not clear if it was DD-YY-MM or DD-MM-YY or YY-DD-MM or YY-MM-DD it would simply ask: this is unclear please chose one"
      • oh hmm
      • I thoguht i did add one
      • monkey
        Also, do you see a horizontal scroll with the navbar? Shouldn't happen
      • CatQuest
        i dunno. i cant really see what was worng with the new image in that first link
      • so i made an assumption
      • monkey
        OK, then rest assured, no scrolling.
      • CatQuest
        bra
      • Shubh has quit
      • BrainzBot
        BB-641: Date Format Parser
      • CatQuest
        tadaa
      • sorry it took hours