#bookbrainz

Leftmost: As pointed out this is common issue with identifier editor and regex detection in general, i believe rather than hacking around the regex detection, we should have simple "turn off" checkbox to disable this behavior.

Shubh, there are some issues with that, yeah, but I think they're exacerbated by taking automatic action when we detect an ISBN and we should probably be more liberal in deciding when two ISBNs are equal. (If we have 978-0-15-603521-7, we shouldn't add 97806035217.) And I think rather than putting the responsibility on users to disable the behavior, we should probably be checking if something is a valid ISBN rather than

relying on regex when ISBNs aren't a regular language.

I think we can verify the last digit of ISBN using checksum algorithm when detecting for identifier type

but that doesn't solve the issue for other types we might have in future...

monkey: i'm facing some issues with adding bookbrainz orm from github branch, any idea on how prabal did it?

What are the issues?

I know I've hit this issue before for example: https://github.com/npm/cli/issues/2610

But generally, if you have both repos locally, you can run `npm link` in the ORM and then `npm link bookbrainz-data` in bookbrainz-site to use your local version

(note that if you install nay package after that you'll need to re-link)

Shubh are you still facing the issue? I always forget to install the dependencies before linking. 👀