#bookbrainz

/

      • Shubh joined the channel
      • Shubh
        glad it worked, but i suppose language options are not sorted anymore?, need to fix that
      • MRiddickW joined the channel
      • Shubh has quit
      • Shubh joined the channel
      • CatQuest
        no, the laguage options are as expected
      • i think?
      • monkey
        I did see them sorted alphabetically rather than by popularity as we want
      • MRiddickW has quit
      • CatQuest
        what i mean is that i typed "norw" and "norwegian" was sorted above the others
      • one thing is: I've notied a little bit of lag when "x"'ing the country (ie if choosing the wrong one so wanting to chose another)
      • oh yes i see it's alphaetical again tho. lol some rare languages up top for sure
      • never head of !O!ung
      • ha.. that's becasue it's called https://en.wikipedia.org/wiki/Sekele_language in english
      • ...
      • "" Two of the Angolan varieties have gone by the outdated term ǃʼOǃKung (or ǃʼO ǃuŋ
      • o nthe flip side if anyone actually searches for "sekele" they get nothing
      • not that i'm against having two differnt types of seke or vasekela Bushman i nour language options...
      • you know what I mean here
      • i think we really, really for everyone involved need to limit this to a list of them ost commonly written languages. say maybe the top 200, 300 languages. and thne we can re-implement languages on demand
      • this is what musicbrainz does with the language dropdown on releases
      • i don't know how many languages there, but as a startingpoint we shoudl copy thre's. (s wel las include braille and sign languages)
      • but it in our documentation, and directly onto the page itself : if langguage you need is not in the list, please ask for it in [link] (so link to jira or a wikipage explaining how to do it)
      • BenOckmore has quit
      • Shubh
        monkey: for routes, i'm thinking of having new revisions for each entity ( edition, work...), and new revisions for adding relationship on them, does this sound sane to you?
      • CatQuest
        this sounds more liek what mb does ? if it makes things more asy to see i definitly like it
      • monkey
        I think that's a good idea Shubh. Once we have the ability to revert revisions, we will be happy to have a bit more granularity
      • For example we could revert adding the relationships without reverting the revision that creates an entity.
      • Yes, that all makes good sense
      • MRiddickW joined the channel
      • Shubh
        monkey: is it bad idea to create multiple entities asynchronously (parallelly)?, somehow i'm getting same bbid for each of them, any idea why that can be?
      • monkey
        I'm surprised the BBID would be exactly the same. Did you confirm that by querying the database directly?
      • Agreed CatQuest this should come sooner than later
      • Shubh
        monkey: `new Entity()` producing model with the same bbid thus giving unique key error
      • monkey
        Huh. Well that's new to me
      • Can I peek at the code you use to instanciate the Entity models?
      • Shubh
      • monkey
        Nothing that I can see that seems wrong.
      • Perhaps you can try creating the `bookshelf.transaction` in the `Object.keys(body).map` instead, so that each entity is treated in a separate tranaction?
      • Shubh
        still same issue, although it does work fine synchronously https://usercontent.irccloud-cdn.com/file/KAyYG...
      • but doing that way drastically increases the response time for large number of entities
      • monkey
        I'm stumped. I think it would be best to make a minimal reproducible test case that could be used to create an issue with bookshelfjs or with knex
      • It will also clarify if the issue is coming with our code or deifinitely from the ORM or database side
      • I'm guessing the ORM is getting its wires crossed somehow
      • Or that we're using it wrong but neither of us can tell how or why :)
      • Shubh
        also one more thing, `save()` didn't throw any error for the second entity but later it throw when commiting the transaction, does that mean constraints aren't check on `save()`?
      • monkey
        I'm not certain. I do notice we don't explicitly catch any errors for that async call though
      • Maybe if you wrap it in a try-catch block you'll be able to catch the error early.
      • One last thing: you can set `"debug": true,` in the database section of your config.json to see DB debug
      • Shubh
        Ah it worked, i realize it tried to access the entity that hasn't been even created
      • MRiddickW has quit
      • monkey
        Ah great, cause that was a riddle we didn't want to have to solve :D
      • Shubh
        still not sure why the single transaction thing didn't work, i find it more elegant than creating new transaction for each entity :/
      • monkey: weird stuff but in single transaction if i move up the `new Revision(...)` code few lines, it generates unique bbid for each entity though still giving the unique constraint error https://usercontent.irccloud-cdn.com/file/geemN...
      • Shubh has quit
      • ShivamAwasthi joined the channel
      • ShivamAwasthi
        Hey monkey, I've been thinking and I feel that I really want to go ahead with the project if allowed. I also think that it might not be a good idea to get started on it right away, as you will be busy with the other two projects and me just bustling in would defeat the purpose. Do you think it would be a good idea if I start working on it once
      • you're through with the meaty part of these two projects(I'm assuming somewhere around the end of July) or can you suggest some other timeline or any other suggestion with respect to how I can approach this
      • ShivamAwasthi has quit
      • Shubh joined the channel