#bookbrainz

/

      • ZaphodBeeblebrox is now known as CatQuest
      • Shubh
        monkey: do you think modal is fine for confirming created entities?
      • monkey
        Shubh: You'll need to be more specific. Where and when would we show the modal?
      • CatQuest: I did see the message thanks. Understood about the fake links, I'll see if it can be improved
      • CatQuest
        awesome!
      • monkey
        The extra testing you did (language dropdown) was after I deployed another PR to test.BB, so not sure it's relevant but I'll check
      • Shubh
        monkey: my bad, i meant when user submit the unified form, we should show some kind of dialog to confirm the changes that will made by submission. so a modal sounds good for this?
      • CatQuest
        hmm. i tested it on the same page so i dunno
      • monkey
        I think this would be best done as a final step in the form (a separate tab) which would also contain the edit note input and the submit button (the whole SubmissionSection component)
      • That was for Shubh
      • CatQuest
        ok!
      • monkey
        CatQuest: Thanks, I'l double check
      • CatQuest
        if you need mee talk to kass since i'm going ot the library ˆ__^
      • monkey
        Have fun !
      • Shubh
        monkey: so moving whole submission section to a separate tab?
      • monkey
        I think that's the best way to go IMO
      • A tab for recap of entities + edit note + submit button
      • Shubh
        Hmm, sounds good to me
      • monkey
        👍