#bookbrainz

/

      • G0maa joined the channel
      • G0maa has quit
      • stoichy joined the channel
      • stoichy has quit
      • stoichy joined the channel
      • stoichy30 joined the channel
      • stoichy30 has quit
      • stoichy
        Hello! First time talking here. Just solved BB-583 issue. Can someone specify if the the button dimensions are right? If not please specify preferences. Also solved issue BB-716 regarding the developer docs.
      • BrainzBot
        BB-583: conflicting visual hierarchy on search section of landing page https://tickets.metabrainz.org/browse/BB-583
      • BB-716: Fix for command in Testing section in BookBrainz Developer Docs https://tickets.metabrainz.org/browse/BB-716
      • monkey
        Hello stoichy, I'll be able to review your PR sometime this week. For info, there are two things you can do that will help others:
      • 1. assign a ticket you want to work on to yourself. that helps prevent multiple people working on the same issue
      • 2. Your PR title should start with the ticket number as follows: "BB-XXX: " as described in our PR guidelines here https://github.com/metabrainz/guidelines/blob/m...
      • ShivamAwasthi joined the channel
      • ShivamAwasthi
        hi stoichy
      • monkey
        ShivamAwasthi: Hi! Regarding BB-709 I think we want the authors to be shown the same way across the website (especially with regards to a component that is used in multiple places)
      • BrainzBot
        BB-709: Add “Author” column in publisher editions listing https://tickets.metabrainz.org/browse/BB-709
      • ShivamAwasthi
        So do you think we should reconstruct the author-credits using the AuthorCreditDisplay component, or should we list the authors being credited(without mentioning their aliases, etc) just like we do in case of the WorkTable?
      • monkey
        I fit's for an edition or edition group, we should use author credits (and the AuthorCreditsDisplay component). If it's a work with relationships to author(s) then we should display them like the work table
      • Author credits and "author wrote work" relationships are not the same :)
      • It makes sense to display full reconstituted author credits for Editions
      • (& EGs)
      • ShivamAwasthi95 joined the channel
      • ShivamAwasthi95 has quit
      • ShivamAwasthi has quit
      • ShivamAwasthi50 joined the channel
      • ShivamAwasthi50 has quit
      • ShivamAwasthi joined the channel
      • ShivamAwasthi
        got it monkey, thanks!
      • monkey
        👍
      • ShivamAwasthi has quit
      • kellnerd joined the channel
      • stoichy has quit
      • Legend11 joined the channel
      • Legend11 is now known as mrigeshThakur
      • Legend11 joined the channel
      • Legend11 is now known as mrigeshThakur11
      • mrigeshThakur has quit
      • mrigeshThakur11 has quit
      • Legend11 joined the channel
      • Legend11 is now known as mrigeshThakur
      • Aditi joined the channel
      • mrigeshThakur
        Hi guys could anyone help me with Live Reloading , what does Mount the src folder to the bookbrainz-site service mentioned in the doc means ??
      • monkey
        mrigeshThakur: Check out this PR about to be merged, there are better instructions for how to use docker-compose files for overrides: https://github.com/metabrainz/bookbrainz-dev-do...
      • Another way, hopefully simpler, to override the commands run in docker
      • Sorry, more precise link mrigeshThakur : https://github.com/metabrainz/bookbrainz-dev-do...
      • mrigeshThakur
        Thank you monkeyO:3
      • monkey I had another wild idea about a feature that could be added to bb , a guide bot that would help users to get started ( basically do job of these docs https://bookbrainz-user-guide.readthedocs.io/en...) and also help to create tickets , like if a user finds a bug he/she could report it and it automatically becomes a ticket .( It could
      • also be used for reporting spam content if found any )
      • monkey
        Help wizard style ! Not a bad idea, although it might double up a bit on the simplified book editor from last year's GSOC that already simplifies the process. What would be its features, other than helping report bugs?
      • Aditi has quit
      • mrigeshThakur
        Yup initially it would provide a guide tour of bb, like how the stuff works and how to contribute , then for particular pages it could be used as an assistant , like for example you are adding a new author or a book ( so sometimes we need to look up in web for certain info , like I added a new author had to google some details regarding him , about
      • this place of birth and dob , so I had to switch tabs ( and it ended up me having going to netflix '=D ), so it would be very subtle , but would add on to the user experience , next it would also help users to check if a author or book already exits ( like before adding a book or author as mentioned in docs we need to check for  duplication ) so
      • it would help with that too.
      • These were a few features I had in my mind , would tinker more about it , like what other features it could have
      • monkey
        I don't understand the part about switching tabs for searching for info. What would the guide thing do?
      • All in all I'm not convinced it would be a lot easier than improving and adding the right help text in the right place in the entity forms
      • Leftmost has quit
      • Leftmost joined the channel
      • mrigeshThakur
        Oh sorry by tabs I meant chrome tabs , It was that I was adding an Indian author (Ankur Warikoo) , so firstly I had to search if that author was previously there( so the wizard could help with that ) , then while adding info about him , https://pasteboard.co/QE5OZeyUXuIx.png  I had to look up his place of birth and dob , and I guide would be like
      • a interactive walkthrough like here https://whatfix.com/interactive-walkthrough/ ( please only see the examples pictures and video the rest text is out-of context)
      • Aditi joined the channel
      • Aditi has quit
      • G0maa joined the channel
      • Aditi joined the channel
      • monkey
        I understand what the wizard would look like, what I don't understand is how exactly it would help with searching for the extra information (dob, etc.)As for avoiding duplicates, we have this system in place; what would the wizard do differently? How do you see it working? https://usercontent.irccloud-cdn.com/file/oiYne...
      • ShivamAwasthi joined the channel
      • mrigeshThakur has quit
      • aadil25 joined the channel
      • aadil2522 joined the channel
      • aadil2522 has quit
      • aadil25 has quit
      • Aditi has quit
      • Legend11 joined the channel
      • Legend11 is now known as mrigeshThakur
      • mrigeshThakur
        it would just provide a searching functionality , that at the end would give the corresponding google results , just a simple feature , so that someone does not need to change their chrome tabs and search those things ( a little snub at user experience ) '=D ,
      • Also like if someone wants to know about a particular thing about a book or a author , they can ask questions like " What books did this author wrote " and then get the results ...
      • again instead of searching for the whole thing ( it would add to the overall user experience)
      • ShivamAwasthi has quit
      • ShivamAwasthi joined the channel
      • ShivamAwasthi
      • mrigeshThakur
        Hi ShivamAwasthi how you have been
      • ShivamAwasthi
        I'm doing great mrigeshThakur! What about you?
      • monkey
        ShivamAwasthi: That doesn't look very close to the mockup #8 in MBS-12866: https://tickets.metabrainz.org/secure/attachmen...
      • BrainzBot
        MBS-12866: Make grouping relationship types more visible in dropdowns
      • monkey
        Ah, sorry, just seeing the comment now
      • I would probably make it a bit smaller, and give it a gray color (like the `text-muted` css class maybe)
      • ShivamAwasthi
        do you think we can improve the icon? Perhaps thin it a bit
      • I have grayed it in the image shared above(not in the ticket tracker comment)
      • monkey
        I'm looking at https://pasteboard.co/XDZEqpLeDlFr.png , it looks like the same black as the rest of the text
      • Or as the other icons I should say
      • I think there should aslo be a bit more space between the arrows and the rest, like in the mockup
      • ShivamAwasthi
        Ok so initially the icon was pitch black. I changed it to the same color as the other icons. Let me try to lighten it a bit more
      • monkey
        Ahh, I see
      • Yes, I'd go for a similar tone as the mockup, a light grey
      • Right, I see the pitch black in the ticket comment, that was pretty wild :)
      • mrigeshThakur has quit
      • ShivamAwasthi
      • ignore that one
      • Made one more change https://pasteboard.co/k53Q42Z5Y3xs.png I have removed the indentation for relationships with depth 1 because the icon itself kind of provides an indentation
      • kellnerd
        That's what I'd have suggested too.
      • But to be honest, I'm not really convinced by the arrow icon itself, no matter how light it is...
      • ShivamAwasthi
        I see. Do you have any suggestion/alternative in mind?
      • Perhaps something thinner(akin to the square corner in the original mockup) would look better?
      • kellnerd
        It draws too much attention, IMO, I would expect something more subtle as in mockup 7 or 8.
      • Thinner, definitely.
      • ShivamAwasthi
        Maybe aerozol can help
      • kellnerd
        We can probably ask him in #metabrainz after today's meeting.
      • ShivamAwasthi
        hmm sure
      • ShivamAwasthi has quit
      • kellnerd
        My personal favourite would be a combination of 7 and 8, i.e. the arrows/angles from 8 but with the continuous vertical line from 7. That would require some precise tiling, but it should be possible.
      • (The menu would have to be gapless)
      • ShivamAwasthi joined the channel
      • Legend11 joined the channel
      • Legend11 is now known as mrigeshThakur
      • ShivamAwasthi
        I think something like this https://fontawesome.com/icons/corner?s=thin&... if flipped/rotated will be great for our use case
      • ShivamAwasthi has quit
      • G0maa has quit
      • monkey
        I agree
      • Chaitanya joined the channel
      • Aditi joined the channel
      • Chaitanya has quit
      • mrigeshThakur
        monkey thoughts on that wizard '=D
      • stoichy joined the channel
      • Aditi has quit
      • Aditi joined the channel
      • Aditi has quit
      • mrigeshThakur has quit
      • ShivamAwasthi joined the channel
      • ShivamAwasthi has quit
      • stoichy has left the channel
      • stoichy joined the channel
      • stoichy has left the channel
      • stoichy joined the channel
      • stoichy has left the channel
      • stoichy joined the channel
      • stoichy
        Hello! Just noticed that when running the command for the test suite I get a warning saying that my typescript version is too new(4.5.2 and i need < 4.5.0). After the warning I only get linter errors and no other test is being run. Is that what should happen and can I skip it so that the other tests can run?
      • Aditi joined the channel
      • Aditi has quit
      • kellnerd
        stoichy: If the linter is blocking the test suite from being run, I would either fix the issues reported by the linter or run the test command without the linter.
      • i.e. chnaging the test command in package.json from "npm run lint-errors && cross-env NODE_ENV=test mocha -r jsdom-global/register" to "cross-env NODE_ENV=test mocha -r jsdom-global/register"
      • *changing
      • Alternatively you can also run the modified command with npx, so you don't have to alter package.json
      • `npx cross-env NODE_ENV=test mocha -r jsdom-global/register`
      • I haven't run the full test suite of bookbrainz-site myself, yet, so I hope that works for you.I'm off for today, it's getting late here ;)
      • kellnerd has quit
      • stoichy has left the channel