#bookbrainz

/

      • anonn has quit
      • Shelly joined the channel
      • Shelly has quit
      • Shelly joined the channel
      • Shelly has quit
      • maddy007 joined the channel
      • maddy007[m]
        Hello monkey ?
      • maddy007 has quit
      • anonn joined the channel
      • anonn has quit
      • ZaphodBeeblebrox is now known as CatQuest
      • Meziyum joined the channel
      • Meziyum
        Hello. I was going through the bookbrainz database schema, specially the import related tables which will be used in the future for importing large databases.
      • I was able to identify a relationship between import table which is just like the entity table and author_import_header which acts an intermediatory between the import and author_data.
      • The question which I had was suppose if a large amount of books are imported into the database then how is an editor supposed to edit one of those imported book if there was some kind of error. Since i dont see the author_import_header storing the revision but directly the author_data.Wont it be better if like the normal entities, the import entity
      • headers also have revision which are then related to their author_data?
      • kellnerd joined the channel
      • iamgroot joined the channel
      • iamgroot has quit
      • kellnerd has quit
      • kellnerd joined the channel
      • iamgroot joined the channel
      • iamgroot has quit
      • Meziyum has quit
      • Meziyum joined the channel
      • Meziyum has quit
      • monkey
        Meziyum: Hi! I think having revision tracking for the temporary import entities would be overkill. The goal is for users to validate/modify the information before making them into regular entities (or merging it into an existing entity), at which point they enter the normal revision system.
      • Meziyum joined the channel
      • Meziyum has quit
      • Hello maddy007[m] ! Don't hesitate to post your questions in advance, so that I can respond when I am online. You can then check the chat logs and search for your name, and hopefully have an answer waiting for you :)
      • What can i help you with?
      • kellnerd
        Oof, just spent two hours to understand what I did wrong during refactoring: https://github.com/metabrainz/bookbrainz-site/p...
      • I thought there was a timing issue but a race condition seems more likely now: Two different places are trying to call `redisClient.connect()` when they are importing the same shared module, which is leading to a timeout in the end...
      • Actually I could squash these commits, but it's also interesting to see how *not* to do this ;)