HI, I was looking into a [ticket](https://tickets.metabrainz.org/projects/L… is there any method to retrieve the `artist_name` from `artist_mbid` for a single artist or will have to use `load_artists_from_mbids_with_redirects`
2025-04-07 09756, 2025
lucifer[m]
holycow23: ah, i already have a fix for it. had forgotten to open a PR, will do it today.
2025-04-07 09719, 2025
holycow23[m]
<lucifer[m]> "holycow23: ah, i already have..." <- Are you done with the ticket, I had already started working on it actually
2025-04-07 09707, 2025
fettuccinae[m] joined the channel
2025-04-07 09707, 2025
fettuccinae[m]
lucifer:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/PMEttHGdUEprBVRtbnCBDPlq>)
2025-04-07 09715, 2025
lucifer[m]
fettuccinae[m]: > <@fettuccinae:matrix.org> lucifer:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/rOwxmGcMDuoeAgNaabGVvxPh>)
2025-04-07 09717, 2025
fettuccinae[m]
<lucifer[m]> "> <@fettuccinae:matrix.org..." <- can you please suggest any further changes i should make.
2025-04-07 09725, 2025
lucifer[m]
I don't have any further suggestions, I think you can submit it to the GSoC portal
2025-04-07 09749, 2025
suvid[m]
Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/IoiMyayWCFbdpmnAZJdxrXLK>)
I think it was supposed to have some other changes as well right?
2025-04-07 09723, 2025
monkey[m] joined the channel
2025-04-07 09723, 2025
monkey[m]
I've decided to leave it for another PR as I still need to work on the fetching. So I merged this PR as a temporary fix with no loss of functionality, and will work on improving with proper event loading. I anticipate some small complications that might take me a bit of time to finish up correctly, but wanted to push this fix out.
2025-04-07 09747, 2025
suvid[m]
ohh I see
2025-04-07 09721, 2025
suvid[m]
monkey: I didnt reply to your message asking me to review as I responded on chat here 😅
2025-04-07 09721, 2025
suvid[m]
Also, I couldnt find any bug or something
2025-04-07 09721, 2025
suvid[m]
is that fine right?
2025-04-07 09731, 2025
suvid[m]
* monkey: Sorry, I didnt
2025-04-07 09756, 2025
monkey[m]
For your curiosity, it is the front-end fetching aspect which isn't exactly clear to me. Since showing the event under the thank you is done using a filtering method on already-loaded events, it's not clear how I am going to programatically trigger fetching of the missing event.
2025-04-07 09738, 2025
suvid[m]
monkey[m]: I think what we can do is
2025-04-07 09738, 2025
suvid[m]
when we are fetching already-loaded events, we can fetch the thank you events using the id as well
2025-04-07 09749, 2025
monkey[m]
If you want, you can create a ticket for this missing improvement, now that I've determined it's not trivial to solve
2025-04-07 09750, 2025
suvid[m]
this way, we won't have to change our existing implementation
2025-04-07 09702, 2025
suvid[m]
s/thank/thanked/, s/you//
2025-04-07 09745, 2025
suvid[m]
* I think what we can do is
2025-04-07 09745, 2025
suvid[m]
when we are fetching already-loaded events, we can fetch the thanked events using their IDs as well
2025-04-07 09705, 2025
monkey[m]
suvid[m]: Not clear how to do that, since we currently load by pages. Maybe some post-processing step after loading a page of events than ensures all required events are somewhere in the results. But I have to investigate how to do that properly.
2025-04-07 09705, 2025
suvid[m]
yes so when we load events of a page, we see all the thank you events and load the thanked events as well from their IDs
2025-04-07 09719, 2025
suvid[m]
idk if its possible tho as I haven't looked at that code propoerly
2025-04-07 09723, 2025
suvid[m]
s/propoerly/properly/
2025-04-07 09753, 2025
monkey[m]
Right, that's what I'm saying, it's not clear where loading the extra events is going to happen in the lifecylc eof the react component
2025-04-07 09709, 2025
suvid[m]
and this process gets repeated when we click load more events right?
2025-04-07 09709, 2025
suvid[m]
as it loads events of the next page
2025-04-07 09715, 2025
suvid[m]
monkey[m]: ohh ok
2025-04-07 09719, 2025
suvid[m]
yea will have to figure that out
2025-04-07 09745, 2025
suvid[m]
i think i'll look into it in a few days
2025-04-07 09704, 2025
monkey[m]
Yes, this needs to happen again if we load more events (check for thank-you events, check if original event is in cached results, if not load the event using ID)
2025-04-07 09705, 2025
monkey[m]
The complicated part is combining fetching a single event by ID and fetching events by page+count.
2025-04-07 09757, 2025
suvid[m]
but I think you mentioned that fetching a single event by ID is trivial and you had implemented it
2025-04-07 09704, 2025
suvid[m]
so ig that part is done right?
2025-04-07 09721, 2025
monkey[m]
The API side of it is trivial, and I have it implemented locally
2025-04-07 09725, 2025
monkey[m]
Yep
2025-04-07 09732, 2025
suvid[m]
yea
2025-04-07 09759, 2025
monkey[m]
We already had method for fetching a single event by its ID, so a new API endpoint to wrap that up was easy to implement.
2025-04-07 09715, 2025
suvid[m]
ohh 👍️
2025-04-07 09732, 2025
suvid[m]
ok so i'll look into it asap
2025-04-07 09732, 2025
suvid[m]
sounds like an interesting problem
2025-04-07 09732, 2025
monkey[m]
and by 'fetching', I meant getting it from the database
