holycow23: yeah i forgot to open a pr the other day but let me just test it quickly on test.lb and open a PR. there's two things to do here actually: group artists based on artist mbid instead of the artist name. this would sort of fix the the issue of splitting into multiple artists. however, as then the question would be which artist name to use in case of conflicts. so the right way would be to query the artist metadata cache in
2025-04-09 09935, 2025
lucifer[m]
LB for those artists.
2025-04-09 09925, 2025
lucifer[m]
there is also another issue here that distinct artists can have the same name, therefore the grouping should be done on artist mbid if available.
also ideally this stat should be generated on the spark with the final data stored in LB couchdb, to avoid making these queries everytime at runtime.
2025-04-09 09913, 2025
TheCivvie joined the channel
2025-04-09 09922, 2025
TheCivvie has quit
2025-04-09 09948, 2025
TheCivvie joined the channel
2025-04-09 09954, 2025
holycow23[m]
<lucifer[m]> "also ideally this stat should be..." <- If you want I will look into it once the dump for Spark is done for local testing
2025-04-09 09927, 2025
holycow23[m]
<lucifer[m]> "holycow23: yeah i forgot to open..." <- Yeah that was my approach too but got stuck at fetching the `artist-name` from the `artist-mbid`.
2025-04-09 09929, 2025
fettuccinae[m] has quit
2025-04-09 09909, 2025
mshahnawaz1[m] has quit
2025-04-09 09912, 2025
vardhan joined the channel
2025-04-09 09926, 2025
shisma[m] joined the channel
2025-04-09 09926, 2025
shisma[m]
Sometimes i would like Recommend Song A to everyone who likes Song B
2025-04-09 09931, 2025
shisma[m]
* Sometimes i would like to Recommend Song A to everyone who likes Song B
2025-04-09 09922, 2025
shisma[m]
Could be more abstract like recommend Artist A to everyone who likes Release group B and so on
2025-04-09 09905, 2025
monkey[m]
That sounds pretty cool, not sure how feasible it is with our current setup, but it would be worth opening a ticket for it in Jira if you are so inclined
2025-04-09 09911, 2025
julian45[m] joined the channel
2025-04-09 09912, 2025
julian45[m]
agreed that it sounds pretty cool - thinking about the implementation side, i think it'd be prudent to limit use of that feature at least a little bit to reduce spam/DoS risks
2025-04-09 09907, 2025
lucifer[m]
holycow23: i've opened https://github.com/metabrainz/listenbrainz-server… with a fix, its currently deployed on test.listenbrainz.org for testing. there is one more related change that i would like to make but haven't yet as i am not much familiar with nivo charts, so if you would like to work on that let me know.
2025-04-09 09923, 2025
lucifer[m] uploaded an image: (11KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/UWKdaCjzWHKsyUETZtwmaVSt/image.png >
2025-04-09 09941, 2025
lucifer[m]
adding links on the x-axis ticks, . if an artist mbid is available for that artist.
2025-04-09 09950, 2025
lucifer[m]
s/.//
2025-04-09 09955, 2025
TheCivvie has quit
2025-04-09 09946, 2025
monkey[m]
Also while in there, I think we might want to remove the artist name in the tooltips, considering it only repeats the same info that is already below. For long album titles I think it'll make a difference
