I have to say the idea for maintaining a design system is really clever
2021-09-01 24442, 2021
akshaaatt[m]
Morning everyone!
2021-09-01 24458, 2021
akshaaatt[m]
I've been planning how the mb server will be revamped. I was initially planning to slowly make the changes to the mb server we have and make progress. However, I have realised that would take a while since we have to make the web interface mobile first this time.
2021-09-01 24405, 2021
akshaaatt[m]
I decided to make it on the go since my major focus right now is towards getting the new design live.
2021-09-01 24413, 2021
lucifer
s/mobile first/mobile friendly :)
2021-09-01 24437, 2021
akshaaatt[m]
In short, I started a new react project to make it convenient for me to firstly get my thoughts straight and even connect with the community
2021-09-01 24443, 2021
akshaaatt[m]
Hi lucifer !
2021-09-01 24450, 2021
lucifer
hi!
2021-09-01 24407, 2021
akshaaatt[m]
So yeah, I have hosted the app at musicbrainz-web.web.app
2021-09-01 24417, 2021
akshaaatt[m]
Right now, only the header and the footer have been added
2021-09-01 24450, 2021
akshaaatt[m]
I am still exploring stuff and looking to make the changes here firstly, get everyone's feedback, and then quickly push these designs to our main project
2021-09-01 24440, 2021
akshaaatt[m]
Plus we need to restart the docker everytime we need to see the changes on the mb server. Overall I would say that from development point of view, mb server is way better but from a design perspective, where we need to checkout every detail precisely, directly jumping to the mb server for that makes less sense
2021-09-01 24452, 2021
akshaaatt[m]
Hopefully, in some time we can have the app live on the link complete (the home page) I shared and over the course of time, we can finalize that first.
2021-09-01 24455, 2021
akshaaatt[m]
If anyone has any suggestions regarding this thinking, I would be happy to communicate. Have a great day ahead!
btw, bitmap said you can enable watch mode of webpack, though I haven't tried it yet
2021-09-01 24408, 2021
yyoung[m]
Aren't we going to match the theme of other *Brainz projects?
2021-09-01 24410, 2021
akshaaatt[m]
Even with that, how do you test an app that you have hosted on your laptop, to your mobile device?
2021-09-01 24441, 2021
lucifer
you can resize the browser screen size with dev tools.
2021-09-01 24402, 2021
yyoung[m]
Yes, and you can access it from your mobile under local network
2021-09-01 24409, 2021
akshaaatt[m]
yyoung I am here to work on all the projects. MB is just the beginning. So if we all love one design, we can adapt that to others
2021-09-01 24421, 2021
yyoung[m]
Sure, why not ;)
2021-09-01 24441, 2021
akshaaatt[m]
lucifer as they say, that feel doesn't come on resizing that way :)
2021-09-01 24409, 2021
akshaaatt[m]
yyoung hmm I could try that
2021-09-01 24423, 2021
akshaaatt[m]
But how would I share the project to you on the go yyoung for example?
2021-09-01 24434, 2021
akshaaatt[m]
Like I make some changes and want some design related feedback for which, getting on beta would take a while
2021-09-01 24448, 2021
akshaaatt[m]
This way, I could just host it and share the link to everyone
2021-09-01 24401, 2021
yyoung[m]
I think the devtools works nice, it let you try different sizes of devices, unless you want to test compatibility
2021-09-01 24412, 2021
lucifer
sure, whatever works is fine.
2021-09-01 24419, 2021
yyoung[m]
Right, in that case a static web host or SaaS would be better
2021-09-01 24414, 2021
yyoung[m]
e.g. Vercel, Cloudflare pages, Firebase (I saw you've already used it)
2021-09-01 24431, 2021
akshaaatt[m]
Yup
2021-09-01 24444, 2021
lucifer
for mockup work, i think this is fine. when you start integrating these changes to MB codebase, you can setup a MB server on bono and then everyone can view it.
2021-09-01 24405, 2021
akshaaatt[m]
Makes sense
2021-09-01 24407, 2021
yyoung[m]
To me the biggest problem of the demo is that the header is too big
2021-09-01 24416, 2021
akshaaatt[m]
😂😂😂
2021-09-01 24425, 2021
yyoung[m]
s/biggest/most obvious
2021-09-01 24438, 2021
reosarevok
I mean, it is :) Header and footer are huge here
2021-09-01 24439, 2021
akshaaatt[m]
Cool I'll look into it
2021-09-01 24420, 2021
reosarevok
I would expect our header and footer to remain similar to what they are or at most to what other MeB projects currently have - and just change if needed once the screen becomes smaller
2021-09-01 24426, 2021
yyoung[m]
y'know, us laptop users have a limited space, that header takes up 1/4 of viewport XD
the old code too passes __tablename__ to this method but one of the checks removes and prevents deferred being called on it
2021-09-01 24447, 2021
reosarevok
Which of the checks?
2021-09-01 24427, 2021
reosarevok
Also, our current code doesn't actually actively load the primary keys, but my understanding is that those get loaded whatever happens? (got reminded seeing this)
2021-09-01 24440, 2021
lucifer
i'll need to separate each of the conditions into different statement to find that out :)
2021-09-01 24413, 2021
lucifer
yes, right.
2021-09-01 24414, 2021
reosarevok
Ok. I am confused because none of these seems to match "tablename"
2021-09-01 24425, 2021
reosarevok
I mean, maybe key is in columns
2021-09-01 24427, 2021
lucifer
i'll verify which one it is soon
2021-09-01 24431, 2021
reosarevok
Thanks!
2021-09-01 24445, 2021
lucifer
but we'll also need to figure out if other checks are needed.
lucifer: sure. I guess if the whole thing runs then other checks aren't *needed*, but might make things faster? :) Like the position column mentioned there
hello lucifer, when it comes to music recommendation, the user recommends the music to his/her followers. And this is stored in the DB and is retrieved again while rendering the feed of his/her followers. So when trying to implement deletion of recommendation event from the feed, we cannot straight up delete the entry, since other users might have not deleted the same event.
2021-09-01 24442, 2021
riksucks
so for this what should be done?
2021-09-01 24442, 2021
riksucks
Do you have anything in mind? Or do you want me to come up with a solution for this and then discuss with you
2021-09-01 24400, 2021
lucifer
riksucks: letting the user that made a recommendation to delete it should be sufficient for now methinks.
2021-09-01 24441, 2021
lucifer
allowing other users to hide those events from feed is a different feature imo.
2021-09-01 24432, 2021
riksucks
ohh okay, so the followers won't delete it, but the one who made the recommendation will, I see
2021-09-01 24432, 2021
riksucks
>allowing other users to hide is different
2021-09-01 24432, 2021
riksucks
I see, I kind of misunderstood the purpose, the ticket makes more sense now. Thank you
2021-09-01 24402, 2021
lucifer
>so the followers won't delete it, but the one who made the recommendation will
2021-09-01 24403, 2021
lucifer
yup
2021-09-01 24448, 2021
riksucks
Also, idk if its an issue only I am having, but the LB frontend locally won't talk with the backend APIs properly. It would always say how the auth token is invalid. So I am resorting to curl and postman to test things out. Is this some common issue or does it seem to only affect me here?
2021-09-01 24403, 2021
lucifer
there's a setting in config.py file to set whether the app should connect to LB prod or your local version.
2021-09-01 24428, 2021
riksucks
ahh I see, I should have checked there, sorry for the trouble
this should hopefully cover everything needed to set up the dev env. if you find something missing, we should add it there
2021-09-01 24428, 2021
lucifer
due to some reason, the wrong version of mbdata was installed in indexer on bono. strange, running reindex now.
2021-09-01 24435, 2021
lucifer
reosarevok: ^
2021-09-01 24437, 2021
peterhil has quit
2021-09-01 24421, 2021
lucifer
instrument worked.
2021-09-01 24420, 2021
prabaaaaal joined the channel
2021-09-01 24429, 2021
reosarevok
lucifer: oh yeah, I got that locally at first too
2021-09-01 24433, 2021
reosarevok
Dunno why
2021-09-01 24451, 2021
reosarevok
Are you running a full one now?
2021-09-01 24449, 2021
lucifer
reosarevok: yes. full reindex.
2021-09-01 24455, 2021
reosarevok
Thanks
2021-09-01 24459, 2021
reosarevok
Guess that'll take a while :D
2021-09-01 24420, 2021
lucifer
place/event/intrument completed so far. yup indeed.
2021-09-01 24424, 2021
reosarevok
Do we have a good way to check it worked fine?
2021-09-01 24447, 2021
reosarevok
I guess "no errors" is a good start, but I mean, that they actually look like they should as well
2021-09-01 24448, 2021
lucifer
yvanzo might?
2021-09-01 24420, 2021
lucifer
i think we could run it in test.mb and see make some chagnes there observe if they show up in search
2021-09-01 24425, 2021
Toasty joined the channel
2021-09-01 24458, 2021
Toasty has quit
2021-09-01 24420, 2021
krishan has quit
2021-09-01 24442, 2021
krishan joined the channel
2021-09-01 24426, 2021
ruaok waves
2021-09-01 24438, 2021
ruaok
if you get your invoice in in the next 5 minutes, I'll pay it.
2021-09-01 24450, 2021
ruaok
otherwise #vacation for the rest of the day
2021-09-01 24418, 2021
akshaaatt[m]
ruaok I started work on 30th September, right😃
2021-09-01 24406, 2021
akshaaatt[m]
August**
2021-09-01 24408, 2021
akshaaatt[m]
Hah!
2021-09-01 24448, 2021
akshaaatt[m]
I'll let you enjoy your #vacations 💯
2021-09-01 24410, 2021
ruaok
thanks!
2021-09-01 24416, 2021
ruaok runs off for the day
2021-09-01 24421, 2021
reosarevok
lucifer: how is that going? :)
2021-09-01 24422, 2021
lucifer
reosarevok: i had gone away for a bit. didn't get the chance to trigger reindex for all entities. started reindexing all now.
2021-09-01 24457, 2021
reosarevok
Ok :)
2021-09-01 24452, 2021
monkey
akshaaatt[m]: I for one think it's a good idea to work on a mockup like this and being able to host it and get feedback!
2021-09-01 24452, 2021
monkey
In my experience it's easier to seek feedback fewer times but on designs that are well advanced, rather than more regular feedback every time something changes in the mockup. (it's easier to integrate a few waves of feedback than continuous feedback)
yes indeed. also, as much as it pains me to say this. it's much easier to see how the mockup if it's made like it will look on the screen, preliminary paper scetches are god for ideas, but bad for getting "how does this mockup look2 type feedback
2021-09-01 24400, 2021
CatQuest
for exmple, I need full colour to be able to ake judgement
2021-09-01 24432, 2021
akshaaatt[m]
Agreed
2021-09-01 24453, 2021
akshaaatt[m]
But I found the paper sketches really helpful for myself
2021-09-01 24422, 2021
CatQuest
absolutely. it's a very good idea
2021-09-01 24435, 2021
CatQuest
i do those myelf
2021-09-01 24457, 2021
akshaaatt[m]
I really think that coming up with a design is really hard. I never used to think about this until 2-3 years back because it comes naturally to me. But when I explored recently, people have a designated job for this!
2021-09-01 24400, 2021
CatQuest
trying to think about how f.ex. instrument families evolved to
2021-09-01 24410, 2021
akshaaatt[m]
Right
2021-09-01 24434, 2021
CatQuest
to me the most important thing is that edit screns don't change *too* much
2021-09-01 24446, 2021
CatQuest
and that good ideas/scripts get implemented as well
2021-09-01 24403, 2021
CatQuest
like batch adding aliases, expand/collaps releases script of bitmap's
2021-09-01 24424, 2021
CatQuest
having front cover art iamges more palces
2021-09-01 24429, 2021
CatQuest
more data aobut releases more places
2021-09-01 24440, 2021
CatQuest
having "edit" links more palces
2021-09-01 24408, 2021
CatQuest
it'd be really cool if I could go directly to the "edit" screen in a search result for example
2021-09-01 24449, 2021
CatQuest
and making this more mobile friendly. essentially changing the screen-soze wil make things still logical
2021-09-01 24453, 2021
CatQuest
size*
2021-09-01 24415, 2021
CatQuest
while at the same time utilising desktop's wide screen space better
