akshat: ruaok: looked at the logs, i think the issue here is trying to access element using `getElementById`. react/ts don't like that. you'd need to create `ref` to access it like that. but that is discouraged. afaik, preferred way to do this would be to add a field to the component's state.
2021-10-15 28858, 2021
lucifer
using `document.body` is kinda an exception to it because 1) its always there 2) its not created inside react
2021-10-15 28845, 2021
bitmap
zas: tests still take longer now (18-19 minutes instead of 17) but it is a little better, thanks
2021-10-15 28830, 2021
lucifer
i have pushed a sample fix for the grid background. you can revert that for going back to full page background color.
2021-10-15 28800, 2021
bitmap
if you need to access document.body you can normally do it inside componentDidMount() (or useEffect() for functional components)
2021-10-15 28826, 2021
lucifer
i see. makes sense.
2021-10-15 28800, 2021
lucifer
here its the opoosite case, we currently do document.body but want to change to switch to just a div rendered by react.
2021-10-15 28822, 2021
Lotheric has quit
2021-10-15 28847, 2021
Lotheric joined the channel
2021-10-15 28811, 2021
Lotheric has quit
2021-10-15 28840, 2021
Lotheric joined the channel
2021-10-15 28824, 2021
Lotheric_ joined the channel
2021-10-15 28804, 2021
Lotheric has quit
2021-10-15 28813, 2021
loujine_ joined the channel
2021-10-15 28815, 2021
Leftmost_ joined the channel
2021-10-15 28854, 2021
Leftmost has quit
2021-10-15 28854, 2021
loujine has quit
2021-10-15 28855, 2021
Leftmost_ is now known as Leftmost
2021-10-15 28852, 2021
peterhil joined the channel
2021-10-15 28846, 2021
peterhil has quit
2021-10-15 28803, 2021
ruaok
mooin!
2021-10-15 28816, 2021
ruaok
thanks for the grid fix, preparing to send to test
2021-10-15 28826, 2021
ruaok
lucifer: thanks for the fix -- I think the box could use some top/bottom margin, but this is pretty good.
2021-10-15 28849, 2021
lucifer
agreed.
2021-10-15 28815, 2021
lucifer
should i add those? i can probably also throw in some rounded corners if you like.
2021-10-15 28830, 2021
ruaok
❤️
2021-10-15 28834, 2021
lucifer
huh. the color wheel seems to broken sometimes but i am unable to reproduce the issue reliably.
2021-10-15 28843, 2021
ruaok
what do you think of the idea of having the color wheel in the center of the screen when the page loads?
2021-10-15 28804, 2021
ruaok
and then when a color is clicked, it moves to its correct position, ideally with a short animation.
2021-10-15 28831, 2021
lucifer
i think it looks fine. +1 on the animation. the current movements are too abrupt.
2021-10-15 28841, 2021
ruaok
exactly.
2021-10-15 28802, 2021
ruaok
that way we can also adjust the text a bit for each of the two stages.
2021-10-15 28829, 2021
ruaok
perhaps just start with "Click on a color below" and the color wheel.
2021-10-15 28835, 2021
lucifer
same for BP btw, it shifts position from left to right when cover art is clicked abruptly.
2021-10-15 28854, 2021
lucifer
thoughts on making BP hidden by default? and only render it when cover art is clicked
2021-10-15 28801, 2021
ruaok
yerp, would be good to fix.
2021-10-15 28805, 2021
ruaok
yes, please to hiding.
2021-10-15 28838, 2021
lucifer
cool. let's see how far along i can take this.
2021-10-15 28848, 2021
ruaok
show it when the grid appears and then change the instruction text to "Now click on an album cover to listen to that album".
2021-10-15 28854, 2021
ruaok
woo, thanks!
2021-10-15 28804, 2021
lucifer
👍
2021-10-15 28843, 2021
ruaok
I have worked out how I want the scripts to stay in sync, but I doubt I'll get them done today. today is a bit fractured for me. (and I still need to prep a state of metabrainz talk)
2021-10-15 28814, 2021
lucifer
oh nice, the state talks :D
2021-10-15 28829, 2021
lucifer
if you can write it up, i'll lend a hand on backend cleanup
2021-10-15 28848, 2021
lucifer
(write up what needs to be done to update the scripts)
2021-10-15 28841, 2021
ruaok
I think it would take longer to explain the tasks at hand than to actually carry it out, but thanks.
2021-10-15 28808, 2021
ruaok
what are missing are some tests for the python code, if you feel really heroic. :)
2021-10-15 28821, 2021
MrClon joined the channel
2021-10-15 28849, 2021
akshat
moin!
2021-10-15 28854, 2021
ruaok
moin moin!
2021-10-15 28826, 2021
akshat
Is there anything more to be done for huesound from my end or lucifer is looking into the orientation?
2021-10-15 28820, 2021
ruaok
we're nearing the end for this round of changes. not sure if there are any front end tests that we should have, but that is still on the list.
2021-10-15 28800, 2021
akshat
Oh okay.
2021-10-15 28849, 2021
akshat
Currently I'm back to working on the mb web interface. We can start the huesound tests once we have finalized stuff I would like to help with that whenever we decide to :)
2021-10-15 28814, 2021
ruaok
I updated the todo items in the PR -- most are mine. I'll try and do some cleanup today, but I won't finish the migration script. that will have to wait until next week, sadly.
2021-10-15 28839, 2021
ruaok
ok, sounds good. also need to give you feedback on the new homepage. let me do that this morning.
2021-10-15 28811, 2021
alastairp
good morning
2021-10-15 28821, 2021
ruaok
morning!
2021-10-15 28830, 2021
akshat
Thanks ruaok
2021-10-15 28838, 2021
alastairp
zas: hi, yes. 1.2T is the size of the AB database now. no way to reduce it, because that's the data that we have
2021-10-15 28857, 2021
ruaok
oy.
2021-10-15 28803, 2021
alastairp
however, perhaps we should start looking at our plans for moving data files to disk, so that we can put them in a separate location
2021-10-15 28821, 2021
ruaok
why is it that I always feel that "that will be a nice problem to have", but then when the time comes I no longer feel that way? thanks past rob. bastard.
2021-10-15 28835, 2021
ruaok
alastairp: +1
2021-10-15 28846, 2021
alastairp
regarding /home, I make periodic db backups into there. I can delete the most recent one that I made
2021-10-15 28805, 2021
alastairp
OK, looks like my AB priority list is 1) dumps, 2) new data storage. happy to start working on that next
lucifer do check this out. This will solve all our problems. I'm planning to work some part of the mb web mock with this setup.
2021-10-15 28847, 2021
yyoung[m]
There're tons of frameworks that'll solve our problems
2021-10-15 28821, 2021
adhawkins has quit
2021-10-15 28834, 2021
yyoung[m]
But considering the current setup of MB codebase, some of them may need great effort to fit into the current system.
2021-10-15 28839, 2021
akshat
Correct yyoung[m] absolutely agreed! But from my understanding next js seems to be the most intuitive, tested and reliable resource as a solution for our problems
2021-10-15 28840, 2021
akshat
For now I can confirm that CRA won't solve what we're looking for and a nice framework like next js is very handy for us
2021-10-15 28821, 2021
ruaok
akshat: remember that when you're picking tools, that you need to be really mindful of the rest of the MB team -- they will need to code with it for the foreseeable future. so, they should be your target audience for these things.
2021-10-15 28826, 2021
yyoung[m]
Right, I just want to remind you not to be too aggressive :) I like bleeding-edge technologies too, I like SPA as well, but the reality is we don't have every API needed for SPA
2021-10-15 28806, 2021
ruaok doesnt like bleeding edge technologies
2021-10-15 28813, 2021
ruaok
I like solid working stuff.
2021-10-15 28820, 2021
akshat
Agreed
2021-10-15 28823, 2021
yyoung[m]
These tools are cool and easy to use when starting a new project, like your mockup, but for existing system like MB there're tradeoffs to consideer
2021-10-15 28847, 2021
ruaok
loads and loads of tradeoffs
2021-10-15 28857, 2021
akshat
Right
2021-10-15 28810, 2021
yyoung[m]
After doing your research and decision, maybe ask for advice from the MB dev team before directly jumping into it :)
2021-10-15 28859, 2021
ruaok
akshat: yyoung[m] is exactly on the right track. this can be very sensitive and these tools need careful choosing.
2021-10-15 28848, 2021
adhawkins joined the channel
2021-10-15 28856, 2021
akshat
Does make sense. I'll slow down and work as is for now then. Let's wait for more discussion on this stuff. For now I'll continue with the integration of my current work to mb server then
2021-10-15 28834, 2021
akshat
Will finish the mockup based on some feedback received then move ahead
2021-10-15 28813, 2021
yyoung[m]
Wow have you already started the integration?
2021-10-15 28843, 2021
akshat
Not yet yyoung[m]
2021-10-15 28842, 2021
zas
yvanzo: I'm restarting sir-prod on pink
2021-10-15 28800, 2021
zas
yvanzo: if it doesn't recover you may need to have a look
ruaok do we want to add a Pricing section to the mb homepage?
2021-10-15 28850, 2021
ruaok
no.
2021-10-15 28806, 2021
akshat
Cool. I've roved the FAQ section
2021-10-15 28807, 2021
ruaok
that's MeB's domain.
2021-10-15 28810, 2021
ruaok
k
2021-10-15 28811, 2021
akshat
Okayy
2021-10-15 28850, 2021
akshat
So, Main section, what is mb, brainz projects, understand mb, supporters, download software, footer
2021-10-15 28802, 2021
akshat
I think we can conclude the homepage with these sections
2021-10-15 28828, 2021
akshat
Obviously based on the feedback some improvements to the sections
2021-10-15 28844, 2021
ruaok
I think supporters could even be smaller -- I still think there are too many sections. but having some big name logos on our home page gives use a lot of cred.
2021-10-15 28809, 2021
akshat
Yeaah
2021-10-15 28830, 2021
akshat
I'll make the understand mb sections a but smaller
2021-10-15 28833, 2021
akshat
Bit^
2021-10-15 28839, 2021
akshat
Logos as well
2021-10-15 28846, 2021
akshat
Of the supporters
2021-10-15 28811, 2021
ruaok
yeah.
2021-10-15 28824, 2021
ruaok
and the brainzprojects section also feels a bit lengthy.
2021-10-15 28825, 2021
akshat
Great!
2021-10-15 28838, 2021
akshat
Oh okayy. Maybe let me reduce the font size?
2021-10-15 28847, 2021
ruaok
I think we mostly need to signpost them from the MB homepage -- a short blurb and the logo is enough.
