#metabrainz

akshat: ruaok: looked at the logs, i think the issue here is trying to access element using `getElementById`. react/ts don't like that. you'd need to create `ref` to access it like that. but that is discouraged. afaik, preferred way to do this would be to add a field to the component's state.

using `document.body` is kinda an exception to it because 1) its always there 2) its not created inside react

zas: tests still take longer now (18-19 minutes instead of 17) but it is a little better, thanks

i have pushed a sample fix for the grid background. you can revert that for going back to full page background color.

if you need to access document.body you can normally do it inside componentDidMount() (or useEffect() for functional components)

i see. makes sense.

here its the opoosite case, we currently do document.body but want to change to switch to just a div rendered by react.

mooin!

thanks for the grid fix, preparing to send to test

lucifer: thanks for the fix -- I think the box could use some top/bottom margin, but this is pretty good.

agreed.

should i add those? i can probably also throw in some rounded corners if you like.

❤️

huh. the color wheel seems to broken sometimes but i am unable to reproduce the issue reliably.

what do you think of the idea of having the color wheel in the center of the screen when the page loads?

and then when a color is clicked, it moves to its correct position, ideally with a short animation.

i think it looks fine. +1 on the animation. the current movements are too abrupt.

exactly.

that way we can also adjust the text a bit for each of the two stages.

perhaps just start with "Click on a color below" and the color wheel.

same for BP btw, it shifts position from left to right when cover art is clicked abruptly.

thoughts on making BP hidden by default? and only render it when cover art is clicked

yerp, would be good to fix.

yes, please to hiding.

cool. let's see how far along i can take this.

show it when the grid appears and then change the instruction text to "Now click on an album cover to listen to that album".

woo, thanks!

👍

I have worked out how I want the scripts to stay in sync, but I doubt I'll get them done today. today is a bit fractured for me. (and I still need to prep a state of metabrainz talk)

oh nice, the state talks :D

if you can write it up, i'll lend a hand on backend cleanup

(write up what needs to be done to update the scripts)

I think it would take longer to explain the tasks at hand than to actually carry it out, but thanks.

what are missing are some tests for the python code, if you feel really heroic. :)

moin!

moin moin!

Is there anything more to be done for huesound from my end or lucifer is looking into the orientation?

we're nearing the end for this round of changes. not sure if there are any front end tests that we should have, but that is still on the list.

Oh okay.

Currently I'm back to working on the mb web interface. We can start the huesound tests once we have finalized stuff I would like to help with that whenever we decide to :)

I updated the todo items in the PR -- most are mine. I'll try and do some cleanup today, but I won't finish the migration script. that will have to wait until next week, sadly.

ok, sounds good. also need to give you feedback on the new homepage. let me do that this morning.

good morning

morning!

Thanks ruaok

zas: hi, yes. 1.2T is the size of the AB database now. no way to reduce it, because that's the data that we have

oy.

however, perhaps we should start looking at our plans for moving data files to disk, so that we can put them in a separate location

why is it that I always feel that "that will be a nice problem to have", but then when the time comes I no longer feel that way? thanks past rob. bastard.

alastairp: +1

regarding /home, I make periodic db backups into there. I can delete the most recent one that I made

OK, looks like my AB priority list is 1) dumps, 2) new data storage. happy to start working on that next

works for me.

k

lucifer do check this out. This will solve all our problems. I'm planning to work some part of the mb web mock with this setup.

There're tons of frameworks that'll solve our problems

But considering the current setup of MB codebase, some of them may need great effort to fit into the current system.

Correct yyoung[m] absolutely agreed! But from my understanding next js seems to be the most intuitive, tested and reliable resource as a solution for our problems

For now I can confirm that CRA won't solve what we're looking for and a nice framework like next js is very handy for us

akshat: remember that when you're picking tools, that you need to be really mindful of the rest of the MB team -- they will need to code with it for the foreseeable future. so, they should be your target audience for these things.

Right, I just want to remind you not to be too aggressive :) I like bleeding-edge technologies too, I like SPA as well, but the reality is we don't have every API needed for SPA

I like solid working stuff.

Agreed

These tools are cool and easy to use when starting a new project, like your mockup, but for existing system like MB there're tradeoffs to consideer

loads and loads of tradeoffs

Right

After doing your research and decision, maybe ask for advice from the MB dev team before directly jumping into it :)

akshat: yyoung[m] is exactly on the right track. this can be very sensitive and these tools need careful choosing.

Does make sense. I'll slow down and work as is for now then. Let's wait for more discussion on this stuff. For now I'll continue with the integration of my current work to mb server then

Will finish the mockup based on some feedback received then move ahead

Wow have you already started the integration?

Not yet yyoung[m]

yvanzo: I'm restarting sir-prod on pink

yvanzo: if it doesn't recover you may need to have a look

alastairp: what's the growth rate of ab db?

zas: https://acousticbrainz.org/statistics-graph

I can run some stats to try and calculate number of submissions vs disk space

akshat: commented on the design finally.

25M in AB? wow. just wow.

yeah, and they keep coming

I wonder if that recent jump was thanks to MrClon :)

a lot of stats are sort of stuck in my mind from 5 years ago.

and picard will also add to that soon.

alastairp: yes, because we may need more disk space very soon for it

just got sent this

> Acoustic similarities of the audio files, using a trained Self-Organizing Map

using AB data

oh that looks nice.

dmitry just sent it to me. we'll look into it and see how it works

Thanks ruaok

man, I really want to sort out the MB database integration into AB now

lucifer: one day we'll get it finished :)

so many cool things coming out of it

yvanzo: ^^

ruaok do we want to add a Pricing section to the mb homepage?

no.

Cool. I've roved the FAQ section

that's MeB's domain.

k

Okayy

So, Main section, what is mb, brainz projects, understand mb, supporters, download software, footer

I think we can conclude the homepage with these sections

Obviously based on the feedback some improvements to the sections

I think supporters could even be smaller -- I still think there are too many sections. but having some big name logos on our home page gives use a lot of cred.

Yeaah

I'll make the understand mb sections a but smaller

Bit^

Logos as well

Of the supporters

yeah.

and the brainzprojects section also feels a bit lengthy.

Oh okayy. Maybe let me reduce the font size?

I think we mostly need to signpost them from the MB homepage -- a short blurb and the logo is enough.

[musicbrainz-server] 14reosarevok merged pull request #2020 (03master…MBS-11519): MBS-11519: Convert Edit Relationship Type edit to React https://github.com/metabrainz/musicbrainz-serve...

yes, and some whitespace.