akshat: oh, yes. I tried to set this up once, but failed on the app side of things and the Gradle changes. Let me check
2021-11-01 30520, 2021
akshat
Great, I've done this to over 4 apps now and I'm loving it.
2021-11-01 30524, 2021
akshat
Please do not share the json files here in public though, just a reminder 😃
2021-11-01 30520, 2021
lucifer
alastairp: is it safe to remove blocks like `except Exception: raise APIInternalServerError`. afair, the 500 error handler you put in some time ago handles all uncaught exceptions and these blocks are redundant, wanted to confirm I am not forgetting something?
2021-11-01 30534, 2021
akshat
outsidecontext: now head to your repo's settings and on to Secrets
2021-11-01 30506, 2021
akshat
ANDROID_KEYSTORE_FILE
2021-11-01 30506, 2021
akshat
KEYSTORE_KEY_ALIAS
2021-11-01 30506, 2021
akshat
KEYSTORE_KEY_PASSWORD
2021-11-01 30506, 2021
akshat
KEYSTORE_STORE_PASSWORD
2021-11-01 30542, 2021
akshat
PLAY_CONIFG_JSON
2021-11-01 30516, 2021
akshat
All these five variables with the respective values
2021-11-01 30547, 2021
akshat
Only the play config json value and the Android keystore file value should be in the base64 encoded version
2021-11-01 30528, 2021
akshat
Just the command `base64 -i play_config.json > play_config.json.b64 ` the gather the base64 encoded version of the file
2021-11-01 30537, 2021
akshat
Use^
2021-11-01 30507, 2021
akshat
Once you've added these, merge my Fastlane PR.
2021-11-01 30539, 2021
akshat
After that all we'll need to do is increment the version code in the next push and the release should be made as a draft on the playstore hope
2021-11-01 30549, 2021
akshat
hopefully^
2021-11-01 30537, 2021
outsidecontext
cool, let us test this :) need a few minutes to set this up
2021-11-01 30547, 2021
akshat
Sure!
2021-11-01 30501, 2021
outsidecontext
the json file I think we probably could also do as plaintext instead of base64 encoding it, but let's got with this first
2021-11-01 30522, 2021
akshat
I learnt my lesson to encode large text lol because that might contain whitespace
2021-11-01 30533, 2021
akshat
But I think the plain text might work for json
2021-11-01 30507, 2021
akshat
I just saw that you use the `main` branch and not the `master` branch for the default work so I'll make those changes accordingly for you
2021-11-01 30507, 2021
akshat
If I forgot to mention, the ANDROID _KEYSTORE_FILE is the .jks file we use to sign our aab files
2021-11-01 30537, 2021
outsidecontext
the keystore file that can be managed with keytool, right? I just changed the passwords for that so it is unique for the CI. Setup should work that way.
2021-11-01 30508, 2021
outsidecontext
PR looks good to me. Let's try by merging to beta branch, I'll create one
2021-11-01 30540, 2021
akshat
Great!
2021-11-01 30544, 2021
akshat
And yeah
2021-11-01 30541, 2021
ruaok
akshat: lucifer: alastairp: monkey: yvanzo: remember to add the hours we spent on zoom for the summit to your invoice, ok?
outsidecontext: typo from my end, the Secret is supposed to be PLAY_CONFIG_JSON
2021-11-01 30511, 2021
akshat
Had the I and F switched previously
2021-11-01 30515, 2021
outsidecontext
I update it
2021-11-01 30519, 2021
akshat
Great
2021-11-01 30526, 2021
akshat
You'll have to push to beta a change to trigger the action again
2021-11-01 30540, 2021
outsidecontext
I rerun the action, just to see if it works. Secret should actually have been ok, but maybe wrong value. I updated it again, let's see
2021-11-01 30510, 2021
akshat
Okayyy
2021-11-01 30542, 2021
outsidecontext
it should still fail to publish because I haven't pushed bumping the versionCode, but I want to see first if the general setup works
2021-11-01 30508, 2021
akshat
Cool sounds good
2021-11-01 30529, 2021
akshat
I basically failed this setup over 100 times this weekend😂
2021-11-01 30550, 2021
akshat
But it was worth it in the end :)
2021-11-01 30514, 2021
outsidecontext
:D not sure quite now, how does it behave when you released to beta, then to production? can this be done with the same versionCode, or does it need to be bumped again?
2021-11-01 30520, 2021
akshat
I think it can be done with the same versionCode
2021-11-01 30523, 2021
outsidecontext
I think it is running now. I had failed to save the key permissions, but that should be fixed
2021-11-01 30532, 2021
akshat
Amazing!
2021-11-01 30513, 2021
akshat
I think you need to go through an additional step outsidecontext ?
2021-11-01 30519, 2021
outsidecontext
oh well "For uploading an AppBundle you must be enrolled in Play Signing.". I avoided this so far, not a fan :D
2021-11-01 30540, 2021
akshat
Why though?
2021-11-01 30539, 2021
akshat
We can modify the setup for you so that you can locally send the release through the command `fastlane beta`
2021-11-01 30520, 2021
outsidecontext
don't liked the idea that google instead of myself signs the code being distributed. Don't have much of an issue with that on f-droid, different trust situation. But anyway, I'll set this up here
2021-11-01 30548, 2021
akshat
Haha okaaayy!
2021-11-01 30512, 2021
akshat
So are you setting up the local solution or enrolling to play signing?
2021-11-01 30515, 2021
akshat
Btw let me know if you learn something new in the process :)
2021-11-01 30529, 2021
akshat
We are yet to write UI tests for the app to automate the screenshots.
2021-11-01 30509, 2021
outsidecontext
I'll enroll for play signing. I just wonder if we need the keystore on the CI then still
2021-11-01 30514, 2021
akshat
We do need it. It's just that we only need to sign using these credentials only. Idk if you were allowed to change the password until now, but moving forward we can't.
2021-11-01 30557, 2021
akshat
If we misplace these credentials, we'll have to contact Google to reset our keystore. Pretty good support for that though
2021-11-01 30511, 2021
outsidecontext
ah, ok. good I changed passwords then right now.
2021-11-01 30527, 2021
akshat
Great 👍
2021-11-01 30519, 2021
outsidecontext
ok, let me read up about this. I will set this up later then and test the builds. I'll write you on the results. But thanks a lot for setting this up, I love it. That there was no full CI deployment for this porject already bothered me
(FWIW, I have a few listens submitted with the current code: https://api.listenbrainz.org/1/user/Freso/listens - only local files though, so the `music_service` part hasn’t been tested in action (yet).)
2021-11-01 30533, 2021
zas
I deployed serviceregistrator on serge & zappa, it replaces registrator. I'll continue deployment over the week, I'm careful because this stuff is quite critical in our infra.
2021-11-01 30539, 2021
Sophist-UK joined the channel
2021-11-01 30558, 2021
Sophist_UK has quit
2021-11-01 30533, 2021
alastairp
Freso: it means that I will look at your stuff at the same time as I finish this PR
2021-11-01 30550, 2021
Freso
alastairp: Alright. Thanks. :)
2021-11-01 30550, 2021
yyoung[m]
Hi Freso , I've been quite busy recently and there're some problems with my development environment, so nothing to review for last week :)
2021-11-01 30540, 2021
Freso
yyoung[m]: 👍 You’re not under any obligation to give a review btw (anymore), so if you’re not on my list at https://wiki.musicbrainz.org/User:Freso/MetaBrain… and you don’t mail anything to me, you won’t be called on for the reviews. :)
2021-11-01 30541, 2021
yyoung[m]
OK
2021-11-01 30516, 2021
outsidecontext
akshat: the deployment does not work yet :( Complains about "The Android App Bundle was not signed.", but I don't see any error to the signing itself. It's supposed to work, as far as I can tell the secrets are setup correctly. Any ideas? https://github.com/phw/PicardBarcodeScanner/runs/…
2021-11-01 30509, 2021
BrainzGit joined the channel
2021-11-01 30527, 2021
zas
switching to herb, for maint
2021-11-01 30522, 2021
zas
hmmm, something went wrong
2021-11-01 30510, 2021
lucifer
uh yeah, all websites inaccessible. any way we can help?
2021-11-01 30505, 2021
zas
well, not sure what's happening, since sometimes it works
2021-11-01 30528, 2021
zas
I think we had similar issue in the past, it was related to hetzner floating IP
2021-11-01 30536, 2021
lucifer
currently unable to ssh to herb.
2021-11-01 30546, 2021
zas
yes, rebooting right now
2021-11-01 30556, 2021
zas
I'll switch to it when it will come back
2021-11-01 30556, 2021
lucifer
👍
2021-11-01 30507, 2021
zas
I think that's an issue at IP or TCP level, nginx doesn't output any error, config is ok
2021-11-01 30544, 2021
zas
switching to herb
2021-11-01 30559, 2021
zas
help welcome if someone can identify the actual issue
