If it helps, I require some guidance for https://github.com/metabrainz/musicbrainz-server/…. The UI is present but none of the button clicks or so work. I am assuming it has something related to javascript for now.
2021-11-22 32627, 2021
Freso has quit
2021-11-22 32600, 2021
reosarevok
Ok, lemme try to test your PR and see if I find the issue
2021-11-22 32611, 2021
Freso joined the channel
2021-11-22 32650, 2021
akshaaatt
Thank you so much!
2021-11-22 32659, 2021
reosarevok
akshaaatt: well, the first thing I'm seeing is "Refused to load the stylesheet 'https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css' because it violates the following Content Security Policy directive: "style-src 'self' staticbrainz.org". Note that 'style-src-elem' was not explicitly set, so 'style-src' is used as a fallback." in the console.
2021-11-22 32610, 2021
reosarevok
We probably should have those stylesheets locally
2021-11-22 32622, 2021
reosarevok
But bitmap can tell you exactly whether to put them on staticbrainz or what :)
but the absolute value of this metric is also not meaningful -- number of listens processed since ts writer start is meaningless.
2021-11-22 32652, 2021
ruaok
zas: I'm going to hold off on the prom. migration for now. we can work on that in jan, but right now we have too much stuff on to add this to our tasks.
2021-11-22 32616, 2021
ruaok
yeah, reading those docs, its clear as mud and I'll throw myself down yet another rabbit role wasting time.
2021-11-22 32638, 2021
ruaok
lucifer: yes, please, lets change the graph to "number of listens processed since the last update"
2021-11-22 32652, 2021
lucifer
ok 👍
2021-11-22 32653, 2021
ruaok
which should be a simple and straightforward change, then grafana can follow easily.
(if you want the whole result I can send it, it's 30 mb of text)
2021-11-22 32638, 2021
ruaok
ok, thanks all good.
2021-11-22 32620, 2021
ruaok
a lot of those are not what I would expect spammers to look like. though the "dry run" bits seem clearly spam accounts.
2021-11-22 32604, 2021
zas
"but the absolute value of this metric is also not meaningful -- number of listens processed since ts writer start is meaningless." -> how so? that's what is called a counter in metrics world, and it's widely used. Your app just have to increase it over the time. For example, that's how we get rates from interfaces traffic (number of bytes since the start). But it doesn't work for temperature for example (for this, a gauge is used)
2021-11-22 32607, 2021
ruaok
yes, I understand counters.
2021-11-22 32602, 2021
ruaok
but this counter is counting something meaningless. the number of counts like the start of the component. I could care less. this is not about the validity of counters, it is about the validity of the metric we're measuring.
2021-11-22 32629, 2021
zas
ah, yes, that's another issue ;)
2021-11-22 32603, 2021
zas
well, most apps just counts number of hits, number of items, etc... since the start because that's convenient (you don't have to store anything to disk), and since, by definition, the value cannot decrease, when it happens points are just ignored.
yeah, I hear that. but for us it is trivial to make this into a meaningful metric by only reporting the listens processed in the last update interval. it requires no data storage -- dead simple.
ruaok: https://github.com/metabrainz/listenbrainz-server… first because its ready. other PRs still need changes like adding api docs. i'll do those and apply comments from this PR to those at the same time.
ruaok: the graph for Incoming listens has no derivative anymore, is that expected? I also just noticed the use of fill(0) (that's perhaps me when I tried to fix those), it should be fill(previous) or fill(linear)
yes, just to reset the nonsense. I'll fix it when lucifer releases an updated timescale writer.
2021-11-22 32614, 2021
zas
ok
2021-11-22 32647, 2021
ruaok
at least it is good to know the seekrit incantation on how to make this graph.
2021-11-22 32647, 2021
zas
fill() is tricky, because it is only used when values are missing, and missing values depends on group by time(), for counters, we usually want to fill with previous values (when no values, we assume it didn't change), it can also be linear (but it then extrapolates too much imho)
2021-11-22 32617, 2021
ruaok
ah, very good to know, thanks.
2021-11-22 32654, 2021
zas
query inspector is your friend in this field
2021-11-22 32644, 2021
BrainzGit
[listenbrainz-server] 14amCap1712 opened pull request #1752 (03master…timescale-writer-counts): Timescale Writer: Use counts since last metric update https://github.com/metabrainz/listenbrainz-server…
ruaok: also trigger a full dump to fix missing pre-2018 listens?
2021-11-22 32645, 2021
ruaok
absolutely. (no need to ask me this question in the future, you're the boss in this area)
2021-11-22 32630, 2021
lucifer
intending to use the flags alastairp added last week to dump just spark listens first as that take ~4-5 hrs so can request import today and get stats fixed tomorrow. after that can trigger normal listens to complete the set of file (takes ~18-24 hrs).
2021-11-22 32639, 2021
lucifer
:D 👍
2021-11-22 32620, 2021
ruaok
I'm quite curious about the outcome of this -- the recheck on the mapping should have included a pile of new matches on the top discoveries. should be fun tomorrow.
2021-11-22 32600, 2021
lucifer
oh. indeed then hoping tommorrow's stats to be better
