#metabrainz

/

      • santiagofn joined the channel
      • Shubh joined the channel
      • Shubh has quit
      • Shubh joined the channel
      • Shubh has quit
      • Shubh joined the channel
      • Shubh has quit
      • gcrkrause1 has quit
      • gcrkrause1 joined the channel
      • outsidecontext has quit
      • outsidecontext joined the channel
      • CatQuest has quit
      • VxJasonxV has quit
      • Pokey has quit
      • Pokey joined the channel
      • FichteFoll has quit
      • FichteFoll joined the channel
      • yvanzo
        O’Moin
      • reosarevok
        Moin!
      • yvanzo: I'll be releasing later today - anything special about docker? :)
      • akshaaatt
        Moin!
      • Hi monkey! Will you be working on YIM today?
      • yvanzo
        reosarevok: not yet
      • BrainzGit joined the channel
      • reosarevok
        yvanzo: does that mean I should wait a bit and you'll have something special? :D
      • yvanzo
        reosarevok: don't wait :)
      • reosarevok
        Ok, going for a walk but releasing when back
      • yvanzo
        I have a large rework in progress.
      • riksucks
        lucifer: hi lucifer, can you check what is up with the feed api? It gives 500 for some reason
      • lucifer
        riksucks: same reason why feed page is down. i have opened a PR with the fix here https://github.com/metabrainz/listenbrainz-serv...
      • riksucks
        which is probably the reason why the feed api was never replying with the CORS headers, because it was crashing midway, hence the cors decorator never got to complete
      • I see
      • yvanzo
        reosarevok: wait, there is a blocking bug again with pgp keys
      • lucifer
        uh i think linked the wrong ticket to the PR. let me recheck
      • riksucks
        sure, no worries
      • lucifer
        yeah PR title and linked ticket is wrong. I'll fix that.
      • zas: we added more stats so the spark_result queue alert count is outdated again. looking at current graphs i think 150k would be a better number.
      • zas
        ok, I'll adjust
      • lucifer
        thanks
      • alastairp
        morning
      • reosarevok
        yvanzo: sure no problems. Just let me know
      • monkey
        akshaaatt: Yes, I think a bit of year in music is in order today
      • lucifer: I haven't tested PR #1762 but it seems like a tiny but very important change, and a clear fix. Considering the feed page is broken, should we go ahead and merge?
      • lucifer
        monkey: its up on beta and beta feed is working. i think merging and releasing makes sense
      • monkey
        Great, I'll test there quickly
      • Looks great, I'll approve and merge
      • lucifer
        đź‘Ť
      • ruaok
        moooin!
      • lucifer
        morning!
      • ruaok
        alastairp: sucky ! get well soon!
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #1762 (03master…feed-bug-fix): Fix broken feed due to incorrect dict access https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        i'll release
      • BrainzGit
        [listenbrainz-server] release 03v-2021-11-29.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • monkey
        Thank you !
      • lucifer
        prod updated.
      • ruaok: monkey: for when you have some time, https://github.com/metabrainz/listenbrainz-serv...
      • the issue is reviews for recordings are directly playable because the mbid stored in those cases is recording mbid and we can fetch that data from mapping table. however for artist/release group review, we don't have that data. we don't even have the entity name in that case.
      • yvanzo
        reosarevok: I had a WIP patch about the same issue with SIR, just have to adapt to MB Docker Compose.
      • reosarevok
        Ok :)
      • yvanzo
        (It's not just updating a list.)
      • riksucks
        hello, so me and monkey were talking at the github pr, and realised that we need to come up with a lucid and succinct paragraph telling the user what the missing mb page is all about
      • monkey also pointed out, that some users may not even know about mb
      • so does anyone have an idea about what to write, I would put that in the page
      • monkey
        How about this, as a starting point?
      • > MusicBrainz is the music encyclopedia that ListenBrainz uses to display more information about your music, entirely built by a passionate open-source community.
      • > The songs (or “recordings”) below don’t seem to exist yet in MusicBrainz. Please take a few minutes to submit this new data and help us improve this community resource and everyone’s experience on ListenBrainz.
      • reosarevok
        yvanzo: if I can help, let me know :)
      • And should I still release MBS anyway, or will the issue affect that too?
      • I guess it will, if it's affecting all docker stuff
      • riksucks
        monkey: that sounds sweet.
      • If anyone feels like adding to it, feel free to. :D
      • CatQuest joined the channel
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1745 (03master…sitewide-listening): Add sitewide listening activity statistics https://github.com/metabrainz/listenbrainz-serv...
      • ruaok is dealing with BS complaint
      • ruaok
        people who claim trademark infringement just because there is a user who has the same name and their non-existant trademark does not give you the right to be an asshole.
      • #mondaymorningfun
      • CatQuest
        srsly?@
      • dumb
      • ruaok
        yep.
      • CatQuest
        . andthey dont realise his could be like a fan or something?
      • srsly those people do not know how the internet works
      • ruaok
        they are not listening to anything I say, so I have no clue what they might be realizing.
      • or how law works.
      • CatQuest shakes head inhouse style
      • CatQuest
        wait so by this logic anyone who names themselves "coca-cola" would be trademark infringing ?
      • ruaok
        yes.
      • CatQuest
        oh shit. ther is a game called "catcat" (never mind i names myself catcat before that gmae excisted)
      • ruaok
        but that is now how it works.
      • CatQuest
        erh catquest*
      • eh
      • reosarevok
        CatQuest: I think it's fine, because you're not a game called CatQuest :)
      • Or otherwise related to games, other than playing some
      • ruaok
        exactly that. trademarks only apply to given areas.
      • CatQuest
        oh am I not Ô___Ô
      • :D
      • reosarevok
        ruaok: you mean "that is *not* how it works", above, right?
      • (not "now")
      • CatQuest
        or like said in a sarcastic tone
      • ruaok nods at reosarevok
      • "because apparently that's how it works now"
      • ah
      • reosarevok
        Anyway, just ignore and let them try to sue? :)
      • CatQuest
        idiots
      • never mind that *we* aren't responisble for what users call themselves
      • atj
        generally best to avoid them trying to sue in the first place
      • ruaok
        very likely. the guy stopped responding and is waiting for his archive team to look up the registration.
      • CatQuest
        (unless like it's intentinally vandalising or horrible slurs etc)
      • ruaok
        he might just be some asshole from a rival band or something.
      • CatQuest
        lol
      • i guess this is growing pains. w're big enough ot be targeted by these idiots
      • ruaok
        this is nothing new. I deal with stupid shit like this all the time.
      • CatQuest
        :C
      • do we need a new legal person thing who's job it is to deal with this isntead of you so you cna do more of hat you're supposed to do?
      • deal with legalities, contracts, etc
      • ruaok
        not really. we just need someone to tell these people to STFU.
      • CatQuest
        hm.
      • atj
        something tells me ruaok is quite adept at that
      • ruaok
        20 years of doing that will give you... skillz.
      • CatQuest
        yeeeeaaaaa but
      • futureproofing and busfactoring
      • ruaok
        the best way to shut someone down is to take them up on their legal bluff.
      • CatQuest
        yes
      • reosarevok
        Basically "go ahead and sue", then 99% won't sue because any lawyer will tell them they're being dumb
      • CatQuest
        :D
      • ruaok
        and passing along the link where we ridiculed the one guy who ever dared to sue us.... helps a lot.
      • atj
        reosarevok: I'd go a bit lower than 99% - have a read of Techdirt
      • CatQuest
        oh no.
      • ruaok
        exactly. some lawyers know its dumb, but smell money.
      • atj
        however I think it's probably reasonably clear after 2-3 emails whether they're in the 1-2% of idiots with money
      • CatQuest
        !recall oh no.
      • BrainzBot
      • atj
        *with money to waste on lawyers
      • CatQuest
        see our copyright troll?
      • ruaok
        yerp. they knew exactly what they were doing. scattershot sue people and when someone puts up a real fight, fold immediately.
      • riksucks
        hi lucifer , going through a silly bug rn
      • in my local build, it says
      • ```sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedColumn) column "data" does not exist
      • LINE 2: SELECT user_id, last_updated, data, count, from_...```
      • sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedColumn) column "data" does not exist
      • LINE 2: SELECT user_id, last_updated, data, count, from_...
      • I faced this issue earlier too, but then I ran the update at `admin/sql/updates` and then it had worked
      • but surprisingly, its broken once again
      • lucifer
        riksucks: probably delete the existing volume and recreate those, it is possible a db update script broke something.
      • riksucks
        yeah I was thinking of that too, thanks for confirming
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1763 (03master…cap-listen-count): Cap listen counts for sitewide stats https://github.com/metabrainz/listenbrainz-serv...
      • riksucks
        lucifer: just curious to ask, hope you don't mind. Why does this line throw error (and then proceeds to render the whole websocket container useless) *locally*
      • It seems like the local websocket is broken because of this. I wonder what is different in production, so that it works there, but not locally.
      • lucifer
        riksucks: uh yes, i noticed that bug in prod so i reverted it to an older version. will try to fix it in sometime.
      • https://github.com/metabrainz/listenbrainz-serv... broke it because this is the only WS PR i merged today.