[bookbrainz-site] 14tr1ten opened pull request #731 (03master…fix#BB-604): Fix[BB-604]: making datepicker and link button responisve on small screen devices. https://github.com/bookbrainz/bookbrainz-site/pul…
hmm, submitting a listen to listenbrainz with "additional_info": {"artist_mbids": [""]} results in a different recording_msid being assigned to the listen vs if artist_mbids is omitted entirely. is this expected behavior? looking at the API code the empty string will be filtered out, but just the presence of an artist_mbids key seems to affect things. (the end result is that on the
2021-12-02 33642, 2021
nbin
listenbrainz website the listen doesn't have a link to the artist mbz page)
akshaaatt: that just looks like your DB is down - how do you usually connect to it?
2021-12-02 33631, 2021
reosarevok
santiagofn: ¡Hola! Hay cosas que hacer aún con React pero muchas son cambios enormes
2021-12-02 33643, 2021
reosarevok
Pero seguro que encontramos algo :)
2021-12-02 33621, 2021
reosarevok
Una opción es pensar en qué encuentras molesto al editar MusicBrainz, y mirar si es posible cambiarlo - así empecé yo, al menos :)
2021-12-02 33634, 2021
reosarevok
alastairp: I cc'd you on someone who wants to change their MB/LB username. Less than 1k listens, I understood for small numbers you had a simple way of doing it by hand or something?
2021-12-02 33610, 2021
lucifer
nbin: i checked and see what you mean, there are 2 related issues here. while "" is removed from the list of artist_mbids, the json retains the then empty list [] for artist_mbids. the frontend checks whether an artist_mbid was submitted by the user, since it was (even though its an empty list) it tries to use it. if that artist_mbids field wasn't submitted, it'll try to use a mapped one.
2021-12-02 33656, 2021
lucifer
nbin: did more tests, we actually try to handle this case in submission already but the check is incomplete. i'll fix it.
2021-12-02 33634, 2021
nbin
cool, thanks. noticed the odd behavior with scrobbles submitted from a go-based client since it just marshals the artist_mbids to an empty string if it's empty. wanted to check before updating the code to omit the key
2021-12-02 33630, 2021
nbin
if the fix is in the submission i assume that means existing scrobbles will still retain the empty key?
2021-12-02 33643, 2021
lucifer
yes existing one will still retain the empty key. at least till we manually run a cleanup on the db.
2021-12-02 33637, 2021
lucifer
we can also try to improve the frontend display to try use the mapped mbids if the user submitted empty ones.
2021-12-02 33625, 2021
nbin
gotcha. not a huge deal there. not sure if there's any other clients that would submit the empty list, but this one would've only started sending scrobbles within the last 2 weeks so there's probably not many
ruaok: one more please, 8f3471b5-7e6a-48da-86a9-c1c07a0f47ae ;)
2021-12-02 33643, 2021
ruaok
gawd damn you, lucifer.
2021-12-02 33649, 2021
ruaok
good one!
2021-12-02 33651, 2021
ruaok
!m lucifer
2021-12-02 33651, 2021
BrainzBot
You're doing good work, lucifer!
2021-12-02 33600, 2021
ruaok
or did you actually want that playlist??
2021-12-02 33641, 2021
lucifer
i guess doesn't hurt to have it. might come useful sometime 😈
2021-12-02 33617, 2021
ruaok
done. see my playlist page
2021-12-02 33647, 2021
lucifer
monkey: hi! the BP animation on hovering on the video is preventing me from cancelling ads when using youtube player. anything we can do here?
2021-12-02 33651, 2021
lucifer
thanks!
2021-12-02 33627, 2021
ruaok
wow, track 2 on the GFCCSW. #thingsdutchieslove
2021-12-02 33645, 2021
monkey
Oh wow. Forgot about ads entirely.
2021-12-02 33634, 2021
monkey
Well, apart from suggesting a browser that blocks them i guess it'll have to wait until I finish the BP redesign that's in progress
2021-12-02 33657, 2021
lucifer
makes sense 👍
2021-12-02 33639, 2021
monkey
Maybe some CSS could help not crop the video, but it's a band-aid
2021-12-02 33623, 2021
akshaaatt
lucifer is it possible to provide other apps/websites the ability to integrate ListenBrainz to their project and query users based on similarity? Example, instagram providing a means to connect your lb account and providing user suggestions/lb stats to them on their platform?
2021-12-02 33629, 2021
akshaaatt
I would assume it is possible to do so but can they use their exisiting database and just associate it to the lb username for gathering the results?
2021-12-02 33617, 2021
lucifer
sure almost everything on LB is available through an API, if you can do something on LB you can do that elsewhere too.
2021-12-02 33605, 2021
akshaaatt
Can this be a potential business model? I see dating apps connecting Spotify for showcasing a better profile
2021-12-02 33632, 2021
lucifer
re similariry, you can query top 25-50 similar users of a user because that's what LB stores itself. general similarity between every two users is not retained.
2021-12-02 33647, 2021
akshaaatt
But can't these apps be using LB for providing better user recommendations?
2021-12-02 33654, 2021
akshaaatt
Okayy
2021-12-02 33615, 2021
lucifer
¯\_(ツ)_/¯, the data is there. we know its not always great but probably good enough. its upto one how they want to use it.
2021-12-02 33624, 2021
akshaaatt
I really believe it can be a hit in that market. I think what we can do from end is provide examples of how that could be done.
2021-12-02 33634, 2021
akshaaatt
Our end*
2021-12-02 33619, 2021
lucifer
the yim stuff, top missed tracks are an example of combining various stuff and probably a good example.
2021-12-02 33611, 2021
lucifer
ruaok: i see the playlists generated for the first mbid are both named gfccsw. probably a typo, do you know which one is which?
done. stupid terminal text wrap issues -- been problematic for 30 years now.
2021-12-02 33617, 2021
lucifer
lol thanks
2021-12-02 33631, 2021
nbin
is the "Recent listens" total cached? i just cleared my listens and it went down by a lot, but with no listens it still shows 4k there
2021-12-02 33615, 2021
akshaaatt
reosarevok: thanks for the heads up. Seemed to have been a problem with my setup. Working fine now 👌
2021-12-02 33622, 2021
nbin
i also noticed that it'd decrease when "deleting" a nonexistent listen as well
2021-12-02 33638, 2021
ruaok
nbin: yes, indeed, all cached.
2021-12-02 33629, 2021
lucifer
decreasing on deleting nonexistent listens is a bug. shouldn't be much difficult to fix.
2021-12-02 33614, 2021
nbin
gotcha. lmk if you want me to open an issue for it
2021-12-02 33630, 2021
lucifer
sure, a ticket sounds good
2021-12-02 33653, 2021
nbin
will do
2021-12-02 33641, 2021
lucifer
CatQuest: i was just able to import the scrobbles of last 3 months from your LFM to a dummy LB account. can you try importing again?
2021-12-02 33633, 2021
lucifer
monkey: while looking at LFM importer, i see it is making 4 requests to LB per LFM page. seems a bit too much. can we reduce the number of requests to LB by making each payload heavier? i doubt one LFM is so large that we can't fit it in 1 request.
Still needs genre, similar artist or year filtering to produce listenable results.
2021-12-02 33606, 2021
lucifer
ruaok: how do troi, inputs and outputs work? does each element produce only 1 output and what's the number of inputs a element can accept?
2021-12-02 33618, 2021
ruaok
The list of inputs is an unordered list of types (in a list) it can accept.
2021-12-02 33635, 2021
ruaok
The output lists what it actually outputs.
2021-12-02 33612, 2021
ruaok
The whole system isn't fully hashed out yet, so changes might still come.
2021-12-02 33601, 2021
ruaok
It is possible to return more than one item from an element, but it's never been used nor do I have a use case for it. Still uncertain.
2021-12-02 33654, 2021
ruaok
Take the set functions for instance... They can take more than one input to combine data from multiple input streams.
2021-12-02 33633, 2021
ruaok
I'm going to try to combine mfccsw results with gfccsw results to see if there is any overlap.
2021-12-02 33629, 2021
alastairp
ruaok: cool, interesting first step
2021-12-02 33621, 2021
alastairp
you're right that it definitely needs another filtering step to pull together tracks that make sense
2021-12-02 33658, 2021
lucifer
ruaok: makes sense. thanks.
2021-12-02 33632, 2021
ruaok
alastairp: I was considering the typical test -- is this better than randomly picked tracks, but its clear that it is.
2021-12-02 33633, 2021
alastairp
it's interesting that there seems to be this rap/hiphop cluster in the mfccs one. so obviously there's some kind of similarity match going on there, but not exactly sure what - especially because of the others
so you can place things in 2-n dimensions instead of just 1
2021-12-02 33624, 2021
ruaok
interesting
2021-12-02 33632, 2021
alastairp
that is, is there a way of characterising this similarity in a way that makes it clearer _what_ is being made similar
2021-12-02 33604, 2021
alastairp
he's moved on to more detailed similarity (deep learning, again...), so I'm not sure how much of what he's doing is directly applicable to our data, but...
lucifer: I'm not very familiar with the LastFm importer code, not sure what's making multiple queries. Can you expand on that, or provide some logs?
2021-12-02 33639, 2021
monkey
Ah, it also helps if I read your question right. So 4 queries to the LB API per LFM page.
2021-12-02 33647, 2021
monkey
Let me look at the code to see how we chunk things
2021-12-02 33620, 2021
monkey
Hmm, not sure how it's making 4 requests, I don't see that in the code
2021-12-02 33625, 2021
lucifer
monkey: i closed the site so don't have logs currently. but looking at code, i think it was a false alarm. i don't think we chunk at all. 4 api queries were probably submit listens, submit ts, retrieve ts.
2021-12-02 33646, 2021
monkey
Ah yes, here it is. `MAX_LISTEN_SIZE`
2021-12-02 33634, 2021
lucifer
oh right, the chunking code is in APIService not in LastFMImporter.
