To be honest, that section really doesn't suggest to me that in order to be able to combine types, you *need* to use multiple or a nested array, nor that multiple means that it must have both unless you also add them separately :)
Mainly Norfolk restrict code can be used as an example of allowing one type or another.
2021-12-06 34052, 2021
yvanzo
(for "work" entity type)
2021-12-06 34004, 2021
lucifer
ruaok: monkey: alastairp: for adding recording mbid to feedback, i am thinking of adding recording mbid column to the table. make recording msid column nullable. support both recording msid and recording mbid in api for some months. then remove msid support from api and delete msid column. thoughts?
2021-12-06 34013, 2021
reosarevok
Oh, so adding more examples to the same original test ticket?
2021-12-06 34015, 2021
reosarevok
*PR
2021-12-06 34019, 2021
reosarevok
Sure, can look into it
2021-12-06 34033, 2021
yvanzo
Yes
2021-12-06 34050, 2021
CatQuest
ack, broken heart is fine for hate/dislike. it's really logial and works with the heart one logically
2021-12-06 34056, 2021
yvanzo
So we can test the tests with code that we think is working already :)
2021-12-06 34059, 2021
lucifer
for existing feedback, run a script to fetch mapped mbids and put in the table.
2021-12-06 34005, 2021
CatQuest
I will veto any vomit :grøss:
2021-12-06 34030, 2021
ruaok
lucifer: yes I've been thinking thar would be good.
2021-12-06 34034, 2021
reosarevok
I wouldn't necessarily veto it but it's a bit gross :)
2021-12-06 34039, 2021
reosarevok
yvanzo: on it
2021-12-06 34022, 2021
reosarevok
yvanzo: jamendo already does expected_relationship_type: ['downloadfree', 'streamingfree'], since there's just one allowed option
2021-12-06 34024, 2021
lucifer
ruaok: although that plan means unmapped listens can't be given feedback on. to keep feedback on unmapped listens we keep supporting msid forever.
2021-12-06 34058, 2021
lucifer
i guess that is fine but we'd need a way to update that table when new msids get mapped to recording mbids.
2021-12-06 34040, 2021
CatQuest
alastairp: don't forget to actually vote in the middle of all the tickets ;)
2021-12-06 34005, 2021
yvanzo
bitmap: Would it be helpful to parallelize json-dump on different servers to lower the load on aretha? Or would it be worse for completion time since it involves more networking?
2021-12-06 34018, 2021
yvanzo
reosarevok: yes
2021-12-06 34033, 2021
reosarevok
yvanzo: mainlynorfolk does expected_relationship_type: 'otherdatabases', to test the autoselect, but I guess that suggests we should actually allow both types of testing *in combination*
2021-12-06 34050, 2021
yvanzo
reosarevok: I mean, we can refer to it in code documentation of 'restrict'
2021-12-06 34006, 2021
reosarevok
Oh
2021-12-06 34022, 2021
reosarevok
Still, we have no way to test rn that norfolk allows both but autoselects one
2021-12-06 34057, 2021
yvanzo
Hmm…
2021-12-06 34036, 2021
reosarevok
So maybe these two shouldn't be either-or, but both be allowed :)
2021-12-06 34011, 2021
yvanzo
reosarevok: It seems that Mainly Norfolk code correctly allows either 'otherdatabases' or the combination of 'otherdatabases' and 'lyrics' for works.
2021-12-06 34033, 2021
reosarevok
Yes, it does, we just don't test it
2021-12-06 34029, 2021
yvanzo
Ok, would testing it in that PR help with testing the tests? :)
2021-12-06 34001, 2021
reosarevok
I think it would help make the tests more stable long-term in any case
2021-12-06 34004, 2021
reosarevok
I'm checking
2021-12-06 34016, 2021
bitmap
yvanzo: i'm sure it would help but it would take some time to parallelize it properly, I think, making sure everything gets synced to the same FTP dir. it adds more complexity so more places for things to go wrong
2021-12-06 34001, 2021
CatQuest
wth "mainly norfolk" ????
2021-12-06 34002, 2021
reosarevok
CatQuest: a folk website
2021-12-06 34023, 2021
CatQuest
uh folk in like about people? or uh genre
2021-12-06 34036, 2021
reosarevok
A website about mostly folk music we have in otherdbs
But that just failed because one sorted to 'string', ['string', 'string'] and the other to array then string
2021-12-06 34052, 2021
yvanzo Ok, I didn’t review the details of the tests, so
2021-12-06 34017, 2021
ruaok
monkey: last week we though of a mechanism by which we can make liking an now_listening track. I don't recall the details of how that was supposed to work. do you?
2021-12-06 34019, 2021
bitmap
i'm guessing it stringifies the arrays to string,string before comparing
2021-12-06 34024, 2021
yvanzo
it is likely it requires changes indeed.
2021-12-06 34041, 2021
ruaok
lucifer: monkey and I thought up an idea that seemed plausible last week.
2021-12-06 34058, 2021
reosarevok
bitmap: wouldn't then it always sort the same?
2021-12-06 34048, 2021
bitmap
yeah it should
2021-12-06 34006, 2021
bitmap
which ones are sorting different?
2021-12-06 34015, 2021
CatQuest
also plox someone explain what the definition and origin of moin is exactly
I haven’t received any mailed in reviews, so the people I have as up for reviews today are: bitmap, reosarevok, lucifer, akshat, ruaok, monkey, yvanzo, zas, alastairp, CatQuest, Freso – anyone else who may want to give review, let me know ASAP. :)
2021-12-06 34000, 2021
Freso
bitmap: Go!
2021-12-06 34007, 2021
bitmap
hi
2021-12-06 34029, 2021
bitmap
last week I did code review and finished converting most of the release editor .tt templates to JSX
2021-12-06 34049, 2021
bitmap
I still have to convert the actual events and actions to React though, which will take a while, so that when you click on stuff, stuff happens
Plus I helped alastairp a bit more with genre stuff
2021-12-06 34018, 2021
reosarevok
CatQuest: you?
2021-12-06 34027, 2021
CatQuest
Meow! `😺`
2021-12-06 34035, 2021
CatQuest has been afk
2021-12-06 34058, 2021
CatQuest
⛎
2021-12-06 34059, 2021
CatQuest
fin, go zas?
2021-12-06 34002, 2021
zas
Hey
2021-12-06 34022, 2021
zas
I upgraded discourse & grafana instances + usual system upgrades
2021-12-06 34049, 2021
zas
We also release Picard 2.7beta3, so I handled a bunch of post-releases bug reports & associated fixes
2021-12-06 34017, 2021
zas
We expect to release final version in 10 days or so
2021-12-06 34048, 2021
zas
apart that, I'm preparing a docker server configs patch to handle the deployment of new consul cluster
2021-12-06 34053, 2021
monkey
!m crew of the Enterprise
2021-12-06 34053, 2021
BrainzBot
You're doing good work, crew of the Enterprise!
2021-12-06 34002, 2021
zas
fin. lucifer ?
2021-12-06 34011, 2021
lucifer
hi all!
2021-12-06 34058, 2021
lucifer
i worked ahead on the pinned recordings api last week. reviewed troi and LB prs. worked on progressing the PR to replace username with user ids in LB.
2021-12-06 34013, 2021
Freso
(People still up: akshaaatt, ruaok, monkey, yvanzo, alastairp, Freso – anyone else who may want to give review, let me know ASAP. :))
2021-12-06 34035, 2021
lucifer
i also looked into the summit document and created the remaining tickets. all topics now have tickets! :D
2021-12-06 34045, 2021
alastairp
!m lucifer
2021-12-06 34045, 2021
BrainzBot
You're doing good work, lucifer!
2021-12-06 34048, 2021
ruaok
thank you!
2021-12-06 34048, 2021
CatQuest
!m lucifer
2021-12-06 34048, 2021
BrainzBot
You're doing good work, lucifer!
2021-12-06 34052, 2021
monkey
+1
2021-12-06 34006, 2021
lucifer
i also speant some time on BPM and AB stuff in the start of the last week.
2021-12-06 34014, 2021
CatQuest highfive with lucifer
2021-12-06 34016, 2021
lucifer
that's it for me. alastairp: next?
2021-12-06 34020, 2021
alastairp
hi
2021-12-06 34003, 2021
alastairp
I did more genre import stuff, thanks reosarevok for your detailed notes on what changes we should make to map more closely from these different sources to musicbrainz
2021-12-06 34044, 2021
alastairp
this is now ready to actually import - I'll speak with zas tomorrow about seeing if we can get some API limits raised in MB to perform the actual import, it'll still take 2-4 days to do anyway
2021-12-06 34058, 2021
alastairp
I also open a few LB PRs - fixed an issue with pinning recordings that monkey and I had spoken about the week before, and as a result of that opened a few more PRs to fix some small niggles that I found - improvements to test.sh and the listenbrain-mb release submitter
2021-12-06 34021, 2021
alastairp
I helped lucifer get up to speed with the open PR for LB-866, and tested some of the changes that he made
I helped someone with a broken spotify import (there was an error during an import so we had stopped), but that raised a few open questions about how we can improve the import and associated tools, so I opened LB-1026 and LB-1028
