had an interesting discussion with mayhem about future of AB/how we can make it more useful. some things to think about there, more news in the new year we hope
2021-12-13 34701, 2021
alastairp
on Friday I helped lucifer mitigate the log4j exploit in the MB search cluster
2021-12-13 34727, 2021
alastairp
2 days of holiday in spain last week, so I took some time off too
2021-12-13 34733, 2021
alastairp
fin. yvanzo?
2021-12-13 34737, 2021
yvanzo
Hi!
2021-12-13 34759, 2021
yvanzo
Also helped with mitigating CVE-2021-44228 in MB Solr on production and for mirrors.
2021-12-13 34712, 2021
yvanzo
Reviewed some MBS PRs.
2021-12-13 34722, 2021
yvanzo
Jira server update is still going on.
2021-12-13 34735, 2021
yvanzo
Fin. Go lucifer
2021-12-13 34739, 2021
lucifer
hi all!
2021-12-13 34744, 2021
Freso
(Still up for review: bitmap, akshaaatt, zas, monkey, Freso – anyone else who wants to give review, let me know ASAP.)
2021-12-13 34711, 2021
CatQuest waves
2021-12-13 34743, 2021
lucifer
last week, i had did some work on YI stuff to add total listen counts/listen count per day and top stats.
2021-12-13 34733, 2021
lucifer
helped in debugging some mapping edge cases (LEFT JOINs say hello), debugged listen counts issues (continues to be a pain)
2021-12-13 34716, 2021
lucifer
also helped in optimizing top missing tracks query and in the process discovered an awesome website for pg explains https://explain.depesz.com/
2021-12-13 34759, 2021
alastairp
oh no! have we not shown that page to you before? :(
2021-12-13 34732, 2021
mayhem
I had even forgotten about it
2021-12-13 34736, 2021
lucifer
towards the end of the week, the log4j RCE was disclosed. initially, we thought we were unaffected but in some time realised we run several Java based services. (SOLR, ES, Spark and JIRA). helped others with patching and investigating impact.
2021-12-13 34743, 2021
lucifer
that's it for me.
2021-12-13 34746, 2021
lucifer
bitmap: next?
2021-12-13 34751, 2021
bitmap
hey
2021-12-13 34701, 2021
lucifer
CatQuest: lol
2021-12-13 34716, 2021
bitmap
last week I worked on some functions/triggers for the *_tag_raw tables to keep the tag.ref_count and aggregate count columns in sync
2021-12-13 34742, 2021
alastairp
🎉
2021-12-13 34744, 2021
alastairp
thanks bitmap!
2021-12-13 34749, 2021
bitmap
those are pretty much done. I'm writing the upgrade script to fix the existing counts today and then I'll add some pgtap tests, hopefully.
2021-12-13 34725, 2021
bitmap
fyi tag.ref_count is a count of how many times the tag is references at all, but the aggregrate counts on e.g. artist_tag.count is a sum of the votes (downvotes being negative)
2021-12-13 34756, 2021
bitmap
other than that I worked a little bit more on React-ifying events/actions in the release editor
2021-12-13 34713, 2021
bitmap
fin. go monkey
2021-12-13 34714, 2021
alastairp
is a downvote a reference to a tag?
2021-12-13 34719, 2021
monkey
Hi everyone !
2021-12-13 34725, 2021
bitmap
alastairp: yes
2021-12-13 34750, 2021
CatQuest
alastairp: i also have thoguhts on that
2021-12-13 34752, 2021
monkey
The biggest chunk for me last week was continuing the year in music page, which is pretty close to finished now.
2021-12-13 34717, 2021
monkey
I also reviewed PRs on LB and BB, and continued finishing up some old PRs on LB
2021-12-13 34748, 2021
monkey
Helped new contributors with some local development issues, and helped them navigate the codebase, answered questions, etc.
2021-12-13 34756, 2021
monkey
In short, some new contributor onboarding
2021-12-13 34726, 2021
monkey
following the log4j report, I read some documentation for upgrading ElasticSearch. It's not currently vulnerable, but BB is using an old unsupported version that needs updating
2021-12-13 34745, 2021
monkey
That's it on my side,akshaaatt go !
2021-12-13 34751, 2021
akshaaatt
Hi everyone!
2021-12-13 34720, 2021
Freso
(Only zas and myself (Freso) left for reviews – last call for anyone else who wants to chime in!)
2021-12-13 34721, 2021
akshaaatt
Last week I resolved over a million Eslint issues in my MB PR which is good to be reviewed and finalized soon!
2021-12-13 34720, 2021
akshaaatt
Also, I read a few posts on the community forum that mb isn't showing up on Google searches, one reason being the mobile support and hence I'm pumped to get the revamp going on full throttle!
2021-12-13 34740, 2021
akshaaatt
I connected with aerozol a bit as he mtivated me to design even more mb pages!
2021-12-13 34711, 2021
akshaaatt
I'm badically going to refactor a lot of code this month across projects this month!
2021-12-13 34745, 2021
akshaaatt
Had some lb work going as well including year in music and cleanup stuff
2021-12-13 34758, 2021
akshaaatt
That's it for me. Go zas!
2021-12-13 34720, 2021
zas
Last week, I upgraded discourse (it fails, I had to fix it quickly)
2021-12-13 34756, 2021
zas
I also upgraded our grafana instances (security issue)
2021-12-13 34751, 2021
zas
I worked on Picard upcoming release, mainly French translation (a lot of strings to translate)
2021-12-13 34733, 2021
zas
plus usual stuff and help on LOG4J issue
2021-12-13 34738, 2021
zas
fin. Freso?
2021-12-13 34748, 2021
Freso
🙋
2021-12-13 34721, 2021
Freso
Editor we’ve been dealing with for the last few weeks popped up once, so spent some time looking for other activity from them.
2021-12-13 34730, 2021
Freso
Reviewed/feedbacked some PRs.
2021-12-13 34749, 2021
Freso
Dealt with some spam profiles on MB and forums.
2021-12-13 34700, 2021
Freso
Oh, and I helped mayhem get the "mayhem" nick on this network. :)
2021-12-13 34705, 2021
CatQuest
:D
2021-12-13 34706, 2021
Freso
I think that’s about it.
2021-12-13 34709, 2021
mayhem
thanks!
2021-12-13 34718, 2021
Freso
CatQuest: Are you around?
2021-12-13 34722, 2021
CatQuest
yes
2021-12-13 34732, 2021
Freso
cat: gravatar (MD5 adresses)
2021-12-13 34735, 2021
Freso
Go then. :)
2021-12-13 34740, 2021
CatQuest
ok so, recently chaban pointed out on MBS-9725 that the MD5 email address hashes were cracked
2021-12-13 34740, 2021
CatQuest
and I agree with them that it is about hightime we really remove gravatar.
I also know that it hasn't been done because a lot of other stuff needed doing anyway" (which is fine)
2021-12-13 34749, 2021
CatQuest
but now with this issue, maybe we should expedition the solution of MBS-9725 a bit?
2021-12-13 34744, 2021
CatQuest
yes?
2021-12-13 34753, 2021
mayhem
reosarevok: bitmap yvanzo : how much work is this?
2021-12-13 34756, 2021
bitmap
can we remove gravatar before adding the the discouse replacement?
2021-12-13 34700, 2021
bitmap
discourse*
2021-12-13 34701, 2021
CatQuest
hope so
2021-12-13 34722, 2021
bitmap
removing gravatar isn't a lot of work, so if we can do without avatars for a bit, let's do that
2021-12-13 34724, 2021
reosarevok
I think that'd be ok
2021-12-13 34739, 2021
CatQuest
yep
2021-12-13 34747, 2021
CatQuest
i have them turned off/blocked anyway
2021-12-13 34759, 2021
bitmap
I looked into syncing the discourse ones a while ago an it's not super trivial
2021-12-13 34702, 2021
Freso
So… I guess that’s decided?
2021-12-13 34709, 2021
Freso
Next topic?
2021-12-13 34718, 2021
yvanzo
yup
2021-12-13 34723, 2021
mayhem
who is going to do this work?
2021-12-13 34725, 2021
CatQuest
yay!
2021-12-13 34729, 2021
CatQuest
yea! who
2021-12-13 34740, 2021
bitmap
I'll submit a PR to remove gravatar today
2021-12-13 34748, 2021
CatQuest
<3 bitmap
2021-12-13 34752, 2021
mayhem
perfect, thanks.
2021-12-13 34700, 2021
Freso
👍
2021-12-13 34700, 2021
CatQuest agree
2021-12-13 34711, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MB team ignoring telegram (ruaok), upcoming meeting(s) (Freso)
2021-12-13 34717, 2021
Freso
ruaok: MB team ignoring telegram
2021-12-13 34720, 2021
Freso
mayhem: ^
2021-12-13 34731, 2021
CatQuest
oh no
2021-12-13 34753, 2021
mayhem
so, it happened again today. last time we left it at "we'll turn notifications back on", but that clearly didn't fix it.
2021-12-13 34707, 2021
mayhem
bitmap: how can we improve this?
2021-12-13 34715, 2021
bitmap
that's my fault... I have family visiting until thursday so my attention has been diverted for a bit
2021-12-13 34748, 2021
bitmap
well, I saw some notifications an hour ago but thought they might be due to the MBS release
2021-12-13 34752, 2021
mayhem
I think it might be time to setup time slices where certain team members are responsible for watching things/
2021-12-13 34730, 2021
yvanzo
I would do something if I knew what to do: for example, I react to SIR alerts.
2021-12-13 34750, 2021
mayhem
yvanzo: then its time for more cross training.
2021-12-13 34705, 2021
reosarevok
For this one, all I did once I noticed it is docker logs --tail 500 -f musicbrainz-website-prod in burnside
2021-12-13 34710, 2021
reosarevok
That made the issue obvious enough
2021-12-13 34717, 2021
mayhem
everyone on the team should have a basic idea on how to do diagnostics.
2021-12-13 34725, 2021
reosarevok
That said, if that had *not* made the issue obvious enough, I would have probably been kinda stuck
2021-12-13 34738, 2021
mayhem
and if someone doesn't know how, but sees the alerts, then this person should rouse others to help.
2021-12-13 34755, 2021
mayhem
but sitting by and doing nothing, simply isn't acceptable anymore.
2021-12-13 34715, 2021
mayhem
kinda stuck and paying attention to things is far far better than "not my problem".
2021-12-13 34729, 2021
mayhem
and not everything can be bitmap's problem. that isn't fair to bitmap.
2021-12-13 34743, 2021
yvanzo
This is not what happened, I didn’t think it was a big issue.
2021-12-13 34752, 2021
mayhem
so, I'm giving a concrete assignment to the three of you, yvanzo, bitmap and reosarevok.
2021-12-13 34716, 2021
mayhem
I want a plan for how this get improved. I want a plan to addresses who is responsible at a certain time of day and I want a cross training plan.
2021-12-13 34728, 2021
mayhem
this is due for the first meeting in the new year, ok?
2021-12-13 34750, 2021
bitmap
ok with me
2021-12-13 34758, 2021
mayhem
yvanzo? reosarevok ?
2021-12-13 34739, 2021
mayhem
please ack this assignment.
2021-12-13 34749, 2021
reosarevok
Sure I guess?
2021-12-13 34729, 2021
Freso
yvanzo: Ping?
2021-12-13 34739, 2021
reosarevok
I don't know what's the source of the being dickish about it instead of asking nicely way of dealing with it, but the request seems sensible enoug
2021-12-13 34743, 2021
reosarevok
*enough
2021-12-13 34745, 2021
reosarevok
So sure, whatever
2021-12-13 34751, 2021
yvanzo
thanks reosarevok
2021-12-13 34708, 2021
CatQuest
:/ pls no fighting :/
2021-12-13 34711, 2021
mayhem
I'm angry because this is the third time I've asked for a concrete plan, but I keep getting blown off.
2021-12-13 34737, 2021
mayhem
yvanzo?
2021-12-13 34701, 2021
reosarevok
IIRC you just asked us to not ignore the alerts, not for a specific plan :) But anyway, not against a specific plan
2021-12-13 34710, 2021
yvanzo
Yes, and improving alerts was part of the plan. Anyhow, I want to improve the current situation.
2021-12-13 34719, 2021
mayhem
thank you.
2021-12-13 34727, 2021
mayhem
Freso: lets figure out meetings then./.
2021-12-13 34734, 2021
Freso
Alright… and speaking of next meeting!
2021-12-13 34742, 2021
Freso
Or first meeting in next year, rather.
2021-12-13 34744, 2021
Freso
Freso: upcoming meeting(s)
2021-12-13 34724, 2021
CatQuest
personally I'm happy if the next meeting is cancelled
2021-12-13 34746, 2021
Freso
So. Next Monday is a few days before Christmas, after that is between Christmas and New Year’s, and then after that is just after New Year’s. Any of these we want to cancel? (I assume the one on the 27th is off, we usually don’t do the Monday in between Christmas and NY.)
2021-12-13 34757, 2021
reosarevok
I'm semi-away Dec 20 to Jan 12 but I guess I can be around for at least meetings (and probably discussion of stuff like the alerts thing)
2021-12-13 34757, 2021
mayhem
I'll be flying for the next meeting.
2021-12-13 34759, 2021
Freso
But do we want the 20th and/or the 3rd off as well?
2021-12-13 34711, 2021
CatQuest
kinda wanna be afk for atleast before new years
2021-12-13 34713, 2021
alastairp
I don't be back until the 10th. I don't have a problem having a meething next week
2021-12-13 34718, 2021
alastairp
*I won't be back
2021-12-13 34720, 2021
reosarevok
20th I'm traveling, I should be done by meeting time, but :) not sure
2021-12-13 34739, 2021
CatQuest wil lbe afk
2021-12-13 34757, 2021
mayhem
lets cancel both, so that the MB team has another week for the deadline.
2021-12-13 34759, 2021
Freso
I’m personally leaning towards calling off the next three Mondays. Have a bit more of a relaxed Holiday Season and have time to recover for those doing things on/around Christmas and NY. :)
2021-12-13 34709, 2021
CatQuest
+1 to that
2021-12-13 34718, 2021
Freso
So next meeting will be January 10th!
2021-12-13 34722, 2021
monkey
Same as Alastair, I'm here for next meeting but away until the 9th.
