The two topics at hand: in my feed page, I want to hide other people's recommendations for example, and have that saved in some way so that if i refresh the page they're still hidden
2022-03-11 07054, 2022
alastairp
hmm. monkey, I was thinking about generic user preferences a few weeks ago
2022-03-11 07001, 2022
alastairp
might be time to bring something like that in
2022-03-11 07016, 2022
alastairp
(instead of always adding another column to the user table)
2022-03-11 07017, 2022
monkey
second topic: on my listens page, if I "delete" a listen it will be hidden on the page, but if I refresh the page it'll be showing again.
2022-03-11 07042, 2022
monkey
alastairp: Definitely skirting around the same topic
2022-03-11 07014, 2022
mayhem
alastairp: if you'd like to expand on the scope of the idea, feel free to edit the desc.
2022-03-11 07021, 2022
lucifer
for 1) do we want the ability for a user to show hidden event again?
2022-03-11 07035, 2022
alastairp
👍
2022-03-11 07031, 2022
monkey
I think so lucifer
2022-03-11 07046, 2022
lucifer
i see. to confirm i understand the issue correctly, this is like: someone recommended a track and i don't want to see it my feed but only the recommender can delete a recommendation and that too for all so we need a hide button.
2022-03-11 07011, 2022
monkey
Correct
2022-03-11 07025, 2022
lucifer
👍
2022-03-11 07043, 2022
CatQuest
[11:36] <mayhem> two weeks past, two weeks into the future.
2022-03-11 07043, 2022
CatQuest
honestly I'd let people be able to set the time themselves. personally I don't really apy attention (and lots don't :D) so they might miss this, esp if they don't "follow" a lot of artists, thy might not check often, and if they *do* a lot of artists, things might be lost in the swarm
2022-03-11 07043, 2022
CatQuest
else i'd leave atleast a couple of months
2022-03-11 07008, 2022
lucifer
i think we may need to do some backend redesign to support such events.
2022-03-11 07029, 2022
monkey
Yeah, so storing that on the front-end might be the simple option here
2022-03-11 07057, 2022
monkey
And has the benefit of working for listens pending deletion too
2022-03-11 07003, 2022
riksucks
yes, but suppose I login from phone, then it won't be hidden
2022-03-11 07007, 2022
lucifer
the device issue still remains then :/.
2022-03-11 07055, 2022
monkey
True. I don't know if that's a major problem, but it's not ideal
2022-03-11 07006, 2022
riksucks
+1
2022-03-11 07007, 2022
lucifer
for feed events, i think that's a bigger issue because those events are persistent. deleted listens are going to go away in ~1hr so we could probably get away with it.
2022-03-11 07055, 2022
riksucks
I think we need a backend for this
2022-03-11 07056, 2022
CatQuest
honeslt I'd actually have no deadline on it, just show a time line, and show the upcombingmost and latestmost near your *now* and you'll scroll in either direction get further and further "back" or "future"
2022-03-11 07048, 2022
CatQuest
with some fancy jss/css gadgjet
2022-03-11 07007, 2022
lucifer
yeah, i am fine with adding a LB site only endpoint for this. (site only because in the longer run we may want to rearchitect this in case feed page gains more traction)
2022-03-11 07016, 2022
monkey
The drawback of a backend solution is that the way we store event scurrently doesn't allow to store userx X wants to hide event created by user Y
2022-03-11 07042, 2022
lucifer
yeah we'll need to add a table for that.
2022-03-11 07048, 2022
CatQuest
tch
2022-03-11 07014, 2022
lucifer
should be doable though and happy to help adding that.
2022-03-11 07019, 2022
monkey
Then again it's not the end of the world, and it does mean we have long term storage
2022-03-11 07031, 2022
lucifer
alastairp, mayhem: thoughts?
2022-03-11 07012, 2022
riksucks
also I wanted to ask something, what if, I hid a listen that no longer exists
2022-03-11 07030, 2022
riksucks
we need to run some sort of checks time to time, to clean stale data from the hiding listens table
2022-03-11 07036, 2022
monkey
And so then when user load their feed page, we also pass in the page props the list of events they chose to hide? Or do we add that metadata to the feed event json?
2022-03-11 07016, 2022
lucifer
we could do filtering backend side. only send events that are not hidden to frontend
2022-03-11 07034, 2022
monkey
riksucks: You mean hiding a feed event that then gets deleted? I think that's a non issue, the event just won't be on the feed page anywhere
2022-03-11 07055, 2022
mayhem
lucifer: seems good to me.
2022-03-11 07056, 2022
monkey
lucifer: But then how do I unhide it? :p
2022-03-11 07013, 2022
lucifer
oh yeah :/
2022-03-11 07014, 2022
mayhem
lucifer: are you on support@ ? There is a very odd email that just arrived.
2022-03-11 07017, 2022
riksucks
true, but there would be junk in the databse right?
2022-03-11 07028, 2022
alastairp
riksucks: that would be easy to clean up from time to time
2022-03-11 07028, 2022
SothoTalKer joined the channel
2022-03-11 07031, 2022
monkey
Very minimal, I'd wager
2022-03-11 07045, 2022
riksucks
I see alastairp, so some sort of cron job?
2022-03-11 07055, 2022
monkey
But you could indeed clean up when an event gets deleted
2022-03-11 07056, 2022
alastairp
monkey: is this hiding specific events, or all types of events from a user? ("block")
2022-03-11 07002, 2022
lucifer
mayhem: nope. you can add me there or forward the mail?
2022-03-11 07005, 2022
monkey
Specific events
2022-03-11 07010, 2022
alastairp
mmm
2022-03-11 07012, 2022
mayhem
the latter is done, former is coming
2022-03-11 07020, 2022
lucifer
👍
2022-03-11 07033, 2022
riksucks
monkey: yes, when listens are deleted, we can run check
2022-03-11 07047, 2022
lucifer
monkey, then we can pass to frontend in props/api and let frontend handle it.
2022-03-11 07049, 2022
monkey
feed events or listens?
2022-03-11 07059, 2022
lucifer
both.
2022-03-11 07006, 2022
monkey
Sorry, that was for riksucks :p
2022-03-11 07013, 2022
lucifer
ah ok.
2022-03-11 07020, 2022
mayhem
lucifer: added you. have fun reading that. :)
2022-03-11 07033, 2022
lucifer
lol looking
2022-03-11 07035, 2022
mayhem
if you respond to a user, make sure to copy support@ so we know the issue is resolved.
2022-03-11 07038, 2022
alastairp
I wonder if a user wants to hide an event, if they're even interested in getting it back in the future
2022-03-11 07040, 2022
monkey
Agreed lucifer, we can either send a separate list of hidden events, or zip that metadata to the list of events
2022-03-11 07004, 2022
alastairp
monkey: ^ or I was just about to also say "and n other hidden events", that you can expand if you want
2022-03-11 07024, 2022
riksucks
monkey: afaik, the listens that appear in feed aren't stored in the db as events, the backend just finds listens that should appear in feed and passes it to the client.
2022-03-11 07030, 2022
monkey
alastairp: A good question. That being said, I'm in favor of giving more flexibility
2022-03-11 07048, 2022
riksucks
so when a listen is deleted, we can run a check to see if some user has hidden it or not, and delete those entries
2022-03-11 07016, 2022
monkey
Right, gotcha.
2022-03-11 07047, 2022
riksucks
alastairp: we were going for a reddit/hackernews style hide button
2022-03-11 07028, 2022
monkey
To be honest, for now I would simply not worry about hiding *listens* in the feed page. We might ultimately not show random listensin the feed page in the future
2022-03-11 07057, 2022
riksucks
I see
2022-03-11 07013, 2022
monkey
Since they are pretty transient (reload the page 10 minutes later, get another set of listens) it shouldn't be a big worry
2022-03-11 07036, 2022
monkey
the feed events on the other hand are there to stay on the feed page
2022-03-11 07008, 2022
Dijia joined the channel
2022-03-11 07011, 2022
riksucks
right
2022-03-11 07014, 2022
riksucks
also lucifer monkey , sorry for digressing, but I wanted to ask something. I was looking at GSoC ideas list, and saw the project involving sending a user personal recommendation. The description said that backend would be done by someone from metabrainz to give the project short. Can it be made a long project, because I might want to do full stacks here.
2022-03-11 07020, 2022
monkey
I see no issue with that personally (but I also won't be mentoring anything back-end related on LB)
2022-03-11 07024, 2022
lucifer
sure i guess we could do that.
2022-03-11 07052, 2022
monkey
It's always nice to see extra motivation to do more :)
2022-03-11 07015, 2022
lucifer
i or mayhem can mentor the backend stuff as needed/availability.
2022-03-11 07045, 2022
lucifer
(depending on what other projects we get)
2022-03-11 07047, 2022
mayhem
yes, sounds great. you've already got a feature under your belt, so that is promising.
2022-03-11 07012, 2022
riksucks
:D
2022-03-11 07024, 2022
agatzk has quit
2022-03-11 07057, 2022
riksucks
also mayhem, I wanted to ask something. Do you remember the typesense idea in the missing mb page I once mentioned here?
2022-03-11 07005, 2022
monkey
OK, so to sum up I think we've agreed that we'll be storing hidden feed events and pending-deletion listens on the database rather than the front-end.
2022-03-11 07020, 2022
riksucks
yes
2022-03-11 07027, 2022
monkey
We'll probably still want to store some user preferences in the browser, but that's for another day
2022-03-11 07036, 2022
mayhem
riksucks: remind me.
2022-03-11 07037, 2022
monkey
Great 👍
2022-03-11 07045, 2022
mayhem isn't so hot on typesense anymore
2022-03-11 07045, 2022
agatzk joined the channel
2022-03-11 07051, 2022
mayhem
I only have love for postgres.
2022-03-11 07044, 2022
riksucks
mayhem: so basically there were false positives in the missing mb page. There were songs that were already part of mb but we thought that they weren't. So I had suggested that we could have a typesense searchbox where users can search up the song that already exists
2022-03-11 07052, 2022
mayhem
yes, we can do that. it may not be backed by typesense much longer, but we need a general point where we can look up these tracks. it is one of the many projects I'm currently examining and hope to work on in the coming week.
2022-03-11 07003, 2022
riksucks
I see. I had some mock ups in mind for the missing mb page, for reporting false positives. If you want, I can show you soon
2022-03-11 07011, 2022
mayhem
sure.
2022-03-11 07050, 2022
mayhem
there is also a bug report from a user who has found serious problems in adding tracks to playlists, so I think it is important that we get this endpoint right, since it will serve at least 3 different features.
2022-03-11 07016, 2022
CatQuest
tch
2022-03-11 07025, 2022
lucifer
mayhem: did you see the new recs with rank 120?
2022-03-11 07025, 2022
Dijia
Hi there! Sorry for the interruption but just making a short self-introduction.
2022-03-11 07025, 2022
Dijia
I'm Dijia, now a master student of UCL. My major is integrated machine learning systems.
2022-03-11 07025, 2022
Dijia
I'm a fun of music. I like playing musical instruments like guitar and keyboards.
2022-03-11 07025, 2022
Dijia
I'm good at python and machine learning but now I hope to do something different.
2022-03-11 07025, 2022
Dijia
I'm now learning React by myself and hope to try some front-end tasks.
2022-03-11 07026, 2022
Dijia
I'm interested in gsoc tasks of ListenBrainz (as some of them may use both python and react). Hope to contribute to it!
2022-03-11 07059, 2022
mayhem
UCL, london?
2022-03-11 07004, 2022
Dijia
Yes!
2022-03-11 07005, 2022
mayhem
hia Dijia
2022-03-11 07010, 2022
mayhem
ok, cool.
2022-03-11 07016, 2022
lucifer
hi Dijia, welcome!
2022-03-11 07028, 2022
mayhem
which task in particular? I added a pile new ones.
2022-03-11 07029, 2022
monkey
Welcome Dijia !
2022-03-11 07056, 2022
Dijia
I'm interested on the "new releases page" one and "Integrate more music services" one.
So if we're introducing ourselves, I'm finishing high school right before GSoC start, so I'll have plenty of free time. I mostly write Python and am interested in solving the single instance problem of Picard :) I've already assigned a simple task to myself to better understand the code. Hope I'll have both fun and decent experiences, and that our cooperation will be nice. Simply -- hi :>
hi skelly37. zas and outsidecontext would be the people who you should engage with
2022-03-11 07019, 2022
skelly37
I've talked a bit with outsidecontext on the tickets page so I think they aknowledged my existence hah
2022-03-11 07031, 2022
zas
Hey skelly37
2022-03-11 07018, 2022
Dijia
Thank you mayhem fot rhw website! I use spotify in UK. And when I'm in China (my home), I mainly use QQ music.
2022-03-11 07021, 2022
zas
outsidecontext: what about organizing a small meeting to discuss this matter with skelly37 ? In which timezone are you skelly37 ?
2022-03-11 07025, 2022
Dijia
'the'
2022-03-11 07012, 2022
skelly37 has quit
2022-03-11 07023, 2022
skelly37 joined the channel
2022-03-11 07035, 2022
monkey
lucifer: Quick feedback without much context: recs pages don't look all that different for me. Top Artists is still 96% a single band, Similar artists is pretty similar result as before (also feels like a lot of the same bands)
2022-03-11 07048, 2022
skelly37
zas: I live in Poland, currently it's 12:43PM
2022-03-11 07012, 2022
atj
ideal timezone then :)
2022-03-11 07021, 2022
mayhem
yep, lots of us in that timezone.
2022-03-11 07025, 2022
mayhem
or close to it.
2022-03-11 07000, 2022
mayhem
Dijia: I think our goal would be to implement apple music next.
2022-03-11 07013, 2022
mayhem
do you have a mac/iphone?
2022-03-11 07018, 2022
Dijia
Yes!
2022-03-11 07022, 2022
skelly37
fantastic :) Also, we're going to switch from UTC +1 to UTC +2 in a few weeks but it's still a small difference, I guess.
2022-03-11 07025, 2022
atj
and a strong will to live?
2022-03-11 07035, 2022
mayhem
lolol, atj
2022-03-11 07056, 2022
mayhem
Dijia: then that could work, if you're so inclined. we're very much looking forward to having more music services supported.
2022-03-11 07010, 2022
mayhem
ok, running off for some lunch. bbiab!
2022-03-11 07011, 2022
atj
Apple is transitioning from iTunes purchase/download model to Apple Music streaming model at present
2022-03-11 07016, 2022
lucifer
monkey: yeah results have been more or less same for me as well. my top artists tracks are more diverse than yours (have been so most ranks though i thikn).
2022-03-11 07041, 2022
atj
lots of issues being reported with iTunes APIs
2022-03-11 07010, 2022
monkey
Just to clarify, I'm not complaining at all, just one more user's worth of feedback on the different runs :)
