#metabrainz

/

      • Shubh joined the channel
      • 2022-05-19 13901, 2022

      • darkstardevx joined the channel
      • 2022-05-19 13906, 2022

      • darkstardevx has quit
      • 2022-05-19 13931, 2022

      • darkstardevx joined the channel
      • 2022-05-19 13951, 2022

      • Shubh has quit
      • 2022-05-19 13914, 2022

      • Shubh joined the channel
      • 2022-05-19 13917, 2022

      • odnes joined the channel
      • 2022-05-19 13915, 2022

      • yvanzo
        O’Moin
      • 2022-05-19 13907, 2022

      • yvanzo
        recordings indexed, restart processing queued messages now
      • 2022-05-19 13913, 2022

      • zas
        mooin
      • 2022-05-19 13948, 2022

      • zas
        yvanzo: what was needed from me? I saw few pings, but I was afk for a while
      • 2022-05-19 13905, 2022

      • zas
        do you still need /ws/2/recordings to 503?
      • 2022-05-19 13924, 2022

      • yvanzo
        hi zas: not anymore
      • 2022-05-19 13936, 2022

      • yvanzo
        however, it seems something is amiss with cover art
      • 2022-05-19 13958, 2022

      • zas
        is this the DNS change to point coverartarchive.org back to gateways?
      • 2022-05-19 13929, 2022

      • yvanzo
        possibly
      • 2022-05-19 13947, 2022

      • yvanzo
        zas: "prod.caa-redirect" has been readded to consul config
      • 2022-05-19 13921, 2022

      • yvanzo
        on Monday
      • 2022-05-19 13938, 2022

      • MRiddickW joined the channel
      • 2022-05-19 13950, 2022

      • Goldmaster61 has quit
      • 2022-05-19 13904, 2022

      • Goldmaster61 joined the channel
      • 2022-05-19 13955, 2022

      • Shubh has quit
      • 2022-05-19 13920, 2022

      • Shubh joined the channel
      • 2022-05-19 13936, 2022

      • chinmay joined the channel
      • 2022-05-19 13933, 2022

      • skelly37 joined the channel
      • 2022-05-19 13935, 2022

      • alastairp
        tandy1000: yes! recommended albums + some fun way of filtering like huesound would be great
      • 2022-05-19 13903, 2022

      • alastairp
        good morning everyone
      • 2022-05-19 13934, 2022

      • lucifer
        morning!
      • 2022-05-19 13937, 2022

      • akshaaatt
        moin!
      • 2022-05-19 13916, 2022

      • alastairp books tickets to Prague
      • 2022-05-19 13910, 2022

      • mayhem
        alastairp: beer trip?
      • 2022-05-19 13916, 2022

      • mayhem
        I got a beer place rec for ya.
      • 2022-05-19 13923, 2022

      • alastairp
        conference / holiday / beer
      • 2022-05-19 13943, 2022

      • mayhem
        very nice.
      • 2022-05-19 13903, 2022

      • alastairp
        even nicer when the grant pays for the flights ;)
      • 2022-05-19 13913, 2022

      • mayhem
        monkey: when I brought my desktop machine out of sleep, the metadata viewer updated to show my now listening.
      • 2022-05-19 13918, 2022

      • mayhem
        that is freaking great. :)
      • 2022-05-19 13929, 2022

      • monkey
        Ah, good :)
      • 2022-05-19 13941, 2022

      • monkey
        Good to know the websocket connection/reconnection works well
      • 2022-05-19 13910, 2022

      • mayhem
        it does. quite happy about that.
      • 2022-05-19 13901, 2022

      • akshaaatt
        reosarevok: do we have a doc/readme as to how tests are written for musicbrainz?
      • 2022-05-19 13911, 2022

      • reosarevok
        There's maybe a bit in HACKING.md
      • 2022-05-19 13954, 2022

      • CatQuest
        just as long as it's not in SLASHING.md
      • 2022-05-19 13932, 2022

      • akshaaatt
        resoarevok I'm still unable to fix https://ci.metabrainz.org/job/musicbrainz-server/…
      • 2022-05-19 13938, 2022

      • akshaaatt
        I'm not quite sure as to how these tests work. Are there any resources available talking about how to understand the process?
      • 2022-05-19 13918, 2022

      • akshaaatt
        aerozol did we come up with a final conclusion for https://github.com/metabrainz/design-system/pull/… ?
      • 2022-05-19 13927, 2022

      • alastairp spies 2022-05-018 sample dump
      • 2022-05-19 13934, 2022

      • alastairp
        thanks bitmap, reosarevok, and yvanzo
      • 2022-05-19 13959, 2022

      • yvanzo
        search indexer now processes upcoming updates normally, it still has to retry 70k updates sidelined during the recording reindex.
      • 2022-05-19 13927, 2022

      • alastairp
        yvanzo: did it manage to finish recording index?
      • 2022-05-19 13918, 2022

      • yvanzo
        yes
      • 2022-05-19 13901, 2022

      • reosarevok
        akshaaatt: selenium is magic. I'm on holidayish until next week, but maybe yvanzo or bitmap can help
      • 2022-05-19 13925, 2022

      • reosarevok
        Given it's open ac related, probably bitmap :)
      • 2022-05-19 13951, 2022

      • akshaaatt
        Hahaha. Calling it magic in a positive term or considering it as an oracle?
      • 2022-05-19 13902, 2022

      • akshaaatt
        bitmap it is then!
      • 2022-05-19 13913, 2022

      • alastairp
        great news
      • 2022-05-19 13938, 2022

      • akshaaatt
        You guys do deserve a break btw. Congrats on the schema change bitmap, reosarevok, yvanzo!
      • 2022-05-19 13953, 2022

      • yvanzo
        I’m still not to the level of Selenium tests.
      • 2022-05-19 13924, 2022

      • akshaaatt
        I'm in no hurry btw. Already got a lot to work on. Feel free to setup a week or two for me where we can review and merge the revamp PRs
      • 2022-05-19 13954, 2022

      • yvanzo
        bitmap, reosarevok: I will be half-off too once the search indexes have been fully restored.
      • 2022-05-19 13917, 2022

      • mayhem
        monkey: is being able to tag a release from the metadata viewer on your radar? It seems we can tag a track, but not a release.
      • 2022-05-19 13958, 2022

      • monkey
        There are currently no tags returned for releases in the metadata, but it would be easy to add if we get that piece of data
      • 2022-05-19 13921, 2022

      • alastairp
        but do you mean to submit a tag to MB, or show them?
      • 2022-05-19 13932, 2022

      • mayhem
        both, ideally.
      • 2022-05-19 13944, 2022

      • monkey
      • 2022-05-19 13959, 2022

      • mayhem
        I believe you. :)
      • 2022-05-19 13920, 2022

      • mayhem asks himself why this wasn't included in the first place.
      • 2022-05-19 13928, 2022

      • monkey
        And we did talk about it a month or so ago :)
      • 2022-05-19 13953, 2022

      • monkey
        I've also got to add the API query to get more release info
      • 2022-05-19 13903, 2022

      • mayhem
        sorry, my brain has been impacted for a couple of months now. hopefully digging out now.
      • 2022-05-19 13906, 2022

      • monkey
        Because that panel is too empty for my taste at the moment
      • 2022-05-19 13924, 2022

      • monkey
        No worries, I've had a mushy brain myself
      • 2022-05-19 13930, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1993 (03master…futures-fix): Fix threading issues in MBIDMappingWriter https://github.com/metabrainz/listenbrainz-server…
      • 2022-05-19 13910, 2022

      • MRiddickW has quit
      • 2022-05-19 13919, 2022

      • mayhem
        done. :) lol.
      • 2022-05-19 13921, 2022

      • Etua joined the channel
      • 2022-05-19 13959, 2022

      • lucifer
        mayhem: what do you think of rechecking incoming listens if their msids are unmatched and were last checked over X days ago (2 weeks?) ?
      • 2022-05-19 13932, 2022

      • mayhem
        yes, I'd love to have that happen.
      • 2022-05-19 13939, 2022

      • mayhem
        the devil is in the details, really.
      • 2022-05-19 13944, 2022

      • alastairp
        if there is available time in the mapper then that sounds nice
      • 2022-05-19 13953, 2022

      • lucifer
        cool, will add it then.
      • 2022-05-19 13900, 2022

      • mayhem
        given that we have threads that fire off periodically, how would you do that, lucifer ?
      • 2022-05-19 13904, 2022

      • mayhem
        lets discuss a plan for that.
      • 2022-05-19 13921, 2022

      • lucifer
        mayhem, i'd do it in the incoming thread.
      • 2022-05-19 13946, 2022

      • mayhem
        elaborate, please.
      • 2022-05-19 13956, 2022

      • lucifer
        sure one sec
      • 2022-05-19 13902, 2022

      • lucifer
        we have this check: https://github.com/metabrainz/listenbrainz-server… . i want to modify it to compare last_updated with NOW() and recheck those as well.
      • 2022-05-19 13911, 2022

      • lucifer
        WHERE recording_msid IN :msids AND (last_updated != '1970-01-01' OR (NOW() - last_updated > INTERVAL '2 weeks' AND match_type = 'no_match'))
      • 2022-05-19 13955, 2022

      • lucifer
        alternatively we could invalidate the msids matching ` last_updated > INTERVAL '2 weeks' AND match_type = 'no_match')` and wait for the legacy thread to pick those up
      • 2022-05-19 13925, 2022

      • mayhem
        huh, your first idea is very clever.
      • 2022-05-19 13935, 2022

      • mayhem
        so your idea would re-check if an unmatched listen comes in again. but it would never match if that is never listened to again.
      • 2022-05-19 13958, 2022

      • lucifer
        yes that is the case i currently aim at solving.
      • 2022-05-19 13931, 2022

      • mayhem
        I think that is a simple fix for a lot of listens that don;t get rechecked. lets do that for sure.
      • 2022-05-19 13933, 2022

      • lucifer
        if noone listened again, that is a case that'd need to be solved separately.
      • 2022-05-19 13939, 2022

      • lucifer
        makes sense
      • 2022-05-19 13944, 2022

      • mayhem
        agreed. lets do that.
      • 2022-05-19 13903, 2022

      • mayhem
        I think the second idea is one we should pursue as well, but that isn't as pressing.
      • 2022-05-19 13904, 2022

      • lucifer
        👍
      • 2022-05-19 13939, 2022

      • Etua has quit
      • 2022-05-19 13920, 2022

      • chinmay has quit
      • 2022-05-19 13911, 2022

      • akshaaatt
        Hi monkey! Thanks for your review on the PR I had requested :)
      • 2022-05-19 13957, 2022

      • akshaaatt
        Regarding the updates, I'm hoping we'll fix the CSS including changes like hover color, width of the items etc in another PR once we have the base ready
      • 2022-05-19 13931, 2022

      • monkey
        Yeah, that sounds good. I just wanted to put it on our radar, but it doesn't seem to be the right PR for this
      • 2022-05-19 13935, 2022

      • akshaaatt
        My major aim is to completely get rid of the custom CSS and then target global variables/theme to work on that
      • 2022-05-19 13944, 2022

      • akshaaatt
        Yes, lovely review!
      • 2022-05-19 13925, 2022

      • monkey
        Gotta be somewhat careful about css variables though, it's not supported everywhere: https://caniuse.com/?search=css%20variables
      • 2022-05-19 13941, 2022

      • monkey
        We might need to have some fallback css for older borwsers
      • 2022-05-19 13953, 2022

      • akshaaatt
        Interesting!
      • 2022-05-19 13955, 2022

      • akshaaatt
        Makes sense
      • 2022-05-19 13901, 2022

      • akshaaatt
        Thanks for the heads up
      • 2022-05-19 13918, 2022

      • akshaaatt
        So, what do we consider the status of the PR, is it ready to be merged?
      • 2022-05-19 13911, 2022

      • monkey
        There are some items in my reveiw that need to be modified in this PR (and I just added another comment: the navbar doesn't collapse in small sizes)
      • 2022-05-19 13933, 2022

      • akshaaatt
        Yusss just saw that
      • 2022-05-19 13939, 2022

      • akshaaatt
        Onto it then! Thank you!
      • 2022-05-19 13935, 2022

      • monkey
        My pleasure !
      • 2022-05-19 13900, 2022

      • monkey
        Good work :)
      • 2022-05-19 13916, 2022

      • atj
        akshaaatt: I noted that the README file for the docker dashboard is the index page on GitHub pages. What's the URL for the actual dashboard?
      • 2022-05-19 13937, 2022

      • akshaaatt
      • 2022-05-19 13956, 2022

      • akshaaatt
        Anytime we make updates to the repo, it will automatically be updated
      • 2022-05-19 13903, 2022

      • atj
        OK, thanks
      • 2022-05-19 13908, 2022

      • atj
        can you install the Datatables plugins?
      • 2022-05-19 13918, 2022

      • akshaaatt
        Yaass suree
      • 2022-05-19 13952, 2022

      • atj
        we'll have to get some consensus about paging, I just disabled it because I think most people will want to be filtering the entire list
      • 2022-05-19 13924, 2022

      • akshaaatt
        Makes sense
      • 2022-05-19 13944, 2022

      • akshaaatt
        For reference btw atj, https://github.com/metabrainz/docker-container-da… is where our actual code lies. Feel free to check it out and let me know what should be done. We'll mostly finalize the UI for this page by tomorrow and look to make an endpoint for serving the json
      • 2022-05-19 13916, 2022

      • akshaaatt
        Your script would be handy for the api
      • 2022-05-19 13956, 2022

      • BrainzGit
        [musicbrainz-docker] 14yvanzo opened pull request #229 (03master…mbvm-85-renaming): MBVM-85: Rename "slave" to "mirror" https://github.com/metabrainz/musicbrainz-docker/…
      • 2022-05-19 13955, 2022

      • Shubh has quit
      • 2022-05-19 13924, 2022

      • mayhem
        among my BS tasks for the day: full out our insurance renewal.
      • 2022-05-19 13934, 2022

      • mayhem
        we're weird. very weird. even on paper we're weird.
      • 2022-05-19 13936, 2022

      • mayhem
      • 2022-05-19 13959, 2022

      • mayhem
        no employees, 12 contractors, 25k volunteers.
      • 2022-05-19 13943, 2022

      • akshaaatt
        😂😂😂😂😂😂
      • 2022-05-19 13927, 2022

      • akshaaatt
        Well, ideal open-source environment!
      • 2022-05-19 13958, 2022

      • mayhem
      • 2022-05-19 13939, 2022

      • yvanzo
        dumping search update messages as 50k have still not been processed
      • 2022-05-19 13929, 2022

      • yvanzo
        now re-queuing
      • 2022-05-19 13936, 2022

      • mayhem
        WTF does insurance ask about cars?
      • 2022-05-19 13954, 2022

      • mayhem
        reosarevok has a car as Zas does. not sure about anyone else. what does it matter?
      • 2022-05-19 13910, 2022

      • skelly37 has quit
      • 2022-05-19 13950, 2022

      • reosarevok
        Well, officially the car is my wife's, but :D
      • 2022-05-19 13904, 2022

      • yvanzo
        isn't it just about professional car, rather than personal car?
      • 2022-05-19 13941, 2022

      • mayhem
        it included mentions of personal cars, but it might only be in context of employees not contractors.
      • 2022-05-19 13951, 2022

      • mayhem
        it has no relevance for us.
      • 2022-05-19 13902, 2022

      • yvanzo nods
      • 2022-05-19 13902, 2022

      • yvanzo
        nobody uses a personal car in the context of work afaik, even when BCNers go to the office it's not by car
      • 2022-05-19 13917, 2022

      • mayhem
        exactly.
      • 2022-05-19 13950, 2022

      • mayhem
        there are almost no parking spots between my hour and the office. a car would be a nightmare!
      • 2022-05-19 13916, 2022

      • mayhem
      • 2022-05-19 13901, 2022

      • monkey
        mayhem: Looking much better with more release data (PR soon): https://usercontent.irccloud-cdn.com/file/h7HVoaQ…