0:34 AM
Shubh joined the channel
2022-05-19 13901, 2022
2:22 AM
darkstardevx joined the channel
2022-05-19 13906, 2022
2:23 AM
darkstardevx has quit
2022-05-19 13931, 2022
2:23 AM
darkstardevx joined the channel
2022-05-19 13951, 2022
3:43 AM
Shubh has quit
2022-05-19 13914, 2022
5:06 AM
Shubh joined the channel
2022-05-19 13917, 2022
6:45 AM
odnes joined the channel
2022-05-19 13915, 2022
7:09 AM
yvanzo
O’Moin
2022-05-19 13907, 2022
7:10 AM
yvanzo
recordings indexed, restart processing queued messages now
2022-05-19 13913, 2022
7:10 AM
zas
mooin
2022-05-19 13948, 2022
7:10 AM
zas
yvanzo: what was needed from me? I saw few pings, but I was afk for a while
2022-05-19 13905, 2022
7:11 AM
zas
do you still need /ws/2/recordings to 503?
2022-05-19 13924, 2022
7:11 AM
yvanzo
hi zas: not anymore
2022-05-19 13936, 2022
7:11 AM
yvanzo
however, it seems something is amiss with cover art
2022-05-19 13958, 2022
7:11 AM
zas
2022-05-19 13929, 2022
7:16 AM
yvanzo
possibly
2022-05-19 13947, 2022
7:18 AM
yvanzo
zas: "prod.caa-redirect" has been readded to consul config
2022-05-19 13921, 2022
7:19 AM
yvanzo
on Monday
2022-05-19 13938, 2022
8:11 AM
MRiddickW joined the channel
2022-05-19 13950, 2022
8:13 AM
Goldmaster61 has quit
2022-05-19 13904, 2022
8:14 AM
Goldmaster61 joined the channel
2022-05-19 13955, 2022
8:15 AM
Shubh has quit
2022-05-19 13920, 2022
8:35 AM
Shubh joined the channel
2022-05-19 13936, 2022
8:45 AM
chinmay joined the channel
2022-05-19 13933, 2022
8:48 AM
skelly37 joined the channel
2022-05-19 13935, 2022
9:10 AM
alastairp
tandy1000: yes! recommended albums + some fun way of filtering like huesound would be great
2022-05-19 13903, 2022
9:14 AM
alastairp
good morning everyone
2022-05-19 13934, 2022
9:15 AM
lucifer
morning!
2022-05-19 13937, 2022
9:23 AM
akshaaatt
moin!
2022-05-19 13916, 2022
9:24 AM
alastairp books tickets to Prague
2022-05-19 13910, 2022
9:29 AM
mayhem
alastairp: beer trip?
2022-05-19 13916, 2022
9:29 AM
mayhem
I got a beer place rec for ya.
2022-05-19 13923, 2022
9:29 AM
alastairp
conference / holiday / beer
2022-05-19 13943, 2022
9:29 AM
mayhem
very nice.
2022-05-19 13903, 2022
9:30 AM
alastairp
even nicer when the grant pays for the flights ;)
2022-05-19 13913, 2022
9:30 AM
mayhem
monkey: when I brought my desktop machine out of sleep, the metadata viewer updated to show my now listening.
2022-05-19 13918, 2022
9:30 AM
mayhem
that is freaking great. :)
2022-05-19 13929, 2022
9:30 AM
monkey
Ah, good :)
2022-05-19 13941, 2022
9:30 AM
monkey
Good to know the websocket connection/reconnection works well
2022-05-19 13910, 2022
9:31 AM
mayhem
it does. quite happy about that.
2022-05-19 13901, 2022
9:33 AM
akshaaatt
reosarevok: do we have a doc/readme as to how tests are written for musicbrainz?
2022-05-19 13911, 2022
9:38 AM
reosarevok
There's maybe a bit in HACKING.md
2022-05-19 13954, 2022
9:38 AM
CatQuest
just as long as it's not in SLASHING.md
2022-05-19 13932, 2022
9:39 AM
akshaaatt
2022-05-19 13938, 2022
9:40 AM
akshaaatt
I'm not quite sure as to how these tests work. Are there any resources available talking about how to understand the process?
2022-05-19 13918, 2022
9:48 AM
akshaaatt
2022-05-19 13927, 2022
9:48 AM
alastairp spies 2022-05-018 sample dump
2022-05-19 13934, 2022
9:48 AM
alastairp
thanks bitmap, reosarevok, and yvanzo
2022-05-19 13959, 2022
9:53 AM
yvanzo
search indexer now processes upcoming updates normally, it still has to retry 70k updates sidelined during the recording reindex.
2022-05-19 13927, 2022
9:55 AM
alastairp
yvanzo: did it manage to finish recording index?
2022-05-19 13918, 2022
9:56 AM
yvanzo
yes
2022-05-19 13901, 2022
9:57 AM
reosarevok
akshaaatt: selenium is magic. I'm on holidayish until next week, but maybe yvanzo or bitmap can help
2022-05-19 13925, 2022
9:58 AM
reosarevok
Given it's open ac related, probably bitmap :)
2022-05-19 13951, 2022
9:58 AM
akshaaatt
Hahaha. Calling it magic in a positive term or considering it as an oracle?
2022-05-19 13902, 2022
9:59 AM
akshaaatt
bitmap it is then!
2022-05-19 13913, 2022
9:59 AM
alastairp
great news
2022-05-19 13938, 2022
9:59 AM
akshaaatt
You guys do deserve a break btw. Congrats on the schema change bitmap, reosarevok, yvanzo!
2022-05-19 13953, 2022
9:59 AM
yvanzo
I’m still not to the level of Selenium tests.
2022-05-19 13924, 2022
10:00 AM
akshaaatt
I'm in no hurry btw. Already got a lot to work on. Feel free to setup a week or two for me where we can review and merge the revamp PRs
2022-05-19 13954, 2022
10:01 AM
yvanzo
bitmap, reosarevok: I will be half-off too once the search indexes have been fully restored.
2022-05-19 13917, 2022
10:03 AM
mayhem
monkey: is being able to tag a release from the metadata viewer on your radar? It seems we can tag a track, but not a release.
2022-05-19 13958, 2022
10:03 AM
monkey
There are currently no tags returned for releases in the metadata, but it would be easy to add if we get that piece of data
2022-05-19 13921, 2022
10:04 AM
alastairp
but do you mean to submit a tag to MB, or show them?
2022-05-19 13932, 2022
10:04 AM
mayhem
both, ideally.
2022-05-19 13944, 2022
10:04 AM
monkey
2022-05-19 13959, 2022
10:04 AM
mayhem
I believe you. :)
2022-05-19 13920, 2022
10:07 AM
mayhem asks himself why this wasn't included in the first place.
2022-05-19 13928, 2022
10:09 AM
monkey
And we did talk about it a month or so ago :)
2022-05-19 13953, 2022
10:09 AM
monkey
I've also got to add the API query to get more release info
2022-05-19 13903, 2022
10:10 AM
mayhem
sorry, my brain has been impacted for a couple of months now. hopefully digging out now.
2022-05-19 13906, 2022
10:10 AM
monkey
Because that panel is too empty for my taste at the moment
2022-05-19 13924, 2022
10:10 AM
monkey
No worries, I've had a mushy brain myself
2022-05-19 13930, 2022
10:13 AM
BrainzGit
2022-05-19 13910, 2022
10:17 AM
MRiddickW has quit
2022-05-19 13919, 2022
10:21 AM
mayhem
done. :) lol.
2022-05-19 13921, 2022
10:22 AM
Etua joined the channel
2022-05-19 13959, 2022
10:23 AM
lucifer
mayhem: what do you think of rechecking incoming listens if their msids are unmatched and were last checked over X days ago (2 weeks?) ?
2022-05-19 13932, 2022
10:25 AM
mayhem
yes, I'd love to have that happen.
2022-05-19 13939, 2022
10:25 AM
mayhem
the devil is in the details, really.
2022-05-19 13944, 2022
10:25 AM
alastairp
if there is available time in the mapper then that sounds nice
2022-05-19 13953, 2022
10:25 AM
lucifer
cool, will add it then.
2022-05-19 13900, 2022
10:26 AM
mayhem
given that we have threads that fire off periodically, how would you do that, lucifer ?
2022-05-19 13904, 2022
10:26 AM
mayhem
lets discuss a plan for that.
2022-05-19 13921, 2022
10:26 AM
lucifer
mayhem, i'd do it in the incoming thread.
2022-05-19 13946, 2022
10:26 AM
mayhem
elaborate, please.
2022-05-19 13956, 2022
10:26 AM
lucifer
sure one sec
2022-05-19 13902, 2022
10:28 AM
lucifer
2022-05-19 13911, 2022
10:29 AM
lucifer
WHERE recording_msid IN :msids AND (last_updated != '1970-01-01' OR (NOW() - last_updated > INTERVAL '2 weeks' AND match_type = 'no_match'))
2022-05-19 13955, 2022
10:29 AM
lucifer
alternatively we could invalidate the msids matching ` last_updated > INTERVAL '2 weeks' AND match_type = 'no_match')` and wait for the legacy thread to pick those up
2022-05-19 13925, 2022
10:30 AM
mayhem
huh, your first idea is very clever.
2022-05-19 13935, 2022
10:31 AM
mayhem
so your idea would re-check if an unmatched listen comes in again. but it would never match if that is never listened to again.
2022-05-19 13958, 2022
10:32 AM
lucifer
yes that is the case i currently aim at solving.
2022-05-19 13931, 2022
10:33 AM
mayhem
I think that is a simple fix for a lot of listens that don;t get rechecked. lets do that for sure.
2022-05-19 13933, 2022
10:33 AM
lucifer
if noone listened again, that is a case that'd need to be solved separately.
2022-05-19 13939, 2022
10:33 AM
lucifer
makes sense
2022-05-19 13944, 2022
10:33 AM
mayhem
agreed. lets do that.
2022-05-19 13903, 2022
10:34 AM
mayhem
I think the second idea is one we should pursue as well, but that isn't as pressing.
2022-05-19 13904, 2022
10:34 AM
lucifer
👍
2022-05-19 13939, 2022
10:52 AM
Etua has quit
2022-05-19 13920, 2022
10:55 AM
chinmay has quit
2022-05-19 13911, 2022
11:02 AM
akshaaatt
Hi monkey! Thanks for your review on the PR I had requested :)
2022-05-19 13957, 2022
11:02 AM
akshaaatt
Regarding the updates, I'm hoping we'll fix the CSS including changes like hover color, width of the items etc in another PR once we have the base ready
2022-05-19 13931, 2022
11:03 AM
monkey
Yeah, that sounds good. I just wanted to put it on our radar, but it doesn't seem to be the right PR for this
2022-05-19 13935, 2022
11:03 AM
akshaaatt
My major aim is to completely get rid of the custom CSS and then target global variables/theme to work on that
2022-05-19 13944, 2022
11:03 AM
akshaaatt
Yes, lovely review!
2022-05-19 13925, 2022
11:04 AM
monkey
2022-05-19 13941, 2022
11:04 AM
monkey
We might need to have some fallback css for older borwsers
2022-05-19 13953, 2022
11:04 AM
akshaaatt
Interesting!
2022-05-19 13955, 2022
11:04 AM
akshaaatt
Makes sense
2022-05-19 13901, 2022
11:05 AM
akshaaatt
Thanks for the heads up
2022-05-19 13918, 2022
11:05 AM
akshaaatt
So, what do we consider the status of the PR, is it ready to be merged?
2022-05-19 13911, 2022
11:06 AM
monkey
There are some items in my reveiw that need to be modified in this PR (and I just added another comment: the navbar doesn't collapse in small sizes)
2022-05-19 13933, 2022
11:06 AM
akshaaatt
Yusss just saw that
2022-05-19 13939, 2022
11:06 AM
akshaaatt
Onto it then! Thank you!
2022-05-19 13935, 2022
11:07 AM
monkey
My pleasure !
2022-05-19 13900, 2022
11:08 AM
monkey
Good work :)
2022-05-19 13916, 2022
11:10 AM
atj
akshaaatt: I noted that the README file for the docker dashboard is the index page on GitHub pages. What's the URL for the actual dashboard?
2022-05-19 13937, 2022
11:12 AM
akshaaatt
2022-05-19 13956, 2022
11:12 AM
akshaaatt
Anytime we make updates to the repo, it will automatically be updated
2022-05-19 13903, 2022
11:13 AM
atj
OK, thanks
2022-05-19 13908, 2022
11:13 AM
atj
can you install the Datatables plugins?
2022-05-19 13918, 2022
11:13 AM
akshaaatt
Yaass suree
2022-05-19 13952, 2022
11:13 AM
atj
we'll have to get some consensus about paging, I just disabled it because I think most people will want to be filtering the entire list
2022-05-19 13924, 2022
11:14 AM
akshaaatt
Makes sense
2022-05-19 13944, 2022
11:20 AM
akshaaatt
For reference btw atj,
https://github.com/metabrainz/docker-container-da… is where our actual code lies. Feel free to check it out and let me know what should be done. We'll mostly finalize the UI for this page by tomorrow and look to make an endpoint for serving the json
2022-05-19 13916, 2022
11:21 AM
akshaaatt
Your script would be handy for the api
2022-05-19 13956, 2022
11:26 AM
BrainzGit
2022-05-19 13955, 2022
11:35 AM
Shubh has quit
2022-05-19 13924, 2022
12:21 PM
mayhem
among my BS tasks for the day: full out our insurance renewal.
2022-05-19 13934, 2022
12:21 PM
mayhem
we're weird. very weird. even on paper we're weird.
2022-05-19 13936, 2022
12:21 PM
mayhem
2022-05-19 13959, 2022
12:21 PM
mayhem
no employees, 12 contractors, 25k volunteers.
2022-05-19 13943, 2022
12:22 PM
akshaaatt
😂😂😂😂😂😂
2022-05-19 13927, 2022
12:23 PM
akshaaatt
Well, ideal open-source environment!
2022-05-19 13958, 2022
12:28 PM
mayhem
2022-05-19 13939, 2022
12:32 PM
yvanzo
dumping search update messages as 50k have still not been processed
2022-05-19 13929, 2022
12:36 PM
yvanzo
now re-queuing
2022-05-19 13936, 2022
12:39 PM
mayhem
WTF does insurance ask about cars?
2022-05-19 13954, 2022
12:39 PM
mayhem
reosarevok has a car as Zas does. not sure about anyone else. what does it matter?
2022-05-19 13910, 2022
12:46 PM
skelly37 has quit
2022-05-19 13950, 2022
12:50 PM
reosarevok
Well, officially the car is my wife's, but :D
2022-05-19 13904, 2022
12:51 PM
yvanzo
isn't it just about professional car, rather than personal car?
2022-05-19 13941, 2022
12:51 PM
mayhem
it included mentions of personal cars, but it might only be in context of employees not contractors.
2022-05-19 13951, 2022
12:51 PM
mayhem
it has no relevance for us.
2022-05-19 13902, 2022
12:52 PM
yvanzo nods
2022-05-19 13902, 2022
12:54 PM
yvanzo
nobody uses a personal car in the context of work afaik, even when BCNers go to the office it's not by car
2022-05-19 13917, 2022
12:54 PM
mayhem
exactly.
2022-05-19 13950, 2022
12:54 PM
mayhem
there are almost no parking spots between my hour and the office. a car would be a nightmare!
2022-05-19 13916, 2022
12:59 PM
mayhem
2022-05-19 13901, 2022
13:00 PM
monkey
