#metabrainz

O’Moin

recordings indexed, restart processing queued messages now

mooin

yvanzo: what was needed from me? I saw few pings, but I was afk for a while

do you still need /ws/2/recordings to 503?

hi zas: not anymore

however, it seems something is amiss with cover art

is this the DNS change to point coverartarchive.org back to gateways?

possibly

zas: "prod.caa-redirect" has been readded to consul config

on Monday

tandy1000: yes! recommended albums + some fun way of filtering like huesound would be great

good morning everyone

morning!

moin!

alastairp: beer trip?

I got a beer place rec for ya.

conference / holiday / beer

very nice.

even nicer when the grant pays for the flights ;)

monkey: when I brought my desktop machine out of sleep, the metadata viewer updated to show my now listening.

that is freaking great. :)

Ah, good :)

Good to know the websocket connection/reconnection works well

it does. quite happy about that.

reosarevok: do we have a doc/readme as to how tests are written for musicbrainz?

There's maybe a bit in HACKING.md

just as long as it's not in SLASHING.md

resoarevok I'm still unable to fix https://ci.metabrainz.org/job/musicbrainz-serve...

I'm not quite sure as to how these tests work. Are there any resources available talking about how to understand the process?

aerozol did we come up with a final conclusion for https://github.com/metabrainz/design-system/pul... ?

thanks bitmap, reosarevok, and yvanzo

search indexer now processes upcoming updates normally, it still has to retry 70k updates sidelined during the recording reindex.

yvanzo: did it manage to finish recording index?

yes

akshaaatt: selenium is magic. I'm on holidayish until next week, but maybe yvanzo or bitmap can help

Given it's open ac related, probably bitmap :)

Hahaha. Calling it magic in a positive term or considering it as an oracle?

bitmap it is then!

great news

You guys do deserve a break btw. Congrats on the schema change bitmap, reosarevok, yvanzo!

I’m still not to the level of Selenium tests.

I'm in no hurry btw. Already got a lot to work on. Feel free to setup a week or two for me where we can review and merge the revamp PRs

monkey: is being able to tag a release from the metadata viewer on your radar? It seems we can tag a track, but not a release.

There are currently no tags returned for releases in the metadata, but it would be easy to add if we get that piece of data

but do you mean to submit a tag to MB, or show them?

both, ideally.

See https://api.listenbrainz.org/1/metadata/lookup/...

I believe you. :)

And we did talk about it a month or so ago :)

I've also got to add the API query to get more release info

sorry, my brain has been impacted for a couple of months now. hopefully digging out now.

Because that panel is too empty for my taste at the moment

No worries, I've had a mushy brain myself

[listenbrainz-server] 14amCap1712 merged pull request #1993 (03master…futures-fix): Fix threading issues in MBIDMappingWriter https://github.com/metabrainz/listenbrainz-serv...

done. :) lol.

mayhem: what do you think of rechecking incoming listens if their msids are unmatched and were last checked over X days ago (2 weeks?) ?

yes, I'd love to have that happen.

the devil is in the details, really.

if there is available time in the mapper then that sounds nice

cool, will add it then.

given that we have threads that fire off periodically, how would you do that, lucifer ?

lets discuss a plan for that.

mayhem, i'd do it in the incoming thread.

elaborate, please.

sure one sec

we have this check: https://github.com/metabrainz/listenbrainz-serv... . i want to modify it to compare last_updated with NOW() and recheck those as well.

WHERE recording_msid IN :msids AND (last_updated != '1970-01-01' OR (NOW() - last_updated > INTERVAL '2 weeks' AND match_type = 'no_match'))

alternatively we could invalidate the msids matching ` last_updated > INTERVAL '2 weeks' AND match_type = 'no_match')` and wait for the legacy thread to pick those up

huh, your first idea is very clever.

so your idea would re-check if an unmatched listen comes in again. but it would never match if that is never listened to again.

yes that is the case i currently aim at solving.

I think that is a simple fix for a lot of listens that don;t get rechecked. lets do that for sure.

if noone listened again, that is a case that'd need to be solved separately.

makes sense

agreed. lets do that.

I think the second idea is one we should pursue as well, but that isn't as pressing.

👍

Hi monkey! Thanks for your review on the PR I had requested :)

Regarding the updates, I'm hoping we'll fix the CSS including changes like hover color, width of the items etc in another PR once we have the base ready

Yeah, that sounds good. I just wanted to put it on our radar, but it doesn't seem to be the right PR for this

My major aim is to completely get rid of the custom CSS and then target global variables/theme to work on that

Yes, lovely review!

Gotta be somewhat careful about css variables though, it's not supported everywhere: https://caniuse.com/?search=css%20variables

We might need to have some fallback css for older borwsers

Interesting!

Makes sense

Thanks for the heads up

So, what do we consider the status of the PR, is it ready to be merged?

There are some items in my reveiw that need to be modified in this PR (and I just added another comment: the navbar doesn't collapse in small sizes)

Yusss just saw that

Onto it then! Thank you!

My pleasure !

Good work :)

akshaaatt: I noted that the README file for the docker dashboard is the index page on GitHub pages. What's the URL for the actual dashboard?

https://metabrainz.github.io/docker-container-d... is the dashboard atj

Anytime we make updates to the repo, it will automatically be updated

OK, thanks

can you install the Datatables plugins?

Yaass suree

we'll have to get some consensus about paging, I just disabled it because I think most people will want to be filtering the entire list

Makes sense

For reference btw atj, https://github.com/metabrainz/docker-container-... is where our actual code lies. Feel free to check it out and let me know what should be done. We'll mostly finalize the UI for this page by tomorrow and look to make an endpoint for serving the json

Your script would be handy for the api

[musicbrainz-docker] 14yvanzo opened pull request #229 (03master…mbvm-85-renaming): MBVM-85: Rename "slave" to "mirror" https://github.com/metabrainz/musicbrainz-docke...

among my BS tasks for the day: full out our insurance renewal.

we're weird. very weird. even on paper we're weird.

no employees, 12 contractors, 25k volunteers.

😂😂😂😂😂😂

Well, ideal open-source environment!

dumping search update messages as 50k have still not been processed

now re-queuing

WTF does insurance ask about cars?

reosarevok has a car as Zas does. not sure about anyone else. what does it matter?

Well, officially the car is my wife's, but :D

isn't it just about professional car, rather than personal car?

it included mentions of personal cars, but it might only be in context of employees not contractors.

it has no relevance for us.

nobody uses a personal car in the context of work afaik, even when BCNers go to the office it's not by car

exactly.

there are almost no parking spots between my hour and the office. a car would be a nightmare!

mayhem: Looking much better with more release data (PR soon): https://usercontent.irccloud-cdn.com/file/h7HVo...