#metabrainz

[listenbrainz-server] 14amCap1712 merged pull request #2017 (03master…listen-count-fe-bug): Fix extraneous 0 in listen count card https://github.com/metabrainz/listenbrainz-serv...

if the place has no concerts, it might switch to the festival tab. but then if someone adds a concert then refreshing the same page will show the concerts tab

so I wanted to add something that would be explicit to say "we're actually showing a different tab to the default"

in this case, it means that no parameter always means the concerts tab (or a redirect)

yes, it's a bit inefficient, because we gather all of the information for the page and then redirect (so another request, another set of queries, etc), but for the size of the site this is OK

Understood

there are definitely other ways of doing it. If we had more javascript in the frontend we could automatically add the query parameter to the URL on the client side

a slightly more efficient way would be to check related events at the beginning of the view and redirect before we do too many DB queries

bitmap: you broke perl again now https://github.com/metabrainz/musicbrainz-serve...

huh. looks like some kind of internal error with chrome remote debugging

I'll try running them again

reosarevok: would it be possible to rebase https://github.com/metabrainz/musicbrainz-serve... ? (I see it's based on two prs, maybe merging the react-annotations one first would make it easier)

Yes, that was the plan, to rebase once those are merged

[sir] 14amCap1712 opened pull request #134 (03master…demock): Fix mocking of entity.build_entity_query https://github.com/metabrainz/sir/pull/134

[critiquebrainz] 14alastair opened pull request #430 (03master…place-part-of-parts): Show both forward and backward place-place rels (Parts and Part of) https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] 14alastair opened pull request #431 (03master…api-default-sort): CB-429: API: Default sort by published_on desc if no sort params provided https://github.com/metabrainz/critiquebrainz/pu...

[musicbrainz-server] 14mwiencek merged pull request #2544 (03master…react-18): Update react, react-dom to v18 https://github.com/metabrainz/musicbrainz-serve...

yvanzo: test is now passing in CI as well. i'll cleanup the PR and add more tests.