hi lucifer, monkey. While coding the backend of personal recommendation feature, I was wondering, that it would be nice for this type of event to be hide-able. What do you guys think? It goes with the idea I think
atj
zas: the zombie processes on herb are ssh, some have been around since April? seems odd
akshaaatt: the fact you don't even have any output from the action makes me think there is something wrong with the configuration
akshaaatt
Makes sense atj
atj
I suggest you disable eslint temporarily, and also disable autofix
akshaaatt
Right
atj
I've no idea if that will help but actions are very opaque
akshaaatt
Yuss
atj
I added a comment with some suggestions
as I said, no idea if it will help, but without any output from the action you're just going to have to guess
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MeB infrastructure - part 5 (atj)
> Adding this delete code to general playlist create method feels wrong. Can we do this elsewhere? Probably just before troi runs in the spark handler or maybe with a --delete-existing flag in troi itself?
my main goal is to have this run as part of the transaction for creating the new playlist.
I could move the code to a separate function and call it from the create playlist function. does that feel better?
lucifer
i see, in that case its fine i think. let's add a comment to spark handler running troi that there is this code in create playlist.
mayhem
let me at least move it to a separate function, I think that will make it more palatable.
lucifer
yes sounds good.
monkey
I don't think so atj, but it should ignore file extensions it doesn't support
But we have tables for all combinations, just in case
lucifer
ah i see. makes sense
i was confused why that table was empty and only later saw place.area column.
reosarevok
For example, you could have a building that is, dunno, the embassy of Germany in France, and then the are would be in France and there could be a relationship to Germany
We probably won't add that, but :)
s/the are/the area/
lucifer
yes makes sense
akshaaatt
atj Thanks for the help! All works well now! :)
monkey Seems like we can only configure one directory for eslint but in our case we have 2. Any thoughts?
monkey
Did you look into ho too do this in the eslintrc file?
Hi yellowhatpro! I'm looking to do an android release next week. Have you made any progress on the CB integration? If yes, we can include that. Looking to add some work before we make a release so just wanted to inform you.
Rotab has quit
Rotab joined the channel
Lucasz10 joined the channel
Lucasz10
I've been making a web-app with the last.fm api, and it only shows track MBID's and not release MBID's.
Is there any way I can make an api call to musicbrainz/coverartarchive with the track MBID to get the cover art of a release?
mayhem
monkey: lolol, I actually like pepinos. its zas who doesn't like them.\
keep in mind that there's not a 1-1 relationship between recordings and releases - there could be many different releases for that recording (singles, official releases, compilations, reissues)
We can merge that and then you can adapt them to support gids, or the other way around :) Just let me know
yellowhatpro
Hello akshaaatt I am done with a basic setup with chips of different entities to choose from and show reviews accordingly,
currently I am stuck on a problem I am facing. It seems cb api returns id of the title and not the title, so I need to perform a lookup on that before.
I will try to find a solution soon, and I hope we will be able to do the release on time.
Lucasz10 has quit
Sophist-UK has quit
Sophist-UK joined the channel
reosarevok
yvanzo: hmm, actually, adding recording + rg to the AC breaks your AC merging test. Is that expected?
akshaaatt
I can help you with it if you make a PR for it yellowhatpro
