#metabrainz

/

      • KevlarNoir joined the channel
      • 2022-05-27 14747, 2022

      • yuzie has quit
      • 2022-05-27 14732, 2022

      • MRiddickW joined the channel
      • 2022-05-27 14742, 2022

      • antlarr has quit
      • 2022-05-27 14753, 2022

      • antlarr joined the channel
      • 2022-05-27 14735, 2022

      • MRiddickW has quit
      • 2022-05-27 14738, 2022

      • Lotheric has quit
      • 2022-05-27 14701, 2022

      • Lotheric joined the channel
      • 2022-05-27 14732, 2022

      • Zhele has quit
      • 2022-05-27 14753, 2022

      • Zhele joined the channel
      • 2022-05-27 14733, 2022

      • BrainzGit
        [bookbrainz-site] 14tr1ten opened pull request #848 (03master…multiple-publishers): Feat(edition): Allow multiple publishers for a single edition https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-05-27 14744, 2022

      • wargreen has quit
      • 2022-05-27 14754, 2022

      • reosarevok
        !m lucifer
      • 2022-05-27 14754, 2022

      • BrainzBot
        You're doing good work, lucifer!
      • 2022-05-27 14749, 2022

      • Etua has quit
      • 2022-05-27 14712, 2022

      • hackerman5 joined the channel
      • 2022-05-27 14747, 2022

      • hackerman has quit
      • 2022-05-27 14747, 2022

      • hackerman5 is now known as hackerman
      • 2022-05-27 14724, 2022

      • riksucks
        hi lucifer, monkey. While coding the backend of personal recommendation feature, I was wondering, that it would be nice for this type of event to be hide-able. What do you guys think? It goes with the idea I think
      • 2022-05-27 14750, 2022

      • atj
        zas: the zombie processes on herb are ssh, some have been around since April? seems odd
      • 2022-05-27 14741, 2022

      • atj
        oh, they are spawned by gitzconsul
      • 2022-05-27 14759, 2022

      • atj
        I guess it isn't handling SIGCHLD properly
      • 2022-05-27 14713, 2022

      • lucifer
        riksucks: yes makes sense.
      • 2022-05-27 14738, 2022

      • lucifer
        reosarevok: is there any sql file for testing events? couldn't find one here https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14746, 2022

      • MRiddickW joined the channel
      • 2022-05-27 14743, 2022

      • reosarevok
        lucifer: https://docs.google.com/document/d/1e2Cer4Wq2xjC1… says Missing: "Controller::Event (does not exist as a folder at all)"
      • 2022-05-27 14745, 2022

      • reosarevok
        So, probably not
      • 2022-05-27 14748, 2022

      • reosarevok
        But we should make one
      • 2022-05-27 14715, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2521 (03master…MBS-12212): MBS-12212: Add filtering to artists' events tab https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14729, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2535 (03master…MBS-12385): MBS-12385: Add report for digital releases with mail order rels https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14743, 2022

      • lucifer
        reosarevok: i see, i'll try to make a small one then. (for sir indexing tests)
      • 2022-05-27 14710, 2022

      • hackerman6 joined the channel
      • 2022-05-27 14735, 2022

      • hackerman has quit
      • 2022-05-27 14735, 2022

      • hackerman6 is now known as hackerman
      • 2022-05-27 14703, 2022

      • hackerman8 joined the channel
      • 2022-05-27 14710, 2022

      • reosarevok
        If you do, I can also reuse it for MB maybe and add a few tests of our own :)
      • 2022-05-27 14714, 2022

      • hackerman has quit
      • 2022-05-27 14749, 2022

      • hackerman joined the channel
      • 2022-05-27 14704, 2022

      • hackerman8 has quit
      • 2022-05-27 14723, 2022

      • akshaaatt
        Hi monkey! I have made the required changes to https://github.com/metabrainz/design-system/pull/… but the workflow still doesn't complete
      • 2022-05-27 14744, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2517 (03master…MBS-12347): MBS-12347: Also show RG artist in autocomplete if type is null https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14737, 2022

      • atj
        akshaaatt: the fact you don't even have any output from the action makes me think there is something wrong with the configuration
      • 2022-05-27 14712, 2022

      • akshaaatt
        Makes sense atj
      • 2022-05-27 14717, 2022

      • atj
        I suggest you disable eslint temporarily, and also disable autofix
      • 2022-05-27 14731, 2022

      • akshaaatt
        Right
      • 2022-05-27 14745, 2022

      • atj
        I've no idea if that will help but actions are very opaque
      • 2022-05-27 14746, 2022

      • akshaaatt
        Yuss
      • 2022-05-27 14733, 2022

      • atj
        I added a comment with some suggestions
      • 2022-05-27 14700, 2022

      • atj
        as I said, no idea if it will help, but without any output from the action you're just going to have to guess
      • 2022-05-27 14703, 2022

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MeB infrastructure - part 5 (atj)
      • 2022-05-27 14726, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2520 (03master…MBS-8875): MBS-8875: Improve CatNoLooksLikeASIN regexp https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14713, 2022

      • zas
        atj: yes, it happens sometimes when there are issues connecting to github, I just restarted the container, it should fix zombies
      • 2022-05-27 14759, 2022

      • akshaaatt
        We did get an output this time atj!
      • 2022-05-27 14715, 2022

      • monkey
        akshaaatt: you fixed the command in package.json but that is not the one being run by the workflow
      • 2022-05-27 14729, 2022

      • akshaaatt
        Yeah I was just checking that monkey
      • 2022-05-27 14752, 2022

      • monkey
        So you'll need a way to configure the action to ignore or include folders, perhaps in the eslintrc file
      • 2022-05-27 14759, 2022

      • akshaaatt
        Perhaps `eslint_dir` needs to be specified
      • 2022-05-27 14708, 2022

      • monkey
        Either that or options passed to the actio.s
      • 2022-05-27 14733, 2022

      • akshaaatt
      • 2022-05-27 14723, 2022

      • monkey
        Maybe more eslint_args ./components ./stories
      • 2022-05-27 14731, 2022

      • monkey
        If that works
      • 2022-05-27 14734, 2022

      • atj
        is prettier meant to lint markdown?
      • 2022-05-27 14711, 2022

      • mayhem
        lucifer: ping
      • 2022-05-27 14719, 2022

      • lucifer
        pong
      • 2022-05-27 14740, 2022

      • mayhem
        > Adding this delete code to general playlist create method feels wrong. Can we do this elsewhere? Probably just before troi runs in the spark handler or maybe with a --delete-existing flag in troi itself?
      • 2022-05-27 14756, 2022

      • mayhem
        my main goal is to have this run as part of the transaction for creating the new playlist.
      • 2022-05-27 14711, 2022

      • mayhem
        I could move the code to a separate function and call it from the create playlist function. does that feel better?
      • 2022-05-27 14701, 2022

      • lucifer
        i see, in that case its fine i think. let's add a comment to spark handler running troi that there is this code in create playlist.
      • 2022-05-27 14739, 2022

      • mayhem
        let me at least move it to a separate function, I think that will make it more palatable.
      • 2022-05-27 14757, 2022

      • lucifer
        yes sounds good.
      • 2022-05-27 14701, 2022

      • monkey
        I don't think so atj, but it should ignore file extensions it doesn't support
      • 2022-05-27 14700, 2022

      • atj
      • 2022-05-27 14742, 2022

      • monkey
        Colour me surprised
      • 2022-05-27 14748, 2022

      • atj
        in my userscripts repo I have this in package.json for prettier:format "prettier --write \"{,**/}*.{js,json,md}\""
      • 2022-05-27 14754, 2022

      • Sophist-UK joined the channel
      • 2022-05-27 14727, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2519 (03master…MBS-11694): MBS-11694: Cleanup /intent/user Twitter URLs https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14725, 2022

      • lucifer
        reosarevok: what is l_area_place table used for? since there is already a place.area column
      • 2022-05-27 14735, 2022

      • MRiddickW has quit
      • 2022-05-27 14749, 2022

      • reosarevok
      • 2022-05-27 14702, 2022

      • reosarevok
        But we have tables for all combinations, just in case
      • 2022-05-27 14712, 2022

      • lucifer
        ah i see. makes sense
      • 2022-05-27 14734, 2022

      • lucifer
        i was confused why that table was empty and only later saw place.area column.
      • 2022-05-27 14746, 2022

      • reosarevok
        For example, you could have a building that is, dunno, the embassy of Germany in France, and then the are would be in France and there could be a relationship to Germany
      • 2022-05-27 14752, 2022

      • reosarevok
        We probably won't add that, but :)
      • 2022-05-27 14704, 2022

      • reosarevok
        s/the are/the area/
      • 2022-05-27 14708, 2022

      • lucifer
        yes makes sense
      • 2022-05-27 14717, 2022

      • akshaaatt
        atj Thanks for the help! All works well now! :)
      • 2022-05-27 14748, 2022

      • akshaaatt
        monkey Seems like we can only configure one directory for eslint but in our case we have 2. Any thoughts?
      • 2022-05-27 14712, 2022

      • monkey
        Did you look into ho too do this in the eslintrc file?
      • 2022-05-27 14715, 2022

      • monkey
        how*
      • 2022-05-27 14751, 2022

      • akshaaatt
        No monkey. Will look into that
      • 2022-05-27 14727, 2022

      • monkey
      • 2022-05-27 14755, 2022

      • monkey
        Maybe there's an opposite equivalent to only accept certain file paths?
      • 2022-05-27 14705, 2022

      • akshaaatt
        Makes sense
      • 2022-05-27 14710, 2022

      • BrainzGit
        [troi-recommendation-playground] 14mayhem merged pull request #56 (03main…improve-daily-jams): Improve daily jams https://github.com/metabrainz/troi-recommendation…
      • 2022-05-27 14744, 2022

      • monkey
        Or create an .eslintignore file and populate it with all the root folders except the ones you are interested in linting
      • 2022-05-27 14721, 2022

      • akshaaatt
        Right monkey. We would need to do the same for prettier then
      • 2022-05-27 14747, 2022

      • monkey
        It also looks like you can exclude all folders with a glob pattern, and then re-include just the directories you need with the `!` prefix:
      • 2022-05-27 14753, 2022

      • monkey
        > Lines preceded by ! are negated patterns that re-include a pattern that was ignored by an earlier pattern.
      • 2022-05-27 14753, 2022

      • akshaaatt
        Damn DS repo is so cool though. It has everything lol
      • 2022-05-27 14744, 2022

      • monkey
        If eslint runs prettier then the eslintignore file should be sufficient
      • 2022-05-27 14706, 2022

      • monkey
        You can try all that out locally by the way
      • 2022-05-27 14717, 2022

      • akshaaatt
        Yeaah
      • 2022-05-27 14743, 2022

      • monkey
        remove the file paths that we added to the `lint` script in package.json and see if the ignore file does what you want
      • 2022-05-27 14757, 2022

      • akshaaatt
        Right
      • 2022-05-27 14702, 2022

      • akshaaatt
        Doing
      • 2022-05-27 14744, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2513 (03master…MBS-12361): MBS-4960 / MBS-12361: Allow navigation from donation check page and improve error handling https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14729, 2022

      • akshaaatt
        Perfect monkey. It's just that prettier needs to be configured still
      • 2022-05-27 14735, 2022

      • mayhem
        lucifer: https://github.com/metabrainz/listenbrainz-server… is ready. wanna have a final look?
      • 2022-05-27 14723, 2022

      • lucifer
        mayhem: looks good
      • 2022-05-27 14712, 2022

      • hackerman3 joined the channel
      • 2022-05-27 14709, 2022

      • hackerman has quit
      • 2022-05-27 14709, 2022

      • hackerman3 is now known as hackerman
      • 2022-05-27 14750, 2022

      • lucifer
      • 2022-05-27 14703, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2545 (03master…MBS-12407): MBS-12407: Add tobarandualchais.co.uk to the other dbs whitelist https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14700, 2022

      • reosarevok
        lucifer: sweet, I'll take a look after lunch :)
      • 2022-05-27 14716, 2022

      • monkey
      • 2022-05-27 14707, 2022

      • akshaaatt
        Hi yellowhatpro! I'm looking to do an android release next week. Have you made any progress on the CB integration? If yes, we can include that. Looking to add some work before we make a release so just wanted to inform you.
      • 2022-05-27 14719, 2022

      • Rotab has quit
      • 2022-05-27 14715, 2022

      • Rotab joined the channel
      • 2022-05-27 14719, 2022

      • Lucasz10 joined the channel
      • 2022-05-27 14726, 2022

      • Lucasz10
        I've been making a web-app with the last.fm api, and it only shows track MBID's and not release MBID's.
      • 2022-05-27 14736, 2022

      • Lucasz10
        Is there any way I can make an api call to musicbrainz/coverartarchive with the track MBID to get the cover art of a release?
      • 2022-05-27 14757, 2022

      • mayhem
        monkey: lolol, I actually like pepinos. its zas who doesn't like them.\
      • 2022-05-27 14746, 2022

      • alastairp
        hi Lucasz10, the CAA API doesn't directly let you use recording MBID, but you could first make a query to the musicbrainz API: https://musicbrainz.org/doc/MusicBrainz_API#Browse
      • 2022-05-27 14712, 2022

      • alastairp
        so you could end up with https://musicbrainz.org/ws/2/release?recording=32… which gives you a list of candidate releases, which you can then look up for cover art
      • 2022-05-27 14759, 2022

      • alastairp
        keep in mind that there's not a 1-1 relationship between recordings and releases - there could be many different releases for that recording (singles, official releases, compilations, reissues)
      • 2022-05-27 14707, 2022

      • alastairp
        you can filter a few of these if you want: https://musicbrainz.org/doc/MusicBrainz_API#Relea…
      • 2022-05-27 14714, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2516 (03master…MBS-8193): MBS-8193 / MBS-12332: Wrap absurdly long lines https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14713, 2022

      • BrainzGit
        [listenbrainz-server] 14mayhem merged pull request #2016 (03master…troi-bot-daily-jams): Troi bot daily jams https://github.com/metabrainz/listenbrainz-server…
      • 2022-05-27 14711, 2022

      • Lucasz10
        alastairp: thanks a lot, I think I've got it!
      • 2022-05-27 14752, 2022

      • reosarevok
        yvanzo: pushed some tests for AC pages as part of https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14717, 2022

      • reosarevok
        We can merge that and then you can adapt them to support gids, or the other way around :) Just let me know
      • 2022-05-27 14756, 2022

      • yellowhatpro
        Hello akshaaatt I am done with a basic setup with chips of different entities to choose from and show reviews accordingly,
      • 2022-05-27 14756, 2022

      • yellowhatpro
        currently I am stuck on a problem I am facing. It seems cb api returns id of the title and not the title, so I need to perform a lookup on that before.
      • 2022-05-27 14756, 2022

      • yellowhatpro
        I will try to find a solution soon, and I hope we will be able to do the release on time.
      • 2022-05-27 14711, 2022

      • Lucasz10 has quit
      • 2022-05-27 14736, 2022

      • Sophist-UK has quit
      • 2022-05-27 14742, 2022

      • Sophist-UK joined the channel
      • 2022-05-27 14716, 2022

      • reosarevok
        yvanzo: hmm, actually, adding recording + rg to the AC breaks your AC merging test. Is that expected?
      • 2022-05-27 14719, 2022

      • akshaaatt
        I can help you with it if you make a PR for it yellowhatpro
      • 2022-05-27 14700, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2511 (03master…MBS-12353): MBS-12353: Actually check proposed ratings are allowed https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14717, 2022

      • Sophist_UK joined the channel
      • 2022-05-27 14705, 2022

      • Sophist-UK has quit
      • 2022-05-27 14742, 2022

      • Sophist-UK joined the channel
      • 2022-05-27 14753, 2022

      • Sophist_UK has quit
      • 2022-05-27 14735, 2022

      • BrainzGit
        [musicbrainz-server] 14mwiencek merged pull request #2542 (03master…text-unaccent-pureperl): MBS-12404: Replace Text::Unaccent with Text::Unaccent::PurePerl https://github.com/metabrainz/musicbrainz-server/…
      • 2022-05-27 14700, 2022

      • adhawkins has quit
      • 2022-05-27 14723, 2022

      • adhawkins joined the channel
      • 2022-05-27 14717, 2022

      • adhawkins has quit