[musicbrainz-android] 14yellowHatpro opened pull request #127 (03brainzplayer…bp-implementation): Service completion, Service callbacks and notification stuff created, basic service setup complete https://github.com/metabrainz/musicbrainz-android…
2022-06-27 17844, 2022
yellowhatpro
Moin!!!
2022-06-27 17842, 2022
yellowhatpro
akshaaatt: so our brainzplayer's service is complete for our playback use cases. Now for some time I will be focussing on some UI stuff and implementing functions in a view model
2022-06-27 17849, 2022
yellowhatpro
currently I am targetting playable entitites, i.e. Songs, and after a basic player implementation , when we are able to play songs, I will work on browsables like Albums and Playlists.
2022-06-27 17832, 2022
antlarr has quit
2022-06-27 17832, 2022
antlarr joined the channel
2022-06-27 17843, 2022
antlarr has quit
2022-06-27 17801, 2022
antlarr joined the channel
2022-06-27 17824, 2022
KevlarNoir has quit
2022-06-27 17826, 2022
skelly37 joined the channel
2022-06-27 17810, 2022
adhawkins has quit
2022-06-27 17840, 2022
adhawkins joined the channel
2022-06-27 17818, 2022
yvanzo
O’Moin
2022-06-27 17810, 2022
mayhem
moin moin!
2022-06-27 17844, 2022
skelly37
moin
2022-06-27 17840, 2022
akshaaatt
moin!
2022-06-27 17853, 2022
akshaaatt
Amazing work yellowhatpro ! 💯✨
2022-06-27 17825, 2022
ansh
alastairp: Hi! Finally done with my exams.
2022-06-27 17853, 2022
ansh
For getting the data from the bb database, should I use direct queries then or add the necessary columns in the BB views?
2022-06-27 17856, 2022
alastairp
ansh: congrats, hope that they went well
2022-06-27 17809, 2022
alastairp
ansh: I was just talking to monkey about that last week. what fields are you missing?
2022-06-27 17822, 2022
alastairp
it's probably better that we add the columns that you need to the view
2022-06-27 17853, 2022
ansh
name, author_name, label, etc..
2022-06-27 17831, 2022
monkey
Hi! If you make a list of the fields missing per entity, I can see if they can be added
2022-06-27 17839, 2022
monkey
(to the views)
2022-06-27 17808, 2022
ansh
Okay, I'll make a list of it
2022-06-27 17853, 2022
Pratha-Fish
moin :)
2022-06-27 17817, 2022
Pratha-Fish
alastairp: Here's CSV file with MLHD_artist_mbids that don't belong to artist_credit_list
I definitely think having the default alias name and sort name on all entities is useful. Same for disambiguation
2022-06-27 17814, 2022
monkey
Author credit name + BBID will be for bothe Edition and Edition Group
2022-06-27 17833, 2022
monkey
But then again you won't care about the Edition entity IIRC
2022-06-27 17859, 2022
ansh
Yes
2022-06-27 17843, 2022
ansh
alastairp: Can you give me permissions for the docker/pg_custom folder? I am getting permissions denied.
2022-06-27 17815, 2022
alastairp
ah, sure
2022-06-27 17803, 2022
alastairp
ansh: try that
2022-06-27 17833, 2022
alastairp
Pratha-Fish: great, thanks. I think the next thing we were going to add to this was the canonical recording MBID, right?
2022-06-27 17814, 2022
monkey
ansh: Not sure how to construct a useful author credit in the view: getting the name and BBID of the first author in the author_credit is one thing, but it does not allow multiple authors (i.e. something like that: https://critiquebrainz.org/review/39a9ad67-05a5-4…)
2022-06-27 17853, 2022
monkey
You might have to fetch the author_credit separately by its id and reconstruct the name and links from it
2022-06-27 17818, 2022
alastairp
monkey: one option would be to use array_agg, but not sure if it's worth doing this query every time for the view, or if it will adversly affect query time
2022-06-27 17836, 2022
alastairp
I think it'd probably be OK to query the credit separately if it's needed
2022-06-27 17810, 2022
monkey
Never used array_agg myself, that's why, thanks :)
2022-06-27 17810, 2022
monkey
We could do that indeed
2022-06-27 17834, 2022
alastairp
monkey: is this a view or materialized view?
2022-06-27 17854, 2022
monkey
not materialized
2022-06-27 17855, 2022
alastairp
because if it's a regular view then I'd definitely profile array_agg first
2022-06-27 17808, 2022
alastairp
because I wouldn't be surprised if it makes things much slower
Soo what do we do next in the artist conflation issue?
2022-06-27 17855, 2022
CatQuest
hey Pratha-Fish !
2022-06-27 17821, 2022
ansh
alastairp: worked thanks
2022-06-27 17809, 2022
alastairp
Pratha-Fish: cool. can we do the following, then:
2022-06-27 17853, 2022
Pratha-Fish
CatQuest Hi :D
2022-06-27 17853, 2022
alastairp
Pratha-Fish: oh - the drive file, is that all rows of the same mlhd files that you loaded?
2022-06-27 17804, 2022
Pratha-Fish
alastairp: yes
2022-06-27 17826, 2022
alastairp
and the other one that you linked above - uploaded to irccloud - is the subset of this same file which has mismatching mlhd_artist/artist_credit_mbid ?
2022-06-27 17842, 2022
Pratha-Fish
Yes, that's right
2022-06-27 17847, 2022
alastairp
ok, great!
2022-06-27 17807, 2022
Pratha-Fish
The first one contains all mismatches
2022-06-27 17807, 2022
Pratha-Fish
the 2nd one contains all of them, correct and incorrect ones
2022-06-27 17812, 2022
alastairp
can we make one more small change, then -
2022-06-27 17828, 2022
alastairp
can you generate the 2nd file again, but add the canonical recording mbid as a new column
2022-06-27 17840, 2022
Pratha-Fish
Yes, that should be easy :)
2022-06-27 17846, 2022
alastairp
so recording-MBID should be the value from the mlhd file
2022-06-27 17813, 2022
alastairp
one other really tiny thing - can you make the header of that csv file be all lower-case, and use _ instead of - ?
2022-06-27 17820, 2022
alastairp
artist-MBID -> artist_mbid
2022-06-27 17852, 2022
Pratha-Fish
Oh right, I should've done that from the get go
2022-06-27 17839, 2022
Pratha-Fish
Are there anymore changes required?
2022-06-27 17841, 2022
alastairp
cool, once that file is generated we'll be able to use it to
2022-06-27 17853, 2022
alastairp
use it to compare the mapper lookup
2022-06-27 17835, 2022
Pratha-Fish
Sounds good
2022-06-27 17835, 2022
Pratha-Fish
I'll try to get the file ready in 30mins
2022-06-27 17859, 2022
ansh
alastairp: Again getting the same error.
2022-06-27 17842, 2022
alastairp
ansh: ok, let's debug what's happening here, it's likely that something in your configuration is changing the permissions when you run it
2022-06-27 17858, 2022
alastairp
can you paste the database section of your docker-compose.yml?
[bookbrainz-site] 14tr1ten opened pull request #852 (03master…async-language-select): Feat(language-select): Asynchronously load options in language select https://github.com/metabrainz/bookbrainz-site/pul…
2022-06-27 17804, 2022
alastairp
ansh: can I log in as you on wolf for a moment to test?
2022-06-27 17824, 2022
ansh
yes sure
2022-06-27 17820, 2022
alastairp
ansh: OK, I have a theory. it's possible that the the db container "remembers" that it used to be owned by root, and if we shut it down, chown, and then start it up again, it goes back and corrects it to the original value
2022-06-27 17839, 2022
alastairp
so I'm going to stop and delete the db container, try the chown, and then start it up again
drwxr-xr-x 2 anshg1214 anshg1214 4096 Jun 27 11:17 pg_custom
2022-06-27 17805, 2022
alastairp
now I started it again, and the permissions have stayed the same
2022-06-27 17832, 2022
alastairp
now I stopped it, and started it again, and it's remaining owned by you
2022-06-27 17807, 2022
alastairp
I just learned something new about docker, thanks :)
2022-06-27 17817, 2022
alastairp
ansh: should be good to go now. let me know again if something weird happens
2022-06-27 17838, 2022
alastairp
Pratha-Fish: that's great, thank you!
2022-06-27 17842, 2022
ansh
Sure! Thanks :)
2022-06-27 17813, 2022
skelly37 has quit
2022-06-27 17838, 2022
Pratha-Fish
alastairp: BTW can we implement the "file-sharing through public URL on wolf" thing that you mentioned earlier?
2022-06-27 17803, 2022
alastairp
Pratha-Fish: ok, let me have a look
2022-06-27 17805, 2022
Pratha-Fish
My internet is kinda crap, so it takes ages to upload files to drive as they're getting larger and larger
2022-06-27 17828, 2022
alastairp
btw, of course if you're sharing files to us and they're already on wold, just tell me the file path of it on the server and I can look myself :)
2022-06-27 17832, 2022
alastairp
*wolf
2022-06-27 17839, 2022
Pratha-Fish
thanks :)
2022-06-27 17825, 2022
alastairp
just say "I generated a new file, it's at /home/snaek/mlhd-output/mlhd-sample-metadata-mapping.csv"
2022-06-27 17829, 2022
alastairp
and I can take a look
2022-06-27 17847, 2022
Pratha-Fish
Here's my present working directory:
2022-06-27 17847, 2022
Pratha-Fish
/home/snaek/MLHD/unk_ids
2022-06-27 17828, 2022
alastairp
mayhem: we're now at the point where we can test some MLHD recording-artistcredits on the mapping lookup. I recall that you suggested we write something to run locally/in batch against the lookup code instead of hitting the dataset hoster API
2022-06-27 17819, 2022
mayhem
what exactly should the lookup do?
2022-06-27 17848, 2022
mayhem
alastairp: slightly off topic: a Kiwi traveling to Spain doesn't need a visa, correct?
2022-06-27 17853, 2022
alastairp
artist credit + recording name -> canonical/mapped MBID
2022-06-27 17858, 2022
alastairp
mayhem: correct
2022-06-27 17820, 2022
mayhem
alastairp: thx on the visa q.
2022-06-27 17822, 2022
alastairp
not sure if the electronic shengen permit is active yet?
2022-06-27 17837, 2022
mayhem
not yet, coming later this year (more likely next year)
2022-06-27 17857, 2022
mayhem
but that wouldn't involve visa letters which is what I am working on now.
2022-06-27 17838, 2022
mayhem
for that lookup, hitting the labs endpoint or the LB /metadata endpoint is actually the best.
2022-06-27 17845, 2022
mayhem
how many lookups do you need to do?
2022-06-27 17829, 2022
alastairp
Pratha-Fish: how many lines is the complete file?
2022-06-27 17833, 2022
Pratha-Fish
alastairp: 376038
2022-06-27 17838, 2022
CatQuest
[14:00] <alastairp> not sure if the electronic shengen permit is active yet?
2022-06-27 17838, 2022
CatQuest
I read that as "electronic shenanigan" at first
2022-06-27 17839, 2022
CatQuest
:D
2022-06-27 17819, 2022
Pratha-Fish
alastairp: and ~34k of them are incorrect
2022-06-27 17834, 2022
alastairp
Pratha-Fish: for now we're not too worried about the incorrect artist credits, for now we just want to compare the results of our two mapping techniques
2022-06-27 17847, 2022
Pratha-Fish
okie
2022-06-27 17841, 2022
alastairp
oh, that file also includes the timestamp right? so does it include duplicate artistmbid/recordingmbid lines?
2022-06-27 17802, 2022
Pratha-Fish
alastairp: Nah, it doesn't include any duplicate files
