Yvanzo: hah, I didn't even realize it was closed, I guess I'm still working on it anyway! Thanks
alastairp: I wonder if it was someone else... It was a concert in sure. Ah well
yes, MeB is paying for the flights and accomodation.
and yes, get started on some training.
Tumeke (too much)
aerozol: The resolution is set to “Fixed” when a pull request has been identified to address it. But the status is not Closed yet.
Ahhhh makes sense. Kind of. But I'll bookmark that all assigned link instead
Anyone know any good sites or courses to learn git?
aerozol: in the guidelines, avide -> abide
aerozol: sorry, I didn't follow too much of your discussion with others over the last week, but were there originally more details in the guidelines section and you simplified it in order to make it easier to understand?
They was much more in there and then I stripped it right back. CatQuest had feedback around not wanting to police reviews too much, Freso helped make it more succinct and we removed any overlap with the MetaBratnz CoC
antlarr has quit
However there might be some stuff we want put back in - the most common thing seem to be SEO manipulation (removed because it's in the CoC) and purely promotional reviews (still in there)
what if we had a "I'm the artist or representing the artist" flag?
Which is kind of a review, but mainly promotional (and pasted from the label website)
or even more explicit "this is promotional content by the artist"
antlarr joined the channel
Yeah would do the same thing. As long as it can be assigned by admin/mods
I'm going to have dinner, I'll let you mull it over :D
yeah, the idea would be that the reviewer set it, but we could set it ourselves if it's clear that this is the case
my feedback would be 1) add another sentence to point 3 to clarify what "primarily promotional" means, 2) consider adding "no seo" explicitly? (I know it's also in the CoC, does it make sense to explicitly drawing attention to it?)
antlarr has quit
antlarr joined the channel
Okay, so clarify the promotional material part and leave it in, until we (maybe) get a flag system or something? Most of the troublemakers on that front have been single review/use burner accounts so I can't say we're losing much but we can always proceed more cautiously if an artist or label comes along and uses it on good faith
I'm a fan of being explicit on no SEO but also hear the feedback re. duplication. Make a call chef!
I don't mind the MetaBrainz wording of 'don't game our projects' which covers SEO gaming imo
"3. Promotional content that doesn't meet guideline 1. will be removed"? Ahh I dunno
a few ideas about promotional material: maybe if we make it easier for a user to say "I'm affiliated with these artists", and then we put in the guidelines that you have to do this if it's promotional? then if it's a burner account we can clear it
yeah, good question about the difference between "a review by the artist" and "clearly just promo text like you would find in a press kit or on the label's website"
maybe 3. could be as simple as "No primarily promotional content, if [you are affiliated with the item being reviewed] please make sure that there is some review-like content in there too"
not exactly like that, but do you get the idea?
Yeah, I was trying to do something like that in 1. and then be more explicit re promo stuff in 3.
that's true, 1 encompasses what I was trying to say anyway
I guess I also have no idea what the aim of CritiqueBrainz is - is it just for "reviews"?
perhaps a good wider discussion to have :) I think the answer is yes, but also to be a counter to wikipedia's "Neutral point of view only", to have a place where you can be non-neurtral. in that case I see promo material fitting in there (if it's flagged as such)
alastairp: do we use folder for test reports anywhere? Can we add it in the .gitignore ?
ansh: the one that generates the junit xml?
I don't think that we use it. In our old test setup (using a service called jenkins) we were able to generate graphs using this file.
yes, we can add it to gitignore, but also we could configure it to not generate this file when running tests locally
I'll have a look
Pratha-Fish: sorry - I saw all of your messages and sat down twice to respond to them, but got distracted both times! looking at them again now
Pratha-Fish: yeah, logging performance stats for this kind of thing is very useful. let me find some code which I use for this kind of thing
another very important thing is to save your work as soon as you complete it. so if you look up 15 items, go ahead and save them (as an example, you could map the track name/artsit name back to the recording mbid and save it in mapping_lookup/[mbid].json (just the item for that single mbid))
in the case of no match, consider saving an empty file
and then, at the other end - when you do the lookup you can first see if this MBID has a saved json file. if it does, skip it. this means that you can cancel/restart as many times as you want
when I do stuff like this in a loop, I will often run a counter, and every 1000 items or so (it definitely changes depending on the amount of work each item requires) I will print how many items it has done, how many remaining, how much total time has elapsed, and I'll calculate an estimated remaining time for completion
that second link also has some code for my example of saving intermediate results, take a look at the `filter_mbids_from_destination` method, and then how I call write_lowlevel in the get_lowlevel_for_all_and_save method
ansh: btw, monkey found that these views are used in many places in BB, and therefore he cannot add 'and master=true' to the query. so we'll have to add it to the CB version of the code
okay, I'll make the changes
The script gave me exactly what I wanted. Are there any other changes required?
I don't think so! let me have a look again at the work
do you want to add the entity page to the existing PR that include the DB lookups, or do you want to make a separate one?
1108423325,ce58d854-7430-4231-aa44-97f0144b3372,eced9a9b-cd59-40f8-a580-f27094bd8a89,6ae8e64a-d208-4f4e-8d88-155ed0568344,Building a Mystery,Sarah McLachlan,ce58d854-7430-4231-aa44-97f0144b3372,6ae8e64a-d208-4f4e-8d88-155ed0568344
Let me know if you need any specific "broken" rows filtered out
well, the whole purpose of this is for you to learn how do do this
so from my perspective, everything over the last few weeks has been absolutely perfect
alastairp: Thanks! That means a lot to me :)
I gotta stop slacking off though.
My daily schedule has been shifted to whole another timezone due to insomnia, so I've been barely able to work for a few hours a day
Pratha-Fish: no problem. don't worry about trying to stay up to cross with my timezone if that's causing you issues, I think we're managing well regardless. if you need to take a few days to decompress then that's fine as well
alastairp: OT: Know a good shop that duplicates keys? I need one to handle the keys with the dimples in particular
Pratha-Fish: I think this next step is pretty exiting. Can we do a check of "how many canonical mbids are the same as mapping mbids?"
nah, it's not due to work TBH
It's my own messed up schedule due to lifestyle changes