ansh: hi, could you please review CB#448? And if it works for you, please rebase your existing PRs with it (I'm having trouble doing a docker build with node 12, so have upgraded it to v16)
let's add both lookups, and have a flag in the code to switch between them. At the moment I think that the MBC lookup will give better results
2022-07-25 20611, 2022
alastairp
in fact, for a handful of the nan values that I checked, the mbc lookup does give a result
2022-07-25 20636, 2022
Pratha-Fish
Interesting. I'll add the option to switch then
2022-07-25 20617, 2022
alastairp
sweet
2022-07-25 20651, 2022
alastairp
Pratha-Fish: when that's done, I have a few potential PRs for you to do. let me know if you're interested in them
2022-07-25 20614, 2022
Pratha-Fish
alastairp: definitely, getting used to the OSS workflow is a must for me
2022-07-25 20606, 2022
alastairp
perfect - it'll require you to set up listenbrainz on wolf (not the whole infrastructure, but the code is there). I can help you step through it, but I have a lunch meeting in ~1 hour. so up to you - we can do it, now, or we can do it when I'm back in 3-4h
ansh: 👍 thanks, will do. I think the lock file might be because I generated the updated lock file locally with node 17 instead of the 16
2022-07-25 20635, 2022
ansh
I noticed these things when I setup CB following the docs
2022-07-25 20647, 2022
alastairp
and I can see why the static builder one happened too (see that it's using `docker run` without the --user flag, this means that it'll probably be running as user 1001, which means that it can't modify the existing files in your home directory)
2022-07-25 20611, 2022
Pratha-Fish
alastairp: Let's do it after lunch. Till then I'll be able to finalize the mapper script as well
2022-07-25 20637, 2022
alastairp
this is similar to the pg_custom errors you were seeing previously, and related to a fix that lucifer made on LB node tests too
actually, I see that we don't have the --user flag in CB's develop.sh like we do in LB. interesting. looking more
2022-07-25 20653, 2022
alastairp
I'm just rebuilding the docs now. I guess they're on manual. I still don't understand how building docs works :( same issues with LB
2022-07-25 20629, 2022
ansh
I think we can have a script that runs every time a new release is made
2022-07-25 20604, 2022
alastairp
yes, we tried that with LB, but it was creating new versions each time, which made things very messy in the readthedocs interface, because sometimes we would make many releases a week
2022-07-25 20648, 2022
alastairp
doc builds are failing. I suspect a similar reason to what lucifer found in LB last week. when I'm back after lunch I'll look at them
2022-07-25 20652, 2022
alastairp
ansh: `search_editon_group` just noticed this 😅
2022-07-25 20622, 2022
lucifer
alastairp: probably jinja2 incompat version. can open a PR to fix.
lucifer: alastairp : I cleaned up old "Top 100 top artist..." playlists that were old and stale.
2022-07-25 20653, 2022
riksucks
hi lucifer, I wanted to ask you something
2022-07-25 20659, 2022
lucifer
hi!
2022-07-25 20623, 2022
riksucks
so the api rn is sending back the userids of the followers. I was wondering the following approach.
2022-07-25 20639, 2022
riksucks
the frontend has an access to all the people following me
2022-07-25 20601, 2022
riksucks
so in the frontend, I can do the mapping, and show the usernames of the people I sent personal recommendation to
2022-07-25 20638, 2022
riksucks
if a name is not present in the frontend, but the userid is there, frontend would assume, that the person has unfollowed him, hence not show anything
2022-07-25 20620, 2022
lucifer
riksucks: but external api users do not have access user ids so they can't do such a mapping
2022-07-25 20614, 2022
riksucks
oh right, yes
2022-07-25 20640, 2022
lucifer
thus, the api should only deal in user names, it should convert usernames to user ids when writing to db then convert user ids back to user names when sending events to users.
2022-07-25 20647, 2022
riksucks
also another question. We should be saving data with the ids, but when serving them, we would be populating it with usernames. right?
2022-07-25 20655, 2022
riksucks
because again, usernames can change
2022-07-25 20620, 2022
riksucks
right
2022-07-25 20655, 2022
lucifer
yup db should store user ids for this reason
2022-07-25 20608, 2022
riksucks
right thanks. also, there exists `get_many_users_by_mb_id` to get info about users from mb_id. making a `get_many_users_by_id` sounds like an okay approach to you for this right?
2022-07-25 20631, 2022
lucifer
riksucks: yes. that sounds good.
2022-07-25 20651, 2022
lucifer
but i'd suggest to first try adding a join to "user" table directly in the events query.
2022-07-25 20612, 2022
lucifer
you can user something json_array_elements_text to expand the array to 1 row per id, join with username then collect back by grouping on event id.
2022-07-25 20635, 2022
lucifer
i can help with that if you get stuck.
2022-07-25 20622, 2022
akshaaatt
Thank you mayhem! Received.
2022-07-25 20606, 2022
chinmay
lucifer: how often does lb get a new prod build?
2022-07-25 20641, 2022
lucifer
chinmay: do you mean how often we do a new release?
2022-07-25 20658, 2022
chinmay
yes
2022-07-25 20647, 2022
lucifer
there's no fixed timeline, whenever we have enough stuff to release or there's an urgent fix so on. sometimes its multiple times a week sometimes a couple of weeks without any release/
2022-07-25 20606, 2022
chinmay
oh, alright
2022-07-25 20604, 2022
chinmay
I wanted to try out fresh releases api and I was avoiding setting up musicbrainz server locally
2022-07-25 20643, 2022
mayhem
we could deplay to test.mb.org and let you do that, chinmay
ansh: I think I worked out the reason for the permission denied errors. newer versions of npm have this funny behaviour where they will see if they are running as root, and if the owner of the directory that they are running in is different to root, they will try and chown the output
