#metabrainz

[musicbrainz-server] 14mwiencek opened pull request #2600 (03master…entities-js-flow): Add entities.mjs & generate entities.json from it https://github.com/metabrainz/musicbrainz-serve...

monkey: akshaaatt: yellowhatpro: MEB-138

MEB-138: BrainzPlayer Icon https://tickets.metabrainz.org/browse/MEB-138

Not really my style (I prefer less busy icons), but hopefully matches the ones already there which are quite flash? Anyway, see my notes on the ticket and comment away. Otherwise feel free to use :)

akshaaatt: which reminds me, could I get write permissions on the design system repo?

[musicbrainz-server] 14mwiencek opened pull request #2601 (03master…react-catalyst-context-access): Access $c via React context APIs, not props https://github.com/metabrainz/musicbrainz-serve...

one HDD on moroder needs to be replaced, it should be an hot swap, I prepared the server for it, support request sent

HDD hotswapped, rebuilding RAID arrays now

thanks zas

O’Moin

hi yvanzo

yvanzo: later today do you have some time to help me set up sir dev again? I used to have it, and I tried again earlier in the week, but I'm encountering some python errors on startup

hi alastairp: sure, I’m available now and until 7 pm CEST

thanks. I'm busy now, but I'll ping you in about 4 hours

[musicbrainz-server] 14reosarevok merged pull request #1930 (03master…MBS-10478): MBS-10478: Show useful message if too large search result page requested https://github.com/metabrainz/musicbrainz-serve...

yvanzo: by any chance do you have the pg server logs for when you encountered the error here https://github.com/metabrainz/sir/pull/111?

lucifer: No and I had to change its setup for other tests. Do you mind if I reset the SIR setup on wolf?

(If it is still up)

yvanzo: oh i see. yes please reset.

Huh, that merge broke some tests, even though they seemed fine earlier. Wonder if I broke something rebasing. Checking

Hmm. Passes locally, rerunning

yvanzo, bitmap: no idea why https://app.circleci.com/pipelines/github/metab... failed twice while passing locally

Wait. Maybe I do know. Because I might have done a dumb

Running again with a patch

Yeah, it was me forgetting to push my rebase before merge, sigh.

[musicbrainz-server] 14reosarevok merged pull request #2598 (03master…fix-import-extensions): Fix eslint rule import/extensions https://github.com/metabrainz/musicbrainz-serve...

I recently subitted a web service bug MBS-12154

MBS-12154: MB Search API is broken, no pagination possible https://tickets.metabrainz.org/browse/MBS-12154

I have identified another web service bug also with query: MBS-12534

MBS-12534: Recording search query web service: undefined or wrong release date and release-events https://tickets.metabrainz.org/browse/MBS-12534

[listenbrainz-server] 14amCap1712 opened pull request #2093 (03master…cleanup): Cleanup unused files https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2093 (03master…cleanup): Cleanup unused files https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 opened pull request #2094 (03master…tests-speed-up): [Do not merge] Speed up LB tests https://github.com/metabrainz/listenbrainz-serv...

thanks jesus2099!

akshaaatt: for implementing repository entites, should I go for RoomDB?

As it will all be in local only

yvanzo: sorry, things got complicated today, we can talk another day. have a good evening

don't worry, hope that's not too bad, good evening too

outsidecontext, rdswift, zas: Hello, I've rather finished implementing the stuff from the ticket (code review & minor refactorings are taking place now). Would you like to see any more commands in this PR?

Also, especially asking zas as the inventor of the solution, do we have any ideas for commands with arguments or are they written just in case?

[musicbrainz-server] 14yvanzo merged pull request #2599 (03master…update-datetime-locale): MBS-12527: Update DateTime::Locale to 1.35 https://github.com/metabrainz/musicbrainz-serve...

skelly37: I was thinking about Look Up CD command: without arg, it uses "first" cd reader, but an arg let the user select which cd reader to use

that's not something we have to do now, the PR is good enough to be merged, and we can additional commands later

[bookbrainz-site] 14tr1ten opened pull request #871 (03master…fix/ac-validations): Fix(AC): AC field should show error when empty https://github.com/metabrainz/bookbrainz-site/p...

Looks good, both the idea and leaving it for a next PR

I suggest adding command REMOVE $PATH where one could specify a path and remove it from picard, doesn't matter if from album or track pane

album or cluster pane*

So I think that we can finalize my current PR, add a few commands with args and then move to the second part of my gsoc proposal (better error handling), unless you have some better ideas

I didn't forget about the `imp` issue btw ;)

+1

great :)

Done aerozol

Sounds good to me yellowhatpro

<zas> ```skelly37: I was thinking about Look Up CD command: without arg, it uses "first" cd reader, but an arg let the user select which cd reader to use``` Or to specify the path/file to use for the ripper log file.

sorry, connection issues

rdswift: +1

Thanks akshaaatt!

[design-system] 14Aerozol merged pull request #80 (03master…master): Some general tidy up https://github.com/metabrainz/design-system/pul...