#metabrainz

chinmay: i think i fixed the issue of filters not getting applied right away. its because `useState` is async so calling `setFilteredList` right after will use an outdated value. for the other issue, releases disappearing after removing all filters. its because the checkedList becomes empty and then the filtering returns no releases so i added an if to special case that and show all releases.

i have pushed the changes to your branch, latest two commits. it seems to work fine for me but try it out and if there any issues or if you have any doubts or further questions.

FYI summit attendees, still tons of space in my bag if anyone wants anything from NZ > Spain (I’ve stocked up on treats and hops)

"Cover Art Archive - 429 Too Many Requests Errors" in support

zas: do you know if this was just the IA or it can be something else?

It can be anything, I'll check

reosarevok: zas: bitmap mentioned this yesterday. he suspected a spammer.

Oh, ok

aerozol: I think that genre icon is pretty good - have you checked how it looks inverted?

https://github.com/metabrainz/musicbrainz-serve... is where these would go

So I guess ideally we'd have the equivalent for genre to the other entity icons there? :)

I can do the implementation

zas is on the case for the CAA issues.

aerozol: when do you fly?

reosarevok: CAA issue was on our side, there was an increase of (apparently legit) traffic, but our rate limit was a bit low, I increased it, now all requests are handled, 429s disappeared. I also added an alert to detect this in the future.

Thanks!

aerozol: I asked my Kiwi friend here about how to answer your question. She says: "Whittakers peanut slab, Pixie Caramel, pineapple lumps and Perky Nana bars (just for the name 😂).

which of course is all goobelydegook to me, but hey. :)

so, if any of those still fit, sign us up. :)

Pineapple lumps sound ominous

Like something you tell your doctor about

Perky nana got me. :)

mayhem: those are all nice things

mmmm, pineapple lumps are great

I was wondering how you'd feel about those.

lol, that advert must sit really deeply in your psyche of kiwis -- my friend sent the me same link, lol.

hahahaha

yeah, I don't think I've ever eaten one? but the moment I read the name I thought of that ad

well maybe we'll get the chance to eat one. not like we don't have these things in the EU, but its all about nostalgia, right?

lucifer: Awesome! It's working now. I knew I had to use useeffect somehow but couldn't figure it out

thanks

np

I'll do some css changes and start working on timeline today

```

Access to fetch at 'https://coverartarchive.org/release/8ace46d4-560d-432b-8dda-037b26a9d7c2' from origin 'http://localhost:8100' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

```

I'm getting this error on every CAA request

do those requests have 429 as status?

Umm no

307 redirects

uh weird. i tried your branch locally. the 307 ones work fine the CORS errors are thrown only on 404 and 429.

🤯

amazing!

Oh!

Let me see

[musicbrainz-server] 14reosarevok opened pull request #2668 (03master…MBS-12645): MBS-12645: Add guess case to genre edit form https://github.com/metabrainz/musicbrainz-serve...

bitmap: opened that both for my qol purposes and to have something to base stuff like the React label form on (since that'll need the guess case too)

Can you take a look when you have some time? Also, is there any reason we're not updating master with the relationship editor changes? :) I don't want to open every PR on beta but I do want to test with the less buggy code ;)

I'm using this function to fetch CAA which is written by monkey (getAlbumArtFromListenMetadata). I had to copy it as a new function because I needed it to accept a MBID parameter instead of listen metadata.

monkey: can this be done somehow by modifying the existing getAlbumArtFromListenMetadata function? I do not want to duplicate the code.

you can create a fake listen as a stopgap measure.

alastairp: thanks! there's a lot of work left

perhaps we could create getAlbumArtFromMbid(), and the fromListenMetadata version just parses the id out and calls the first one?

yes! that sounds doable

lucifer: you mean I call the fromListenMetadata function with some fake listen data?

chinmay: yes, something like `{"track_metadata": "additional_info": {"release_mbid": RELEASE_MBID_HERE}} as Listen`. but separating out a function for mbid sounds better in longer run.

lucifer: got it

Yes, alastairp's solution is the way to go. Separate getAlbumArtFromReleaseMbid method that will be called by getAlbumArtFromListenMetadata

chinmay: I'd like to make a quick change to the getAlbumArtFromListenMetadata retry mechanism before you do that, if possible. Just to avoid some merge conflicts

mayhem: alastairp: I already got a few packs of pineapple lumps haha. They're a kiwi classic, which means good enough to stick around, but not good enough to take off anywhere else haha

:D

I fly Monday evening (3 days away)

I don't think that there's anything specific that I'm craving from there

but thanks! (and super exited about the hops)

monkey: maybe we should open a pils and test it

I tried one this week, it's very nice! Probably better with a couple more weeks but certainly fine for next week

Great nose

oh that's right, you took some with you!

alastairp: hi! were you able to look at the BU#95?

Enable sqlalchemy warnings and update mbdata: https://github.com/metabrainz/brainzutils-pytho...

lucifer: hi! it looks good

and the other one

and the mbdata patch too

great, thanks! i'll do a BU release.

any preference for doing an sqlalchemy version check in mbdata instead of `except ImportError`?

I'm not 100% what this does: https://github.com/metabrainz/brainzutils-pytho...

i was unable to find which version they moved the method so I went with ImportError but i can dig deeper and try to find it.

why did `relation` change?

that's because if you just use `target_attr` then it's the same as using a string?

so you're using getattr(model, str) to get the attribute with that name?

yes

yeah, in that case I guess I would maybe just do it on 1.4, since this is the version where the warning starts to appear?

so the "new" one doesn't exist in old versions of sqlalchemy, then? but we're not sure if that's 1, 1.1, 1.2 or 1.3?

basically joinedload("l_artist_url.link") is deprecated and we need to use joinedload(LinkArtistUrl.link_type), since the part after `.` varies in that method using `getattr`

right, not sure in which all versions the new one exists.

yeah, got it. sorry, I understand the usage in _relationship_link_helper now. no need for further explanations :)

I have no string preference, I think the ImportError is a fine way of doing it

no strong preference either

cool, i'll let it be the current way then because i have already tested with 1.3 and 1.4 versions

i have write access to mbdata repo but i'll not merge the PR there for now because the CI seems to be broken currently.

[listenbrainz-server] 14MonkeyDo opened pull request #2189 (03master…caa-retry-rate): Tweak CAA retry strategy https://github.com/metabrainz/listenbrainz-serv...

[brainzutils-python] 14amCap1712 merged pull request #95 (03master…update-mbdata): Enable sqlalchemy warnings and update mbdata https://github.com/metabrainz/brainzutils-pytho...

mayhem: hourly daily jams is live now, from tommorrow playlists should appear at user's midnight.

[brainzutils-python] 14amCap1712 merged pull request #96 (03master…sqlalchemy-warnings): Join relationships using attributes, not strings https://github.com/metabrainz/brainzutils-pytho...

[brainzutils-python] release 03v2.7.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/brainzutils-pytho...

[listenbrainz-server] 14amCap1712 merged pull request #2184 (03master…update-scripts): Make develop.sh and test.sh compatible with compose v2 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14MonkeyDo merged pull request #2189 (03master…caa-retry-rate): Tweak CAA retry strategy https://github.com/metabrainz/listenbrainz-serv...

chinmay: I'm done with the thing I wanted to change on getAlbumArtFromListenMetadata, all yours !

lucifer: that's great, thank you!

[listenbrainz-server] 14amCap1712 merged pull request #2164 (03master…sqlalchemy-20/errors): Turn sqlalchemy.exc.Base20DeprecationWarning into errors in tests https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release 03v-2022-09-30.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

monkey: Alright

mayhem: did you start working on the reverse painter's index?

not yet, but I've started working out how to make it work. Let me hammer out some code to start. did you need anything in particular?

ah no, the spotify server side playlist generation seems mostly done except for that endpoint so asked.

let me know if i can help on that.

k, let me dive in and see what I can come up with.

reosarevok: feel free to merge beta into master if you need the changes there, I just hadn't gotten around to it

monkey: ^ review please

Will do

lucifer: Can I deploy a branch to test.LB or are you using it?

monkey: sure. not using it

👍

chinmay: the commit looks great

monkey: thanks

FYI: to avoid having to export functions like in here: https://github.com/metabrainz/listenbrainz-serv...

You can simply use the syntax

`export async function getCoverartFromReleaseMBID…` for example

as in export functions when you defined them, rather than at the very end of the file. I'm fixing it across the codebase little by little

oh

Yeah I know this format

pure js instead of es6 right?

bitmap: not that I need it actively, just easier to review :)

But I'll do it on Monday if you haven't before then I guess

reosarevok: np I'll rebase the two I have up

though rn MBS-12634 is the only thing in beta not in master

MBS-12634: Beta: related entities do not show disambiguation in relationship editor https://tickets.metabrainz.org/browse/MBS-12634

oh nvm, my branch was stale, ignore me :)