I was able to identify the problem as some conditionals were returning false in getListenCard and i tried deactivating those conditionals and directly pushing the options
2022-11-30 33404, 2022
jivte_
and It worked
2022-11-30 33441, 2022
jivte_
I just need some clarity about other options like where which options should come
2022-11-30 33403, 2022
monkey
So about the options on the listencard, there are some that we should definitely have on all cards (recommendations and pin options) and some we can only show in certain conditions (open in spotify/musicbrainz, for which we need a spotify ID and MusicBrainz ID respectively).
2022-11-30 33447, 2022
jivte_
should I attach screenshots in JIRA
2022-11-30 33420, 2022
monkey
For the recommendation options it might depend on whether we have an MBID or and MSID available, not sure if any of the API endpoints still work with MSID.. calling dr. Lucifer
2022-11-30 33430, 2022
monkey
No need for screenshots jivte_ if you open a PR I'll be able to check it at some point
2022-11-30 33445, 2022
jivte_
Actually if I remove the MSID or MBID conditions It was working
2022-11-30 33434, 2022
monkey
But there's no guarantee that the feature would actually work, apart from showing the option in the dropdown. In theory the conditionals are there for a reason
2022-11-30 33455, 2022
monkey
That being said some of our features have evolved over time and some checks might not be necessary anymore.
2022-11-30 33447, 2022
jivte_
Thats what I discovered if only we remove the conditionals our issue also gest resolved and feature was also working
2022-11-30 33405, 2022
monkey
One thing to check is which information the API endpoint requires (in the dev docs) and compare to the implementation in the APIService.ts file
2022-11-30 33459, 2022
monkey
OK, then perhaps that's all that was needed! Check the "recent" page for an example of a page where we don't usually have an MBID available.
2022-11-30 33436, 2022
monkey
Other than that i'd be hapy to review a pr if you open one. Thanks for working on this!
2022-11-30 33401, 2022
jivte_
monkey: I just need to learn about MSID and MBID part where I can learn about there
2022-11-30 33409, 2022
jivte_
Is it in the documentation
2022-11-30 33431, 2022
jivte_
Bcz these MSID and MBID are creating all the problems
2022-11-30 33435, 2022
monkey
For the most part you should be able to ignore MSIDs, we are moving away from using them.
They are the way we refer to a recording, which is the base of all our endpoints. if you like a track in ListenBrainz, or recommend it, or review it, etc. that uses a unique identifier
2022-11-30 33415, 2022
monkey
An esay way to see if a listen has a recording MBID is if the track title is a link to musicbrainz. If it'l not a link, we don't have an MBID for that listen at that moment, which also most likely means we can't use the recommend, write a review, open in MusicBrainz, and maybe other features
2022-11-30 33423, 2022
monkey
(since they rely on an MBID)
2022-11-30 33419, 2022
monkey
Perhaps the options could be grayed out and unclickable when not available, rather than not having them in the dropdown? That could be less disturbing for users.
2022-11-30 33421, 2022
jivte_
Now I got the clarity will make a PR soon
2022-11-30 33429, 2022
jivte_
thanks for helping out
2022-11-30 33459, 2022
monkey
Thank you for digging in !
2022-11-30 33443, 2022
monkey
aerozol: Actually, I think a little speech bubble popping out with a "This if fine." would be *chef's kiss*
2022-11-30 33408, 2022
monkey
+1 to the use of memes for extra shareability
2022-11-30 33429, 2022
jivte__ joined the channel
2022-11-30 33437, 2022
jivte_ has quit
2022-11-30 33408, 2022
aerozol
Thanks jivte__ !
2022-11-30 33423, 2022
aerozol
monkey: cool I'll see what I can do
2022-11-30 33429, 2022
jivte__ has quit
2022-11-30 33456, 2022
jivte__ joined the channel
2022-11-30 33438, 2022
jivte__ has quit
2022-11-30 33421, 2022
chinmay
aerozol: awesome art!
2022-11-30 33459, 2022
lucifer
jivte: i see monkey answered your questions already. in case you have any other doubts, feel free to ask us again
but one thing, we should aim to be the gyys that alway can do these things, ie"not become a n ultracorp"
2022-11-30 33453, 2022
CatQuest
<3
2022-11-30 33414, 2022
alastairp
> Per poder fer el check-in sense entretenir-los tant,
2022-11-30 33421, 2022
alastairp
el check-in, huh?
2022-11-30 33432, 2022
CatQuest
al check-in
2022-11-30 33416, 2022
CatQuest
.. why is it bad to entertain people tho
2022-11-30 33407, 2022
CatQuest
we can put on the yim "original firedog idea KC " in smal letter right?
2022-11-30 33430, 2022
alastairp
CatQuest: it's the sense "take too much of your time"
2022-11-30 33438, 2022
CatQuest
oooh
2022-11-30 33404, 2022
CatQuest
kc green
2022-11-30 33430, 2022
chinmay
mayhem: payment received 💯
2022-11-30 33439, 2022
alastairp
🎉
2022-11-30 33441, 2022
alastairp
well done chinmay!
2022-11-30 33447, 2022
mayhem
yay! no hassles, it just appeared in your account?
2022-11-30 33453, 2022
chinmay
Yeah!
2022-11-30 33402, 2022
alastairp
(well done mayhem for making that happen too!)
2022-11-30 33418, 2022
mayhem
:)
2022-11-30 33420, 2022
chinmay
Thanks alastairp :)
2022-11-30 33427, 2022
mayhem
perhaps lucifer should change banks. :)
2022-11-30 33433, 2022
alastairp
what a great year of projects this year
2022-11-30 33437, 2022
chinmay
Lol
2022-11-30 33420, 2022
chinmay
Love you, MetaBrainz ❤️
2022-11-30 33459, 2022
mayhem
now what we need is to find a volunteer who will constantly watch the fresh releases and import missing cover art.
2022-11-30 33442, 2022
alastairp
jivte__: thanks for the report, this is actually an issue with our development environment when a new developer needs to do something that involves MBIDs and MSIDs. This is definitely something that we need to fix so that new developers can set up listenbrainz and work with it
2022-11-30 33440, 2022
jivte__
alastairp: anything I could do to solve it
2022-11-30 33456, 2022
alastairp
jivte__: yes, I think you should be able to create the database table but with no data in it, so the operation should run but just return no data
2022-11-30 33407, 2022
alastairp
however I believe we don't have an automated way to do this.
2022-11-30 33421, 2022
alastairp
jivte__: how familiar are you with postgresql and the psql query console?
2022-11-30 33453, 2022
jivte__
I know sql databases but not much as I mainly work with mongoDB.
if you set it to api.listenbrainz.org then the react frontend should request this data from the main listenbrainz server instead of requesting it from your server
2022-11-30 33428, 2022
jivte__
okk okk
2022-11-30 33443, 2022
saumon has quit
2022-11-30 33444, 2022
jivte__
after setting I should run the magic script again right
2022-11-30 33409, 2022
alastairp
sorry, which magic script is that?
2022-11-30 33431, 2022
jivte__
./develop.sh up
2022-11-30 33452, 2022
alastairp
ah yes, right. stop the original one that you ran, and run it again
2022-11-30 33402, 2022
jivte__
alastairp: thank you so much IT is gone finally :)
