#metabrainz

[musicbrainz-server] 14mwiencek opened pull request #2769 (03master…mbs-12630): MBS-12630: Make the relationship type autocompletes more compact https://github.com/metabrainz/musicbrainz-serve...

lucifer: Hey I figured out the errors in frontend and resolved them and afterwards ran all the tests successfully and then pushed the changes

can u kindly review it :)

aerozol: asking chatgpt about picard is indeed quite impressive https://usercontent.irccloud-cdn.com/file/Okc6h...

it didn't get the date thing right. but given that I just gave a very rough description of my file naming wishes it answered this question very well https://usercontent.irccloud-cdn.com/file/Rgs6O...

[musicbrainz-server] 14reosarevok opened pull request #2770 (03master…MBS-12780): MBS-12780: Fix allowNew check for AddRelationship https://github.com/metabrainz/musicbrainz-serve...

O’Moin

Morning yvanzo

\o/

|o|

rdswift: we may release Picard 2.9 alpha version before Christmas

lucifer: Do you remember why we had SIR failing with - 'sessionmaker' object has no attribute 'query' - prior to merging the SQLAlchemy 1.4 PR (that was on dff0a113)?

yvanzo: yes, this commit had fixed the issue iirc. https://github.com/metabrainz/sir/commit/5d86c7...

it was introduced by https://github.com/metabrainz/sir/commit/ce8bf4... i think.

Thank you!

reosarevok: SIR PRs #136 and #137 couldn’t have ever been working (but generating triggers) because of the above issue.

[musicbrainz-server] 14reosarevok opened pull request #2771 (03master…MBS-12740): MBS-12740: Convert Delete attribute page to React https://github.com/metabrainz/musicbrainz-serve...

yvanzo: oh, ok :) These were theoretical PRs, not tested locally - and I never claimed I had :) (hence the AFAICT disclaimers)

But now we have proper indexing tests, I guess I could look into add some tests for those at the very least

s/into add/into adding/

Unfortunately we don’t because these have been added along with this same issue.

Oh, I guess I misunderstood the "this commit had fixed the issue" bit as "we can just fix the issue applying this on the branch" :)

reosarevok: As a workaround it can based on the branch "released-master" (which matches the latest v3.0.1); See PR #157

reosarevok: The fix comes after the migration to SQLAlchemy 1.4 which isn’t running properly for now.

Oh, so it's 1.4 dependent? Ok then

I tried cherry-picking at least.

The branch "released-master" is temporary only until the next release whichever new features set or stable SQLAlchemy 1.4 comes first.

How's the 1.4 improvement going? I saw more and more entities are getting back to 3.0.1 speeds

recording index is the blocking point atm

and the only blocking point for full reindex

I don’t think that live reindex will be an issue but it cannot tested for perfs without recording

that's about it :)

yvanzo, for live index i don't think recording will do OOM. could try testing it.

i am not sure why it OOMs for recordings but simplest explanation would be that it has the largest amount of data to process. for live reindex, the number of entities being processed at a given time are low so might not be an issue.

lucifer: yes but it requires a full index to test it for real :)

ah ok, makes sense

I’m not worrying about it either

lucifer: maybe we can add more parameters to config.ini if that can help with fine tuning it?

if there is a need for specific settings not to OOM on recording for example

yes makes sense i think. maybe lower number of processes or batch size for only specific cores: recording for now.

reosarevok: Getting a better picture of dependencies for new search features :)

lucifer: Hey fixed the error and pushed the code

jivte: thanks, running actions again. if everything passes, i'll merge it.

okk and thanks so much for being so helping me out

[listenbrainz-server] 14amCap1712 merged pull request #2274 (03master…New-Terminilogy): Terminology Updated https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-android] 1407jasjeet opened pull request #164 (03master…MOBILE-68): Mobile 68 And Mobile 69 https://github.com/metabrainz/musicbrainz-andro...

Don't suppose anyone can point me to a release that has a PNG for the front cover art in the cover art archive?

Updating flactag to handle it, it only supports JPEGs at the moment.

akshaaatt: Created pr on musicBrainz as well check it out!

Hi jasje ! I’m really enjoying the work which you are doing on the android apps.

Idk if you are aware, but https://blog.metabrainz.org/2022/10/13/mobile-a... was decided a while back

adhawkins, I just uploaded a png to https://beta.musicbrainz.org/release/7a0827cd-f...

I just want you to be aware of it. However, this doesn't mean that we do not want to work on the MusicBrainz android app. I love it!

We just need more focused devs. Feel free to work on either/both the apps in future as per your convenience! Thank you so much!

Once your PR for MB android is merged by me, let me know what you would like to work on next. It'll be great if we have a discussion on your interests for the apps

akshaaatt: Yes i know i read the blogposts on newsbrainz

i would like to work on listenBrainz primarily but ofcourse work on anything necessary for musicBrainz

Mainly will do anything that alleviates some pressure off of you guys

lucifer: Hey I would like to work on LB-1046 ticket and if I can work can u please explain the ticket a little more

LB-1046: Add a "Add to Playlist" option to listen dropdown https://tickets.metabrainz.org/browse/LB-1046

like what changes do we expect?

Lotheric: Thanks. Would be easier if it were on the 'main' site. Will work with that one unless I find another.

Ah, seems to be accessible from the main URL too. Thanks Lotheric.

jivte: i need to discuss how to implement that with monkey. also how the ui should work will need to be decided with monkey and aerozol so i suggest to leave it for now. (monkey is not around today)

adhawkins, yeah beta and main share the same database

for tests there is test.musicbrainz.org where you can try stuff out

Got it,. thanks Lotheric

lucifer: okk thanks like could u please tell what kind of issues you handle so maybe I can work on them :)

jivte: you can try working on LB-1111.

LB-1111: Cover art not shown on recommendation pages https://tickets.metabrainz.org/browse/LB-1111

thanks will work on it

as the comment on the ticket says that some of the fields are missing in the response.

the server adds metadata to the recommendations here: https://github.com/metabrainz/listenbrainz-serv...

`_get_playable_recommendations_list` function further calls internally https://github.com/metabrainz/listenbrainz-serv...

this is the complete list of fields available. some of these are not used by the `_get_playable_recommendations_list` function.

to fix the issue, look into other uses of `load_recordings_from_mbids` in the codebase and then add the fields which are missing in `_get_playable_recommendations_list` by taking help from how its done in other places

okk understood will try and then inform you

👍

aerozol, reosarevok: does showing release group cover art as a fallback for listens solve LB-1119?

LB-1119: Fetch correct artwork for pseudo-releases https://tickets.metabrainz.org/browse/LB-1119

The ticket is right that the best option would be to follow the relationship

But it might be fine to just fall back to the RG tbh

Especially since soon bitmap will implement the alternative tracklists and pseudos will go away, right bitmap? :D

ah cool. getting that link and following it would be too much work for not much benefit i think.

especially because currently we don't have a way to detect whether a release is psuedo release in LB.

yvanzo: I rebased those two SIR PRs to be on top of released-master

What should be the next step?

<zas> "rdswift: we may release Picard 2.9 alpha version before Christmas" Okay, thanks. I'll be away for a week or two around Christmas so I'll merge all 2.9 documentation changes into a single branch and keep it up-to-date so that there will be only one merge required in case I'm away when it happens.

reosarevok: Testing it

rdswift: thanks

Actually, two merges because the second one will be to update the translation files. ;-)

Will the 2.9 release be tagged as an alpha or beta?

So I get it right in the config file.

lucifer: I silenced the alert for a day

yvanzo: thanks!

yvanzo: the recording index has currently been running fine on wolf with 4gb shared buffers. ofc taking longer. can you share the 1) vm specs 2) postgresql.conf 3) oom logs both pg and linux syslogs of the vm that crashes with recording core.

Sorry, I just re-read zas' note. Alpha it is.

i want to try and reproduce the error on wolf so that we can know what exactly causes the crash.

lucifer: 3½) PG logs are under ~musicbrainz/log-dc96c30-master/*.db.stderr.log already

lucifer: 1) which specs/commands do you need exactly?

reosarevok> Especially since soon bitmap will implement the alternative tracklists and pseudos will go away, right bitmap? :D riiiight bitmap??? 🥺

yvanzo: yes but those are from wolf where the index completes. i am talking about the db logs when the indexing crashes. re specs, i think `lscpu` and `free` should suffice.

Oops sorry!

lucifer: for which branch/commit of sir?

yvanzo: current master probably but any commit where recording core crashes would work

lucifer: here is the setup: https://gist.github.com/yvanzo/393f1b59aa8812e1... (postgresql.conf is the same as in musicbrainz-docker)

I’m be looking for logs now (if these are still available)

lucifer: full logs (sir, pg, dmesg) for last OOM on building recording index under ~musicbrainz/log-recording-14db7a1-raiseload-rebased-on-dc96c30-master/

(on wolf)

thanks yvanzo!

yvanzo: on this vm can you trigger a recording index with cores configured to 2 (it has 4. so half)?

lucifer: I guess using https://docs.docker.com/compose/compose-file/co...

yvanzo: ah no, only changing sir config. `import_threads` options

sorry for the confusion i meant threads/processes above not cpu cores.

Ok, from 8 to 4, right?

but that vm has only 4 cpus right?