rdswift: we may release Picard 2.9 alpha version before Christmas
2022-12-06 34052, 2022
yvanzo
lucifer: Do you remember why we had SIR failing with - 'sessionmaker' object has no attribute 'query' - prior to merging the SQLAlchemy 1.4 PR (that was on dff0a113)?
yvanzo: oh, ok :) These were theoretical PRs, not tested locally - and I never claimed I had :) (hence the AFAICT disclaimers)
2022-12-06 34021, 2022
reosarevok
But now we have proper indexing tests, I guess I could look into add some tests for those at the very least
2022-12-06 34029, 2022
reosarevok
s/into add/into adding/
2022-12-06 34010, 2022
yvanzo
Unfortunately we don’t because these have been added along with this same issue.
2022-12-06 34017, 2022
reosarevok
Oh, I guess I misunderstood the "this commit had fixed the issue" bit as "we can just fix the issue applying this on the branch" :)
2022-12-06 34026, 2022
yvanzo
reosarevok: As a workaround it can based on the branch "released-master" (which matches the latest v3.0.1); See PR #157
2022-12-06 34022, 2022
yvanzo
reosarevok: The fix comes after the migration to SQLAlchemy 1.4 which isn’t running properly for now.
2022-12-06 34043, 2022
reosarevok
Oh, so it's 1.4 dependent? Ok then
2022-12-06 34020, 2022
Sophist_UK has quit
2022-12-06 34050, 2022
yvanzo
I tried cherry-picking at least.
2022-12-06 34027, 2022
yvanzo
The branch "released-master" is temporary only until the next release whichever new features set or stable SQLAlchemy 1.4 comes first.
2022-12-06 34020, 2022
reosarevok
How's the 1.4 improvement going? I saw more and more entities are getting back to 3.0.1 speeds
2022-12-06 34009, 2022
Sophist-UK joined the channel
2022-12-06 34002, 2022
yvanzo
recording index is the blocking point atm
2022-12-06 34008, 2022
yvanzo
and the only blocking point for full reindex
2022-12-06 34057, 2022
yvanzo
I don’t think that live reindex will be an issue but it cannot tested for perfs without recording
2022-12-06 34016, 2022
yvanzo
that's about it :)
2022-12-06 34017, 2022
lucifer
yvanzo, for live index i don't think recording will do OOM. could try testing it.
2022-12-06 34003, 2022
lucifer
i am not sure why it OOMs for recordings but simplest explanation would be that it has the largest amount of data to process. for live reindex, the number of entities being processed at a given time are low so might not be an issue.
2022-12-06 34005, 2022
yvanzo
lucifer: yes but it requires a full index to test it for real :)
2022-12-06 34013, 2022
lucifer
ah ok, makes sense
2022-12-06 34033, 2022
yvanzo
I’m not worrying about it either
2022-12-06 34034, 2022
yvanzo
lucifer: maybe we can add more parameters to config.ini if that can help with fine tuning it?
2022-12-06 34016, 2022
yvanzo
if there is a need for specific settings not to OOM on recording for example
2022-12-06 34030, 2022
lucifer
yes makes sense i think. maybe lower number of processes or batch size for only specific cores: recording for now.
2022-12-06 34046, 2022
yvanzo
reosarevok: Getting a better picture of dependencies for new search features :)
2022-12-06 34002, 2022
Maxr1998 joined the channel
2022-12-06 34034, 2022
Maxr1998_ has quit
2022-12-06 34010, 2022
jivte joined the channel
2022-12-06 34044, 2022
jivte
lucifer: Hey fixed the error and pushed the code
2022-12-06 34044, 2022
lucifer
jivte: thanks, running actions again. if everything passes, i'll merge it.
2022-12-06 34010, 2022
jivte
okk and thanks so much for being so helping me out
I just want you to be aware of it. However, this doesn't mean that we do not want to work on the MusicBrainz android app. I love it!
2022-12-06 34024, 2022
jasje has quit
2022-12-06 34052, 2022
akshaaatt
We just need more focused devs. Feel free to work on either/both the apps in future as per your convenience! Thank you so much!
2022-12-06 34025, 2022
akshaaatt
Once your PR for MB android is merged by me, let me know what you would like to work on next. It'll be great if we have a discussion on your interests for the apps
2022-12-06 34059, 2022
jasje joined the channel
2022-12-06 34036, 2022
jasje
akshaaatt: Yes i know i read the blogposts on newsbrainz
2022-12-06 34016, 2022
jasje
i would like to work on listenBrainz primarily but ofcourse work on anything necessary for musicBrainz
2022-12-06 34004, 2022
jasje
Mainly will do anything that alleviates some pressure off of you guys
2022-12-06 34057, 2022
jasje has quit
2022-12-06 34020, 2022
jivte
lucifer: Hey I would like to work on LB-1046 ticket and if I can work can u please explain the ticket a little more
Lotheric: Thanks. Would be easier if it were on the 'main' site. Will work with that one unless I find another.
2022-12-06 34022, 2022
adhawkins
Ah, seems to be accessible from the main URL too. Thanks Lotheric.
2022-12-06 34055, 2022
lucifer
jivte: i need to discuss how to implement that with monkey. also how the ui should work will need to be decided with monkey and aerozol so i suggest to leave it for now. (monkey is not around today)
2022-12-06 34029, 2022
Lotheric
adhawkins, yeah beta and main share the same database
this is the complete list of fields available. some of these are not used by the `_get_playable_recommendations_list` function.
2022-12-06 34004, 2022
lucifer
to fix the issue, look into other uses of `load_recordings_from_mbids` in the codebase and then add the fields which are missing in `_get_playable_recommendations_list` by taking help from how its done in other places
2022-12-06 34030, 2022
jivte
okk understood will try and then inform you
2022-12-06 34039, 2022
lucifer
👍
2022-12-06 34049, 2022
lucifer
aerozol, reosarevok: does showing release group cover art as a fallback for listens solve LB-1119?
The ticket is right that the best option would be to follow the relationship
2022-12-06 34001, 2022
reosarevok
But it might be fine to just fall back to the RG tbh
2022-12-06 34021, 2022
reosarevok
Especially since soon bitmap will implement the alternative tracklists and pseudos will go away, right bitmap? :D
2022-12-06 34054, 2022
lucifer
ah cool. getting that link and following it would be too much work for not much benefit i think.
2022-12-06 34057, 2022
lucifer
especially because currently we don't have a way to detect whether a release is psuedo release in LB.
2022-12-06 34028, 2022
reosarevok
yvanzo: I rebased those two SIR PRs to be on top of released-master
2022-12-06 34041, 2022
reosarevok
What should be the next step?
2022-12-06 34052, 2022
rdswift
<zas> "rdswift: we may release Picard 2.9 alpha version before Christmas" Okay, thanks. I'll be away for a week or two around Christmas so I'll merge all 2.9 documentation changes into a single branch and keep it up-to-date so that there will be only one merge required in case I'm away when it happens.
2022-12-06 34024, 2022
yvanzo
reosarevok: Testing it
2022-12-06 34032, 2022
outsidecontext
rdswift: thanks
2022-12-06 34052, 2022
rdswift
Actually, two merges because the second one will be to update the translation files. ;-)
2022-12-06 34029, 2022
rdswift
Will the 2.9 release be tagged as an alpha or beta?
2022-12-06 34006, 2022
rdswift
So I get it right in the config file.
2022-12-06 34055, 2022
yvanzo
lucifer: I silenced the alert for a day
2022-12-06 34046, 2022
lucifer
yvanzo: thanks!
2022-12-06 34008, 2022
lucifer
yvanzo: the recording index has currently been running fine on wolf with 4gb shared buffers. ofc taking longer. can you share the 1) vm specs 2) postgresql.conf 3) oom logs both pg and linux syslogs of the vm that crashes with recording core.
2022-12-06 34034, 2022
rdswift
Sorry, I just re-read zas' note. Alpha it is.
2022-12-06 34047, 2022
lucifer
i want to try and reproduce the error on wolf so that we can know what exactly causes the crash.
2022-12-06 34035, 2022
yvanzo
lucifer: 3½) PG logs are under ~musicbrainz/log-dc96c30-master/*.db.stderr.log already
2022-12-06 34032, 2022
yvanzo
lucifer: 1) which specs/commands do you need exactly?
2022-12-06 34019, 2022
KassOtsimine
reosarevok> Especially since soon bitmap will implement the alternative tracklists and pseudos will go away, right bitmap? :D riiiight bitmap??? 🥺
2022-12-06 34021, 2022
lucifer
yvanzo: yes but those are from wolf where the index completes. i am talking about the db logs when the indexing crashes. re specs, i think `lscpu` and `free` should suffice.
2022-12-06 34021, 2022
yvanzo
Oops sorry!
2022-12-06 34000, 2022
yvanzo
lucifer: for which branch/commit of sir?
2022-12-06 34003, 2022
lucifer
yvanzo: current master probably but any commit where recording core crashes would work
I’m be looking for logs now (if these are still available)
2022-12-06 34005, 2022
jivte has quit
2022-12-06 34045, 2022
Aswin joined the channel
2022-12-06 34024, 2022
Aswin has quit
2022-12-06 34010, 2022
yvanzo
lucifer: full logs (sir, pg, dmesg) for last OOM on building recording index under ~musicbrainz/log-recording-14db7a1-raiseload-rebased-on-dc96c30-master/
2022-12-06 34019, 2022
yvanzo
(on wolf)
2022-12-06 34028, 2022
lucifer
thanks yvanzo!
2022-12-06 34000, 2022
lucifer
yvanzo: on this vm can you trigger a recording index with cores configured to 2 (it has 4. so half)?
