bitmap: has anyone mentioned in the beta that if you add a new artist from the relationship editor the interface goes a bit fuzzy/eye-watering? I couldn’t find a note anywhere, shall I add a comment to MBS-11847? Or is it known somewhere else?
Bit hard to see in this screenshot, but it’s being scaled or something weird in a just slight enough way to give me a bit of a headache on my screen :( https://usercontent.irccloud-cdn.com/file/7j7Vg1N…
2022-12-09 34325, 2022
jasje joined the channel
2022-12-09 34354, 2022
jasje has quit
2022-12-09 34357, 2022
piwu9 joined the channel
2022-12-09 34350, 2022
DjSlash has quit
2022-12-09 34351, 2022
piwu has quit
2022-12-09 34351, 2022
s1b1 has quit
2022-12-09 34351, 2022
piwu9 is now known as piwu
2022-12-09 34335, 2022
DjSlash joined the channel
2022-12-09 34311, 2022
jasje joined the channel
2022-12-09 34345, 2022
s1b1 joined the channel
2022-12-09 34308, 2022
jasje has quit
2022-12-09 34343, 2022
jivte joined the channel
2022-12-09 34308, 2022
jivte has quit
2022-12-09 34302, 2022
lucifer
mayhem: yes doing it currently on artist mbids instead of artist credit id. do you mean that we should instead calculate similarity of artist credit ids but filter out same artist using artist mbid? so find similarity between `A ft. B` and `B ft. C` but filter out A, B, C from similarity index.
2022-12-09 34302, 2022
vibhoo_24 joined the channel
2022-12-09 34304, 2022
vibhoo_24
hi @lucifer...I tried exploring the listenbrainz website locally and I also tried learning docker basics.Should I start working on some bugs?
2022-12-09 34317, 2022
lucifer
vibhoo_24: yes. try to find a ticket to work on from tickets.metabrainz.org . if are unable to find one, let us know and we'll help
2022-12-09 34359, 2022
vibhoo_24 has quit
2022-12-09 34320, 2022
tykling has quit
2022-12-09 34317, 2022
vibhoo_24 joined the channel
2022-12-09 34356, 2022
vibhoo_24 has quit
2022-12-09 34326, 2022
tykling joined the channel
2022-12-09 34358, 2022
Rishabh joined the channel
2022-12-09 34300, 2022
strider has quit
2022-12-09 34320, 2022
strider joined the channel
2022-12-09 34359, 2022
v6lur joined the channel
2022-12-09 34309, 2022
v6lur has quit
2022-12-09 34305, 2022
mayhem
lucifer: yes, I think that is right. lets try that.
2022-12-09 34354, 2022
Rishabh has quit
2022-12-09 34357, 2022
monkey
Mornin'. My Glob, jetlag is real.
2022-12-09 34325, 2022
monkey
mayhem: I'll have to see if a URL to an SVG would work for all the sharing stuff, I have no idea.
2022-12-09 34335, 2022
monkey
I assumed it would have to be a more common image format, but…
Oh, quite interesting. I knew Twitter was the least likely to support svg..
2022-12-09 34343, 2022
monkey
Not sure what's going on there to be honest. They might support SVG. I think it's just the tool I'm usign, will conduct more testing
2022-12-09 34345, 2022
monkey
Anything with cover art won't load, so that's out.
2022-12-09 34321, 2022
monkey
And I confirm it's the same for the custom fonts, it won't load them. So aerozol that's going to limit your range, the preview will only use default browser fonts
On today's episode of "reosarevok tries something dumb, finds it's allowed"
2022-12-09 34308, 2022
monkey
lol
2022-12-09 34317, 2022
reosarevok
aerozol: is it vandalism if you respond to everything with the eggplant emoji? :p
2022-12-09 34324, 2022
monkey
An infinity of monkeys with an infinity of keyboards…
2022-12-09 34340, 2022
lucifer
monkey: they don't support svg.
2022-12-09 34342, 2022
lucifer
>A URL to a unique image representing the content of the page. You should not use a generic image such as your website logo, author photo, or other image that spans multiple pages. Images for this Card support an aspect ratio of 2:1 with minimum dimensions of 300x157 or maximum of 4096x4096 pixels. Images must be less than 5MB in size. JPG, PNG, WEBP and GIF formats are supported. Only the first frame of an animated GIF will be
2022-12-09 34342, 2022
lucifer
used. SVG is not supported.
2022-12-09 34314, 2022
monkey
Bleh.
2022-12-09 34307, 2022
monkey
At this point, between the lack of custom font and the lack of SVG support I wonder if we should just generate an image for each user
There are more, but none that we can act on right away I think.
2022-12-09 34322, 2022
monkey
So green light ! :)
2022-12-09 34322, 2022
lucifer
right makes sense
2022-12-09 34341, 2022
lucifer
should i open a PR or are you on it?
2022-12-09 34325, 2022
monkey
Please do :)
2022-12-09 34332, 2022
lucifer
👍
2022-12-09 34342, 2022
lucifer
thoughts on name the new folder `listenbrainz-frontend`?
2022-12-09 34315, 2022
monkey
What about just `frontend`? Not like we're likely to have other front-ends in there
2022-12-09 34327, 2022
lucifer
makes sense
2022-12-09 34313, 2022
monkey
Was doing a quick test of PNG size: Original SVG: 6Ko (of course), PNG: 550Ko, JPG 765Ko.
2022-12-09 34313, 2022
monkey
I'm expecting a 2:1 aspect ratio version to be roughly around half of those sizes.
2022-12-09 34359, 2022
Maxr1998_ joined the channel
2022-12-09 34310, 2022
lucifer
if we take 0.5MB per image * 10k users at max, ~5 GB storage needed.
2022-12-09 34329, 2022
Maxr1998 has quit
2022-12-09 34304, 2022
alastairp
monkey: what does pngcrush do to that png?
2022-12-09 34311, 2022
alastairp
(hi, good morning)
2022-12-09 34332, 2022
monkey brews
2022-12-09 34334, 2022
monkey
Hi!
2022-12-09 34322, 2022
mayhem
lucifer: yes, sounds right.
2022-12-09 34351, 2022
monkey
alastairp: Good call. 550 -> 400 Ko
2022-12-09 34335, 2022
alastairp
5gb is nothing, anyway - both for storage and data transfer
2022-12-09 34325, 2022
alastairp
one trick would be to have a URL which builds it on demand if it doesn't exist and then save it - subsequent requests just serve the generated file (I'm unsure how long generation takes), so we'd only generate/store for users who actually use the card
2022-12-09 34319, 2022
lucifer
mayhem: ok. can try that. oh but just realised, i am not sure if it'll work though because band members don't usually occur in the same artist credit anyway?
2022-12-09 34322, 2022
mayhem
That is the whole point of this change... We should be moving the similarity comparison to the artist credit level.
2022-12-09 34302, 2022
mayhem
We want to find out which bands are similar, rather then which individual artists are similar. (Painting this with a very broad brush here)
2022-12-09 34322, 2022
lucifer
i mean yes but bands and artists are both represented by artist mbids in MB
2022-12-09 34329, 2022
lucifer
*individual artists
2022-12-09 34314, 2022
lucifer
the artist credit in this case is only relevant to how their name appears on a track iiuc.
2022-12-09 34359, 2022
lucifer
i think we'll need to export artist relationship data from MB to spark and add some filters to remove artists from same band from the similarity list.
Horace Andy is a member of massive attack. He should not be in the results.
2022-12-09 34333, 2022
mayhem
Elizabeth Fräser and Robert de nala too
2022-12-09 34351, 2022
lucifer
i see.
2022-12-09 34351, 2022
lucifer
i'll add the artist credit level thing for testing. but i think we'll need to use MB relationships to do this filtering properly.
2022-12-09 34319, 2022
monkey
> one trick would be to have a URL which builds it on demand if it doesn't exist and then save it
2022-12-09 34319, 2022
monkey
I suppose that would be each user's YIM page itself
2022-12-09 34326, 2022
alastairp
there's a meta tag for the card image, right?
2022-12-09 34335, 2022
lucifer
yes
2022-12-09 34315, 2022
yvanzo
lucifer: not really any effect, as mentioned yesterday.
2022-12-09 34333, 2022
lucifer
yvanzo: oh, crashed again?
2022-12-09 34355, 2022
yvanzo
after about the same time with about the same amount of memory
2022-12-09 34324, 2022
lucifer
i see. makes sense
2022-12-09 34358, 2022
monkey
alastairp: yes. Are you thinking of using the image URL to build on demand?
2022-12-09 34320, 2022
lucifer
yvanzo: thoughts on what to do then? since 3.0.1 also crashes with same amount of memory.
2022-12-09 34302, 2022
alastairp
monkey: so I'm saying to have something like `<meta property="og:image" content="https://listenbrainz.org/yim-2022/us… />`, which is actually a flask route, which generates/saves the png, and serves it from cache if it's already generated
2022-12-09 34317, 2022
monkey
Right.
2022-12-09 34326, 2022
alastairp
monkey: but I would only suggest that if we think it's infeasible to pre-generate and store for all users
2022-12-09 34343, 2022
monkey
I suppose image generation would be quick enough to actually serve the image the first time around?
2022-12-09 34311, 2022
alastairp
yeah, exactly. in the case that it's 1-2 seconds max to generate the image then we could definitely generate/serve it the first request
2022-12-09 34319, 2022
lucifer
how long would we want to keep this around? 1 year, forever?
2022-12-09 34329, 2022
monkey
I think a mechanism like that would make sense, especially if we want users to be able to generate images for other stats
2022-12-09 34344, 2022
lucifer
this image will always be needed or just the first time the social media site renders the card?
2022-12-09 34300, 2022
monkey
i.e. useful for the OG meta tags, but also for "share your top 10 albums" feature
2022-12-09 34305, 2022
alastairp
kind of why I put the year in the url... as long as we had the stats we could generate it at any time. I guess we plan on removing it after a year?
2022-12-09 34324, 2022
alastairp
lucifer: I don't know if social sites just deep link to the image or if they cache it
2022-12-09 34354, 2022
lucifer
i see, maybe there's something in the spec but will have to check.
2022-12-09 34317, 2022
yvanzo
lucifer: It’s weird indeed. It used to work with these settings though. It even used to work on less powerful development stations too.
2022-12-09 34325, 2022
lucifer
yvanzo: maybe we should try with an even older release then. one prior to the schema change and see if that works? if that still fails maybe an issue in vm conf otherwise.
2022-12-09 34331, 2022
lucifer
monkey: is there any reason to keep config files like webpack.config.js etc in root, or should those be moved to frotned dir as well?
2022-12-09 34311, 2022
yvanzo
lucifer: The most impacting change was about (recording/release/release-group) first release date.
2022-12-09 34351, 2022
monkey
I reckon it could all go into frontend, along with the package.json etc. Which means node_modules would also end up in there and need to be ignored
2022-12-09 34353, 2022
yvanzo
lucifer: I will try previous versions and see. But I wonder if there would be a way to make SIR freed its memory sooner after having built some index entries.
2022-12-09 34332, 2022
lucifer
yvanzo: that was the intent of reducing query batch size. but that made it crash even faster. can you try with query batch size of say 1000?
alastairp: Do we even need to save the generated image? We could use our regular art API routes with an extra image format option and just use a py library to generate a PNG on the spot and return that?
2022-12-09 34321, 2022
alastairp
monkey: right, saving it is just an optimisation trick. if it's fast (<0.2s?) then we could generate on demand each time
2022-12-09 34340, 2022
monkey
I think those rotes would be very useful for embedding
2022-12-09 34343, 2022
monkey
routes
2022-12-09 34355, 2022
monkey
Currently embedding the SVGs is a tiny bit tricky
2022-12-09 34320, 2022
monkey
The text-based ones would be fast, the cover art based ones less so
