Looking into post #5 by UltimateRiff which has 1 bug (possibly a regression) about “Change credits for other relationships”, 1 improvement suggestion for “Credited as”, 1 regression about edits submission delay.
2023-02-03 03417, 2023
bitmap
I'm pretty sure we include a pager in the ws/js output
2023-02-03 03427, 2023
bitmap
so it may be possible to improve
2023-02-03 03438, 2023
reosarevok
Ok, then I can add a ticket
2023-02-03 03424, 2023
bitmap
yvanzo: the edit submission delay might be MBS-12832
MBS-11811: Make Tracklist editing buttons behave consistently on collapsed mediums
2023-02-03 03454, 2023
reosarevok
That's what I was thinking of
2023-02-03 03439, 2023
reosarevok
We intentionally changed the release editor behaviour to *not* run on collapsed mediums, since that could cause edits that are invisible to the editor until they submit
2023-02-03 03459, 2023
reosarevok
(and might be wrong, or at the very least unchecked)
2023-02-03 03447, 2023
bitmap
hmm, right
2023-02-03 03436, 2023
bitmap
not sure what should happen to the track selections if you select a mediumm and then collapse it
2023-02-03 03420, 2023
reosarevok
Me neither. I guess we could automatically expand it again if something changes?
2023-02-03 03427, 2023
reosarevok
That could be a good compromise
2023-02-03 03427, 2023
bitmap
yeah, maybe
2023-02-03 03417, 2023
reosarevok
I don't think this is a "delay the release" issue, or even a bug necessarily
2023-02-03 03420, 2023
reosarevok
But a ticket would be good
2023-02-03 03425, 2023
yvanzo
bitmap: Is there a ticket for dynamically loading numerous medium in the release relationship editor?
2023-02-03 03442, 2023
yvanzo
(dynamically/lazily)
2023-02-03 03442, 2023
reosarevok
"expand all" like in the release editor?
2023-02-03 03431, 2023
bitmap
there is MBS-7919 which I forgot about, but it's more about collapsing than lazy-loading
I'm not sure if there's one for the dynamic loading aspect
2023-02-03 03452, 2023
reosarevok
Yeah, that should be set as in beta testing
2023-02-03 03408, 2023
bitmap
don't see one with search
2023-02-03 03422, 2023
reosarevok
Hmm, one thing that I saw in that thread re:accessibility, do text readers move by tabbing? Because the fact that tab selects the first autocomplete result might make a mess for blind people if so
bitmap: Would you prefer to edit MBS-7919 to mention lazily loading too, or have a separate ticket for it?
2023-02-03 03440, 2023
reosarevok
Sorry, not release editor, release index, my bad
2023-02-03 03413, 2023
bitmap
yvanzo: hmm, I think editing it is fine since they're pretty related features
2023-02-03 03421, 2023
reosarevok
I would not, actually
2023-02-03 03429, 2023
reosarevok
I think that ticket is solved by the current editor
2023-02-03 03434, 2023
reosarevok
(I'd know, it's mine :D )
2023-02-03 03405, 2023
reosarevok
I would add an improvement ticket to add expand all / collapse all options to both the release editor *and* the relationship editor in one go
2023-02-03 03418, 2023
yvanzo
The current release relationship editor doesn’t allow collapsing, or am I missing something?
2023-02-03 03434, 2023
reosarevok
The current *beta* editor I meant :)
2023-02-03 03439, 2023
reosarevok
It already does what I asked for
2023-02-03 03447, 2023
reosarevok
The expand all thing with lazy loading is a different feature
2023-02-03 03449, 2023
jivte has quit
2023-02-03 03408, 2023
yvanzo
We are only speaking about the release relationship editor here.
2023-02-03 03429, 2023
reosarevok
(I'd also like that, but it's not an inseparable part of the other, as you can see by the fact the release editor has collapsing and expanding but no option to load all AFAICT)
2023-02-03 03433, 2023
yvanzo
Or do you mean that lazy loading is implemented the same way for both the release editor and the release relationship editor?
2023-02-03 03452, 2023
reosarevok
I mean neither has lazy loading now, and we should implement it for both :)
2023-02-03 03453, 2023
yvanzo
(in beta)
2023-02-03 03424, 2023
reosarevok
But that it is, IMO, a different feature than the collapsing / expanding option itselfd
2023-02-03 03426, 2023
reosarevok
*itself
2023-02-03 03429, 2023
reosarevok
And a different ticket
2023-02-03 03436, 2023
bitmap
they both have lazy loading?
2023-02-03 03442, 2023
yvanzo
bitmap: isn’t the beta release relationship editor doing lazy loading when there are too many medium?
2023-02-03 03403, 2023
reosarevok
I mean, I assume the point is "let the user expand them all and load them in one go", because otherwise, both already do that :)
2023-02-03 03409, 2023
bitmap
yes
2023-02-03 03417, 2023
yvanzo
reosarevok: I cannot follow you.
2023-02-03 03425, 2023
reosarevok
Ok, I'm not sure what the lazy loading issue is then :D
2023-02-03 03430, 2023
reosarevok
Sorry
2023-02-03 03447, 2023
reosarevok
I thought this was about having one button to lazy-load all mediums in one go
2023-02-03 03402, 2023
reosarevok
(Because as far as I can tell, it already lazy-loads each medium on demand)
2023-02-03 03420, 2023
reosarevok
So, sorry for the confusing talk :D
2023-02-03 03421, 2023
bitmap
basically it will only load the first n mediums or tracks and the rest are only loaded once you expand them
the 'expand all' button is just a convenience feature for that, but not required for lazy loading
2023-02-03 03416, 2023
reosarevok
Oh
2023-02-03 03417, 2023
reosarevok
Wait
2023-02-03 03429, 2023
reosarevok
Were you asking if we should *document* the feature with a ticket?
2023-02-03 03441, 2023
reosarevok
I thought there was a bug you were bringing up :D
2023-02-03 03455, 2023
reosarevok
For documenting that they lazy-load, sure, the same ticket works :D
2023-02-03 03429, 2023
reosarevok
But I'll add a ticket for expanding all :)
2023-02-03 03442, 2023
yvanzo
There is a bug indeed, I’m just asking if there is a ticket for this new feature or if we should expand MBS-7919 to include this feature as these are closely related.
I keep writing the shit-tab issue, which might also be appropriate
2023-02-03 03457, 2023
bitmap
lol
2023-02-03 03416, 2023
reosarevok
I would talk to aerozol about shortcuts before adding them - I'm sure there's a lot that could be useful if we choose to go that way (e.g., expand/collapse all, lol)
2023-02-03 03455, 2023
reosarevok
But I'm always a bit worried about those because of sites that implement them in annoying ways which block basic features (sigh, discourse hijacking ctrl+f)
2023-02-03 03404, 2023
yvanzo
bitmap: what is the threshold for not loading last mediums?
2023-02-03 03417, 2023
reosarevok
Was it 100 total tracks?
2023-02-03 03423, 2023
reosarevok
Rings a bell, but
2023-02-03 03434, 2023
yvanzo
(in the beta release relationship editor)
2023-02-03 03412, 2023
bitmap
it loads up to 10 mediums or 100 tracks, whichever it hits first
