That's why we need to indicate the difference in a clearer way (and having the icon allows for a link to the edits, which is useful)
2023-06-12 16343, 2023
CatQuest
oh!
2023-06-12 16348, 2023
reosarevok
So adding an icon is probably happening, just not sure which :)
2023-06-12 16350, 2023
CatQuest
how about an orange exlamation mark instead
2023-06-12 16337, 2023
CatQuest
like "oh! notice, this entity already has open edits on it"
2023-06-12 16306, 2023
CatQuest
somewhat like if you're doing something that clashs with osmething it wil give an red exlamation to wanr you, an orange will be like "oh btu already we have dits"
MBS-12942: Consider indicating pending edits for an entity in the relationship editor
2023-06-12 16336, 2023
CatQuest
we already did this aages ago in.. pre ngs iirc, howwe did it then?
2023-06-12 16310, 2023
aerozol
My pick atm is the clock, which was suggested by atj, but happy for more people to comment on the ticket
2023-06-12 16316, 2023
CatQuest
orange yellow for "is being edited/has pending" is established mb colour cannon imho fwiw
2023-06-12 16333, 2023
CatQuest
the pencil is deff a no-go
2023-06-12 16341, 2023
CatQuest
but i don't hate it for the edit icon :D
2023-06-12 16349, 2023
CatQuest
i'd liek "edit" as a flat button *better* but
2023-06-12 16316, 2023
TOPIC: [MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, static.meb/LE (zas), Passkeys on @meb accounts (reosarevok)
2023-06-12 16333, 2023
wargreen has quit
2023-06-12 16358, 2023
wargreen joined the channel
2023-06-12 16304, 2023
mayhem
reosarevok: I've added a agenda item to let the team know that I've enabled passkeys for all metabrainz google accounts. I clearly won't be there for the topic, but all that needs to be communicated is that this is an option for the team. people can read more here: https://support.google.com/accounts/answer/135483…
2023-06-12 16321, 2023
mayhem
so, if you could please handle that topic for me, great!
2023-06-12 16326, 2023
reosarevok
Sure
2023-06-12 16329, 2023
mayhem
thx
2023-06-12 16349, 2023
lucifer
monkey: i pushed the fix. and fixed a couple of other small bugs i had noticed.
2023-06-12 16327, 2023
lucifer
bugs in the created for and the playlist card selection.
2023-06-12 16335, 2023
aerozol
Night all! I check back on all pings btw, if you have thoughts on anything discussed in the last couple of hours
Hi, I'm having problems downloading my listens from listenbrainz, it keeps killing the download at 10MB and the json is corrupt. I tried emailing and posting on matrix, hoping I have a more fruitful time here
2023-06-12 16326, 2023
mayhem
hi codified!
2023-06-12 16349, 2023
codified
Hi Mayhem :)
2023-06-12 16350, 2023
mayhem
sorry for not getting back to you -- its been a busy week and things kept interrupting.
2023-06-12 16308, 2023
codified
no worries perfectly understand
2023-06-12 16320, 2023
mayhem
my listens didn't export correctly either when I tried, but I hadn't gotten further to look at the problem yet.
2023-06-12 16305, 2023
mayhem
let me take care of one more pressing thing, then I will look in more detail.
2023-06-12 16325, 2023
codified
For me it exits the generation at roughly 20%, it might be a memory issue
2023-06-12 16344, 2023
codified
Appreciate your time
2023-06-12 16310, 2023
mayhem
it it probably a gateway timeout issue. the request takes longer than our gateways are willing to keep the connection open for.
2023-06-12 16357, 2023
codified
Could be that yes, my previous pulls were getting over 60MB
2023-06-12 16359, 2023
mayhem
codified: actually, you might try that. do a couple more exports and see how long they take to fail.
2023-06-12 16321, 2023
codified
Let me see
2023-06-12 16306, 2023
mayhem
shit, now there are two pressing things, lol
2023-06-12 16354, 2023
codified
Started: 15:42:31, End: 15:42:44, so roughly over 10 seconds, 10.33MB pulled
2023-06-12 16302, 2023
codified
I'm not in a rush, I just wanted someone other than me to be aware of it :)
2023-06-12 16339, 2023
mayhem
the server logs are not showing anything abnormal.
2023-06-12 16350, 2023
codified
oh dear
2023-06-12 16312, 2023
codified
Maybe it's in the generator then?
2023-06-12 16346, 2023
mayhem
atj: zas: is there a gateway timeout that might interrupt long loading pages?
2023-06-12 16335, 2023
mayhem
the LB download your listens page take a while to generate its output, and I fear the gateways are closing the connection before the page is fully done.
2023-06-12 16334, 2023
codified
Especially with listens my size
2023-06-12 16351, 2023
codified
couple of years worth
2023-06-12 16302, 2023
atj
mayhem: currently 150s
2023-06-12 16311, 2023
mayhem
thanks. then that is not it.
2023-06-12 16339, 2023
mayhem
my listens (and more than just a couple of years worth) download fine and are consistent. (same md5sum)
2023-06-12 16334, 2023
codified
I thought it could be specific to mine, maybe an unhandled character, it ends at the same point each time if I don't listen to more in the meantime
2023-06-12 16329, 2023
mayhem
it may very well be that.
2023-06-12 16348, 2023
mayhem
but I would expect to see an error in the logs in that case.
and if that was the case, it would always error in the same place.
2023-06-12 16319, 2023
codified
I agree but if it's unhandled, no telling
2023-06-12 16338, 2023
mayhem
lucifer: any ideas?
2023-06-12 16357, 2023
mayhem has to do a final review on a unicorn
2023-06-12 16353, 2023
mayhem
let me take care of the critical tasks and I'll get back to you codified
2023-06-12 16335, 2023
codified
THanks for your time Mayhem!!
2023-06-12 16346, 2023
codified has quit
2023-06-12 16351, 2023
lucifer
atj: as long as some data is sent over http, the connection won't be close right? like downloading a large file which can take longer than 150s.
2023-06-12 16333, 2023
lucifer
mayhem: i don't have much idea. it does fail for me as well but that didn't use to be the case. we should probably revamp it to a background process either way.
2023-06-12 16306, 2023
mayhem
I had one export fail as well, so its flaky, for sure.
2023-06-12 16320, 2023
mayhem
but the background task is real bear to deal with.
2023-06-12 16359, 2023
lucifer
yup well :/
2023-06-12 16349, 2023
atj
lucifer: these timeouts are at the TCP level as opposed to HTTP, so my assumption is that if data is flowing the timeout will not be triggered
2023-06-12 16315, 2023
lucifer
atj: makes sense
2023-06-12 16308, 2023
atj
if you want to debug this further my suggestion would be to use developer tools and look at how old the connection is when it fails. if it's consistent close to a round number then that suggests a timeout somewhere in the stack
2023-06-12 16347, 2023
mayhem
dev tools gave me no useful information, atj
2023-06-12 16328, 2023
atj
did you see the request timeout?
2023-06-12 16351, 2023
mayhem
no, each time I tried it, it worked fine.
2023-06-12 16304, 2023
mayhem
which makes sense I guess.
2023-06-12 16341, 2023
mayhem has quit
2023-06-12 16350, 2023
mayhem joined the channel
2023-06-12 16305, 2023
ijc has left the channel
2023-06-12 16336, 2023
bitmap
CatQuest: sorry I meant to look into that sooner, I'll check it out today
2023-06-12 16316, 2023
v6lur joined the channel
2023-06-12 16336, 2023
mayhem
reosarevok: let me go first, plz
2023-06-12 16314, 2023
CatQuest
bitmap: no prob
2023-06-12 16352, 2023
monkey
Thanks for the bug fixes lucifer !
2023-06-12 16301, 2023
reosarevok
<BANG>
2023-06-12 16312, 2023
CatQuest
:D
2023-06-12 16315, 2023
reosarevok
It is Monday. That means you get to put up with me again
2023-06-12 16320, 2023
mayhem
joy!!
2023-06-12 16324, 2023
reosarevok
We have two mailed in reviews today:
2023-06-12 16331, 2023
reosarevok
yvanzo says:
2023-06-12 16348, 2023
reosarevok
'''
2023-06-12 16351, 2023
reosarevok
Last week I helped with zas-driven maintenance operations around Consul & RabbitMQ.
2023-06-12 16354, 2023
reosarevok
Reviewed some MBS PRs and worked on docker server configs.
2023-06-12 16358, 2023
reosarevok
Progressed in Weblate with outsidecontext, rdswift and reosarevok but ended up investigating CAA issues.
2023-06-12 16310, 2023
reosarevok
I won’t have anything to report on the 19th.
2023-06-12 16311, 2023
reosarevok
'''
2023-06-12 16327, 2023
reosarevok
(yvanzo is on holiday this week and hopefully he's enjoying it!)
2023-06-12 16334, 2023
reosarevok
aerozol says:
2023-06-12 16336, 2023
reosarevok
'''
2023-06-12 16351, 2023
CatQuest
happy holiday yvanzo !
2023-06-12 16351, 2023
reosarevok
Winter’s setting in and I’ve slowed to a crawl around our poorly insulated house. Drinking lots of hot chocolates to try prepare for hibernation.
2023-06-12 16356, 2023
reosarevok
I did some comms stuff, tackled a bunch of smaller tickets, none of which are exciting enough to link to imo.
2023-06-12 16304, 2023
reosarevok
Back to you Reo
2023-06-12 16309, 2023
reosarevok
Thanks aerozol. I don’t say this enough, but you really are the backbone of MeB. And probably our entire civilization, now that I think about it.
2023-06-12 16312, 2023
reosarevok
!m aerozol
2023-06-12 16312, 2023
BrainzBot
You're doing good work, aerozol!
2023-06-12 16314, 2023
reosarevok
'''
2023-06-12 16315, 2023
Sophist_UK joined the channel
2023-06-12 16339, 2023
reosarevok
I saw what he did there, but it's ok, someone needs to say good things to him while he sleeps so he's happy in the morning, it might as well be fake me
2023-06-12 16344, 2023
monkey
:D
2023-06-12 16359, 2023
CatQuest
:D
2023-06-12 16302, 2023
reosarevok
So
2023-06-12 16310, 2023
Sophist-UK has quit
2023-06-12 16315, 2023
reosarevok
On with actual humans who are actually present, and mayhem asked to go first
2023-06-12 16321, 2023
mayhem
oy!
2023-06-12 16325, 2023
reosarevok
(yvanzo, aerozol: did not mean to imply you're not actual humans)
2023-06-12 16335, 2023
reosarevok
go mayhem :)
2023-06-12 16348, 2023
mayhem
last week I reviewed some contracts and did the usual background emails.
2023-06-12 16314, 2023
mayhem
and we have a new unicorn supporter, but not all details are ironed out yet, I'll announce the company tomorrow.
2023-06-12 16331, 2023
mayhem
I also worked with our accountant go once again conclude that quickbooks sucks.
2023-06-12 16351, 2023
monkey
🎉 🦄
2023-06-12 16300, 2023
mayhem
and her fix made me shudder. if we engineered like that, the internet wouldn't work. at all.
2023-06-12 16312, 2023
mayhem
srsly.
2023-06-12 16330, 2023
mayhem
I also worked on troi to generated recs for all users only to realize that it must be done in spark.
2023-06-12 16351, 2023
mayhem
so lucifer replace the periodic-jams patch with 12 lines of SQL.
2023-06-12 16355, 2023
mayhem
humbled!
2023-06-12 16335, 2023
mayhem
over the weekend I worked on the lb-radio (was artist-radio) which was a fun change, but things are so busy right now, that I can only work on it in my spare time.
2023-06-12 16345, 2023
Sophist_UK has quit
2023-06-12 16354, 2023
mayhem
there were lots more things last week, but Imma shut up now.
2023-06-12 16356, 2023
mayhem
monkey: go!
2023-06-12 16302, 2023
reosarevok
Other people on my list today: reosarevok, bitmap, zas, lucifer, akshaaatt, atj, CatQuest, riksucks, jivte, kellnerd, Pratha-Fish, shivam_, vscode, pixelpenguin, arsh, jasje
Also pushed some PRs along an did some ticket triage
2023-06-12 16311, 2023
monkey
On the BookBrainz side I've been working on some old PRs that I really want to see merged
2023-06-12 16328, 2023
monkey
So lots of reviewing and working on finishing them up
2023-06-12 16345, 2023
monkey
And a little bit of GSoC discussions. That's me !
2023-06-12 16349, 2023
monkey
akshaaatt: go !
2023-06-12 16304, 2023
monkey
Oh, also helped beta testing the LB android app :)
2023-06-12 16305, 2023
akshaaatt
Hi everyone!
2023-06-12 16346, 2023
akshaaatt
I reviewed lots of PRs, completed the realtime listening now on the android app and other misc stuff
2023-06-12 16302, 2023
akshaaatt
We should be doing a final beta soon for next prod release
2023-06-12 16319, 2023
akshaaatt
That’s pretty much it for now. Great stuff upcoming!
2023-06-12 16328, 2023
akshaaatt
Go lucifer!
2023-06-12 16335, 2023
lucifer
hey all
2023-06-12 16338, 2023
vardan joined the channel
2023-06-12 16330, 2023
lucifer
last week, i worked on adding the bulk-generation of playlists on spark, some more work on meb-oauth and some additions to the android app (login workaround and websockets for now playing).
