#metabrainz

/

      • relaxoMob has quit
      • relaxoMob joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • aerozol
      • relaxoMob has quit
      • relaxoMob joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • lusciouslover has quit
      • relaxoMob has quit
      • relaxoMob joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • micheal joined the channel
      • micheal has quit
      • thevar1able has quit
      • thevar1able joined the channel
      • reosarevok
        aerozol: ok, mails sending :)
      • MonkeyPython
        aerozol: re https://docs.google.com/document/d/1aPeAM0wQyPW... you write about adding more columns but honestly i couldn't get it to work well. the pages are already way too narrow (why does an electronic document have wide margins anyway?) and i can't change it or anything
      • aerozol: there are quite a lot of "aerozol to create tickets" in https://docs.google.com/document/d/1bz32duq95jS... so I assume this is not for me to do (but if you want I can create those tickets and link them in the doc for you to edit. would they be MBS or DESIGN?)
      • moufl joined the channel
      • CatQuest joined the channel
      • CatQuest is now known as MonkeyPython
      • relaxoMob has quit
      • relaxoMob joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • yellowhatpro_ joined the channel
      • Thuraabtech joined the channel
      • Thuraabtech has quit
      • relaxoMob has quit
      • relaxoMob joined the channel
      • outsidecontext
        aerozol: I updated the code signing notes
      • relaxoMob has quit
      • relaxoMob joined the channel
      • moufl has quit
      • reosarevok
        bitmap: any idea whether https://sentry.metabrainz.org/organizations/met... is a userscript or a legit release-editor error?
      • (I always find it near impossible to figure out the common-chunks errors)
      • We get a surprisingly high amount of "The “X” relationship between “Foo” and “Bar” already exists." errors
      • Does that show even if the relationship editor itself detects and blocks the rels?
      • Or are these dupes getting through to perl somehow?
      • kellnerd
        I've seen this kind of error in the relationship editor.
      • It probably should not be logged in sentry as it is a recoverable user error.
      • Oh, wait no, it shows "This relationship already exists.", sorry :)
      • outsidecontext
        yvanzo, reosarevok: weblate 5.1 is out and allows customization of the translation workflow per language. That means we have the ability to e.g. introduce a translate -> review worklfow for languages where there is a large enough translator team (and interest to work this way)
      • it's not yet on our instance, but will be updated in the next days usually.
      • bitmap
        reosarevok: I think it's legit, I'll check once I'm awke and caffeinated
      • tux0r has quit
      • yellowhatpro_ has quit
      • reosarevok
        outsidecontext: sounds good :) For now I think most of our "teams" are currently one-person affairs, but it would be nice to expand that...
      • outsidecontext
        reosarevok: yes, that's also why I argued for this not being needed. actually I think we probably first need to build up something like "teams", that also use e.g. the forums to coordinate.
      • But if there are 1-3 users that actively translate a language and that then also act as reviewers I think this would work well.
      • tux0r joined the channel
      • relaxoMob has quit
      • relaxoMob joined the channel
      • reosarevok
        bitmap: also https://sentry.metabrainz.org/organizations/met... - any idea if that's expected behavior?
      • mayhem waves from 'tsüri
      • bitmap
        reosarevok: where do you see the high number of relationship-already-exists errors? I only see one with two users and another with one user
      • but I believe it's possible to trigger this if the relationship gets added in another tab/session, whether by the same user or a different one
      • I'm not actually sure how to reproduce the first release-editor one, but the "loop" bindingHandler is known to be buggy
      • the url one is kinda expected due to the way the function is written...there's a race condition where a concurrent transaction can use the url before the DELETE obtains a lock
      • this is tricky to fix but I'll open a ticket
      • basically delete_unused_urls needs to use `SELECT ... FOR UPDATE`, and whichever transaction is inserting the conflicting row should use `SELECT ... FOR SHARE` ... I think
      • reosarevok
        bitmap: I see a few every time I check sentry, so I guess it's a few a week?
      • bitmap
        ah probably my search query isn't finding them
      • reosarevok
        Maybe I'm remembering it wrong, also possible :D
      • mayhem
        reosarevok: due to flight delay i can make the meeting. My summary: summit.
      • reosarevok
        Ok
      • mayhem
        All the things I can share, lucifer also knows about, so I'm sure he'll share
      • reosarevok
        "mayhem says: just the right amount of chocolate"
      • mayhem
        I'm hoping to work half days this week, that is it for me.
      • It was. The table got cleared up at the end
      • nawcom has quit
      • nawcom joined the channel
      • reosarevok
        Hmm. MBS-13296 seems like a tricky one to display
      • BrainzBot
        MBS-13296: Whitespace changes not visible in edit https://tickets.metabrainz.org/browse/MBS-13296
      • reosarevok
        bitmap, yvanzo, aerozol: suggestions welcome
      • bitmap: also, is STYLE-2391 a schema change?
      • BrainzBot
        STYLE-2391: add a language attribute to the "Voice of" relationship https://tickets.metabrainz.org/browse/STYLE-2391
      • reosarevok
        (It seems like it'd require us to have languages as attributes the same way we have instruments so I guess that's at least a few triggers/functions)
      • bitmap
        well, I suppose we could store them as text attributes and validate it on the server until a better solution is available
      • reosarevok
        I mean, I don't think it's the kind of issue where there's a huge rush
      • But I guess I could make a schema change ticket and put it under the next schema change, and work on it in the meantime
      • (when I am bored otherwise)
      • yvanzo
        wouldn't it be redundant with the work's language?
      • reosarevok
        Not a work attribute, a relationship attribute
      • Requests so far using it are STYLE-2391 for artist-artist "voice of character" and STYLE-1162 for artist-release "liner notes author/translator"
      • BrainzBot
        STYLE-2391: add a language attribute to the "Voice of" relationship https://tickets.metabrainz.org/browse/STYLE-2391
      • STYLE-1162: Language attribute on (translated) liner notes relationship https://tickets.metabrainz.org/browse/STYLE-1162
      • bitmap
        iirc the work languages are just a direct fk to the language table whereas this would require mirroring the languages to link_attribute_type
      • outsidecontext
        I finally uploaded my summit photos to the Google drive link aerozol had shared
      • reosarevok
        Yeah, but that's no different than instrument vs instrument link_attribute_types, right? :)
      • So most of the code would be similar I expect
      • bitmap
        right, it's just that tha triggers for it are annoying
      • reosarevok
        I can imagine
      • Luckily we at least don't edit languages very often
      • dseomn has quit
      • dseomn joined the channel
      • BrainzGit
        [bookbrainz-site] 14kellnerd opened pull request #1027 (03master…bb-data-ts-migration): TypeScript migration of the ORM https://github.com/metabrainz/bookbrainz-site/p...
      • relaxoMob has quit
      • relaxoMob joined the channel
      • bitmap
        reosarevok: yvanzo: given that the RemoveEmpty script works on URLs I'm not sure we really need delete_unused_url and associated triggers?
      • reosarevok
        Possibly not? The main benefit I guess is that they are gone immediately rather than after a day, but
      • That's mostly just relevant to spam I guess
      • bitmap
        that's the only benefit I can see, but doesn't seem worth maintaining much to me
      • reosarevok
        I would not be too bothered if we dropped it, yes
      • bitmap
        I mean, the RemoveEmpty script probably has a race condition too, but it's fine if that crashes; if delete_unused_url crashes it brings the whole transaction with it (probably applying some innocuous edit)
      • reosarevok
        Does the RemoveEmpty script restart if crashed?
      • bitmap
        no but we could at least add some exception handling
      • yvanzo
        the question was: wouldn't [this added relationship attribute] be redundant with the work’s language [attribute]?
      • reosarevok
        And I'm confused how that could be redundant given it's not connected to works in anyway :)
      • *any way
      • yvanzo
        To follow the example provided in the ticket, one can add a work and set the language to English.
      • reosarevok
        But the relationship is artist-artist, voice actor to character
      • yvanzo
        Maybe more examples are needed to explain how it can be needed.
      • reosarevok
        Well, all the Disney films for example will have different actors voicing the (singing) characters in Spanish and in English :)
      • yvanzo
        Ok, IIUC, it’s the whole relationship “voice of” that would be redundant with artist-recording relationships (I expected but doesn’t seem to exist) on a period of time.
      • (There is no relationship to say that an artist A interpreted a character C on a recording R.)
      • MonkeyPython
        uhm
      • reosarevok
        Yeah, we cannot have that right now because that would be a 3-point relationship :)
      • MonkeyPython
        bang?
      • reosarevok
        We can only say artist A sang or whatever
      • MonkeyPython: in one min, from my clock!
      • :)
      • MonkeyPython
        oh, it's 19:03 here
      • reosarevok
        <BANG>
      • yvanzo
        <BANG BANG>
      • MonkeyPython
        my baby shot me down
      • reosarevok
      • Welcome to the first post-summit MeB meeting!
      • Hope you're ready for more of the good old talking to your screen rather than to physical people
      • I have two written reviews:
      • mayhem didn't send anything specific, but basically said "GSoC summit" and "we ate all the chocolate"
      • Living the life
      • And aerozol said:
      • MonkeyPython
        lol
      • reosarevok
        '''
      • I had something big on earlier this month… hmm what was it… nope, can’t remember.
      • Anyway, since the last meeting I:
      • Made some tiny PRs - a small step for devs, a giant leap for aerozol-kind - to add new players to the ListenBrainz-enabled apps list, which is looking nice and healthy now (https://listenbrainz.org/add-data/)
      • Did some work on a nice MeB OBS/streaming overlay that would probably not work and we would end up having to use zoom instead (huh, that’s a weird thing to imagine)
      • Spent a ton of time on a plane (hmm, why was I on a plane??) sanitizing and trying to make sense of 2017 survey data
      • Some interesting mockups and discussion on MBS-13292 + MBS-11748 (to be continued)
      • BrainzBot
        MBS-13292: Display partial translations in language drop down https://tickets.metabrainz.org/browse/MBS-13292
      • MBS-11748: Releases are not ordered by date when showing all releases groups https://tickets.metabrainz.org/browse/MBS-11748
      • reosarevok
        Spent a whole weekend writing notes and drafting an enormous blog post on something big that happened early this month… strange… nope still not ringing any bells
      • The person with the best memory can go next