jasje: hiya! we already missed the deadline on providing google that video -- did you manage to record one?
2023-12-11 34536, 2023
yvanzo
reosarevok: Thanks, it opened a couple of open questions.
2023-12-11 34510, 2023
yvanzo
reosarevok: Also, I have a general issue with using `header` as it is missing from a huge amount of messages.
2023-12-11 34506, 2023
eharris joined the channel
2023-12-11 34504, 2023
yvanzo
reosarevok: Also pushed another disambiguation for Edit.
2023-12-11 34507, 2023
yvanzo
reosarevok: The general “issue” is more do we agree on the direction of adding context `header` and `interactive` every where it is needed in the future (not necessarily in this PR)?
2023-12-11 34528, 2023
eharris has quit
2023-12-11 34502, 2023
reosarevok
Sure fot hea
2023-12-11 34505, 2023
reosarevok
...
2023-12-11 34524, 2023
reosarevok
Sure for header, and for interactive I guess as long as we document it it seems fine
2023-12-11 34527, 2023
akshaaatt
Hi reosarevok , I won’t be able to join the meeting. Heading to bed. Still here in Japan and enjoying like crazy. I did some PR reviews and was happy to see that the LB Android app crossed 1k downloads on the playstore! Thanks
2023-12-11 34511, 2023
akshaaatt
Also, I met Linus Torvalds and got to have a 10mins chat with him and Jim Zemlin :)
yvanzo: where are you collecting the donation suggestions?
2023-12-11 34528, 2023
mayhem
monkey: ping
2023-12-11 34555, 2023
jasje
mayhem: oops I keep forgetting
2023-12-11 34520, 2023
jasje
tomorrow I’ll definitely record and send the video
2023-12-11 34525, 2023
jasje
got my exam tomorrow
2023-12-11 34508, 2023
jasje
alarm set
2023-12-11 34516, 2023
mayhem
thx!
2023-12-11 34514, 2023
yvanzo
mayhem: sent a link
2023-12-11 34523, 2023
mayhem
thx
2023-12-11 34541, 2023
Fiend joined the channel
2023-12-11 34515, 2023
Fiend has quit
2023-12-11 34517, 2023
Fiend_ joined the channel
2023-12-11 34521, 2023
Fiend_
Hello I saw the Troi Recommendation Toolkit and wanted to ask if I could contribute for any improvement in that.
2023-12-11 34539, 2023
mayhem
sure, what do you have in mind Fiend_ ?
2023-12-11 34525, 2023
Fiend__ joined the channel
2023-12-11 34505, 2023
Fiend_ has quit
2023-12-11 34519, 2023
Fiend__ has quit
2023-12-11 34519, 2023
mayhem
lucifer: you about?
2023-12-11 34557, 2023
yvanzo
bitmap, reosarevok: Are you having 4 Flow `untyped-import` errors on `master` too?
2023-12-11 34525, 2023
yvanzo
(using Flow 0.220.0 as in `package.json`)
2023-12-11 34502, 2023
bitmap
yvanzo: hey, I am not but I'm guessing this might help: rm root/static/scripts/tests/typeInfo.js; ./script/dump_js_type_info.pl
2023-12-11 34518, 2023
yvanzo
bitmap: Thank you, the errors all came from files under `root/static/scripts/tests/` indeed.
2023-12-11 34519, 2023
yvanzo
Would it make sense to clean these up automatically when compiling scripts?
2023-12-11 34544, 2023
bitmap
yes, perhaps. it skips dumping the file if it already exists because it rarely changes, but it doesn't take very long to execute
2023-12-11 34503, 2023
bitmap
a recent PR added Flow types to it, and then another PR added some new tests (marked as "strict") which import it, hence the issues
2023-12-11 34554, 2023
yvanzo
CircleCI doesn’t start with the old files anyway, so it shouldn’t make it any slower, right?
2023-12-11 34508, 2023
bitmap
right
2023-12-11 34515, 2023
yvanzo
reosarevok: CI tests passed again. Please recheck the conversations, and if it works for you I will rebase the PR in a mergeable way.
2023-12-11 34521, 2023
reosarevok
I'm on a bus but I'll check stuff in an hour ior
2023-12-11 34541, 2023
reosarevok
*or so when home, yvanzo. Thanks!
2023-12-11 34536, 2023
outsidecontext
mayhem, lucifer: is it supposed to be possible to use "Link with MusicBrainz" on other people's listens?
2023-12-11 34524, 2023
reosarevok
Iirc yes
2023-12-11 34535, 2023
reosarevok
But it won't automatically count for them
2023-12-11 34530, 2023
outsidecontext
so it would only me seeing it?
2023-12-11 34505, 2023
outsidecontext
mmh, I think now
2023-12-11 34531, 2023
outsidecontext
*not
2023-12-11 34506, 2023
outsidecontext sees entire new possibilities in rickrolling 😮
2023-12-11 34514, 2023
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #2666 (03master…rg-stat-artists): Link individual artists in release group, release and recordings statistics https://github.com/metabrainz/listenbrainz-server…
2023-12-11 34506, 2023
lucifer
mayhem: hi!
2023-12-11 34552, 2023
lucifer
outsidecontext: yes it is. the intent is if 3 or more people link a listen to the same recording then it will be used sitewide unless a user has provided their own manual mapping.
2023-12-11 34524, 2023
lucifer
if its only you who has mapped someone else's listens then it would only be visible to you.
lucifer: lots of open questions on the entity pages / MB artist/release group cache.
2023-12-11 34525, 2023
mayhem
what we dreamt up in delhi was too simple, lol
2023-12-11 34542, 2023
lucifer
mayhem: sure ask
2023-12-11 34558, 2023
mayhem
ok, first problem is that we need to pick a release from the release group. canonical release would be good for this, but the data is not in MB, so we can't join it.
2023-12-11 34538, 2023
mayhem
second problem is that we didn't discuss how to cache the popularity data. and that will go out of date much faster than the MB data.
2023-12-11 34538, 2023
lucifer
We can create it in the mapping schema of MB db.
2023-12-11 34504, 2023
lucifer
The popularity data generated from listens?
2023-12-11 34508, 2023
mayhem
yes.
2023-12-11 34525, 2023
lucifer
How frequently do we want to update it?
2023-12-11 34556, 2023
mayhem
I think daily would be good, but weekly is probably also ok.
2023-12-11 34514, 2023
lucifer
We can use couch db for it.
2023-12-11 34522, 2023
mayhem
yes, I think that makes sense.
2023-12-11 34526, 2023
lucifer
We do use couch db for it atm afair
2023-12-11 34557, 2023
mayhem
and to make matters worse, I'm headed to germany for the rest of the week and monkey would really like the entity pages to be done for the release of YIM, which I agree on.
2023-12-11 34511, 2023
mayhem
would you be able to take over the data work on the entity pages for the rest of the week?
2023-12-11 34513, 2023
lucifer
I can get those done not an issue
2023-12-11 34526, 2023
mayhem
great, thanks.
2023-12-11 34539, 2023
lucifer
What all is done and what all is left?
2023-12-11 34542, 2023
mayhem
I am going to make notes in entity_pages.py in the views subdir.
2023-12-11 34505, 2023
mayhem
I'll let you know when that is done and then you look at it to make sure that everything makes sense.
2023-12-11 34513, 2023
mayhem
when I am gone, I'll still be available for questions.
2023-12-11 34524, 2023
lucifer
Sounds good
2023-12-11 34546, 2023
mayhem
thanks!
2023-12-11 34546, 2023
lucifer
I want to explore the logical replication router sooner than later for the caches.
2023-12-11 34508, 2023
lucifer
Copy the required MB db tables to timescale using logical replication and then perform all the joins we want there.
2023-12-11 34552, 2023
lucifer
Instead of creating the data twice once in LB dbs and then in MB dbs. It would also prevent the WALs issues we see with Jimmy/Hendrix.
2023-12-11 34538, 2023
mayhem
sounds really promising.
2023-12-11 34512, 2023
lucifer
I'll talk with bitmap about it later today or tomorrow.
yvanzo: I think the lowercasing PR looks fine now, if you agree we can merge?
2023-12-11 34512, 2023
yvanzo
reosarevok: Thanks but we still have to rebase it to apply amending commits and discard changes to po/
2023-12-11 34539, 2023
reosarevok
Hmm
2023-12-11 34502, 2023
reosarevok
Won't tests start failing again if we discard changes though?
2023-12-11 34504, 2023
ApeKattQuest
are instrument translations in the po or ehatevers trasnalte.mbs too?
2023-12-11 34507, 2023
reosarevok
Well, the one change
2023-12-11 34514, 2023
reosarevok
ApeKattQuest: yes but they won't be affected by this
2023-12-11 34515, 2023
ApeKattQuest
are instrument translations in the po or ehatevers translate.mbs too?
2023-12-11 34517, 2023
yvanzo
They will but it won’t break Weblate.
2023-12-11 34534, 2023
ApeKattQuest
oh no. i was just thinking about translations in norwegian
2023-12-11 34534, 2023
yvanzo
No changes to instruments.pot so far.
2023-12-11 34535, 2023
reosarevok
yvanzo: ok, if if seems ok for tests to fail for a bit then I'm fine with that
2023-12-11 34545, 2023
reosarevok
ApeKattQuest: yes, that can be translated from that page too :)
2023-12-11 34523, 2023
ApeKattQuest
hopefully i will atleast have a passable compo soon
2023-12-11 34529, 2023
reosarevok
yvanzo: how do you apply the amending commits, just move them to the right position with git rebase -i and then fixup?
2023-12-11 34512, 2023
yvanzo
reosarevok: Mostly, sometimes the amended commit message might need to be updated too.
2023-12-11 34525, 2023
reosarevok
Ok, do you want to do this or should I?
2023-12-11 34559, 2023
yvanzo
You can give it a try now if you want, busy with preparing the meeting atm.
2023-12-11 34526, 2023
reosarevok
Ok!
2023-12-11 34530, 2023
bitmap
reosarevok: use s instead of f and it'll open your editor to allow merging the commit messages if needed
2023-12-11 34537, 2023
reosarevok
Ok
2023-12-11 34552, 2023
yvanzo
reosarevok: No proposition of OSS project for donations?
2023-12-11 34544, 2023
reosarevok
Not really, I don't use anything you wouldn't already know and have picked as MBS devs tbh : )
2023-12-11 34524, 2023
reosarevok
Well I use outsidecontext's peek (https://github.com/phw/peek) and I would certainly not mind sending outsidecontext some cash but it feels a bit like cheating :p
2023-12-11 34540, 2023
reosarevok
Oh no. "IMPORTANT: The Peek project has been declared deprecated"
