pranav[m] uploaded an image: (1006KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/zNVfpKnhfJyxFGvuOUNdjhbb/Screenshot%202024-07-08%20at%208.23.58%E2%80%AFAM.png >
pranav[m]
aerozol: I think here, we shud be using bar charts as is the case with LB Web
As the format of data we r getting is very different from YIM
So heat map is looking a bit off.. in any case we aren't getting data for each day separately..
In case of year we get monthly listens, in case of all_time we get yearly listens data
pite joined the channel
aerozol[m]
pranav: I just copied that from your proposal, it’s one of the parts I didn’t design! Which means you can play with it :)
pranav[m]
So I’ll make it like a chart only as in LB web coz heat map won’t look good unless we have listening count for every day
aerozol[m]
What I will be strict about is fonts, colours, accessibility etc, but otherwise do what looks best. With data visualisations it’s normal to come up with something cooler as you play with it as well
Is that because we don’t have endpoints for that data? e.g. daily or hourly
pranav[m]
I’ll just confirm from lucifer once.. but as per docs we don’t have the reqd endpoint
A crude way of doing it would be to make 12 requests every time to the server which I don’t want to do aerozol
lucifer: do we have any endpoint which gives out listen count for every day of the year?
In the docs I saw monthly listen activity gives for each day
So one way is to call it 12 times.. which is bad I presume
aerozol[m]
I personally would advise to try do something cool with the data you have, keeping it simple. But I am only responsible for design, your mentor can make the call on how far you want to take this
How’s it all going, anyway?
pranav[m]
It is interesting for sure getting to learn new stuff.. will be done with the stats page today and then get started on tests..
As soon as I am done with the stats page, I’ll send u how everything looks
In both the themes
aerozol[m]
Great progress pranav, really! 🥳
pite has quit
SigHunter has quit
theflash__ joined the channel
theflash__
akshaaatt: hey
read your comments on my recent pr
SigHunter joined the channel
In pinning the track, I have used pinned_until parameter such that it pins the track upto a week in the future which seems wrong
can you please help me with how we can pass pinned_until parameter in the pinning track endpoint
^ lucifer
lucifer[m] joined the channel
lucifer[m]
<pranav[m]> "lucifer: do we have any endpoint..." <- no that is only calculated for Year in Music stuff.
<theflash__> "In pinning the track, I have..." <- Can you share how you are making the api call, [@theflash__ (IRC)](https://matrix.to/#/@irc_theflash__:chatbrainz.org) ?
theflash__ (IRC): that looks correct to me. what issue are you facing with it?
d4rk-ph0enix has quit
theflash__
pinned_until means that for what point of time recording is pinned, right?
d4rkie joined the channel
reosarevok[m] joined the channel
reosarevok[m]
aerozol: IIRC the idea *was* to have this be a one-off at first but after considering running it as a task every X time, yes - automatically probably
Re: the deleting empty users thing
Keep in mind this does not delete spammers specifically - any spammers with a verified email, of which there's also a lot, will be untouched by this
I have considered expanding it later to also delete people who literally only verified but did nothing else, but that's a bit more scary
theflash__
lucifer, akshaattt: My doubt is that whether we have to pass the current timestamp in the pinned_until or some other timestamp in the future just like a week
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
rozlav9 joined the channel
lucifer[m]
theflash__ (IRC): the future timestamp
until which you want the track to be pinned.
the4oo4- joined the channel
the4oo4 has quit
rozlav has quit
d4rkie has quit
rozlav9 is now known as rozlav
d4rkie joined the channel
akshaaatt[m]
lucifer: why was the future timestamp required though?
lucifer[m]
akshaaatt: it is not required, if you don't pass in a timestamp. it defaults to a week in a future.
akshaaatt[m]
Noice. So I think getting the current timestamp should also work
lucifer[m]
not sure what you mean?
theflash__
Currently, I have added for 1 week in future
lucifer[m]
setting pinned_until = current_timestamp + seconds_in_a_week would work yes.
[listenbrainz-android] 14dependabot[bot] closed pull request #443 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-compose-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-compose from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #442 (03dev…dependabot/gradle/dev/androidx.test.espresso-espresso-core-3.6.1): Bump androidx.test.espresso:espresso-core from 3.6.0 to 3.6.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #444 (03dev…dependabot/gradle/dev/androidx.test.ext-junit-1.2.1): Bump androidx.test.ext:junit from 1.2.0 to 1.2.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #447 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-livedata-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-livedata-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #449 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-runtime-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #445 (03dev…dependabot/gradle/dev/androidx.test-monitor-1.7.1): Bump androidx.test:monitor from 1.7.0 to 1.7.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #446 (03dev…dependabot/gradle/dev/androidx.test-runner-1.6.1): Bump androidx.test:runner from 1.6.0 to 1.6.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #441 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #428 (03dev…dependabot/gradle/dev/com.google.devtools.ksp-2.0.0-1.0.22): Bump com.google.devtools.ksp from 1.9.22-1.0.17 to 2.0.0-1.0.22 https://github.com/metabrainz/listenbrainz-andr...
akshaaatt[m]
Hi pranav, I have made some big change to the dev branch. Let me know if anything breaks for you randomly (it should not, but if it does), when you take a pull the next time
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
pranav[m]
Alright, sure
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
mayhem[m] has quit
d4rkie has quit
d4rkie joined the channel
d4rkie has quit
d4rkie joined the channel
mayhem[m] joined the channel
mayhem[m] uploaded an image: (62KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/JwLgilwcdlovzWuRrPAcWGTR/image.png >
mayhem[m]
Crazy shit?? WTAF?
d4rkie has quit
aerozol[m]
Feckin kids putting their weird shit on LB
reosarevok: agreed re. treading carefully with deleting accounts, for now. Do you know what unaddressed comment on the PR bitmap was referring to?
reosarevok[m]
Yes, I've done some work on the PR today, I think it should be better
lucifer[m]
ansh: hi! the apple music PR to fix auth fixes the current error but it won't make the apple music auth work on different devices like it is supposed to. i know because i was looking into it last week.
[bookbrainz-utils] 14MonkeyDo merged pull request #26 (03master…dependabot/npm_and_yarn/cleaner/highlight.js-9.18.5): chore(deps): bump highlight.js from 9.12.0 to 9.18.5 in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] opened pull request #47 (03master…dependabot/npm_and_yarn/cleaner/typeorm-0.3.0): chore(deps): bump typeorm from 0.2.7 to 0.3.0 in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
d4rkie has quit
theflash__ has quit
[bookbrainz-utils] 14dependabot[bot] closed pull request #37 (03master…dependabot/npm_and_yarn/importer/moment-2.29.4): chore(deps): bump moment from 2.24.0 to 2.29.4 in /importer https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #39 (03master…dependabot/npm_and_yarn/importer/decode-uri-component-0.2.2): chore(deps): bump decode-uri-component from 0.2.0 to 0.2.2 in /importer https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #43 (03master…dependabot/npm_and_yarn/importer/babel/traverse-7.23.4): chore(deps-dev): bump @babel/traverse from 7.22.4 to 7.23.4 in /importer https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #33 (03master…dependabot/npm_and_yarn/importer/validator-13.7.0): chore(deps): bump validator from 10.11.0 to 13.7.0 in /importer https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #36 (03master…dependabot/npm_and_yarn/importer/async-2.6.4): chore(deps): bump async from 2.6.0 to 2.6.4 in /importer https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #29 (03master…dependabot/npm_and_yarn/importer/lodash-4.17.21): chore(deps): bump lodash from 4.17.13 to 4.17.21 in /importer https://github.com/metabrainz/bookbrainz-utils/...
monkey[m]
Sorry for the spam everhyone
s/everhyone/everyone/
BrainzGit
[bookbrainz-utils] 14dependabot[bot] opened pull request #48 (03master…dependabot/npm_and_yarn/cleaner/multi-a8a2e3ef50): chore(deps): bump xml2js and typeorm in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14MonkeyDo merged pull request #45 (03master…dependabot/npm_and_yarn/cleaner/minimist-and-mkdirp-1.2.8): chore(deps): bump minimist and mkdirp in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14MonkeyDo merged pull request #48 (03master…dependabot/npm_and_yarn/cleaner/multi-a8a2e3ef50): chore(deps): bump xml2js and typeorm in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #47 (03master…dependabot/npm_and_yarn/cleaner/typeorm-0.3.0): chore(deps): bump typeorm from 0.2.7 to 0.3.0 in /cleaner https://github.com/metabrainz/bookbrainz-utils/...
[bookbrainz-utils] 14dependabot[bot] closed pull request #44 (03master…dependabot/npm_and_yarn/cleaner/xml2js-and-typeorm--removed): chore(deps): bump xml2js and typeorm in /cleaner https://github.com/metabrainz/bookbrainz-utils/...