holycow23[m] uploaded an image: (121KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/mhcUbyqSUwAQzcammVTIOuYe/image.png >
2025-01-20 02030, 2025
holycow23[m]
Hi, I was trying to setup the ListenBrainz Repo on WSL, for some reason the ./develop.sh up command doesn't go ahead after 70%, could someone help me with the same
2025-01-20 02019, 2025
pite has quit
2025-01-20 02047, 2025
pite joined the channel
2025-01-20 02037, 2025
wileyfoxyx[m]
@rdswift: oh darn.. well, thanks for fixing them
2025-01-20 02040, 2025
suvid[m]
<gaurav993[m]> "what I have done is disable..." <- thanks
2025-01-20 02040, 2025
suvid[m]
yea installing all the reqd npm modules worked
2025-01-20 02034, 2025
SothoTalKer has quit
2025-01-20 02006, 2025
SothoTalKer joined the channel
2025-01-20 02032, 2025
texke has quit
2025-01-20 02032, 2025
mayhem[m]
lucifer: LB is down because kiss is out of diskspace.
1) Right now since any user can view other user's profile and link his listens so we could make the page at settings/link-listens public at <username>/link-listens since there is no need for it to be restricated
2025-01-20 02008, 2025
holycow23[m]
2) We could put a button next to Add Listens on dashboard page itself and link it to the Unlinked Listens page
1. Right now since any user can view other user's profile and link his listens so we could make the page at `settings/link-listens` public at `username>/link-listens` since there is no need for it to be restricated
2025-01-20 02028, 2025
holycow23[m]
2. We could put a button next to the `Add Listens` button on dashboard page itself and link it to the Unlinked Listens page or we could get rid of that page and show the content of that page in the dashboard itself.
2025-01-20 02011, 2025
BrainzGit
[listenbrainz-android] 14rahul31124 closed pull request #525 (03main…rahul3112-ImproveRetryButtonDesign): Refactor 'Retry' button design: Updated to a more visually appealing … https://github.com/metabrainz/listenbrainz-androi…
Thanks wileyfoxyx and Bob Swift! I'll look into the whole thing soon TM
2025-01-20 02039, 2025
reosarevok[m]
Hopefully in a few days at most :)
2025-01-20 02045, 2025
reosarevok[m]
I'll add it to my todo
2025-01-20 02006, 2025
monkey[m] joined the channel
2025-01-20 02006, 2025
monkey[m]
holycow23: I'm not exactly sure how the suggestions you posted resolve the ticket LB-1722 , but for what it's worth regarding point 1. the page used to be accessible for other users but we changed that to prevent a vector of attack (or maybe just severe annoyance) considering this manual matching system requires multiple matches for a track in order to become automatic. We wanted to make it harder to game that aspect of the website.
2025-01-20 02006, 2025
monkey[m]
Regarding point 2. we are certainly not getting rid of the link listens page. Adding another link to it might be helpful, but I fail to see how it addresses the ticket.
Regarding the ticket, I did work on it, place a button next to it which just shows the unlinked listens out of all the listens which is kind of what the user can see at settings/link-listens so not really sure if its useful
2025-01-20 02007, 2025
monkey[m]
LB team: I reclaimed another 31G of space by pruning some old unused docker images. A drop in the ocean, perhaps, but a drop might feel like a lake to a thirsty server.
2025-01-20 02029, 2025
mayhem[m]
thanks, I was hesitant to run the prune, but great. :)
2025-01-20 02056, 2025
holycow23[m]
* Regarding the ticket, I did work on it, place a button next to Add listens which just shows the unlinked listens out of all the listens which is kind of what the user can see at settings/link-listens so not really sure if its useful
2025-01-20 02024, 2025
monkey[m]
holycow23[m]: I don't think that's what the ticket is about. I think it is about filtering listens in the existing link listens page, for example I imagine filtering by track, album or artist name to see a smaller list of listens if you have pages of them.
2025-01-20 02051, 2025
monkey[m]
mayhem[m]: I pruned some over the weekend, but looked into it closer and cleansed.
2025-01-20 02019, 2025
monkey[m]
holycow23: That being said, I might be misunderstanding the ticket. It might be worth trying to get in touch witht he user who created the ticket on jira
2025-01-20 02044, 2025
monkey[m]
(considering the ticket description is a bit ambiguous)
2025-01-20 02050, 2025
holycow23[m]
Oh, maybe I misunderstood the Ticket then, cause a user isn't aware of the link listens page so maybe he was referring to filtering the unlinked on the dashboard itself. That being said, do you think the feature I just suggested could be any good?
2025-01-20 02030, 2025
monkey[m]
IMO your suggestion duplicates some of the functionality from the existing link listens page.
2025-01-20 02030, 2025
monkey[m]
I think it would be wiser to funnel people towards and improve the link listens page directly.
2025-01-20 02038, 2025
holycow23[m]
So how about the button just redirecting to that link listens page itself since its tough to find that page as a first time user
2025-01-20 02018, 2025
monkey[m]
Filtering on the dashboard will be tricky at the very best, because we load listens page by page and there is currently no means to filter unlinked listens from that endpoint. The unlinked listens page on the other hand loads all that data on page load, and does grouping and such on the front-end, so filtering would be much more straightforward.
2025-01-20 02036, 2025
mayhem[m]
monkey: I'm updating funding.json with new asks and our last year financials. we're allowed up to 10 asks and I am thinking of:
2025-01-20 02037, 2025
mayhem[m]
one time:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/GztlBQejnJYUNEVsZmyzBAjZ>)
2025-01-20 02042, 2025
monkey[m]
holycow23[m]: I think a mockup might be helpful for what you propose. If the goal is to make the page more discoverable, it's a separate ticket but it's a valid one nonetheless. However I'd like to see an example to be able to evaluate whether it will help with discoverability
2025-01-20 02043, 2025
mayhem[m]
what do you think?
2025-01-20 02020, 2025
holycow23[m]
monkey[m]: I actually did manage to do that, but yes the paging might be complicated and the link-listens page is any day a better option so maybe a button to just redirect to the page might be a better option.
2025-01-20 02030, 2025
mayhem[m]
where the average dev/month cost for 2024 was $2600. I'll set the one month cost at $2500.
2025-01-20 02044, 2025
holycow23[m]
monkey[m]: Sure will work on it and get back
2025-01-20 02037, 2025
suvid[m]
<monkey[m]> "> <@suvid:matrix.org> Hi monkey..." <- Hi monkey... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/rLYiShMsRWLViYhGOPqNZuGn>)
suvid: Yes you will indeed need a back-end endpoint you can call from the front-end. You can look in the fil listenbrainz/webserver/views/user_timeline_event_api.py where the feed events are implemented, for example the hide/unhide endpoints which refer to an existing feed event:
I was working on the `BrainzPlayerListenCard` to implement touch-to-play functionality for the song, as you suggested. Should I remove the `PlayButton` from the `BrainzPlayerListenCard`, or should I keep it as it is?
2025-01-20 02054, 2025
Shreyas[m]
Also, while highlighting the currently playing song in the BP tab, the songs are displayed only in the SongsOverviewScreen and RecentPlaysOverviewScreen. So, the title should be highlighted there only, right? Because in the ArtistsOverviewScreen and AlbumsOverviewScreen, there isn’t any song title to highlight.
2025-01-20 02014, 2025
monkey[m]
gaurav993: I'm not sure about how all this should work. You are right in pointing out we have two different mechanisms, but I think we either forget about disabling the username input or rethink the UI entirely for it to combine long-term status (connected to service) and momentary ones (import loved tracks) which could benefit other music services (for example, import loved tracks from Spotify which we don't currently have).
2025-01-20 02039, 2025
monkey[m]
gaurav993: Actually, i take back what I said ! Let's make it so the "import loved tracks" button is also disabled until you connect your LFM account. It doesn't make much sense to have one without the other, and if someone really wants that there is the possibility to set "Start import from" to today's date (effectively preventing importing existing tracks), click "import loved tracks", then disconnect LFM.
2025-01-20 02040, 2025
monkey[m]
I think that simplifies the system and the UI will be consistent
2025-01-20 02017, 2025
jasje[m] joined the channel
2025-01-20 02017, 2025
jasje[m]
<Shreyas[m]> "Hi jasje ,..." <- Remove play button
2025-01-20 02039, 2025
suvid[m]
<monkey[m]> "> <@suvid:matrix.org> Hi monkey..." <- the UI for the person thanking seems simple
2025-01-20 02039, 2025
suvid[m]
what about the person receiving the thank you?
2025-01-20 02022, 2025
monkey[m]
<suvid[m]> "the UI for the person thanking..." <- I think that should be a new feed event for the thank-you-receiver
2025-01-20 02043, 2025
monkey[m]
(we probably don't want to allow thank yous on thank you events :p )
2025-01-20 02059, 2025
suvid[m]
monkey[m]: yea that would lead to recursive thank you's lol
2025-01-20 02030, 2025
monkey[m]
Good band name
2025-01-20 02050, 2025
gaurav993[m]
<monkey[m]> "gaurav993: Actually, i take back..." <- Since I was a bit free, I have created UI according to what I thought would be good, including all current features just with a submit button. It allows you to connect to an account and also import loved tracks manually from same or some other account irrespective of whether you are connected or not. This is the code for MusicServices.tsx in music services folder in settings
In case this is not upto mark, i will make changes just like you mentioned disabling "Import Loved Tracks" options until you connect to LFM account.
2025-01-20 02009, 2025
gaurav993[m]
* Since I had some spare time, I have created UI according to what I thought would be good, including all current features just with a submit button. It allows you to connect to an account and also import loved tracks manually from same or some other account irrespective of whether you are connected or not. This is the code for MusicServices.tsx in music services folder in settings https://pastebin.com/V6y2qqMp
2025-01-20 02009, 2025
gaurav993[m]
In case this is not upto mark, i will make changes just like you mentioned disabling "Import Loved Tracks" options until you connect to LFM account.
There's a MEB ticket, and the sentry ticket above. I can put more info in the MEB ticket, or I can create an LB ticket as well if you prefer
2025-01-20 02035, 2025
mayhem[m]
MEB ticket should suffice, methinks.
2025-01-20 02016, 2025
JoeBiden957258 joined the channel
2025-01-20 02022, 2025
JoeBiden957258
Hey guys... Joe Biden here. I've decided to step down from the White House to focus on other projects. Billionaires are a threat to democracy, so check out https://BidenCash.st to put them in the bullseye. Keep an eye on the CNN inauguration for a promo code!
2025-01-20 02027, 2025
JoeBiden957258 has quit
2025-01-20 02002, 2025
monkey[m]
Added more info to the MEB ticket
2025-01-20 02009, 2025
mayhem[m]
monkey: I propose that we leave the no-nag until we move the user accounts to meb.org -- right now the no nag flag data exists only on MB.org not in metabrainz.
2025-01-20 02043, 2025
mayhem[m]
as for Maxr1998, I could just enter a donation for the time being, so that Max would not be nagged.
2025-01-20 02044, 2025
monkey[m]
That explains that
2025-01-20 02028, 2025
monkey[m]
I suppose that's a decent stopgap on a personal level, but you're opening yourself to having to add a bunch of phantom donations to the DB, and not sure if that will help your next round of accounting...
2025-01-20 02056, 2025
mayhem[m]
I'll even add a note to remove the phantom donation. ;)
2025-01-20 02008, 2025
Jade[m]1 joined the channel
2025-01-20 02008, 2025
Jade[m]1
<BrainzGit> "[musicbrainz-server] JadedBlueEy..." <- Given I'm not sure how to fix the tests this breaks, should I create a PR for a different email in the meantime, just to keep the ball rolling?
2025-01-20 02009, 2025
julian45[m] joined the channel
2025-01-20 02009, 2025
julian45[m]
MB documentation links seem to be broken. e.g., https://musicbrainz.org/doc/Edit_Note should absolutely be a valid piece of documentation but it just leads to a page saying "Sorry, “Edit Note” is not a valid documentation page." right now
2025-01-20 02028, 2025
mayhem[m]
julian45: FWIW, I see the correct Edit Note page when I click the link above.
2025-01-20 02046, 2025
julian45[m]
mayhem: huh, must have been a momentary issue.
2025-01-20 02054, 2025
julian45[m]
I can see it now
2025-01-20 02031, 2025
julian45[m]
For a moment there, even the "looking for something? check out documentation" link on the broken link page was giving the same error
2025-01-20 02056, 2025
Jade[m]1
<BrainzGit> "[musicbrainz-server] JadedBlueEy..." <- Oops, replied in thread. Try again:
2025-01-20 02056, 2025
Jade[m]1
Given I'm not sure how to fix the tests this breaks, should I create a PR for a different email in the meantime, just to keep the ball rolling?
2025-01-20 02034, 2025
Jade[m]1
I'd love to get this fully deployed before next GSoC rolls around haha
2025-01-20 02054, 2025
Jade[m]1
feel like that may call for enabling multiple at once
2025-01-20 02015, 2025
suvid[m] uploaded an image: (164KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/pIXmLrmjkRswUcbcLNNFdomN/image.png >
2025-01-20 02017, 2025
suvid[m]
how can i test feed locally?
2025-01-20 02035, 2025
julian45[m]
<Jade[m]1> "Oops, replied in thread. Try..." <- > <@jade:ellis.link> Oops, replied in thread. Try again:
2025-01-20 02036, 2025
julian45[m]
> Given I'm not sure how to fix the tests this breaks, should I create a PR for a different email in the meantime, just to keep the ball rolling?
2025-01-20 02036, 2025
julian45[m]
Spurious failures on PR tests do happen, and looking closely at the failed test here, it seems completely unrelated to the code you're working with. Not my final authority, but my personal vote here would be to potentially ignore it
2025-01-20 02012, 2025
julian45[m]
But that being said, if you feel like opening a separate PR for a new mail type would be a productive use of your time, I have no objection to that :)
2025-01-20 02026, 2025
Jade[m]1
From what I can remember, there was an E2EE test for account registration and verification that this broke
2025-01-20 02038, 2025
Jade[m]1
It was a while since I looked at it though, could be wrong
2025-01-20 02003, 2025
Jade[m]1
julian45[m]: Yeah, I'll probably try to do multiple at once
2025-01-20 02015, 2025
suvid[m]
suvid[m]: do i need to build spark as well for it to work?
2025-01-20 02016, 2025
Jade[m]1
given what takes the most time is setting up development and testing the emails
And given that the PR in question is for sending verification emails to users... shrugs
2025-01-20 02032, 2025
Jade[m]1
Ah OK
2025-01-20 02004, 2025
Jade[m]1
There is a lot of output to go through lol
2025-01-20 02013, 2025
Jade[m]1 uploaded an image: but this was the one I was thinking about I think (79KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/ellis.link/PuMCnpTOQapgPuEoDehdFbfQzKJDdFP6 >
2025-01-20 02052, 2025
julian45[m]
good point, i do see that one now
2025-01-20 02001, 2025
monkey[m]
suvid: The feed does not need spark. Check the errors in your computer console where you are running docker
