<Jade[m]> "And then that design looks..." <- I was more of the opinion that the whole bottom bar should be used because it would be evident without reading text what the user was messing with. I don’t have access to my laptop for a few days so can’t really show how
2025-11-12 31604, 2025
zer0bitz- has quit
2025-11-12 31616, 2025
zer0bitz- joined the channel
2025-11-12 31633, 2025
Kladky joined the channel
2025-11-12 31615, 2025
Aerozol[m]1 has quit
2025-11-12 31656, 2025
dabeglavins681 joined the channel
2025-11-12 31600, 2025
dabeglavins68 has quit
2025-11-12 31600, 2025
dabeglavins681 is now known as dabeglavins68
2025-11-12 31640, 2025
zer0bitz- has quit
2025-11-12 31652, 2025
zer0bitz- joined the channel
2025-11-12 31632, 2025
relaxo[m]
^ jasje forgot the ping
2025-11-12 31602, 2025
anuj_ has quit
2025-11-12 31648, 2025
adhawkins
bitmap[m]: The URL I posted above is now working. Still had others fail overnight though. Did they respond?
(I guess we could have an extra function testExpand or something that can be called similarly but acts differently... or allow passing a boolean to return errors all the way down)
ansh: The new MB homepage looks awesome, works really well. From my point of view, it's only some details remaining.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/DAIdGRBWoKMonVYiKoJjgeQe>)
2025-11-12 31627, 2025
reosarevok[m]
Translations not existing will be true for all new strings, until they go to weblate etc :)
2025-11-12 31634, 2025
monkey[m]
Yes I figured. I guess in some cases I was surprised they were new strings. Anyway, a self-solving problem I suppose.
2025-11-12 31642, 2025
reosarevok[m]
I mean, I haven't checked, some might be old and wrongly broken :)
2025-11-12 31654, 2025
reosarevok[m]
Just clarifying
2025-11-12 31641, 2025
Maxr1998_ joined the channel
2025-11-12 31629, 2025
Maxr1998 has quit
2025-11-12 31627, 2025
failure joined the channel
2025-11-12 31604, 2025
failure is now known as shirsakm
2025-11-12 31614, 2025
shirsakm has quit
2025-11-12 31634, 2025
shirsakm joined the channel
2025-11-12 31651, 2025
shirsakm
hi i was looking to contribute to listenbrainz for gsoc and get familiar with the codebase is this the right channel?
MBBE-103: Update 45worlds links to use 45cat domains
2025-11-12 31606, 2025
ansh[m]
<kellnerd[m]> "1. Almost every link has `target..." <- I'm of this opinion that any link which takes the user out of musicbrainz website should have `target="_blank"`. thoughts?
2025-11-12 31648, 2025
mayhem[m]
<ansh[m]> "I'm of this opinion that any..." <- I'm with kellnerd , it shouldn't do that.
2025-11-12 31647, 2025
Jaderecoveringac joined the channel
2025-11-12 31647, 2025
Jaderecoveringac
<ansh[m]> "I'm of this opinion that any..." <- Nope
2025-11-12 31611, 2025
Jaderecoveringac
Target blank has security issues iirc
2025-11-12 31627, 2025
nexitshe[m] joined the channel
2025-11-12 31627, 2025
nexitshe[m]
it does?
2025-11-12 31610, 2025
Jaderecoveringac
Tabnabbing
2025-11-12 31617, 2025
Jaderecoveringac
You need rel noopener
2025-11-12 31625, 2025
nexitshe[m]
Ah
2025-11-12 31634, 2025
nexitshe[m]
I assumed everyone did `rel="noopener noreferrer" regardless ngl
2025-11-12 31637, 2025
mayhem[m]
of course tabnabbing is a thing on the internet. lol.
2025-11-12 31618, 2025
Jaderecoveringac
there's a chance modern browsers have fixed it by now, but they won't have fixed it opening in the same process
I proposed adding these placeholder emails to the sample database dump. this PR would also add them to the main editor dumps, which I'm wondering whether we should bother with
2025-11-12 31625, 2025
reosarevok[m]
What dump we use for test?
2025-11-12 31637, 2025
bitmap[m]
IIRC the current test DB was based on the production one with private tables dropped/scrubbed. so neither :)
2025-11-12 31648, 2025
bitmap[m]
and we just run the schema change script on it
2025-11-12 31655, 2025
reosarevok[m]
Hmm
2025-11-12 31612, 2025
reosarevok[m]
In that case it barely matters
2025-11-12 31651, 2025
reosarevok[m]
Otherwise they are just blank, right?
2025-11-12 31618, 2025
reosarevok[m]
Unless it is a significant hit to already slow dumps, I would say it is an improvement?
2025-11-12 31638, 2025
bitmap[m]
yep. I think it might be fine to populate them, but they've been blank since the beginning, so I'm only worrying about the small chance that it breaks something
2025-11-12 31615, 2025
bitmap[m]
(and it was only requested for the sample dump)
2025-11-12 31650, 2025
yvanzo[m]
I agree with your initial proposition.
2025-11-12 31658, 2025
reosarevok[m]
It feels a bit weird to be inconsistent but as long as it is documented as different I'm fine either way
2025-11-12 31602, 2025
yvanzo[m]
I don’t see any use of setting placeholder emails in the main dumps, so if there are concerns about breaking stuff, probably just avoid doing it.
2025-11-12 31602, 2025
bitmap[m]
ok, let's only do it for the sample dump for now, I'll leave a note in my PR review
2025-11-12 31614, 2025
yvanzo[m]
Or require further tests for not breaking stuff with the main dumps.
2025-11-12 31620, 2025
reosarevok[m]
Where do we document the sample?
2025-11-12 31632, 2025
reosarevok[m]
Let's add a line there about the email thing
2025-11-12 31658, 2025
bitmap[m]
we mention it in INSTALL.md and HACKING.md at least, and the musicbrainz-docker README
2025-11-12 31605, 2025
yvanzo[m]
Also, the related ticket is filed as a bug but titled as a task.
2025-11-12 31659, 2025
bitmap[m]
it should probably be improvement 😅
2025-11-12 31631, 2025
reosarevok[m]
So. Change to improvement, mention it in the docs, and have it for sample only
2025-11-12 31601, 2025
reosarevok[m]
Other than this, how is oauth? I missed last week since I was off
2025-11-12 31613, 2025
reosarevok[m]
Do we need to act on that soon?
2025-11-12 31630, 2025
yvanzo[m]
bitmap[m]: I just linked it from the PR.
2025-11-12 31639, 2025
bitmap[m]
yes, I've started a branch for implementing the oauth login in MBS, but it's rudimentary so far. and I'd like to maintain the ability to use local account for login in development mode, which complicates things
2025-11-12 31602, 2025
bitmap[m]
should have more on this next week
2025-11-12 31621, 2025
yvanzo[m]
About https://github.com/metabrainz/musicbrainz-docker/… what did you actually test @bitmap? Can you please detail these (steps and setup, including the variable COMPOSE_FILE defined in the .env) in a Testing section of the PR’s description?
2025-11-12 31633, 2025
bitmap[m]
sure, I'll have a look at that today
2025-11-12 31619, 2025
yvanzo[m]
Just asking as your review is still fresh :) and the PR contributed.
2025-11-12 31629, 2025
yvanzo[m]
I don't have any other topics for today, I had a lot of work on my plate even before the break, just have to resume it.
2025-11-12 31611, 2025
bitmap[m]
there's a corresponding artwork-redirect PR if you'd like to take a look :) I don't know how common it is to configure MUSICBRAINZ_POSTGRES_SERVER, or POSTGRES_USER, or POSTGRES_PASSWORD in musicbrainz-docker, but it would allow using them in the artwork-redirect config
2025-11-12 31613, 2025
bitmap[m]
yvanzo[m]: same for me, I'm going to continue on the oauth branch and have to catch up on some PR reviews
2025-11-12 31623, 2025
yvanzo[m]
Using these variables is too common, unfortunately, there was a plan to use secrets instead, in the revamped Docker setup in MBS repo.
2025-11-12 31607, 2025
yvanzo[m]
Using these variables for artwork-redirect in the meantime isn’t causing any additional harm.
2025-11-12 31605, 2025
reosarevok[m]
I was working on further React editors and I expect there is no reason not to do more of that
2025-11-12 31624, 2025
reosarevok[m]
bitmap: any luck with that artist credit code you were fighting?
2025-11-12 31619, 2025
bitmap[m]
ah well, I think it just needed some small changes to initialize the fields correctly. and I hadn't written any commit messages yet
2025-11-12 31646, 2025
reosarevok[m]
We're not in a huge rush with it so feel free to prioritize oauth and the like
2025-11-12 31656, 2025
bitmap[m]
I should be able to spend a couple hours on it this week
2025-11-12 31658, 2025
reosarevok[m]
Anything else we should discuss? :)
2025-11-12 31633, 2025
reosarevok[m]
I see ansh put up some homepage stuff and put the page on test
2025-11-12 31649, 2025
reosarevok[m]
Did you two manage to take a look yet? (I didn't)
2025-11-12 31646, 2025
reosarevok[m]
ansh: any questions or comments for the MB team while we are all here? Anything specific you'd want from us?
2025-11-12 31638, 2025
ansh[m]
yes, should i replace the navbar and footer to this new one on all pages?
2025-11-12 31613, 2025
bitmap[m]
reosarevok[m]: I helped with a couple webpack issues yesterday but didn't take an in-depth look yet
2025-11-12 31631, 2025
bitmap[m]
the only unfortunate thing I noticed is that bootstrap 5 depends on an old version of popperjs (since renamed to floating-ui). we're using the newer floating-ui package already
2025-11-12 31647, 2025
bitmap[m]
maybe we can find a way around that so we don't have to include two copies of the library on every page
2025-11-12 31654, 2025
bitmap[m]
<ansh[m]> "yes, should i replace the navbar..." <- we should do this eventually but maybe after the homepage PR
