#metabrainz

/

      • lucifer
        `git checkout -b <new branch name> master` this will create a new branch from master
      • then `git checkout master`, `git reset origin/master --hard`
      • akshaaatt[m]
        <lucifer "then `git checkout master`, `git"> This I understand
      • <lucifer "`git checkout -b <new branch nam"> With this, how do I make a PR of that branch now?
      • Since the branch just exists that way. The commits won't be highlighted?
      • lucifer
        just push to you github fork and open a repo.
      • *open a PR
      • i didn't understand your query.
      • akshaaatt[m]
        Oh! I always commit first and then push so I was confused of what to do next. As you told, I can directly push now hah!
      • outsidecontext: Amazing work you did all these years back!
      • I will now just extract the Client to the MB App and make the necessary changes. Other than this a PR to your app has also been made.
      • Tbh your app was straightforward as is. No boilerplate code. Everything is useful for us straightaway
      • outsidecontext: Should we add a callback feature to the app from Picard?
      • diru1100 has quit
      • outsidecontext
        akshaaatt[m]: how exactly do you mean?
      • akshaaatt[m]
        Like after the file is properly tagged there, the app displays it?
      • But we are doing this on the tagger already
      • So yeah we can do it from the app's client already
      • outsidecontext
        Ah, I wouldn't do such callbacks in this direction for now
      • akshaaatt[m]
        <outsidecontext "lucifer, akshaaatt: btw, I'd lik"> Okay if it's just the sending part, I'll add it asap
      • outsidecontext
        Cool
      • jasondk
        monkey: Hi! I'm working on the pin recording popup modal for LB, could i run it by you and get your suggestions on how to improve the UI?
      • monkey
        Sure, shoot !
      • jasondk
      • (Its very similar to the new report user modal)
      • In my mockup I had the listenbrainz logo and the "Pin This Recording to Your Profile" heading centered at the top, what do you think?
      • monkey
        Looks pretty good ! I would suggest a couple of changes with the wording (maybe in a PR review?), but nothing major.
      • jasondk
        Okie great. Thanks!
      • monkey
        I think we should standardize on one look for the modals. I think this looks fine for now; perhaps you'll be interested in making a reusable modal component with the logo and and modified header
      • But I don't see that as a priority
      • jasondk
        Yeah, makes sense
      • monkey
        One small thing: I think we use green buttons for this type of user actions
      • (for the Pin button)
      • akshaaatt[m]
        outsidecontext: what does the url "http://%s:%d/openalbum?id=%s" signify?
      • jasondk
        I'll change it to green :)
      • outsidecontext
        Picard is listening there. So you'll need local ip of the desktop. Port usually is 8000, but is displayed in Picard window. id is a release MBID
      • akshaaatt[m]
        Right!
      • So in the app even we'll have to add a setting where the user can add their IP and the port
      • outsidecontext
        Best try it on an actual Picard. If you open Picard on your desktop then try opening http://127.0.0.1:8000/openalbum?id=
      • With an actual MBID of course
      • Yes, exactly, this needs to be configurable
      • akshaaatt[m]
        Understood
      • Coool!
      • outsidecontext
        You can also make a request to just / to check if Picard is listening
      • The answers changed a bit in Picard 2.6, though. Earlier versions always answered to all requests with the same text "Nothing to see here"
      • BrainzGit joined the channel
      • Newer return JSON results
      • akshaaatt[m]
        Niceee!
      • samthursfield has quit
      • samthursfield joined the channel
      • legoktm is now known as l5m
      • l5m is now known as legoktm
      • lucifer
        ruaok: gaga seems to be overloaded
      • ruaok
        Oh oh. That doesn't seems good.
      • I'm not near a computer. Can you try and log in and stop the mbid writer?
      • lucifer
        đź‘Ť
      • this one right listenbrainz-mbid-mapping-writer-prod
      • bad question, it had mbid writer in its name :p
      • i stopped mbid writer but doesn't look its going down.
      • typesense seems to be the culprit, should i restart or stop it?
      • yeah this is bad typesense consuming 99% cpu and still not going down after stopping mbid writer.
      • ruaok
        Then kill typesense.
      • I just upgraded to a new version, maybe that was bad.
      • lucifer
        but its been some time since the upgrade?
      • i have stopped typesense, load is coming down.
      • took a look at the logs, weren't much helpful.
      • also the mbid writer started doing 2019 again? it was in 2018 yesterday.
      • ruaok: uh oh! lb went down.
      • lb depends on typesense, consul stopped it.
      • ruaok
        Oh crap.
      • lucifer
        brought back up typesense. monitoring it.
      • meanwhile opening a PR in LB to remove typesense temporarily from consul config.
      • ruaok
        If the writer is off, typesense should not freak out.
      • lucifer
        only labs uses it methinks. hopefully can live without it for a day?
      • yeah writer is off.
      • ruaok
        If it does, then labs is being hit by someone.
      • I need to add rate limiting to labs.
      • lucifer
        currently typesense usage is at 12% (avg of all cpus)
      • ruaok
        If typesense is offline, no one can add tracks to playlists. Which is not a serious problem.
      • lucifer
        in some hours, timescale will try to refresh aggregates at which hell can break loose if typesense is acting up as well.
      • ruaok
        If typesense keeps misbehaving, please change the lb config to not depend on it anymore and shut it down. I'll look at it tomorrow.
      • lucifer
        yeah, i am opening that pr anyways in case we need it urgently.
      • ruaok
        Yeah typesense acting up is not acceptable at all.
      • lucifer
        i'll also build and push an image so we can respond swiftly.
      • ruaok
        Thanks!
      • lucifer
        np :D
      • its time to priortise LB-878
      • BrainzBot
        LB-878: Allow LB to start up if there are missing services https://tickets.metabrainz.org/browse/LB-878
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1525 (03master…typesense): Do not block startup if typesense is down https://github.com/metabrainz/listenbrainz-serv...
      • akshaaatt[m]
        outsidecontext: All done :) You are really gonna like this
      • lucifer
      • tl,dr; stop all lb containers then bring back up with no-typesense image.
      • in case i am not around and typesense needs to be stopped.
      • >Concurrency improvements: utilize all CPU cores and scale to hundreds of thousands of collections
      • đź‘€
      • akshaaatt[m]
        lucifer: still up?
      • lucifer
        akshaaatt[m]: yes
      • akshaaatt[m]
        So I just had a doubt about saving in the sharedprefs using the method we use
      • I have added 2 preference categories in the settings xml
      • preferences xml*
      • They are editable. Just the same way we save the Listen Token
      • But I don't think I am able to save them
      • After hitting okay
      • Where do I add the code for saving the edit text received to the sharedpref?
      • I think I am hitting the same problem we had even with the Listen token
      • lucifer
        i don't think you need to add anything. the preferences fragment handles that
      • anything in logs?
      • akshaaatt[m]
        Hmm it does seem to work
      • But not when I need it
      • lucifer
        lol
      • what's the issue you are facing, lb token is saved but your properties aren't?
      • akshaaatt[m]
        And that's a wrap!
      • Something on the terms of saving string instead of int worked lol
      • What outsidecontext proposed for has been added and it looks really cool.
      • lucifer
        ah strange
      • akshaaatt[m]
        Reminded me of the days spent doing IoT projects
      • lucifer
        if shared prefs act up at any time, try something like this to help debugging https://stackoverflow.com/a/52352741/5557184
      • nice, looking forward to it :D
      • akshaaatt[m]
        I can't believe the things we are doing with the MB app. It can be such a solid representation of all our massive products
      • lucifer
      • that one is getting too big to review :)
      • akshaaatt[m]
        🤓
      • lucifer
        just checkout a new branch from this one and open a new PR for now. it will contain changes from both but will settle out later once we merge the first PR.
      • akshaaatt[m]
        Okaay!
      • lucifer
        once that's done, you can remove the latest commit from the old PR.
      • BrainzGit
        [musicbrainz-android] 14akshaaatt opened pull request #79 (03master…picard_addition): Picard addition https://github.com/metabrainz/musicbrainz-andro...
      • lucifer
        thanks! :D
      • yvanzo
        lucifer: MOBILE-61 has been reported three times this time already.
      • BrainzBot
        MOBILE-61: Can't login on Android app https://tickets.metabrainz.org/browse/MOBILE-61
      • lucifer
        yvanzo: oh! i didn't see those tickets. thanks! i had already pushed the fix, i'll comment on the ticket as well.
      • yvanzo
        s/this time/this week/
      • Thank you and good night! :)
      • lucifer
        good night :D
      • akashgp09 has quit