#metabrainz

/

      • Freso
      • I have received no mailed in reviews, so…
      • People up for reviews: zas, reosarevok, lucifer, alastairp, yvanzo, ruaok, akshaaatt[m], monkey, Freso, bitmap, CatQuest – anyone else who want to give review, let me know ASAP. :)
      • zas: Go!
      • yyoung[m]
        Freso I can go in a short time
      • zas
        hey
      • I finished the deployment of node exporter (metrics collector for prometheus), and tuned some alerts & graphs
      • I did usual maintenance, supervision, patches, and worked on Picard PRs (2.6.4 stable will be out soon, 2.7 alpha too)
      • fin. reosarevok ?
      • reosarevok
        yyoung[m]: go first? :)
      • CatQuest
        hm
      • yyoung[m]
        Thanks
      • Hi
      • Nothing much, just looking at some tickets, regular editing and making userscipts
      • CatQuest
        oohhh
      • yyoung[m]
        Just finishing a project, new term is starting, and hopefully everything will come back on track this week
      • Thanks, go reosarevok
      • reosarevok
        That's a curious idea of "nothing much" ;)
      • Seems decent to me!
      • Anyway, hi!
      • I've mostly been working on a bunch of small URL cleanup changes (new URLs, better cleanup, plus a method to actually better match the favicons to the url so that she-ra.com doesn't show the resident advisor logo because it contains "ra.co")
      • Plus just updating a fair amount of open PRs based on comments / suggestions to put them on beta, since we have started using an actual milestone method again and getting a fair amount of reviews in :)
      • CatQuest: what about you?
      • CatQuest
        Meow! `😺`
      • not much this week, was in a slump.. but things are looking up now!!
      • figured out that i actually *can* use atisket! so
      • !m atj for that
      • BrainzBot
        You're doing good work, atj for that!
      • CatQuest
        otherwise trying to figure things out about a ✨New Browser™✨
      • :O
      • fin, go freso!
      • Freso
        o/
      • riksucks
        I read the same lol
      • Freso
        Dealt with more reports, incl. a lot of spam (in MB and forums and a bit on LB all), did some forum admin stuff toggling options and looking into new features that turned out to not be available in our current version. :( I’ve set a reminder to look into it again for when we update to next version.
      • CatQuest
        !m freso
      • BrainzBot
        You're doing good work, freso!
      • Freso
        Other than that, being around and about.
      • fin.
      • lucifer: Go!
      • lucifer
        hi all!
      • Freso
        (People still up: alastairp, yvanzo, ruaok, akshaaatt[m], monkey, bitmap – anyone else who want to give review, let me know ASAP. :))
      • lucifer
        i worked mostly on sir debugging last week. followed up on some LB PRs, some spark debugging and misc stuff.
      • alastairp: next?
      • alastairp
        hi there
      • last week seemed to run by really quickly
      • I tried a few times to upgrade sentry (our release is about 2 years old, and has some deprecated github integrations)
      • due to the way that our docker setup works, this was much more complex than I expected, though once I learned the right incantations things seemed to go better.
      • we're currently upgraded from 9->10, though we still need to upgrade to the latest v21 release (in 2020 they moved to year-based versioning). I didn't want to waste any more time on that so I've put it to the side for now
      • I did some LB reviews, and am finishing off a LB frontend PR that I opened before summer
      • yvanzo:
      • yvanzo
        hi!
      • Last week I released a new version of musicbrainz-docker (ft. indexer’s bugfixes and improved development setup) at https://github.com/metabrainz/musicbrainz-docke...
      • Also tried to address biweekly load issues on aretha due to MB dumps compression (will see next Wednesday if that worked).
      • Resumed reviewing MBS PRs using the new approach to milestones reosarevok mentioned.
      • Worked on SIR: Debug, Dockerfile, and service maintenance.
      • MrClon
        Hi. I rewrite my Bandcamp tags submitting script. Tested new version on test.musicbrainz.org, seems like it work correct bout i not fully sure. If things will go wrong can you delete all tags submitted by my bot?
      • reosarevok
        MrClon: meeting right now, but yes
      • CatQuest
        oh lol i thoguht MrClon was reviewing :D
      • reosarevok
        Any further questions, please later :)
      • yvanzo
        Hi MrClon, we can answer by 8pm CEST (in ~40min), see https://musicbrainz.org/doc/MetaBrainz_Meeting :)
      • Fin I guess. Go bitmap!
      • bitmap
        hey
      • Freso
        (Only ruaok, akshaaatt[m], and monkey left on my list. Last call for anyone else who may want to give review!)
      • bitmap
        last week we released a new MBS with yyoung's GSoC work (thanks again to yyoung!)
      • monkey
        !m yyoung
      • BrainzBot
        You're doing good work, yyoung!
      • bitmap
        I spent time debugging some out-of-memory errors in the MB webservice containers and found a nasty issue in the /ws/2/isrc endpoint that I hotfixed
      • & I also started working on MBS-10896 and MBS-10238 which are kinda related because they both require moving the email-sending functionality to ModBot (which would run more frequently, probably every 15 mins or so)
      • BrainzBot
        MBS-10896: ISE when voting: LOCK vote IN SHARE ROW EXCLUSIVE MODE https://tickets.metabrainz.org/browse/MBS-10896
      • MBS-10238: MusicBrainz seriously spams when multiple edits are voted upon or commented on https://tickets.metabrainz.org/browse/MBS-10238
      • bitmap
        this is a schema change (since we need a way to track when edits were last processed in order to know whether to send out emails) but at least it only involves a non-replicated/internal-only table
      • other than that, I did some code review for the next MBS milestone
      • fin! go ruaok
      • ruaok
        y
      • CatQuest
        n
      • ruaok
        last week was mostly catching up from vacation. loads of emails, random discussions, that stuff.
      • I also continued working on the MBID release mapper, which I asked feedback on here -- it seems to be on track.
      • I'll have to push that one forward this week, after I ponder how to continue.
      • today monkey and started working on a page that allows an LB user to see their feedback (love/hate)
      • CatQuest
        !m ruaok and monkey!
      • BrainzBot
        You're doing good work, ruaok and monkey!!
      • ruaok
        because with similar users working well now, I've been listening to collections of my similar users and there is some good stuff. so discovery is starting to work, but once I find something, I can't even <3 it or even find my <3s
      • so over the next few weeks I want to pick off little features here and there that allow us to close the loop making LB useful for music discovery -- we're quite close, so this is exciting.\
      • and I've also been seeing more people talking about LB and tweeting that they have moved from last.fm to LB. which is a nice milestone to see. :)\
      • fin. monkey!
      • monkey
        !m ListenBrainz
      • BrainzBot
        You're doing good work, ListenBrainz!
      • monkey
        Hi everyone!
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MBS-11938 (reo), invoices (ruaok)
      • Last week I worked on a few improvements for ListenBrainz: submitting listens when played on the LB website, showing a play button on hovering over listens, and helping lucifer with the LibreFM import page.
      • I also reviewed PR (mostly for LB) and did some testing of akashgp09[m]’s Series project for BookBrainz, as well as some general repo and CI tests housekeeping.
      • Finally I sat down with ruaok to discuss summit t-shirt ideas. Excited to work on this again :)
      • Also got my 2nd vaccine jab over the weekend, so that’s done. 🎉
      • That's it for me, go akshaaatt[m] !
      • akshaaatt[m]
        Hi Everyone!
      • Freso
        (akshaaatt[m] is last on my list. We’ll continue on to other agenda items afterwards if no one else speaks up, like, now(!) that they, too, want to give review!)
      • akshaaatt[m]
        This week I realised I needed to code more so I dived in and worked on building components which we can use across all ours applications
      • I even completed two advanced courses on React which I feel was much needed.
      • I skimmed through the documentations for bootstrap and react very properly
      • Hopefully I can start making PRs to all projects this week and get our work going
      • Other than that I had a lot of college exams this past week. So that's about it. I see amazing changes upcoming and it is really exciting!
      • Fin!
      • And yeah,
      • The Android app now supports Light mode along with Dark mode!
      • CatQuest
        cool!
      • Freso
        Thank you everyone who gave reviews for your reviews! :)
      • Let’s move onward with continuation of last week…
      • reo: MBS-11938
      • BrainzBot
        MBS-11938: Separate most autoselectable websites into their own relationships https://tickets.metabrainz.org/browse/MBS-11938
      • reosarevok
        Hi!
      • So, yvanzo gave his reasoning there
      • I'd like people to take a look and see what they think :)
      • (I personally feel that bundling everything is not ideal, but I would be ok with that too if people prefer it - the current half-and-half seems like the worst of all 3 options)
      • CatQuest
        i'd like separate rels honestly
      • Freso
        I personally _feel_ like it would still be more efficient to have per-site relationships, but I don’t have any benchmarks. Theoretically it feels like it would be faster/more efficient to query an (row) id number than to do a regex or % match on all strings.
      • reosarevok
        It would, but I can see that it makes it harder if you just want "give me all other databases" :)
      • bitmap
        "relationship types describe/document the role of an entity towards another entity" makes sense to me
      • CatQuest
        🤔 isn't that still gonig ot be a (unselectable) parent?
      • bitmap
        I guess my only worry would be breaking existing code that relies on the other databases UUID to filter things?
      • Freso
        CatQuest: Doesn’t help for direct db search :)
      • CatQuest
        is it possible to filter/query for tings udner a spesific parent?
      • (if not then should be)
      • reosarevok
        It is, to some degree, it just requires some more effort :)
      • CatQuest
        weeeeell
      • reosarevok
        From the DB, it's totally doable
      • yvanzo
        It is not implemented though
      • reosarevok
        From the WS for example, not really
      • CatQuest
        so i should write a ticket?
      • reosarevok
        Unless you implement a "grouping ID" or something and add it to the WS, but that seems hacky
      • CatQuest
        (I'd need help formulating it)
      • yvanzo
        It is already possible to filter by URL pattern, the code exists already.
      • CatQuest
        well for other databases the url doesnt necessary have the same format for every type of database
      • yvanzo
        ?
      • reosarevok
        CatQuest: Yeah, the idea yvanzo has is that you store all as just "other databases" and do everything else just based on the URL
      • bitmap
        would the per-site rels become children of 'other databases'? maybe we can have a way to filter by parent type
      • in the WS
      • reosarevok
        bitmap: stuff like Discogs already is :)
      • bitmap
        right
      • CatQuest
        exactly as bitmap said was my point with all this
      • reosarevok
        But this sounds like we could talk about it at a team meeting, see what possibilities we can implement
      • And decide from there :)
      • yvanzo
        Most if not all of databases have normalized URL format, often even permalinks.
      • reosarevok
        Basically, I expect we'll want to either implement stuff for display if we group all (so that Discogs still shows Discogs and not other databases, and whatnot)
      • Or implement stuff for querying if we split all
      • CatQuest
        uh
      • yes
      • Freso
        Definitely doesn’t seem like there’s outright consensus either way right now.
      • reosarevok
        I'll write it down to bring up at a team meeting, in any case :) Freso, I think we can move on
      • Freso
        Alright, great.