ha non sdh ca semble pas être un du raid finalement
booon...
ooops bad channel !
bitmap
reosarevok: will that prevent us from being able to display the changes fully in cases where the type ID is fine? or can we try to display something just from the stored edit data without having to load anything?
darkstardevx joined the channel
peterhil joined the channel
jasondk has quit
jasondk joined the channel
reosarevok
bitmap: this doesn't affect the changes either way, this is only for the data about the rel currently AFAICT
What mean strings like "[Intro Dirty] 9A 97" in recent submitted recording list on acousticbrainz.org?
lucifer
it probably part of the recording title of the submission but alastairp can confirm.
alastairp
I think for recently submitted listens we just show the title which is present in the metadata tag in the file
so it might be different to the title on musicbrainz
lucifer
ruaok: on subject of adding new stats, what do quarterly and half-yearly stats represent? last 3 months and 6 months or actual quarters like Jan-Mar, Apr-Jun so on.
ruaok
yes, that would be most consistent.
lucifer
which one? :) last 3 months or Jan-Mar?
i.e. if its Apr, last 3 months coincide with Jan-Mar. but if its in May last 3 months are Feb-Apr but the quarter would be Jan-Mar.
*last quarter
ruaok
actual quarters. always.
lucifer
👍 makes sense
ruaok
last X <time unit> as measured by a script that runs at unknown times is rather pointless, I think.
so, we should always use calendar aligned units.
lucifer
agreed.
alastairp
so stats for the current quarter will always be not up-to-date?
however, there are a bunch of caveats... it's a research paper that said "when we gave people both a like and a dislike button, people liked their recommendations 20% more than when we only gave them a like button"
ruaok
alastairp: for current quarter, they would be interpreted as "up-to-today", which is a common expression in accounting.
alastairp
but of course, stupid news site took this paper and said "research says spotify would be better if it had a dislike button", which is a stupid takeaway
lucifer
that's the case for all stats. for eg: last week means the last week. not 7 days ago to today.
alastairp
having said that, good that we have a dislike button! it should be useful
ruaok happily listens to another users recent listens page
yvanzo
mo’’in’
ruaok waves from behind yvanzo
Freso
Just a heads up that meeting notes from yesterday will get posted tomorrow. I’m under the weather with a slight fever and have been having tech issues all morning that I just now got resolved, so I’m a bit worn out now. Sorry! :(
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, dead link collection (reosarevok)
to play devil's advocate, do we know that this page is visited often and is slow?
lucifer
no. iirc we thought it would be slow. so opened the ticket during the hack week.
alastairp
the page needs 3 sql queries to get the 3 different parts of the page? It'd be good if we could track page load time (another reason for this functionality!) and see if it's necessary
ruaok
time to add a metric?
alastairp
yep
lucifer
i was thinking to add the metric but then i saw sentry supported it out of the box.
alastairp
mmm
lucifer: yeah, I was just going to say that
request tracing, yeah?
lucifer
yes
alastairp
+1 to that, especially if it can do sql profiling too
has sentry been well since I did the last upgrade? we should try and upgrade to the next version again
lucifer
will need to check about sql stuff.
yes it seems to be working well. we should probably upgrade.
the current version does not seem to support request tracing.
riksucks
so sentry is like a control panel that gives you a birds eye view of how the APIs are performing?
alastairp
riksucks: originally, sentry was a program to track software crashes
so if we had a programming error, it would report that something happened when a user visited a page, and where in the code the error was
riksucks
ahh that makes sense, so it started as a sort of logging software
alastairp: this is so lucid, and you can connect jira too
reosarevok
yvanzo: also, re https://github.com/metabrainz/musicbrainz-serve... - I'm fine, but I guess then we should at least make the new description strings added by this PR either undefined or the same as the label, so that there's no extra work for translators
If we're going to remove them anyway, I guess undefined is easiest, if you're ok with that? :)
alastairp
riksucks: and if you mark it as "fixed", you can indicate in which release of the software it was fixed in, and if it happens again, it'll re-open the ticket and assign the person who fixed it last
riksucks
this is so cool, really helps you keep track of issues and logs at one place
ruaok
it is so cool until you realize that there are thousands of reports, lol
alastairp
hey, we're slowly fixing the frequent ones!
ruaok
true that. it does look a lot better.
alastairp
sorry, let me re-state that
hey, lucifer is slowly fixing the frequent ones!
ruaok
entirely too true.
riksucks
lol, I see, it seems like it can get frustrating very quick. All of these are quite fascinating to me because I have never worked as a team nor have I used such software to keep track of stuff lol. In fact I used Jira for the first time with you guys.
this is one of the things that I think is cool about working with us -- we can give real life experience on how to deal with production systems
lucifer
hehe. its a team effort :)
alastairp
says the person who just opened another PR
riksucks
agreed, in fact I kind of joined open source stuff because of that. I turned sophomore recently. And no (good) company would give me internship for software dev role in my first year despite clearing all coding rounds. So at the end of my freshman year I started messing around with open source
ruaok
wise move riksucks
riksucks
hehe thanks
CatQuest
yep
ruaok
FWIW, alastairp, that renaming seems to have worked.
alastairp
> FAIL: Expected minimum docker-compose version to be 1.23.0 but found Docker Compose version v2.0.0-rc.3
thanks, sentry
riksucks
lmao
lucifer
the quarterly stats backend work ended up being ~100-200 including tests (plus again includes some refactoring). the previous refactoring PRs paid off :D
ruaok has some spare time and goes to read the latest PR
riksucks
also sorry for sounding like a broken record, but I think the pr I was working on is all done according to the review, you guys can take a look
ruaok
sorry, let me do that. lucifer's PR seems to be in progress still.
riksucks
:D
ruaok
riksucks: lucifer has left a few comments with requested improvements. you should address/answer/clarify them and then resolve the conversation.
lucifer
those are already resolved iirc. that's why i had approved. i'll resolve it on Github UI as well.
ruaok
ah, ok. looks quite messy at the moment.
riksucks
I resolved few from my end too
ruaok
👍
monkey
reosarevok: I had a read through the proposed SQL style guide. I'm no SQL expert by any means, but it all looks good to me. I'm lazy when it comes to right-aligning new clauses keywords, but I do see the attraction in terms of readability.
In short, all the proposed guidelines improve readability, which gets a bit fat 👍 from me
yvanzo
reosarevok: true, no need to add descriptions that will be removed.